Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-20 Thread via GitHub


hello-stephen merged PR #51065:
URL: https://github.com/apache/doris/pull/51065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-20 Thread via GitHub


hello-stephen commented on code in PR #51065:
URL: https://github.com/apache/doris/pull/51065#discussion_r2097264624


##
docker/thirdparties/docker-compose/hive/scripts/hive-metastore.sh:
##
@@ -43,6 +44,13 @@ while ! $(nc -z localhost "${HMS_PORT:-9083}"); do
 sleep 5s
 done
 
+if [[ ${NEED_LOAD_DATA} = "0" ]]; then
+rm -f "${lockfile1}"
+echo "NEED_LOAD_DATA is 0, skip load data"
+touch /mnt/SUCCESS
+# Avoid container exit
+tail -f /dev/null
+fi

Review Comment:
   为啥这样就能跳过后面的导入数据?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-20 Thread via GitHub


github-actions[bot] commented on PR #51065:
URL: https://github.com/apache/doris/pull/51065#issuecomment-2893672362

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-20 Thread via GitHub


zgxme commented on code in PR #51065:
URL: https://github.com/apache/doris/pull/51065#discussion_r2097266419


##
docker/thirdparties/docker-compose/hive/scripts/hive-metastore.sh:
##
@@ -43,6 +44,13 @@ while ! $(nc -z localhost "${HMS_PORT:-9083}"); do
 sleep 5s
 done
 
+if [[ ${NEED_LOAD_DATA} = "0" ]]; then
+rm -f "${lockfile1}"
+echo "NEED_LOAD_DATA is 0, skip load data"
+touch /mnt/SUCCESS
+# Avoid container exit
+tail -f /dev/null
+fi

Review Comment:
   block hear
   ```
   tail -f /dev/null
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-20 Thread via GitHub


zgxme commented on PR #51065:
URL: https://github.com/apache/doris/pull/51065#issuecomment-2893115369

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-20 Thread via GitHub


github-actions[bot] commented on PR #51065:
URL: https://github.com/apache/doris/pull/51065#issuecomment-2893277291

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [opt](docker) add a script flag to control load data or not [doris]

2025-05-19 Thread via GitHub


Thearas commented on PR #51065:
URL: https://github.com/apache/doris/pull/51065#issuecomment-2893108363

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]