Re: [PR] [refactor](cloud) Add versioned read checking [doris]
dataroaring merged PR #54278: URL: https://github.com/apache/doris/pull/54278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3164249201 # BE Regression && UT Coverage Report Increment line coverage `100% (0/0)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/54278_6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/54278_6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.36% (22446/27590) | | Line Coverage | 74.08% (232697/314107) | | Region Coverage | 61.52% (193823/315068) | | Branch Coverage | 65.50% (83662/127723) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163593173 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a/report/index.html) | Category | Coverage | |---|| | Function Coverage | 58.84% (16541/28111) | | Line Coverage | 47.79% (150138/314165) | | Region Coverage | 36.71% (112644/306863) | | Branch Coverage | 39.65% (50041/126195) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163508305 TPC-DS: Total hot run time: 170598 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a, data reload: false query1 997 415 425 415 query2 6541191117201720 query3 6742225 232 225 query4 27156 23733 23451 23451 query5 4398626 535 535 query6 331 250 221 221 query7 4626513 291 291 query8 289 230 219 219 query9 8533290929302909 query10 480 339 284 284 query11 16028 14969 14779 14779 query12 187 137 130 130 query13 1666556 422 422 query14 8676574157305730 query15 216 179 158 158 query16 7804650 475 475 query17 1635760 626 626 query18 2056430 317 317 query19 296 202 172 172 query20 160 151 133 133 query21 213 126 109 109 query22 4296404939113911 query23 34517 34144 34236 34144 query24 8128239223792379 query25 544 517 446 446 query26 1245293 164 164 query27 2628501 347 347 query28 4376234923282328 query29 796 603 486 486 query30 301 235 213 213 query31 930 811 705 705 query32 90 78 84 78 query33 562 427 426 426 query34 819 843 519 519 query35 831 829 766 766 query36 10201042929 929 query37 126 108 93 93 query38 4001394639133913 query39 1426135913791359 query40 234 140 130 130 query41 62 61 57 57 query42 141 122 128 122 query43 517 511 474 474 query44 1420872 867 867 query45 200 189 178 178 query46 948 1073675 675 query47 1859185417721772 query48 416 433 333 333 query49 749 501 427 427 query50 678 718 412 412 query51 4299424541464146 query52 127 132 122 122 query53 256 307 209 209 query54 660 642 559 559 query55 95 85 88 85 query56 349 358 352 352 query57 1221125311261126 query58 347 329 333 329 query59 2647268225202520 query60 409 399 383 383 query61 122 131 123 123 query62 822 730 648 648 query63 256 208 215 208 query64 42621185798 798 query65 4252413541304130 query66 1076454 335 335 query67 query68 17028 869 883 869 query69 1037285 281 281 query70 1418107211271072 query71 731 319 322 319 query72 9193238224532382 query73 3193668 355 355 query74 8869911489118911 query75 7568312227052705 query76 88831228787 787 query77 1156398 337 337 query78 968810128 93209320 query79 14076 611 577 577 query80 1167545 471 471 query81 562 257 223 223 query82 365 157 122 122 query83 334 299 270 270 query84 305 96 90 90 query85 879 370 338 338 query86 357 322 316 316 query87 4217422341474147 query88 4519223022402230 query89 479 362 324 324 query90 2665225 230 225 query91 141 142 122 122 query92 97 74 70 70 query93 4722967 658 658 query94 947 391 279 279 query95 394 319 320 319 query96 516 590 286 286 query97 2715272526402640 query98 255 236 225 225 query99 1467142112811281 Total cold run time: 304033 ms Total hot run time: 170598 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163524988 ClickBench: Total hot run time: 33.47 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a, data reload: false query1 0.040.040.04 query2 0.070.050.04 query3 0.240.070.07 query4 1.630.110.12 query5 0.440.440.45 query6 1.150.680.66 query7 0.020.020.02 query8 0.050.040.04 query9 0.560.480.47 query10 0.540.530.53 query11 0.160.100.11 query12 0.150.110.11 query13 0.670.660.65 query14 0.981.051.24 query15 0.920.890.89 query16 0.390.400.39 query17 1.071.051.07 query18 0.210.210.20 query19 2.071.961.82 query20 0.020.020.02 query21 15.41 0.870.58 query22 0.771.100.69 query23 14.94 1.200.59 query24 6.891.031.17 query25 0.480.240.10 query26 0.500.150.14 query27 0.060.070.05 query28 9.610.870.44 query29 12.66 3.833.34 query30 3.033.032.99 query31 2.830.570.40 query32 3.240.570.49 query33 3.023.213.15 query34 15.86 5.324.96 query35 4.945.034.98 query36 0.700.520.51 query37 0.090.070.07 query38 0.060.040.05 query39 0.040.030.02 query40 0.180.130.14 query41 0.080.040.02 query42 0.040.030.03 query43 0.040.030.02 Total cold run time: 106.85 s Total hot run time: 33.47 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163465513 TPC-H: Total hot run time: 34059 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a, data reload: false -- Round 1 -- q1 17062 533552415241 q2 1960294 193 193 q3 10062 1421721 721 q4 10216 1069506 506 q5 7635232723292327 q6 183 170 132 132 q7 910 760 630 630 q8 9308127710931093 q9 7093511551415115 q10 6902238719781978 q11 461 280 268 268 q12 351 362 220 220 q13 17781 346830163016 q14 230 237 226 226 q15 534 458 471 458 q16 424 424 373 373 q17 573 836 359 359 q18 7587720770767076 q19 1097977 560 560 q20 325 317 217 217 q21 3451308923302330 q22 1075102510201020 Total cold run time: 105220 ms Total hot run time: 34059 ms - Round 2, with runtime_filter_mode=off - q1 5440533352775277 q2 245 302 215 215 q3 2073258021842184 q4 1333175113381338 q5 4160442846044428 q6 227 174 133 133 q7 1962193017831783 q8 2556242225002422 q9 7529730873337308 q10 3210337629562956 q11 533 503 541 503 q12 737 806 743 743 q13 3482364132233223 q14 290 306 288 288 q15 496 469 470 469 q16 481 487 467 467 q17 1213143613821382 q18 11284 764677387646 q19 3252107712071077 q20 2041198019001900 q21 14968 421743414217 q22 10491032971 971 Total cold run time: 68561 ms Total hot run time: 50930 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
github-actions[bot] commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163282424 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163249733 # Cloud UT Coverage Report Increment line coverage `59.60% (267/448)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_6aed5e9fca21dd5ae989bb5fc3e7592e1b42885a_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.92% (1409/1720) | | Line Coverage | 66.07% (24072/36434) | | Region Coverage | 67.26% (11975/17805) | | Branch Coverage | 56.91% (6263/11006) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
w41ter commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3163197834 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
gavinchou commented on code in PR #54278:
URL: https://github.com/apache/doris/pull/54278#discussion_r2258740384
##
cloud/src/meta-service/meta_service.cpp:
##
@@ -3531,69 +3592,79 @@ bool
MetaServiceImpl::get_mow_tablet_stats_and_meta(MetaServiceCode& code, std::
};
auto table_id = request->table_id();
std::stringstream ss;
+bool is_versioned_read = is_version_read_enabled(instance_id);
if (!config::enable_batch_get_mow_tablet_stats_and_meta) {
for (const auto& tablet_idx : request->tablet_indexes()) {
// 1. get compaction cnts
TabletStatsPB tablet_stat;
-std::string stats_key =
-stats_tablet_key({instance_id, tablet_idx.table_id(),
tablet_idx.index_id(),
- tablet_idx.partition_id(),
tablet_idx.tablet_id()});
-std::string stats_val;
-TxnErrorCode err = txn->get(stats_key, &stats_val);
-TEST_SYNC_POINT_CALLBACK(
-
"get_delete_bitmap_update_lock.get_compaction_cnts_inject_error", &err);
-if (err == TxnErrorCode::TXN_TOO_OLD) {
-code = MetaServiceCode::OK;
-err = txn_kv_->create_txn(&txn);
+if (!is_versioned_read) {
Review Comment:
看下能不能 `if (is_versioned_reader)` 来分岔新的逻辑
这个 if 增加了缩进, 代码块也太大了, 其他地方类似 考虑下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
github-actions[bot] commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3162211584 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
github-actions[bot] commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3162211528 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3160023014 # BE Regression && UT Coverage Report Increment line coverage `100% (0/0)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/54278_6d4194e313dd9394aeee941a1758fcbdc02f5cdb_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/54278_6d4194e313dd9394aeee941a1758fcbdc02f5cdb_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.25% (22405/27577) | | Line Coverage | 73.90% (231781/313655) | | Region Coverage | 61.10% (192289/314713) | | Branch Coverage | 65.25% (83226/127553) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3159572502 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6d4194e313dd9394aeee941a1758fcbdc02f5cdb_6d4194e313dd9394aeee941a1758fcbdc02f5cdb/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6d4194e313dd9394aeee941a1758fcbdc02f5cdb_6d4194e313dd9394aeee941a1758fcbdc02f5cdb/report/index.html) | Category | Coverage | |---|| | Function Coverage | 58.30% (16382/28100) | | Line Coverage | 47.19% (148055/313717) | | Region Coverage | 36.16% (110834/306510) | | Branch Coverage | 39.04% (49194/126025) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3159381612 ClickBench: Total hot run time: 35.11 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6d4194e313dd9394aeee941a1758fcbdc02f5cdb, data reload: false query1 0.030.030.04 query2 0.120.060.06 query3 0.310.060.07 query4 1.610.090.08 query5 0.420.410.40 query6 1.180.650.65 query7 0.030.010.01 query8 0.070.060.05 query9 0.610.480.47 query10 0.540.540.54 query11 0.250.120.12 query12 0.250.140.13 query13 0.660.660.65 query14 0.941.091.08 query15 1.040.920.91 query16 0.480.390.39 query17 1.121.111.07 query18 0.240.230.25 query19 1.981.811.84 query20 0.010.020.02 query21 15.38 1.000.71 query22 0.981.121.00 query23 14.71 1.530.91 query24 4.930.640.39 query25 0.180.120.11 query26 0.550.230.20 query27 0.120.110.11 query28 11.04 1.170.64 query29 12.57 3.973.52 query30 3.103.053.04 query31 2.810.620.48 query32 3.240.640.57 query33 3.063.263.36 query34 16.97 5.484.99 query35 4.975.025.03 query36 0.730.540.51 query37 0.250.230.21 query38 0.240.240.24 query39 0.070.060.06 query40 0.210.170.17 query41 0.130.080.08 query42 0.090.070.07 query43 0.070.070.06 Total cold run time: 108.29 s Total hot run time: 35.11 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3159314431 TPC-DS: Total hot run time: 169173 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6d4194e313dd9394aeee941a1758fcbdc02f5cdb, data reload: false query1 1039410 414 410 query2 6533180316731673 query3 6746221 217 217 query4 26871 23688 23210 23210 query5 4324650 502 502 query6 331 262 216 216 query7 4640527 294 294 query8 291 236 232 232 query9 8645292629472926 query10 490 333 293 293 query11 15728 14955 14699 14699 query12 185 141 133 133 query13 1667565 433 433 query14 9413594758795879 query15 206 190 163 163 query16 7138711 486 486 query17 974 780 651 651 query18 1996450 324 324 query19 224 213 179 179 query20 151 139 141 139 query21 218 128 108 108 query22 4074397838013801 query23 34343 34104 34122 34104 query24 5221237823972378 query25 491 523 450 450 query26 708 291 171 171 query27 1740473 353 353 query28 2640232223162316 query29 621 621 480 480 query30 285 240 201 201 query31 852 795 727 727 query32 92 81 81 81 query33 505 411 381 381 query34 804 839 517 517 query35 813 848 720 720 query36 998 1044932 932 query37 124 115 87 87 query38 3891392639463926 query39 1431137913771377 query40 240 143 126 126 query41 60 57 53 53 query42 147 122 136 122 query43 514 510 504 504 query44 1406871 865 865 query45 195 190 188 188 query46 941 1050697 697 query47 1789184817221722 query48 395 418 322 322 query49 657 522 418 418 query50 661 673 425 425 query51 4176421441814181 query52 125 134 111 111 query53 279 291 221 221 query54 652 640 548 548 query55 94 84 86 84 query56 351 365 341 341 query57 1187121311371137 query58 333 323 315 315 query59 2666259224692469 query60 409 399 379 379 query61 125 126 125 125 query62 768 738 649 649 query63 254 214 216 214 query64 23591129772 772 query65 4227412341244123 query66 1074446 333 333 query67 query68 17578 591 600 591 query69 1001304 278 278 query70 1461112511461125 query71 726 332 317 317 query72 9223227323632273 query73 3551630 353 353 query74 9107895487728772 query75 7584311326442644 query76 86851205783 783 query77 1135400 348 348 query78 935710181 90259025 query79 14069 611 588 588 query80 1157561 591 561 query81 560 256 230 230 query82 577 147 120 120 query83 379 276 273 273 query84 301 100 80 80 query85 847 393 327 327 query86 354 304 323 304 query87 4214417640144014 query88 5447220322912203 query89 453 366 310 310 query90 2666227 226 226 query91 140 137 111 111 query92 91 70 67 67 query93 61771004655 655 query94 987 398 285 285 query95 399 318 320 318 query96 499 591 279 279 query97 2702275326092609 query98 250 230 217 217 query99 1490141912741274 Total cold run time: 296694 ms Total hot run time: 169173 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3159175399 TPC-H: Total hot run time: 33693 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6d4194e313dd9394aeee941a1758fcbdc02f5cdb, data reload: false -- Round 1 -- q1 17671 526651945194 q2 1947285 198 198 q3 10634 1302708 708 q4 10347 977 530 530 q5 10233 237322622262 q6 225 168 131 131 q7 972 747 638 638 q8 9298149010101010 q9 6881509351005093 q10 6973235919651965 q11 475 284 267 267 q12 361 364 219 219 q13 17805 343729522952 q14 235 238 231 231 q15 555 456 462 456 q16 428 424 381 381 q17 595 830 347 347 q18 7299705070537050 q19 1577980 545 545 q20 325 302 209 209 q21 3478306522892289 q22 1049104610181018 Total cold run time: 109363 ms Total hot run time: 33693 ms - Round 2, with runtime_filter_mode=off - q1 5673527351815181 q2 236 305 222 222 q3 2058253822252225 q4 1366171213231323 q5 4276445043804380 q6 220 176 136 136 q7 1981198917471747 q8 2587252425522524 q9 7374756573307330 q10 3169332629012901 q11 546 515 502 502 q12 744 744 624 624 q13 3456378431423142 q14 288 297 294 294 q15 492 473 456 456 q16 676 526 677 526 q17 1518151413621362 q18 8104761975427542 q19 14457 929 867 867 q20 2896207718161816 q21 13673 421743034217 q22 11201080963 963 Total cold run time: 76910 ms Total hot run time: 50280 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3158939131 # FE UT Coverage Report Increment line coverage `` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/54278_6d4194e313dd9394aeee941a1758fcbdc02f5cdb/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/54278_6d4194e313dd9394aeee941a1758fcbdc02f5cdb/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3158476256 # Cloud UT Coverage Report Increment line coverage `59.60% (267/448)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6d4194e313dd9394aeee941a1758fcbdc02f5cdb_6d4194e313dd9394aeee941a1758fcbdc02f5cdb_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/6d4194e313dd9394aeee941a1758fcbdc02f5cdb_6d4194e313dd9394aeee941a1758fcbdc02f5cdb_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.92% (1409/1720) | | Line Coverage | 66.08% (24070/36427) | | Region Coverage | 67.25% (11967/17796) | | Branch Coverage | 56.92% (6259/10996) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
w41ter commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3158379548 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157586328 # BE UT Coverage Report Increment line coverage ` ` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/7700d28b0a77e095f16dd320960a73f3b0b3b226_7700d28b0a77e095f16dd320960a73f3b0b3b226/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/7700d28b0a77e095f16dd320960a73f3b0b3b226_7700d28b0a77e095f16dd320960a73f3b0b3b226/report/index.html) | Category | Coverage | |---|| | Function Coverage | 58.30% (16382/28100) | | Line Coverage | 47.19% (148049/313717) | | Region Coverage | 36.14% (110777/306510) | | Branch Coverage | 39.03% (49192/126025) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157506938 ClickBench: Total hot run time: 35 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 7700d28b0a77e095f16dd320960a73f3b0b3b226, data reload: false query1 0.030.040.03 query2 0.110.060.06 query3 0.290.070.07 query4 1.590.100.09 query5 0.420.410.41 query6 1.180.650.66 query7 0.040.020.02 query8 0.060.060.05 query9 0.600.480.49 query10 0.550.550.55 query11 0.250.120.13 query12 0.260.140.13 query13 0.680.680.70 query14 0.911.141.10 query15 1.070.940.94 query16 0.390.410.40 query17 1.141.111.11 query18 0.260.240.25 query19 1.971.842.01 query20 0.020.010.01 query21 15.40 0.970.72 query22 0.971.140.89 query23 14.72 1.520.91 query24 5.010.640.39 query25 0.190.120.11 query26 0.570.220.20 query27 0.110.110.11 query28 11.10 1.170.65 query29 12.57 4.023.50 query30 3.102.993.02 query31 2.840.640.48 query32 3.230.640.56 query33 3.153.363.24 query34 16.50 5.474.85 query35 4.925.005.04 query36 0.670.550.53 query37 0.260.230.22 query38 0.240.240.24 query39 0.060.060.06 query40 0.200.180.16 query41 0.110.080.07 query42 0.080.080.08 query43 0.070.060.06 Total cold run time: 107.89 s Total hot run time: 35 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157496248 TPC-DS: Total hot run time: 170252 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7700d28b0a77e095f16dd320960a73f3b0b3b226, data reload: false query1 978 364 398 364 query2 6508182917961796 query3 6745228 230 228 query4 26656 23764 22935 22935 query5 4309644 518 518 query6 344 239 216 216 query7 4631532 296 296 query8 283 235 232 232 query9 8582296329082908 query10 477 341 292 292 query11 16018 15115 14800 14800 query12 185 139 129 129 query13 1661578 426 426 query14 8659597659605960 query15 212 205 173 173 query16 7127690 486 486 query17 1229779 626 626 query18 1999426 307 307 query19 229 201 193 193 query20 152 155 133 133 query21 221 123 106 106 query22 4079392138283828 query23 34298 34011 34074 34011 query24 5370239524642395 query25 490 513 449 449 query26 706 292 162 162 query27 2272510 373 373 query28 2988233423142314 query29 639 590 490 490 query30 289 226 202 202 query31 870 822 726 726 query32 94 82 79 79 query33 514 419 379 379 query34 792 867 533 533 query35 845 839 784 784 query36 10271041944 944 query37 133 110 88 88 query38 3946399339383938 query39 1454139113601360 query40 234 142 129 129 query41 63 60 55 55 query42 142 123 143 123 query43 544 524 485 485 query44 1458886 887 886 query45 195 198 180 180 query46 959 1052679 679 query47 1797182617251725 query48 413 431 317 317 query49 678 513 422 422 query50 670 675 431 431 query51 4220424441384138 query52 126 131 128 128 query53 283 289 219 219 query54 669 645 564 564 query55 92 89 89 89 query56 357 357 345 345 query57 1207119911201120 query58 338 334 347 334 query59 2598260926022602 query60 420 425 411 411 query61 126 128 122 122 query62 748 742 662 662 query63 263 229 222 222 query64 24111154844 844 query65 4196412141224121 query66 1035475 352 352 query67 query68 19697 1053889 889 query69 1016298 298 298 query70 1431110711611107 query71 719 351 319 319 query72 9136227824242278 query73 3755639 355 355 query74 9192907489078907 query75 7704311126582658 query76 89081209787 787 query77 1186422 327 327 query78 966011459 91989198 query79 15275 642 597 597 query80 1760550 504 504 query81 566 261 236 236 query82 484 152 116 116 query83 354 302 276 276 query84 307 95 84 84 query85 1209374 338 338 query86 360 327 316 316 query87 4207418441254125 query88 5627225022552250 query89 511 361 324 324 query90 2580236 241 236 query91 145 187 110 110 query92 88 74 69 69 query93 6615989 661 661 query94 1103395 281 281 query95 415 333 329 329 query96 510 578 287 287 query97 2689271325982598 query98 251 227 231 227 query99 1495136812811281 Total cold run time: 303208 ms Total hot run time: 170252 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157476649 TPC-H: Total hot run time: 34123 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7700d28b0a77e095f16dd320960a73f3b0b3b226, data reload: false -- Round 1 -- q1 16422 539552035203 q2 1917274 189 189 q3 98901268698 698 q4 9886999 517 517 q5 7594238122062206 q6 185 167 138 138 q7 944 740 609 609 q8 9193128810181018 q9 6741503950305030 q10 6888236219881988 q11 451 298 271 271 q12 349 354 233 233 q13 17213 346829812981 q14 233 239 214 214 q15 526 463 460 460 q16 423 430 374 374 q17 561 818 346 346 q18 7181714570227022 q19 1039949 537 537 q20 318 318 219 219 q21 3433302328652865 q22 1075104110051005 Total cold run time: 102462 ms Total hot run time: 34123 ms - Round 2, with runtime_filter_mode=off - q1 5314530453335304 q2 240 327 220 220 q3 2085257521952195 q4 1341170513231323 q5 4118408744104087 q6 221 169 140 140 q7 1987193018141814 q8 2600247723152315 q9 7511711072457110 q10 3229334229012901 q11 563 512 475 475 q12 797 800 600 600 q13 3526377932383238 q14 289 306 287 287 q15 504 451 466 451 q16 444 536 465 465 q17 1123142814381428 q18 8176768376657665 q19 6720995 1096995 q20 1941201118791879 q21 14998 422442674224 q22 10471050997 997 Total cold run time: 68774 ms Total hot run time: 50113 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157414165 # Cloud UT Coverage Report Increment line coverage `59.60% (267/448)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/7700d28b0a77e095f16dd320960a73f3b0b3b226_7700d28b0a77e095f16dd320960a73f3b0b3b226_cloud/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/7700d28b0a77e095f16dd320960a73f3b0b3b226_7700d28b0a77e095f16dd320960a73f3b0b3b226_cloud/report/index.html) | Category | Coverage | |---|| | Function Coverage | 81.72% (1404/1718) | | Line Coverage | 66.09% (23988/36295) | | Region Coverage | 67.20% (11912/17727) | | Branch Coverage | 56.91% (6235/10956) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
w41ter commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157397457 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157343396 ClickBench: Total hot run time: 34.88 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e1b19ccfe0e30ce5193cb57394397df27770610f, data reload: false query1 0.030.030.03 query2 0.120.060.05 query3 0.290.070.07 query4 1.600.090.08 query5 0.410.410.41 query6 1.170.640.66 query7 0.020.010.01 query8 0.090.050.04 query9 0.580.470.49 query10 0.540.530.55 query11 0.250.120.12 query12 0.260.130.13 query13 0.680.680.67 query14 0.921.131.11 query15 1.020.910.92 query16 0.400.380.40 query17 1.041.111.08 query18 0.240.230.25 query19 2.061.891.97 query20 0.010.010.02 query21 15.36 0.960.71 query22 0.961.130.86 query23 14.75 1.480.87 query24 4.760.650.38 query25 0.170.120.11 query26 0.550.220.19 query27 0.120.100.11 query28 11.19 1.170.64 query29 12.55 3.963.48 query30 3.113.013.06 query31 2.830.620.48 query32 3.240.630.58 query33 3.133.213.33 query34 16.45 5.435.01 query35 4.874.975.03 query36 0.690.540.53 query37 0.270.230.23 query38 0.250.240.24 query39 0.060.050.06 query40 0.210.170.17 query41 0.120.090.07 query42 0.080.070.08 query43 0.070.060.06 Total cold run time: 107.52 s Total hot run time: 34.88 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157336199 TPC-DS: Total hot run time: 172037 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e1b19ccfe0e30ce5193cb57394397df27770610f, data reload: false query1 1011369 406 369 query2 6531184017191719 query3 6745225 224 224 query4 26891 23579 23359 23359 query5 4386636 523 523 query6 336 244 240 240 query7 4636516 305 305 query8 271 219 223 219 query9 8579296529812965 query10 471 333 293 293 query11 15913 15028 14829 14829 query12 185 133 135 133 query13 1645568 416 416 query14 8528588859285888 query15 215 189 164 164 query16 7117654 490 490 query17 1226740 614 614 query18 2012435 314 314 query19 230 205 182 182 query20 151 141 172 141 query21 217 126 107 107 query22 3996418041204120 query23 34622 34522 34486 34486 query24 5890241124402411 query25 514 557 473 473 query26 715 299 161 161 query27 2297511 353 353 query28 3036232723122312 query29 673 606 497 497 query30 284 224 189 189 query31 933 786 717 717 query32 89 79 74 74 query33 549 440 385 385 query34 815 869 533 533 query35 831 842 755 755 query36 10221052918 918 query37 140 116 93 93 query38 4040393339653933 query39 1432139014171390 query40 238 149 138 138 query41 70 64 61 61 query42 150 130 138 130 query43 529 530 494 494 query44 1459904 891 891 query45 205 193 184 184 query46 993 1052701 701 query47 1848183317451745 query48 414 444 352 352 query49 703 517 434 434 query50 707 729 426 426 query51 4292420242074202 query52 129 130 126 126 query53 267 303 217 217 query54 691 668 580 580 query55 97 91 94 91 query56 373 403 371 371 query57 1207121111211121 query58 348 392 331 331 query59 2639265825772577 query60 417 405 389 389 query61 128 131 129 129 query62 748 729 700 700 query63 262 227 221 221 query64 23641122772 772 query65 4286421641264126 query66 1013464 336 336 query67 query68 18632 1008617 617 query69 1052329 290 290 query70 1450115811011101 query71 720 355 341 341 query72 9161230548392305 query73 3580787 353 353 query74 9004894988328832 query75 7490316226642664 query76 88511229824 824 query77 1145420 363 363 query78 971511553 99509950 query79 15426 605 576 576 query80 2254562 498 498 query81 580 271 227 227 query82 514 153 124 124 query83 414 296 278 278 query84 377 97 82 82 query85 895 378 388 378 query86 373 328 314 314 query87 4166421241034103 query88 5402225122542251 query89 504 367 329 329 query90 2493235 245 235 query91 163 141 111 111 query92 90 71 68 68 query93 6541986 665 665 query94 1080408 285 285 query95 434 343 336 336 query96 515 591 291 291 query97 2675271126132613 query98 267 226 226 226 query99 1492134212681268 Total cold run time: 303206 ms Total hot run time: 172037 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
doris-robot commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157321134 TPC-H: Total hot run time: 33867 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e1b19ccfe0e30ce5193cb57394397df27770610f, data reload: false -- Round 1 -- q1 17643 522151855185 q2 1928301 180 180 q3 10642 1285688 688 q4 10318 985 541 541 q5 10275 232323182318 q6 236 165 130 130 q7 917 747 648 648 q8 9284129610781078 q9 6874514350595059 q10 6962235519681968 q11 468 283 268 268 q12 357 358 224 224 q13 17790 347330023002 q14 245 241 235 235 q15 534 467 464 464 q16 422 427 374 374 q17 586 835 350 350 q18 7156717671187118 q19 1257975 569 569 q20 328 314 210 210 q21 3451310622812281 q22 10631054977 977 Total cold run time: 108736 ms Total hot run time: 33867 ms - Round 2, with runtime_filter_mode=off - q1 5404535352695269 q2 244 308 223 223 q3 2074260422142214 q4 1308172313531353 q5 4352445545014455 q6 222 183 134 134 q7 1906200317871787 q8 2533236425342364 q9 7288734471027102 q10 3321345128972897 q11 552 508 494 494 q12 677 770 639 639 q13 3441368632963296 q14 289 309 285 285 q15 521 451 457 451 q16 456 502 435 435 q17 1179143814301430 q18 8117774377947743 q19 11257 102210481022 q20 1916191417641764 q21 14602 421943224219 q22 10531016972 972 Total cold run time: 72712 ms Total hot run time: 50548 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
hello-stephen commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157288969 # FE UT Coverage Report Increment line coverage `` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/54278_e1b19ccfe0e30ce5193cb57394397df27770610f/fe_increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/54278_e1b19ccfe0e30ce5193cb57394397df27770610f/fe_report/index.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
w41ter commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3157199034 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
dataroaring commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3150689451 cursor review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refactor](cloud) Add versioned read checking [doris]
Thearas commented on PR #54278: URL: https://github.com/apache/doris/pull/54278#issuecomment-3149415466 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
