Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-20 Thread via GitHub


airborne12 merged PR #63233:
URL: https://github.com/apache/doris/pull/63233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-20 Thread via GitHub


github-actions[bot] commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4498018093

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-20 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4497622185

   # BE Regression && UT Coverage Report
   Increment line coverage `86.63% (149/172)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_c379e58a90c9554f934a78072d0e3299cde27ae6_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_c379e58a90c9554f934a78072d0e3299cde27ae6_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.69% (27875/37828) |
   | Line Coverage | 57.60% (302633/525404) |
   | Region Coverage   | 54.82% (253518/462425) |
   | Branch Coverage   | 56.31% (109398/194275) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-20 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4496102269

   
   
   TPC-DS: Total hot run time: 171520 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c379e58a90c9554f934a78072d0e3299cde27ae6, 
data reload: false
   
   query5   4372673 536 536
   query6   347 220 218 218
   query7   4331608 314 314
   query8   337 245 228 228
   query9   8849404040264026
   query10  450 347 313 313
   query11  5807240122132213
   query12  181 131 132 131
   query13  1276629 421 421
   query14  6048542351085108
   query14_14438440143764376
   query15  216 211 187 187
   query16  1011475 459 459
   query17  1102753 628 628
   query18  2457502 367 367
   query19  226 210 186 186
   query20  149 138 145 138
   query21  221 147 129 129
   query22  13633   13548   13470   13470
   query23  17245   16376   16123   16123
   query23_116116   16263   16174   16174
   query24  7644179213241324
   query24_11337133013331330
   query25  585 505 454 454
   query26  1307337 183 183
   query27  2687572 348 348
   query28  4488196419941964
   query29  1017647 539 539
   query30  314 239 206 206
   query31  11191070949 949
   query32  98  79  79  79
   query33  551 379 321 321
   query34  11941140650 650
   query35  797 774 685 685
   query36  1296127011431143
   query37  157 113 102 102
   query38  3228315730943094
   query39  936 924 903 903
   query39_1862 881 853 853
   query40  244 148 136 136
   query41  70  67  65  65
   query42  109 109 114 109
   query43  325 335 296 296
   query44  
   query45  212 205 197 197
   query46  11011233742 742
   query47  2325227221792179
   query48  386 413 297 297
   query49  651 503 397 397
   query50  1030361 261 261
   query51  4353442542234223
   query52  105 105 97  97
   query53  251 294 208 208
   query54  309 277 255 255
   query55  102 105 85  85
   query56  310 324 300 300
   query57  1402138012771277
   query58  316 286 273 273
   query59  1556163714491449
   query60  338 340 321 321
   query61  168 164 161 161
   query62  677 631 566 566
   query63  245 206 212 206
   query64  2441815 637 637
   query65  
   query66  1749485 358 358
   query67  30254   30173   30168   30168
   query68  
   query69  464 348 315 315
   query70  1063102910031003
   query71  312 286 274 274
   query72  3166273424232423
   query73  887 814 419 419
   query74  5099494547554755
   query75  2685261123912391
   query76  23021150809 809
   query77  412 432 348 348
   query78  12322   12191   11894   11894
   query79  14921010789 789
   query80  993 570 481 481
   query81  509 276 248 248
   query82  1385163 128 128
   query83  372 281 252 252
   query84  291 146 118 118
   query85  936 568 469 469
   query86  454 360 339 339
   query87  3425338832573257
   query88  3595268026702670
   query89  446 395 336 336
   query90  1831190 192 190
   query91  186 175 142 142
   query92  82  83  77  77
   query93  14981495840 840
   query94  633 360 308 308
   query95  692 386 446 386
   query96  1051806 338 338
   query97  2681269526082608
   query98  255 236 228 228
   query99  11291087967 967
   Total cold run time: 254799 ms
   Total hot run time: 171520 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-20 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4496003771

   
   
   TPC-H: Total hot run time: 31562 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c379e58a90c9554f934a78072d0e3299cde27ae6, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17832   396038283828
   q2   q3  10742   1493845 845
   q4   4684483 342 342
   q5   7734233221962196
   q6   238 184 139 139
   q7   979 800 645 645
   q8   9429180815611561
   q9   5137492648934893
   q10  6384210017961796
   q11  448 275 240 240
   q12  634 445 296 296
   q13  18148   340828012801
   q14  258 258 240 240
   q15  q16 822 778 713 713
   q17  969 907 919 907
   q18  6984577056005600
   q19  1154119711371137
   q20  671 454 310 310
   q21  6257297527332733
   q22  478 527 340 340
   Total cold run time: 99982 ms
   Total hot run time: 31562 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4625457645674567
   q2   q3  4855530945774577
   q4   2165222714281428
   q5   5014465946554655
   q6   239 181 133 133
   q7   1912176515391539
   q8   2425213821602138
   q9   7653730472287228
   q10  4488440139883988
   q11  545 398 368 368
   q12  714 728 513 513
   q13  304128262826
   q14  268 274 243 243
   q15  q16 686 700 621 621
   q17  1284126712521252
   q18  7493696165986598
   q19  1142106711381067
   q20  2205224419231923
   q21  5418468645054505
   q22  529 464 415 415
   Total cold run time: 56701 ms
   Total hot run time: 50584 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-19 Thread via GitHub


yiguolei commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4494978803

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-19 Thread via GitHub


csun5285 commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4494929426

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-19 Thread via GitHub


yiguolei commented on code in PR #63233:
URL: https://github.com/apache/doris/pull/63233#discussion_r3270821289


##
be/src/storage/segment/column_writer.cpp:
##
@@ -338,28 +330,25 @@ Status ColumnWriter::create_variant_writer(const 
ColumnWriterOptions& opts,
 if (column->is_extracted_column()) {
 if (column->name().find(DOC_VALUE_COLUMN_PATH) != std::string::npos) {
 *writer = std::make_unique(
-opts, column,
-
std::unique_ptr(StorageFieldFactory::create(*column)));
+opts, std::make_shared(*column));
 return Status::OK();
 }
 VLOG_DEBUG << "gen subwriter for " << 
column->path_info_ptr()->get_path();
-*writer = std::make_unique(
-opts, column, 
std::unique_ptr(StorageFieldFactory::create(*column)));
+*writer = std::make_unique(opts,
+   
std::make_shared(*column));
 return Status::OK();
 }
-*writer = std::make_unique(
-opts, column, 
std::unique_ptr(StorageFieldFactory::create(*column)));
+*writer = std::make_unique(opts, 
std::make_shared(*column));
 return Status::OK();
 }
 
 //Todo(Amory): here should according nullable and offset and need sub to 
simply this function
 Status ColumnWriter::create(const ColumnWriterOptions& opts, const 
TabletColumn* column,

Review Comment:
   我们这堆接口传递column*, 我看底下都是copy了一次,为什么不直接传递column的shared ptr啊



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-19 Thread via GitHub


yiguolei commented on code in PR #63233:
URL: https://github.com/apache/doris/pull/63233#discussion_r3270802946


##
be/benchmark/benchmark_zone_map_index.hpp:
##
@@ -116,9 +115,8 @@ std::unique_ptr make_writer() {
 col = make_column(FieldType::OLAP_FIELD_TYPE_VARCHAR, 64, 1);
 dtype = DataTypeFactory::instance().create_data_type(TYPE_VARCHAR, 
false, 0, 0, 64);
 }
-std::unique_ptr field(StorageFieldFactory::create(*col));
 std::unique_ptr w;
-(void)ZoneMapIndexWriter::create(dtype, field.get(), w);
+(void)ZoneMapIndexWriter::create(dtype, col.get(), w);

Review Comment:
   这个不应该返回void



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-17 Thread via GitHub


airborne12 commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4470060296

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-17 Thread via GitHub


github-actions[bot] commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4470055573

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-17 Thread via GitHub


github-actions[bot] commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4470055327

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-15 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4458307908

   # BE Regression && UT Coverage Report
   Increment line coverage `88.30% (151/171)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_2a6bd48455b629e25dd2b406e79f413994320d94_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_2a6bd48455b629e25dd2b406e79f413994320d94_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.92% (27114/37700) |
   | Line Coverage | 55.21% (288946/523352) |
   | Region Coverage   | 52.17% (239773/459559) |
   | Branch Coverage   | 53.51% (103400/193227) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4457630543

   # BE Regression && UT Coverage Report
   Increment line coverage `88.30% (151/171)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_2a6bd48455b629e25dd2b406e79f413994320d94_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_2a6bd48455b629e25dd2b406e79f413994320d94_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.92% (27114/37700) |
   | Line Coverage | 55.21% (288939/523352) |
   | Region Coverage   | 52.13% (239588/459559) |
   | Branch Coverage   | 53.51% (103391/193227) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4457399795

   # BE UT Coverage Report
   Increment line coverage `69.19% (119/172)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/2a6bd48455b629e25dd2b406e79f413994320d94_2a6bd48455b629e25dd2b406e79f413994320d94/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/2a6bd48455b629e25dd2b406e79f413994320d94_2a6bd48455b629e25dd2b406e79f413994320d94/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.53% (20604/38494) |
   | Line Coverage | 37.15% (194950/524720) |
   | Region Coverage   | 33.53% (152590/455134) |
   | Branch Coverage   | 34.54% (66491/192497) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4457045409

   
   
   TPC-DS: Total hot run time: 170724 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 2a6bd48455b629e25dd2b406e79f413994320d94, 
data reload: false
   
   query5   4346638 519 519
   query6   315 225 193 193
   query7   4248570 304 304
   query8   321 241 213 213
   query9   8836397639523952
   query10  447 336 297 297
   query11  5805239622172217
   query12  180 125 122 122
   query13  1271602 437 437
   query14  6031531850135013
   query14_14312435743464346
   query15  208 198 182 182
   query16  985 444 442 442
   query17  1117734 612 612
   query18  2435468 350 350
   query19  209 196 154 154
   query20  133 127 130 127
   query21  212 135 113 113
   query22  13625   13383   13327   13327
   query23  17233   16255   16707   16255
   query23_116419   16292   16287   16287
   query24  7651181513891389
   query24_11426144414131413
   query25  595 495 436 436
   query26  1398313 160 160
   query27  2727578 325 325
   query28  4422195919711959
   query29  965 621 509 509
   query30  297 229 191 191
   query31  11221063946 946
   query32  85  68  66  66
   query33  522 334 284 284
   query34  11881133657 657
   query35  738 770 678 678
   query36  1346131911981198
   query37  147 101 84  84
   query38  3183308630463046
   query39  927 917 890 890
   query39_1878 881 871 871
   query40  229 150 137 137
   query41  64  59  61  59
   query42  106 103 113 103
   query43  314 326 277 277
   query44  
   query45  207 201 188 188
   query46  10501166719 719
   query47  2361227421602160
   query48  379 432 302 302
   query49  626 522 413 413
   query50  715 278 213 213
   query51  4312424842594248
   query52  105 101 90  90
   query53  250 275 197 197
   query54  302 270 248 248
   query55  90  87  83  83
   query56  284 306 301 301
   query57  1430140813051305
   query58  290 259 265 259
   query59  1553163013831383
   query60  353 319 313 313
   query61  164 159 185 159
   query62  675 622 572 572
   query63  241 206 203 203
   query64  2497866 716 716
   query65  
   query66  1758522 409 409
   query67  30033   30043   29875   29875
   query68  
   query69  471 348 313 313
   query70  1020989 946 946
   query71  310 287 264 264
   query72  3170313425392539
   query73  809 778 419 419
   query74  5088488746924692
   query75  2764266522962296
   query76  22981132780 780
   query77  409 420 353 353
   query78  12958   13021   12346   12346
   query79  1469995 728 728
   query80  1367568 482 482
   query81  519 282 236 236
   query82  1291158 123 123
   query83  353 274 253 253
   query84  264 136 107 107
   query85  944 512 452 452
   query86  463 335 315 315
   query87  3395333732123212
   query88  3551269326822682
   query89  432 373 333 333
   query90  1894177 177 177
   query91  178 169 146 146
   query92  77  77  72  72
   query93  942 954 562 562
   query94  704 326 306 306
   query95  669 473 339 339
   query96  1007766 336 336
   query97  2708268925542554
   query98  231 227 247 227
   query99  11871127982 982
   Total cold run time: 254573 ms
   Total hot run time: 170724 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4457002539

   
   
   TPC-H: Total hot run time: 29501 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2a6bd48455b629e25dd2b406e79f413994320d94, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17659   382538403825
   q2   q3  10700   894 596 596
   q4   4682451 348 348
   q5   7450134811411141
   q6   185 165 137 137
   q7   920 962 745 745
   q8   9310144512741274
   q9   5586536953285328
   q10  6262208817901790
   q11  465 266 258 258
   q12  628 429 288 288
   q13  18066   330327802780
   q14  286 289 260 260
   q15  q16 906 885 800 800
   q17  929 947 755 755
   q18  6539572956095609
   q19  1170125611031103
   q20  525 389 264 264
   q21  4822228318891889
   q22  430 352 311 311
   Total cold run time: 97520 ms
   Total hot run time: 29501 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4150411641124112
   q2   q3  4639475241784178
   q4   2102216313691369
   q5   4961496252374962
   q6   188 163 128 128
   q7   2021176317591759
   q8   3626320032873200
   q9   8459852585318525
   q10  4516449442384238
   q11  611 434 389 389
   q12  699 768 499 499
   q13  3572358529382938
   q14  294 309 288 288
   q15  q16 780 796 678 678
   q17  1334130612541254
   q18  8051708570817081
   q19  1148115511791155
   q20  2205222519541954
   q21  6195541048694869
   q22  567 514 446 446
   Total cold run time: 60118 ms
   Total hot run time: 54022 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


csun5285 commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4456579369

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4449732055

   # BE Regression && UT Coverage Report
   Increment line coverage `91.23% (156/171)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_dba29514cf661aeb26b3d7da818211a793307cac_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/63233_dba29514cf661aeb26b3d7da818211a793307cac_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.77% (27752/37619) |
   | Line Coverage | 57.61% (301012/522530) |
   | Region Coverage   | 54.94% (251796/458291) |
   | Branch Coverage   | 56.40% (108782/192867) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [refactor](storage) drop StorageField wrapper and clean up related dead code [doris]

2026-05-14 Thread via GitHub


hello-stephen commented on PR #63233:
URL: https://github.com/apache/doris/pull/63233#issuecomment-4449645231

   # BE UT Coverage Report
   Increment line coverage `69.19% (119/172)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/dba29514cf661aeb26b3d7da818211a793307cac_dba29514cf661aeb26b3d7da818211a793307cac/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/dba29514cf661aeb26b3d7da818211a793307cac_dba29514cf661aeb26b3d7da818211a793307cac/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 53.64% (20603/38413) |
   | Line Coverage | 37.21% (194930/523904) |
   | Region Coverage   | 33.61% (152566/453867) |
   | Branch Coverage   | 34.60% (66485/192139) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]