Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


zclllyybb merged PR #53472:
URL: https://github.com/apache/doris/pull/53472


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


github-actions[bot] commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3087100070

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


github-actions[bot] commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3087099887

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


hello-stephen commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3087070525

   # BE Regression && UT Coverage Report
   Increment line coverage `97.06% (99/102)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53472_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53472_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.16% (21843/26914) |
   | Line Coverage | 73.71% (225712/306200) |
   | Region Coverage   | 61.43% (188494/306828) |
   | Branch Coverage   | 65.13% (81219/124705) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


Mryange commented on code in PR #53472:
URL: https://github.com/apache/doris/pull/53472#discussion_r2214850280


##
be/src/vec/functions/cast/cast_to_ip.h:
##
@@ -0,0 +1,188 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "cast_base.h"
+#include "runtime/primitive_type.h"
+#include "vec/columns/column_nullable.h"
+#include "vec/data_types/data_type_ipv4.h"
+
+namespace doris::vectorized {
+#include "common/compile_check_begin.h"
+
+template 
+class CastToImpl : public CastToBase {

Review Comment:
   可以的，不过可以先把这个pr合入。我后面补一些。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


yiguolei commented on code in PR #53472:
URL: https://github.com/apache/doris/pull/53472#discussion_r2214838905


##
be/src/vec/functions/cast/cast_to_ip.h:
##
@@ -0,0 +1,188 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "cast_base.h"
+#include "runtime/primitive_type.h"
+#include "vec/columns/column_nullable.h"
+#include "vec/data_types/data_type_ipv4.h"
+
+namespace doris::vectorized {
+#include "common/compile_check_begin.h"
+
+template 
+class CastToImpl : public CastToBase {

Review Comment:
   这些代码能否增加一些单侧啊？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


Mryange commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3086636929

   run cloud_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


hello-stephen commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3086592412

   # BE Regression && UT Coverage Report
   Increment line coverage `97.06% (99/102)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53472_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53472_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.16% (21843/26914) |
   | Line Coverage | 73.71% (225712/306200) |
   | Region Coverage   | 61.43% (188494/306828) |
   | Branch Coverage   | 65.13% (81219/124705) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


Mryange commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3086347946

   run cloud_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


hello-stephen commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3084872735

   # BE Regression && UT Coverage Report
   Increment line coverage `97.06% (99/102)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53472_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53472_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.16% (21843/26914) |
   | Line Coverage | 73.71% (225712/306200) |
   | Region Coverage   | 61.43% (188494/306828) |
   | Branch Coverage   | 65.13% (81219/124705) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


doris-robot commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3084846981

   # BE UT Coverage Report
   Increment line coverage `0.99% (1/101)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/0a4c2ff6c48d3002beb5a63087d4b145d3a9322d_0a4c2ff6c48d3002beb5a63087d4b145d3a9322d/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.43% (15756/27434) |
   | Line Coverage | 46.20% (141680/306683) |
   | Region Coverage   | 35.67% (106684/299115) |
   | Branch Coverage   | 38.18% (47087/123319) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


doris-robot commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3084349693

   
   
   ClickBench: Total hot run time: 32.32 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0a4c2ff6c48d3002beb5a63087d4b145d3a9322d, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.04
   query3   0.240.070.07
   query4   1.620.110.11
   query5   0.430.420.41
   query6   1.170.670.65
   query7   0.020.010.02
   query8   0.050.040.03
   query9   0.610.530.51
   query10  0.580.570.60
   query11  0.150.110.10
   query12  0.150.110.11
   query13  0.630.610.62
   query14  0.780.810.82
   query15  0.890.850.90
   query16  0.380.380.41
   query17  1.091.041.06
   query18  0.220.210.22
   query19  2.001.821.89
   query20  0.020.010.01
   query21  15.42   0.880.54
   query22  0.751.140.65
   query23  15.02   1.380.62
   query24  7.031.790.83
   query25  0.490.340.09
   query26  0.610.160.14
   query27  0.060.050.06
   query28  9.610.940.45
   query29  12.55   4.023.31
   query30  3.072.982.91
   query31  2.820.600.39
   query32  3.230.560.47
   query33  3.063.083.08
   query34  15.93   5.404.80
   query35  4.804.864.80
   query36  0.670.510.50
   query37  0.090.070.06
   query38  0.050.040.03
   query39  0.030.020.03
   query40  0.170.140.13
   query41  0.080.020.03
   query42  0.030.020.02
   query43  0.040.030.03
   Total cold run time: 106.76 s
   Total hot run time: 32.32 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


doris-robot commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3084330688

   
   
   TPC-DS: Total hot run time: 187320 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0a4c2ff6c48d3002beb5a63087d4b145d3a9322d, 
data reload: false
   
   query1   969 377 401 377
   query2   6519171117241711
   query3   6736214 217 214
   query4   26983   23735   23205   23205
   query5   4352589 441 441
   query6   303 227 201 201
   query7   4622480 288 288
   query8   280 247 216 216
   query9   8645260226032602
   query10  476 323 278 278
   query11  15132   15109   15043   15043
   query12  173 107 108 107
   query13  1649529 400 400
   query14  9574595158685868
   query15  200 197 167 167
   query16  7663663 467 467
   query17  1362716 600 600
   query18  2039408 320 320
   query19  196 192 165 165
   query20  125 124 109 109
   query21  215 125 111 111
   query22  4160435840094009
   query23  33967   33214   33365   33214
   query24  8441238724232387
   query25  525 466 414 414
   query26  1230261 150 150
   query27  2728498 335 335
   query28  4265212220982098
   query29  716 556 438 438
   query30  284 224 194 194
   query31  945 865 751 751
   query32  73  64  66  64
   query33  579 364 315 315
   query34  799 843 518 518
   query35  780 822 719 719
   query36  974 991 942 942
   query37  112 126 75  75
   query38  4113408941044089
   query39  1477145215121452
   query40  214 121 109 109
   query41  60  57  53  53
   query42  119 103 109 103
   query43  498 506 462 462
   query44  1352845 824 824
   query45  176 168 163 163
   query46  830 993 623 623
   query47  1733180017441744
   query48  386 433 306 306
   query49  709 498 391 391
   query50  634 703 408 408
   query51  5503549454055405
   query52  110 110 100 100
   query53  218 253 184 184
   query54  581 578 508 508
   query55  83  86  84  84
   query56  305 297 278 278
   query57  1177120511241124
   query58  272 253 259 253
   query59  2647265426432643
   query60  332 314 314 314
   query61  134 136 160 136
   query62  804 732 649 649
   query63  227 194 192 192
   query64  4279989 662 662
   query65  4285418741624162
   query66  1079426 314 314
   query67  15972   15691   15637   15637
   query68  8647878 525 525
   query69  486 315 273 273
   query70  1264115810931093
   query71  461 319 283 283
   query72  5530476747664766
   query73  686 575 350 350
   query74  9227918689838983
   query75  4166319926712671
   query76  36551146720 720
   query77  789 375 328 328
   query78  990810076   92799279
   query79  4313827 571 571
   query80  646 515 458 458
   query81  482 251 224 224
   query82  589 131 96  96
   query83  279 251 238 238
   query84  296 102 86  86
   query85  796 432 313 313
   query86  349 302 314 302
   query87  4468444943524352
   query88  3231231223272312
   query89  444 311 288 288
   query90  1968209 206 206
   query91  138 141 110 110
   query92  73  58  56  56
   query93  2585902 574 574
   query94  679 409 307 307
   query95  373 291 277 277
   query96  490 565 282 282
   query97  2695271926162616
   query98  235 209 210 209
   query99  1452141912871287
   Total cold run time: 280500 ms
   Total hot run time: 187320 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


doris-robot commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3084288060

   
   
   TPC-H: Total hot run time: 33804 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0a4c2ff6c48d3002beb5a63087d4b145d3a9322d, 
data reload: false
   
   -- Round 1 --
   q1   17604   514550645064
   q2   1907292 178 178
   q3   10315   1288712 712
   q4   10230   1008520 520
   q5   7530240222942294
   q6   176 160 126 126
   q7   891 761 601 601
   q8   9312122610751075
   q9   6784512650615061
   q10  6886237119751975
   q11  475 287 289 287
   q12  340 345 225 225
   q13  17767   375431473147
   q14  234 223 230 223
   q15  552 481 467 467
   q16  424 453 373 373
   q17  574 845 348 348
   q18  7436725170467046
   q19  1204957 572 572
   q20  349 338 221 221
   q21  3811312823482348
   q22  1053990 941 941
   Total cold run time: 105854 ms
   Total hot run time: 33804 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5086504851265048
   q2   242 319 221 221
   q3   2192268822722272
   q4   1341176313421342
   q5   4185439146114391
   q6   211 169 125 125
   q7   2030200818161816
   q8   2616261825832583
   q9   7400717172597171
   q10  3294327528922892
   q11  564 511 494 494
   q12  723 803 664 664
   q13  3663417634023402
   q14  295 332 292 292
   q15  540 475 476 475
   q16  456 545 459 459
   q17  1172155613701370
   q18  8049773576277627
   q19  773 785 837 785
   q20  2037206519161916
   q21  5109447444424442
   q22  10211019981 981
   Total cold run time: 52999 ms
   Total hot run time: 50768 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refine](cast) refine cast to ip and delete some useless code [doris]

2025-07-17 Thread via GitHub 


Mryange commented on PR #53472:
URL: https://github.com/apache/doris/pull/53472#issuecomment-3084175499

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]