Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-09-07 Thread via GitHub 


zhouyuan commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3950614216


##
.github/workflows/velox_backend_cache.yml:
##
@@ -139,28 +140,29 @@ jobs:
 uses: actions/cache/restore@v3
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-enhanced-centos7-release-default-${{github.sha}}
+  key: ccache-enhanced-almalinux8-release-default-${{github.sha}}
   restore-keys: |
-ccache-enhanced-centos7-release-default
+ccache-enhanced-almalinux8-release-default
   - name: Build Gluten native libraries
 run: |
-  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-09-07 Thread via GitHub 


zhouyuan commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3950611424


##
.github/workflows/velox_backend_cache.yml:
##
@@ -38,28 +38,29 @@ jobs:
 uses: actions/cache/restore@v3
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-centos7-release-default-${{github.sha}}
+  key: ccache-almalinux8-release-default-${{github.sha}}
   restore-keys: |
-ccache-centos7-release-default
+ccache-almalinux8-release-default
   - name: Build Gluten native libraries
 run: |
-  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "

Review Comment:
   please use docker image name for this job as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-09-07 Thread via GitHub 


zhouyuan commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3950615762


##
.github/workflows/velox_backend_enhanced.yml:
##
@@ -89,28 +89,28 @@ jobs:
 uses: 
apache/infrastructure-actions/stash/restore@69afc125e535c4c41e7f1b7470f583087e0f344b
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-enhanced-centos7-release-default-${{ 
hashFiles('ep/build-velox/src/**') }}
+  key: ccache-enhanced-almalinux8-release-default-${{ 
hashFiles('ep/build-velox/src/**') }}
   - name: Get Ccache from actions/cache (fallback on Stash miss)
 if: steps.ccache-stash.outputs.stash-hit != 'true'
 uses: actions/cache/restore@v4
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-enhanced-centos7-release-default-${{github.sha}}
+  key: ccache-enhanced-almalinux8-release-default-${{github.sha}}
   restore-keys: |
-ccache-enhanced-centos7-release-default
+ccache-enhanced-almalinux8-release-default
   - name: Build Gluten native libraries
 run: |
-  docker pull apache/gluten:vcpkg-centos-7-gcc13
-  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+  docker pull apache/gluten:vcpkg-almalinux-8-gcc13
+  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-08-27 Thread via GitHub 


Copilot commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3869976105


##
dev/vcpkg/README.md:
##
@@ -9,8 +9,9 @@ except for those overridden in `vcpkg.json`, 
`vcpkg-configuration.json`, and ove
 ## Build in docker
 
 For main branch code, you can follow the commands below.
-- Pull the docker image: `docker pull apache/gluten:vcpkg-centos-7-gcc13`
-- Build native code: `bash dev/ci-velox-buildstatic-centos-7.sh`
+
+- Pull the docker image: `docker pull apache/gluten:vcpkg-almalinux-8-gcc13`
+- Build native code: `bash dev/ci-velox-buildstatic-centos-8.sh`
 - Build JVM code: `mvn clean install -Pbackends-velox -Pspark-3.5 -DskipTests`

Review Comment:
   This quick-start uses `mvn` directly. In this repo, Maven should be invoked 
via the `./build/mvn` wrapper (it pins the Maven version and JVM flags Gluten 
expects), so the documented command should use the wrapper as well.



##
dev/docker/Dockerfile.almalinux8-gcc13-static-build:
##
@@ -44,7 +44,7 @@ RUN set -ex; \
 dnf install -y ccache; \
 # gcc-toolset-13 ships GCC 13 on RHEL8-family via Red Hat Software 
Collections. \
 dnf install -y --setopt=install_weak_deps=False gcc-toolset-13; \
-dnf install -y java-1.8.0-openjdk-devel patch git wget perl python3 
automake libtool flex; \
+dnf install -y java-1.8.0-openjdk-devel patch git wget perl python3 
automake libtool flex bison; \

Review Comment:
   `bison` is now baked into the AlmaLinux 8 static-build image here, but 
several workflows still run `yum install bison -y` inside the build container. 
This adds network/package-manager variability to CI and can also mask whether 
the image itself is self-contained. Consider removing those `yum install bison` 
steps (or, if CI needs to install it dynamically, drop it from the image 
instead).



##
.github/workflows/velox_nightly.yml:
##
@@ -184,7 +185,7 @@ jobs:
   build-native-lib-centos-8-arm64:
 if: ${{ startsWith(github.repository, 'apache/') }}
 runs-on: ubuntu-24.04-arm
-container: apache/gluten:vcpkg-centos-8-gcc13
+container: apache/gluten:vcpkg-almalinux-8-gcc13

Review Comment:
   This job now runs in the AlmaLinux 8 vcpkg image (line 188), but the ccache 
restore/save keys later in the job are still prefixed `ccache-centos8-...` 
(e.g. lines 195 and 212). Reusing ccache across different base 
images/toolchains can cause cache pollution and flaky builds; please rename 
those keys/restore-keys to an `almalinux8` prefix (consistent with the x86 job 
above).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-08-27 Thread via GitHub 


zhouyuan commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3869975727


##
.github/workflows/velox_backend_x86.yml:
##
@@ -156,27 +156,27 @@ jobs:
 uses: 
apache/infrastructure-actions/stash/restore@0ba14156c9f4c3cfbe4b0c9f36339ab0f8d81e53
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-centos7-release-default-${{ 
hashFiles('ep/build-velox/src/**') }}
+  key: ccache-almalinux8-release-default-${{ 
hashFiles('ep/build-velox/src/**') }}
   - name: Get Ccache from actions/cache (fallback on Stash miss)
 if: steps.ccache-stash.outputs.stash-hit != 'true'
 uses: actions/cache/restore@v4
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-centos7-release-default-${{github.sha}}
+  key: ccache-almalinux8-release-default-${{github.sha}}
   restore-keys: |
-ccache-centos7-release-default
+ccache-almalinux8-release-default
   - name: Build Gluten native libraries
 run: |
-  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "

Review Comment:
   it's still running inside a docker. using the container image for this job 
should work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-08-24 Thread via GitHub 


zhouyuan commented on code in PR #12663:
URL: https://github.com/apache/gluten/pull/12663#discussion_r3843764158


##
.github/workflows/velox_backend_cache.yml:
##
@@ -38,28 +38,29 @@ jobs:
 uses: actions/cache/restore@v3
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-centos7-release-default-${{github.sha}}
+  key: ccache-centos8-release-default-${{github.sha}}
   restore-keys: |
-ccache-centos7-release-default
+ccache-centos8-release-default
   - name: Build Gluten native libraries
 run: |
-  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "
+yum install bison -y
 export CCACHE_DIR=/work/.ccache
 export CCACHE_MAXSIZE=1G
 mkdir -p /work/.ccache
-bash dev/ci-velox-buildstatic-centos-7.sh
+bash dev/ci-velox-buildstatic-centos-8.sh
   "
   - name: Save Ccache
 uses: actions/cache/save@v3
 id: ccache
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-centos7-release-default-${{github.sha}}
+  key: ccache-centos8-release-default-${{github.sha}}

Review Comment:
   duplicated key name with L79



##
.github/workflows/build_bundle_package.yml:
##
@@ -50,16 +50,17 @@ jobs:
 uses: actions/cache/restore@v3
 with:
   path: '${{ env.CCACHE_DIR }}'
-  key: ccache-centos7-release-default-${{github.sha}}
+  key: ccache-centos8-release-default-${{github.sha}}
   restore-keys: |
-ccache-centos7-release-default
+ccache-centos8-release-default
   - name: Build Gluten velox third party
 run: |
-  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-centos-7-gcc13 bash -c "
+  docker run -v $GITHUB_WORKSPACE:/work -w /work 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "

Review Comment:
   Initially there is a Glibc issue when running the centos7 container on GHA, 
so we switch to run the script inside container instead. Since we have 
upgraded, could we use the container setting of GHA now?
   
https://github.com/apache/gluten/blob/main/.github/workflows/velox_backend_x86.yml#L250



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-08-12 Thread via GitHub 


KushShriv commented on PR #12663:
URL: https://github.com/apache/gluten/pull/12663#issuecomment-5265474171

   @zhouyuan Here's the Other PR with just the new docker image: 
https://github.com/apache/gluten/pull/12757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-08-10 Thread via GitHub 


zhouyuan commented on PR #12663:
URL: https://github.com/apache/gluten/pull/12663#issuecomment-5240954311

   @KushShriv, thanks for the patch! Would you mind splitting it and adding the 
new Docker image as the first step?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] [GLUTEN-12412][VL] Migrate x86/arm vcpkg native lib build from CentOS 7 to AlmaLinux 8 [gluten]

2026-07-30 Thread via GitHub 


KushShriv opened a new pull request, #12663:
URL: https://github.com/apache/gluten/pull/12663

   ## What changes are proposed in this pull request?
   Fixes #12412
   
   CentOS 7 (`glibc 2.17`) is increasingly difficult to maintain as a vcpkg 
build base due to Velox's growing dependency on modern Folly/FBThrift/MVFST 
versions. This PR migrates the x86/arm native lib build to AlmaLinux 8 (`glibc 
2.28`), a 1:1 RHEL 8-compatible rebuild of the EOL CentOS 8.
   
   ### Commit 1 — Add AlmaLinux 8 vcpkg static build CI image:
   
   - Add `dev/docker/Dockerfile.almalinux8-gcc13-static-build` to produce 
`apache/gluten:vcpkg-almalinux-8-gcc13`, modelled on the existing 
`Dockerfile.centos7-gcc13-static-build`. 
   Uses `FROM almalinux:8` (live repos, no mirror fixups needed) with GCC 13 
via `gcc-toolset-13` and a pinned CMake 3.31.12.
   - Add dev/ci-velox-buildstatic-centos-8-enhanced-features.sh — the CentOS 8 
equivalent of the existing ci-velox-buildstatic-centos-7-enhanced-features.sh, 
omitting the socket.h workaround required on CentOS 7.
   - Add build-vcpkg-almalinux-8-gcc13 and merge-almalinux-8-gcc13 jobs to 
docker_image.yml to build and publish the multi-arch image.
   
   ### Commit 2 — Migrate x86/arm native lib build from CentOS 7 to AlmaLinux 8:
   
   - `velox_backend_x86.yml`: rename build job `centos-7` → `centos-8`, switch 
image and build script, update ccache keys and artifact names, remove the 
now-unnecessary `tpc-test-centos7` job and CentOS mirror fixup steps.
   - `velox_backend_enhanced.yml, velox_backend_ansi.yml, velox_nightly.yml, 
velox_backend_cache.yml, build_bundle_package.yml, build_release.yml`: same 
image/script/ccache/artifact migration.
   - `cpp_clang_tidy.yml`: update artifact download name to match the renamed 
artifact from `velox_backend_x86.yml`.
   - `dev/vcpkg/README.md`: update "Build in docker" quick-start to reference 
the new image and script.
   
   ## How was this patch tested?
   CI will validate all workflow changes. The 
`Dockerfile.almalinux8-gcc13-static-build` follows the same structure as the 
existing `Dockerfile.centos8-gcc13-static-build` and has been verified to build 
successfully locally.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   Generated-by: Claude Sonnet 4.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]