Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
marin-ma merged PR #12690: URL: https://github.com/apache/gluten/pull/12690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
marin-ma commented on code in PR #12690:
URL: https://github.com/apache/gluten/pull/12690#discussion_r3760481390
##
dev/build-helper-functions.sh:
##
@@ -234,6 +234,7 @@ function setup_linux {
if [[ "$LINUX_DISTRIBUTION" == "ubuntu" || "$LINUX_DISTRIBUTION" == "debian"
|| "$LINUX_DISTRIBUTION" == "pop" ]]; then
scripts/setup-ubuntu.sh
elif [[ "$LINUX_DISTRIBUTION" == "centos" ]]; then
+source scripts/setup-centos-adapters.sh
Review Comment:
`setup-centos-adapters.sh` is a velox script to install centos dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
marin-ma commented on PR #12690: URL: https://github.com/apache/gluten/pull/12690#issuecomment-5257008653 @zhouyuan @philo-he Can you please help to review again? I also made some changes to the common build scripts. Without these changes, the dynamic build on centos 9 will fail when building from scratch with flags `--enable_s3=ON --enable_gcs=ON --enable_hdfs=ON --enable_abfs=ON` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
marin-ma commented on code in PR #12690:
URL: https://github.com/apache/gluten/pull/12690#discussion_r3760467296
##
dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf:
##
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM quay.io/centos/centos:stream9
+
+ARG JAVA_VERSION=17
+
+ENV JAVA_HOME=/usr/lib/jvm/java-${JAVA_VERSION}-openjdk
+ENV PATH=$JAVA_HOME/bin:$PATH
+ENV CUDA_ARCHITECTURES=75
+ENV
LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH
+ENV
CURL_ROOT=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build
+ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \
+CXX=/opt/rh/gcc-toolset-14/root/bin/g++
+
+RUN dnf config-manager --add-repo
"https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";
&& \
+dnf update -y && \
+dnf install -y sudo patch java-${JAVA_VERSION}-openjdk-devel maven perl
git gcc-toolset-14 cuda-toolkit-13-1 && \
+dnf autoremove -y && dnf clean all
+
+RUN git clone --depth=1 https://github.com/apache/gluten /opt/gluten
+
+WORKDIR /opt/gluten
+
+RUN source /opt/rh/gcc-toolset-14/enable && \
+bash ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.5 --build_tests=ON --build_benchmarks=ON --enable_s3=ON
--enable_gcs=ON --enable_hdfs=ON --enable_abfs=ON --enable_gpu=ON build_arrow
&& \
+rm -rf /opt/gluten /root/.cache/ccache
Review Comment:
`--run_setup_script=ON --build_arrow=ON build_arrow` will install all the
dependencies. No need to build velox and gluten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
Copilot commented on code in PR #12690:
URL: https://github.com/apache/gluten/pull/12690#discussion_r3759595809
##
dev/build-helper-functions.sh:
##
@@ -234,6 +234,7 @@ function setup_linux {
if [[ "$LINUX_DISTRIBUTION" == "ubuntu" || "$LINUX_DISTRIBUTION" == "debian"
|| "$LINUX_DISTRIBUTION" == "pop" ]]; then
scripts/setup-ubuntu.sh
elif [[ "$LINUX_DISTRIBUTION" == "centos" ]]; then
+source scripts/setup-centos-adapters.sh
case "$LINUX_VERSION_ID" in
Review Comment:
`setup_linux` sources `scripts/setup-centos-adapters.sh`, but this file
doesn't exist in this repo, and GitHub code search shows no such file in the
Velox repo (`IBM/velox`) that `get-velox.sh` clones. This will make CentOS
setup fail with "No such file or directory" before dependencies are installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
Copilot commented on code in PR #12690:
URL: https://github.com/apache/gluten/pull/12690#discussion_r3750467305
##
dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf:
##
@@ -0,0 +1,42 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM quay.io/centos/centos:stream9
+
+ARG JAVA_VERSION=17
+
+ENV JAVA_HOME=/usr/lib/jvm/java-${JAVA_VERSION}-openjdk
+ENV PATH=$JAVA_HOME/bin:$PATH
+ENV CUDA_ARCHITECTURES=75
+ENV
LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH
+ENV
CURL_ROOT=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build
+ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \
+CXX=/opt/rh/gcc-toolset-14/root/bin/g++
+
+RUN dnf config-manager --add-repo
"https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";
&& \
+dnf update -y && \
+dnf install -y sudo patch java-${JAVA_VERSION}-openjdk-devel maven perl
git gcc-toolset-14 cuda-toolkit-13-1 && \
+dnf autoremove -y && dnf clean all
+
+RUN git clone --depth=1 https://github.com/apache/gluten /opt/gluten
+
+WORKDIR /opt/gluten
+
+RUN source /opt/rh/gcc-toolset-14/enable && \
+bash ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.5 --build_tests=ON --build_benchmarks=ON --enable_s3=ON
--enable_gcs=ON --enable_hdfs=ON --enable_abfs=ON --enable_gpu=ON build_arrow
&& \
+rm -rf /opt/gluten /root/.cache/ccache
Review Comment:
The trailing `build_arrow` argument changes `buildbundle-veloxbe.sh` into
“run specific command(s)” mode, which skips `get_velox` and
`setup_dependencies` entirely (see `dev/builddeps-veloxbe.sh`: it only does
full setup when no extra commands are passed). This is likely to either fail or
silently skip the adapter dependency installation this image is meant to
include. Drop the explicit `build_arrow` argument and rely on
`--build_arrow=ON` (default flow) instead.
##
dev/build-helper-functions.sh:
##
@@ -234,6 +234,7 @@ function setup_linux {
if [[ "$LINUX_DISTRIBUTION" == "ubuntu" || "$LINUX_DISTRIBUTION" == "debian"
|| "$LINUX_DISTRIBUTION" == "pop" ]]; then
scripts/setup-ubuntu.sh
elif [[ "$LINUX_DISTRIBUTION" == "centos" ]]; then
+source scripts/setup-centos-adapters.sh
Review Comment:
`setup_linux` now sources `scripts/setup-centos-adapters.sh`, but this repo
doesn’t provide that script (and `ep/build-velox/src/get-velox.sh` doesn’t
patch Velox to add it). Unless the external Velox branch happens to contain it,
CentOS builds will fail at `source` time with “No such file or directory”.
Consider sourcing Gluten’s existing adapter setup script instead (it defines
`install_adapters` via `ep/build-velox/src/setup-rhel.sh`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
zhouyuan commented on PR #12690: URL: https://github.com/apache/gluten/pull/12690#issuecomment-5239453553 should we also remove the old jdk8 based image? https://github.com/apache/gluten/blob/main/.github/workflows/docker_image.yml#L61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
Copilot commented on code in PR #12690:
URL: https://github.com/apache/gluten/pull/12690#discussion_r3720124884
##
dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf:
##
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM quay.io/centos/centos:stream9
+
+ARG JAVA_VERSION=17
+
+ENV JAVA_HOME=/usr/lib/jvm/java-${JAVA_VERSION}-openjdk
+ENV PATH=$JAVA_HOME/bin:$PATH
+ENV CUDA_ARCHITECTURES=75
+ENV
LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH
+ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \
+CXX=/opt/rh/gcc-toolset-14/root/bin/g++
+
+RUN dnf config-manager --add-repo
"https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";
&& \
+dnf update -y && \
+dnf install -y sudo patch java-${JAVA_VERSION}-openjdk-devel maven perl
git gcc-toolset-14 cuda-toolkit-13-1 && \
+dnf autoremove -y && dnf clean all && \
+git clone --depth=1 https://github.com/apache/gluten /opt/gluten && \
+cd /opt/gluten && \
+source /opt/rh/gcc-toolset-14/enable && \
+bash ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.5 --build_tests=ON --build_benchmarks=ON --enable_s3=ON
--enable_gcs=ON --enable_abfs=ON --enable_gpu=ON && \
Review Comment:
`RUN` commands use `/bin/sh -c` by default, where `source` is not guaranteed
to exist (often only available in bash). This can break the build on CentOS
Stream 9. Use POSIX dot (`. /opt/rh/gcc-toolset-14/enable`) or run the whole
sequence under bash (e.g., `bash -lc ...`) so enabling the toolset reliably
affects the subsequent build command.
##
dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf:
##
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM quay.io/centos/centos:stream9
+
+ARG JAVA_VERSION=17
+
+ENV JAVA_HOME=/usr/lib/jvm/java-${JAVA_VERSION}-openjdk
+ENV PATH=$JAVA_HOME/bin:$PATH
+ENV CUDA_ARCHITECTURES=75
+ENV
LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH
+ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \
+CXX=/opt/rh/gcc-toolset-14/root/bin/g++
+
+RUN dnf config-manager --add-repo
"https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";
&& \
+dnf update -y && \
+dnf install -y sudo patch java-${JAVA_VERSION}-openjdk-devel maven perl
git gcc-toolset-14 cuda-toolkit-13-1 && \
+dnf autoremove -y && dnf clean all && \
+git clone --depth=1 https://github.com/apache/gluten /opt/gluten && \
+cd /opt/gluten && \
+source /opt/rh/gcc-toolset-14/enable && \
+bash ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.5 --build_tests=ON --build_benchmarks=ON --enable_s3=ON
--enable_gcs=ON --enable_abfs=ON --enable_gpu=ON && \
+rm -rf /opt/gluten && \
Review Comment:
`LD_LIBRARY_PATH` is set to a build output inside `/opt/gluten`, but
`/opt/gluten` is deleted later in the same image build. That makes the
environment variable point to a non-existent path at runtime and can also mask
real dynamic-link errors. Either avoid setting this globally, or copy/install
the needed runtime libraries into a stable location (and point
`LD_LIBRARY_PATH` there) before removing `/opt/gluten`.
##
dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf:
##
@@ -0,0 +1,41 @@
+#
+# Licensed to the
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
Copilot commented on code in PR #12690: URL: https://github.com/apache/gluten/pull/12690#discussion_r3720031731 ## dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf: ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +FROM quay.io/centos/centos:stream9 +ENV CUDA_ARCHITECTURES=75 +ENV LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH +ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \ +CXX=/opt/rh/gcc-toolset-14/root/bin/g++ + +RUN dnf config-manager --add-repo "https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";; \ +dnf update; \ +dnf install -y sudo patch maven perl git gcc-toolset-14 cuda-toolkit-13-1 && \ +dnf autoremove -y && dnf clean all; \ +git clone --depth=1 https://github.com/apache/incubator-gluten /opt/gluten && \ +cd /opt/gluten && \ +source /opt/rh/gcc-toolset-14/enable && \ +bash ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON --spark_version=3.5 --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_gcs=ON --enable_abfs=ON --enable_gpu=ON && \ Review Comment: `dnf config-manager` is provided by `dnf-plugins-core` (or `dnf-command(config-manager)` depending on distro). On CentOS Stream 9 minimal images this frequently isn’t installed by default, so the build can fail immediately. Install the needed plugin before calling `dnf config-manager`, or switch to dropping a `.repo` file into `/etc/yum.repos.d/`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][CI] Add gpu image centos-9-jdk17-cuda13.1-cudf [gluten]
Copilot commented on code in PR #12690: URL: https://github.com/apache/gluten/pull/12690#discussion_r3713788130 ## dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf: ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +FROM quay.io/centos/centos:stream9 +ENV CUDA_ARCHITECTURES=75 +ENV LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH +ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \ +CXX=/opt/rh/gcc-toolset-14/root/bin/g++ + +RUN dnf config-manager --add-repo "https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";; \ +dnf update; \ +dnf install -y sudo patch maven perl git gcc-toolset-14 cuda-toolkit-13-1 && \ +dnf autoremove -y && dnf clean all; \ +git clone --depth=1 https://github.com/apache/incubator-gluten /opt/gluten && \ +cd /opt/gluten && \ +source /opt/rh/gcc-toolset-14/enable && \ +bash ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON --spark_version=3.5 --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_gcs=ON --enable_abfs=ON --enable_gpu=ON && \ +rm -rf /opt/gluten && \ +rm -rf /root/.cache/ccache Review Comment: The image is named `jdk17` but the Dockerfile doesn’t explicitly install a JDK 17 package. On CentOS Stream 9, installing `maven` typically pulls in some Java runtime, which can be a different Java version than intended (and can reintroduce JDK 8). Install `java-17-openjdk-devel` (and/or set `JAVA_HOME`) explicitly to ensure the image consistently matches the tag and avoids CI variability. ## dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf: ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +FROM quay.io/centos/centos:stream9 +ENV CUDA_ARCHITECTURES=75 +ENV LD_LIBRARY_PATH=/opt/gluten/ep/build-velox/build/velox_ep/_build/release/_deps/curl-build/lib:$LD_LIBRARY_PATH +ENV CC=/opt/rh/gcc-toolset-14/root/bin/gcc \ +CXX=/opt/rh/gcc-toolset-14/root/bin/g++ + +RUN dnf config-manager --add-repo "https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo";; \ +dnf update; \ +dnf install -y sudo patch maven perl git gcc-toolset-14 cuda-toolkit-13-1 && \ +dnf autoremove -y && dnf clean all; \ Review Comment: `dnf update` is missing `-y`, which can cause non-interactive Docker builds to fail/hang. Also, the command chain uses `;`/`\\` between steps so failures won’t necessarily stop subsequent steps. Prefer `dnf -y update` and `&&` chaining so the image build fails fast and deterministically when a step fails. ## dev/docker/cudf/Dockerfile.centos-9-jdk17-cuda13.1-cudf: ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the
