Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251210393 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.84%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 68.84% 68.84% + Complexity2822028217-3 = Files 2460 2460 Lines135206 135206 Branches 1638116381 = + Hits 9308493089+5 + Misses3475334746-7 - Partials 7369 7371+2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251181754 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.84%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 68.84% 68.84% + Complexity2822028215-5 = Files 2460 2460 Lines135206 135206 Branches 1638116381 = + Hits 9308493086+2 + Misses3475334748-5 - Partials 7369 7372+3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.85% <ø> (-0.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251175820 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.76%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.84% 68.76% -0.09% + Complexity2822028163 -57 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9308492969 -115 - Misses3475334850 +97 - Partials 7369 7387 +18 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <ø> (-0.19%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251171537 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.72%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.84% 68.72% -0.13% + Complexity2822028147 -73 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9308492920 -164 - Misses3475334891 +138 - Partials 7369 7395 +26 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.58% <ø> (-0.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251166354 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.63%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.84% 68.63% -0.22% + Complexity2822028091 -129 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9308492799 -285 - Misses3475335051 +298 + Partials 7369 7356 -13 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.58% <ø> (-0.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <ø> (-0.15%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjav
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251155574 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.50%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.84% 68.50% -0.34% + Complexity2822028021 -199 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9308492628 -456 - Misses3475335248 +495 + Partials 7369 7330 -39 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.58% <ø> (-0.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <ø> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjav
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251133850 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.59%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.84% 67.59% -1.26% + Complexity2822027639 -581 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9308291390-1692 - Misses3475436473+1719 + Partials 7370 7343 -27 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.66% <ø> (-6.19%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <ø> (-0.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjav
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251130566 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.95%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.84% 65.95% -2.89% + Complexity2822026970-1250 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9308289180-3902 - Misses3475438584+3830 - Partials 7370 7442 +72 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <ø> (-16.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <ø> (-0.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fja
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251100845 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.37%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 5 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|7|5| >|spark-java-tests|8|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 67.77% 61.37% -6.40% + Complexity2773825092-2646 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9163382984-8649 - Misses3619745241+9044 + Partials 7376 6981 -395 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <ø> (-12.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.58%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#dif
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251094085 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.37%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 6 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|7|5| >|spark-java-tests|8|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 67.77% 61.37% -6.40% + Complexity2773825092-2646 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9163382984-8649 - Misses3619745241+9044 + Partials 7376 6981 -395 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <ø> (-12.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.58%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#dif
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251092329 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.37%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 6 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|7|5| >|spark-java-tests|8|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 67.77% 61.37% -6.40% + Complexity2773825092-2646 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9163382984-8649 - Misses3619745241+9044 + Partials 7376 6981 -395 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <ø> (-12.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.58%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#dif
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
voonhous merged PR #18483: URL: https://github.com/apache/hudi/pull/18483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251091512 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.37%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 5 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|6|5| >|spark-java-tests|8|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 67.65% 61.37% -6.28% + Complexity2767125092-2579 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9147482984-8490 - Misses3640345241+8838 + Partials 7329 6981 -348 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <ø> (-12.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#dif
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251085280 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.81%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 7 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|6|5| >|spark-java-tests|7|2| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 67.62% 58.81% -8.81% + Complexity2766224108-3554 Files 2460 2460 Lines135206 135206 Branches 1638116381 - Hits 9143479525 -11909 - Misses3643748841 +12404 + Partials 7335 6840 -495 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <ø> (-11.96%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251080617 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.02%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 8 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|6|5| >|spark-java-tests|7|2| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 67.62% 48.02% -19.61% + Complexity2766216464-11198 = Files 2460 2004 -456 Lines135206 112182-23024 Branches 1638114239 -2142 = - Hits 9143453874-37560 - Misses3643752649+16212 + Partials 7335 5659 -1676 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <ø> (-11.96%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251079536 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.98%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 9 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|6|5| >|spark-java-tests|7|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 67.62% 47.98% -19.65% + Complexity2766216450-11212 = Files 2460 2004 -456 Lines135206 112182-23024 Branches 1638114239 -2142 = - Hits 9143453829-37605 - Misses3643752689+16252 + Partials 7335 5664 -1671 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.56% <ø> (-11.58%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (-12.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251061824 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.21%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 7 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-java-tests|5|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 61.37% 45.21% -16.16% + Complexity2509915543 -9556 = Files 2460 2004 -456 Lines135206 112182-23024 Branches 1638114239 -2142 = - Hits 8298850728-32260 - Misses4524256005+10763 + Partials 6976 5449 -1527 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.58% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1Z
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251052807 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.68%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 8 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|5|4| >|spark-java-tests|5|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 61.37% 45.68% -15.70% + Complexity2509915328 -9771 = Files 2460 1975 -485 Lines135206 109579-25627 Branches 1638113685 -2696 = - Hits 8298850063-32925 - Misses4524254231 +8989 + Partials 6976 5285 -1691 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (+0.13%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ap
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251056510 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.68%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 8 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|5|4| >|spark-java-tests|5|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 61.37% 45.68% -15.70% + Complexity2509915328 -9771 = Files 2460 1975 -485 Lines135206 109579-25627 Branches 1638113685 -2696 = - Hits 8298850063-32925 - Misses4524254231 +8989 + Partials 6976 5285 -1691 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <ø> (+0.13%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ap
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4251034718 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.98%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (da2667c) and HEAD (36b294c). Click for more details. > > HEAD has 12 uploads less than BASE > >| Flag | BASE (da2667c) | HEAD (36b294c) | >|--|--|--| >|spark-scala-tests|5|0| >|spark-java-tests|5|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 61.37% 53.98% -7.40% + Complexity2509912282 -12817 Files 2460 1425-1035 Lines13520670975 -64231 Branches 16381 8005-8376 - Hits 8298838314 -44674 + Misses4524229239 -16003 + Partials 6976 3422-3554 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1717 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4250895636 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.89%. Comparing base ([`da2667c`](https://app.codecov.io/gh/apache/hudi/commit/da2667c4c6e6b7cd34edf85c29fca271f14aa71d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`36b294c`](https://app.codecov.io/gh/apache/hudi/commit/36b294ca686bdaf9d7f0bd51e45d30202bda69a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 44.88% 44.89% - Complexity 8488 8491+3 = Files 1196 1196 Lines 6198761987 Branches 6672 6672 = + Hits 2782427828+4 + Misses3113231131-1 + Partials 3031 3028-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4250820456 ## CI report: * d97042926ca218b21c047c30d3b0cee3dc1be535 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13236) * 36b294ca686bdaf9d7f0bd51e45d30202bda69a8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13260) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
yihua commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3085374679
##
hudi-gcp/src/test/java/org/apache/hudi/gcp/bigquery/TestBigQuerySchemaResolver.java:
##
@@ -350,4 +350,54 @@ void convertSchema_vectorField() {
Assertions.assertEquals(expected, SCHEMA_RESOLVER.convertSchema(input));
}
+
+ @Test
+ void convertSchema_variantField() {
+HoodieSchema input = HoodieSchema.createRecord("testRecord", null, null,
false, Arrays.asList(
+HoodieSchemaField.of("id", HoodieSchema.create(HoodieSchemaType.INT)),
+HoodieSchemaField.of("variant_data", HoodieSchema.createVariant())
+));
+
+Field expectedVariantField = Field.newBuilder("variant_data",
StandardSQLTypeName.STRUCT,
+Field.newBuilder("metadata",
StandardSQLTypeName.BYTES).setMode(Field.Mode.REQUIRED).build(),
+Field.newBuilder("value",
StandardSQLTypeName.BYTES).setMode(Field.Mode.REQUIRED).build())
+.setMode(Field.Mode.REQUIRED).build();
+
+Schema result = SCHEMA_RESOLVER.convertSchema(input);
+Assertions.assertEquals(2, result.getFields().size());
+Assertions.assertEquals(expectedVariantField, result.getFields().get(1));
+ }
+
+ @Test
+ void convertSchema_nullableVariantField() {
+HoodieSchema input = HoodieSchema.createRecord("testRecord", null, null,
false, Arrays.asList(
+HoodieSchemaField.of("id", HoodieSchema.create(HoodieSchemaType.INT)),
+HoodieSchemaField.of("variant_data",
HoodieSchema.createNullable(HoodieSchema.createVariant()))
+));
+
+Schema result = SCHEMA_RESOLVER.convertSchema(input);
+Field variantField = result.getFields().get(1);
+Assertions.assertEquals(Field.Mode.NULLABLE, variantField.getMode());
+Assertions.assertEquals(StandardSQLTypeName.STRUCT,
variantField.getType().getStandardType());
+ }
+
+ @Test
+ void convertSchema_nestedVariantField() {
+HoodieSchema inner = HoodieSchema.createRecord("container", null, null,
false, Arrays.asList(
+HoodieSchemaField.of("title",
HoodieSchema.create(HoodieSchemaType.STRING)),
+HoodieSchemaField.of("variant_data", HoodieSchema.createVariant())
+));
+HoodieSchema input = HoodieSchema.createRecord("testRecord", null, null,
false, Arrays.asList(
+HoodieSchemaField.of("id", HoodieSchema.create(HoodieSchemaType.INT)),
+HoodieSchemaField.of("container", inner)
+));
+
+Schema result = SCHEMA_RESOLVER.convertSchema(input);
+Field containerField = result.getFields().get(1);
+Assertions.assertEquals(StandardSQLTypeName.STRUCT,
containerField.getType().getStandardType());
+// Verify the nested "variant_data" sub-field is a STRUCT
Review Comment:
🤖 nit: consider using `orElseThrow()` with a meaningful error message
instead of calling `.get()` directly on the Optional to make the failure case
explicit.
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4250790974 ## CI report: * d97042926ca218b21c047c30d3b0cee3dc1be535 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13236) * 36b294ca686bdaf9d7f0bd51e45d30202bda69a8 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236871018 ## CI report: * d97042926ca218b21c047c30d3b0cee3dc1be535 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13236) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236433955 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.83%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 68.83% 68.83% - Complexity2817128173+2 = Files 2459 2459 Lines135095 135095 Branches 1637816378 = + Hits 9299292995+3 + Misses3473734736-1 + Partials 7366 7364-2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <ø> (-0.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm_medium=referral&utm_source=github&utm_
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236422531 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.83%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 68.83% 68.83% - Complexity2817128172+1 = Files 2459 2459 Lines135095 135095 Branches 1637816378 = + Hits 9299292993+1 Misses3473734737 + Partials 7366 7365-1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.89% <ø> (-0.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm_medium=referral&utm_source=github&utm_
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236416387 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.83%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 68.83% 68.83% - Complexity2817128172+1 = Files 2459 2459 Lines135095 135095 Branches 1637816378 = + Hits 9299292993+1 Misses3473734737 + Partials 7366 7365-1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <ø> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm_medium=referral&utm_source=github&utm_
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236339241 ## CI report: * 5fc569d1fdb504741ed2993f8b4c314702799ff4 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13234) * d97042926ca218b21c047c30d3b0cee3dc1be535 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13236) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236332194 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.83%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 68.83% -0.01% Complexity2817128171 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299292990 -2 - Misses3473734739 +2 Partials 7366 7366 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <ø> (-0.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236324384 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.82%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 68.82% -0.01% + Complexity2817128170 -1 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299292984 -8 - Misses3473734744 +7 - Partials 7366 7367 +1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <ø> (-0.14%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236328098 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.82%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 68.82% -0.01% + Complexity2817128170 -1 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299292985 -7 - Misses3473734743 +6 - Partials 7366 7367 +1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <ø> (-0.14%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236311147 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.98%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 67.98% -0.85% + Complexity2817127820 -351 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299291848-1144 - Misses3473735808+1071 - Partials 7366 7439 +73 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <ø> (-3.76%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236309864 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.98%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 67.98% -0.85% + Complexity2817127820 -351 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299291848-1144 - Misses3473735808+1071 - Partials 7366 7439 +73 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <ø> (-3.76%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236304939 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.82%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 67.82% -1.01% + Complexity2817127753 -418 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299291628-1364 - Misses3473736013+1276 - Partials 7366 7454 +88 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.42% <ø> (-6.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236298050 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.30%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 66.30% -2.53% + Complexity2817127130-1041 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299289579-3413 - Misses3473737971+3234 - Partials 7366 7545 +179 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&ut
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236279765 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.06%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 66.06% -2.77% + Complexity2817127001-1170 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299289250-3742 - Misses3473738364+3627 - Partials 7366 7481 +115 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <ø> (-0.36%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&u
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236264225 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.94%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 65.94% -2.89% + Complexity2817126934-1237 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299289090-3902 - Misses3473738571+3834 - Partials 7366 7434 +68 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <ø> (-0.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&u
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236248499 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.35%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 61.35% -7.48% + Complexity2817125054-3117 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299282894 -10098 - Misses3473745228 +10491 + Partials 7366 6973 -393 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.20% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9o
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236241605 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.85%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 58.85% -9.99% + Complexity2817124088-4083 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299279506 -13486 - Misses3473748770 +14033 + Partials 7366 6819 -547 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236238513 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.85%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.83% 58.85% -9.99% + Complexity2817124088-4083 Files 2459 2459 Lines135095 135095 Branches 1637816378 - Hits 9299279506 -13486 - Misses3473748770 +14033 + Partials 7366 6819 -547 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.54% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdm
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236232022 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.07%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 48.07% -20.77% + Complexity2817116467-11704 = Files 2459 2004 -455 Lines135095 112118-22977 Branches 1637814237 -2141 = - Hits 9299253898-39094 - Misses3473752578+17841 + Partials 7366 5642 -1724 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.41% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYW
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236227287 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.04%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 48.04% -20.80% + Complexity2817116457-11714 = Files 2459 2004 -455 Lines135095 112118-22977 Branches 1637814237 -2141 = - Hits 9299253865-39127 - Misses3473752607+17870 + Partials 7366 5646 -1720 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-16.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYW
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236225647 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.04%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 48.04% -20.80% + Complexity2817116457-11714 = Files 2459 2004 -455 Lines135095 112118-22977 Branches 1637814237 -2141 = - Hits 9299253865-39127 - Misses3473752607+17870 + Partials 7366 5646 -1720 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-16.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYW
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236218832 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.95%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 47.95% -20.88% + Complexity2817116428-11743 = Files 2459 2004 -455 Lines135095 112118-22977 Branches 1637814237 -2141 = - Hits 9299253768-39224 - Misses3473752685+17948 + Partials 7366 5665 -1701 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.61% <ø> (-15.31%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYW
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236210638 ## CI report: * 5fc569d1fdb504741ed2993f8b4c314702799ff4 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13234) * d97042926ca218b21c047c30d3b0cee3dc1be535 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236203195 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.19%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 45.19% -23.65% + Complexity2817115525-12646 = Files 2459 2004 -455 Lines135095 112118-22977 Branches 1637814237 -2141 = - Hits 9299250669-42323 - Misses3473756002+21265 + Partials 7366 5447 -1919 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236205065 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.19%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 45.19% -23.65% + Complexity2817115525-12646 = Files 2459 2004 -455 Lines135095 112118-22977 Branches 1637814237 -2141 = - Hits 9299250669-42323 - Misses3473756002+21265 + Partials 7366 5447 -1919 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236200260 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.65%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 45.65% -23.18% + Complexity2817115310-12861 = Files 2459 1975 -484 Lines135095 109515-25580 Branches 1637813683 -2695 = - Hits 9299250001-42991 - Misses3473754231+19494 + Partials 7366 5283 -2083 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236201024 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.65%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 45.65% -23.18% + Complexity2817115310-12861 = Files 2459 1975 -484 Lines135095 109515-25580 Branches 1637813683 -2695 = - Hits 9299250001-42991 - Misses3473754231+19494 + Partials 7366 5283 -2083 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236175784 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.95%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 53.95% -14.89% + Complexity2817112272-15899 = Files 2459 1425 -1034 Lines13509570911-64184 Branches 16378 8000 -8378 = - Hits 9299238257-54735 + Misses3473729233 -5504 + Partials 7366 3421 -3945 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1808 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236056423 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.83%. Comparing base ([`fc7f303`](https://app.codecov.io/gh/apache/hudi/commit/fc7f30301e94690780f348e33af39041aafcf7ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d970429`](https://app.codecov.io/gh/apache/hudi/commit/d97042926ca218b21c047c30d3b0cee3dc1be535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (fc7f303) and HEAD (d970429). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (fc7f303) | HEAD (d970429) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.83% 44.83% -24.00% + Complexity28171 8476-19695 = Files 2459 1196 -1263 Lines13509561923-73172 Branches 16378 6667 -9711 = - Hits 9299227766-65226 + Misses3473731127 -3610 + Partials 7366 3030 -4336 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (ø)` | | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2061 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
yihua commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3072663029
##
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/util/SparkSchemaUtils.java:
##
@@ -88,6 +88,7 @@ private static String convertFieldType(HoodieSchema
originalFieldSchema) {
+ ",\"valueContainsNull\":" + valueOptional + "}";
case RECORD:
case BLOB:
+ case VARIANT:
Review Comment:
🤖 BLOB fields tag themselves with `{"hudi_type":"BLOB"}` in the Spark field
metadata so that `HoodieSparkSchemaConverters.toHoodieType()` can reconstruct
the logical type on the way back. VARIANT fields don't get that annotation
here, so after a sync round-trip the VARIANT column would be reconstructed as a
plain `STRUCT` rather than a `VARIANT`. Could you add a similar
`isVariantField()`-style check in `convertToSparkSchemaJson` (the calling
method) and a corresponding reconstruction case in
`HoodieSparkSchemaConverters`?
- Generated by an AI agent and may contain mistakes. Please verify
any suggestions before applying.
##
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestSparkSchemaUtils.java:
##
@@ -194,4 +194,25 @@ public void testConvertSchemaWithBlobField() {
StructType blobStruct = (StructType) sparkSchema.fields()[1].dataType();
assertEquals(3, blobStruct.fields().length);
}
+
+ @Test
+ public void testConvertSchemaWithVariantField() {
+HoodieSchema schema = HoodieSchema.createRecord("root", null, null, false,
Arrays.asList(
Review Comment:
🤖 Looking at the diff, nested variants are already covered in
`TestHiveSchemaUtil` (the `nested_variant_field` case with a record containing
a `variant_data` sub-field) and in `TestBigQuerySchemaResolver`
(`convertSchema_nestedVariantField`). The gap is specifically in
`TestSparkSchemaUtils` — the new `testConvertSchemaWithVariantField` only
exercises a top-level variant. A similar test with a struct-containing-variant
would close the parity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4236005594 ## CI report: * ff034ea0fb1454465b9a9001acf963aecaf40e56 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13149) * 5fc569d1fdb504741ed2993f8b4c314702799ff4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13234) * d97042926ca218b21c047c30d3b0cee3dc1be535 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4235987454 ## CI report: * ff034ea0fb1454465b9a9001acf963aecaf40e56 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13149) * 5fc569d1fdb504741ed2993f8b4c314702799ff4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13234) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4235969374 ## CI report: * ff034ea0fb1454465b9a9001acf963aecaf40e56 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13149) * 5fc569d1fdb504741ed2993f8b4c314702799ff4 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
voonhous commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3072431804
##
hudi-gcp/src/test/java/org/apache/hudi/gcp/bigquery/TestBigQuerySchemaResolver.java:
##
@@ -280,4 +280,21 @@ void getTableSchema_withoutPartitionFields() throws
Exception {
BigQuerySchemaResolver resolver = new BigQuerySchemaResolver(metaClient ->
mockTableSchemaResolver);
Assertions.assertEquals(PRIMITIVE_TYPES_BQ_SCHEMA,
resolver.getTableSchema(mockMetaClient, Collections.emptyList()));
}
+
+ @Test
+ void convertSchema_variantField() {
Review Comment:
The other tests in this file uses a combination of `camelCase_snakeCase` for
naming tests. So, i think it's okay to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
rahil-c commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4227188213 Same feedback as what i mentioned for the blob PR, just want to confirm if we need to consider other syncs, and if we can add one functional or e2e test for this? https://github.com/apache/hudi/pull/18482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
bvaradar commented on code in PR #18483:
URL: https://github.com/apache/hudi/pull/18483#discussion_r3060374315
##
hudi-gcp/src/test/java/org/apache/hudi/gcp/bigquery/TestBigQuerySchemaResolver.java:
##
@@ -280,4 +280,21 @@ void getTableSchema_withoutPartitionFields() throws
Exception {
BigQuerySchemaResolver resolver = new BigQuerySchemaResolver(metaClient ->
mockTableSchemaResolver);
Assertions.assertEquals(PRIMITIVE_TYPES_BQ_SCHEMA,
resolver.getTableSchema(mockMetaClient, Collections.emptyList()));
}
+
+ @Test
+ void convertSchema_variantField() {
Review Comment:
nit: kindly use camelcase
##
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestSparkSchemaUtils.java:
##
@@ -194,4 +194,25 @@ public void testConvertSchemaWithBlobField() {
StructType blobStruct = (StructType) sparkSchema.fields()[1].dataType();
assertEquals(3, blobStruct.fields().length);
}
+
+ @Test
+ public void testConvertSchemaWithVariantField() {
+HoodieSchema schema = HoodieSchema.createRecord("root", null, null, false,
Arrays.asList(
Review Comment:
can we also cover nested variants ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4207377507 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## + Coverage 68.77% 68.78% +0.01% - Complexity2811728121 +4 Files 2452 2452 Lines135033 135033 Branches 1637616376 + Hits 9286992889 +20 + Misses3480134788 -13 + Partials 7363 7356 -7 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <ø> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fs
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4207399644 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## + Coverage 68.77% 68.79% +0.01% - Complexity2811728121 +4 Files 2452 2452 Lines135033 135033 Branches 1637616376 + Hits 9286992890 +21 + Misses3480134788 -13 + Partials 7363 7355 -8 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.90% <ø> (+0.03%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fs
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
voonhous commented on code in PR #18483: URL: https://github.com/apache/hudi/pull/18483#discussion_r3051814278 ## hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySchemaResolver.java: ## @@ -146,6 +146,7 @@ private Field getField(HoodieSchema fieldSchema, String name, boolean nullable) standardSQLTypeName = StandardSQLTypeName.NUMERIC; break; case RECORD: + case VARIANT: Review Comment: Ignore, this is addressed in a separate PR here: https://github.com/apache/hudi/pull/18482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206292107 ## CI report: * ff034ea0fb1454465b9a9001acf963aecaf40e56 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13149) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206234823 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## + Coverage 68.77% 68.78% +0.01% - Complexity2811728121 +4 Files 2452 2452 Lines135033 135033 Branches 1637616376 + Hits 9286992889 +20 + Misses3480134788 -13 + Partials 7363 7356 -7 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.85% <ø> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206233930 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## + Coverage 68.77% 68.78% +0.01% - Complexity2811728121 +4 Files 2452 2452 Lines135033 135033 Branches 1637616376 + Hits 9286992889 +20 + Misses3480134788 -13 + Partials 7363 7356 -7 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.85% <ø> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206178787 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.93%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 67.93% -0.85% + Complexity2811727767 -350 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286991733-1136 - Misses3480135867+1066 - Partials 7363 7433 +70 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <ø> (-3.74%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206165430 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.87%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 67.87% -0.90% + Complexity2811727752 -365 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286991659-1210 - Misses3480135928+1127 - Partials 7363 7446 +83 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <ø> (-3.85%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206173596 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.91%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 67.91% -0.87% + Complexity2811727760 -357 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286991704-1165 - Misses3480135894+1093 - Partials 7363 7435 +72 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <ø> (-3.78%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206171449 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.88%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 67.88% -0.90% + Complexity2811727752 -365 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286991661-1208 - Misses3480135928+1127 - Partials 7363 7444 +81 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <ø> (-3.85%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206202744 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## + Coverage 68.77% 68.78% +0.01% - Complexity2811728119 +2 Files 2452 2452 Lines135033 135033 Branches 1637616376 + Hits 9286992883 +14 + Misses3480134792 -9 + Partials 7363 7358 -5 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.83% <ø> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206199374 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18483 +/- ## = Coverage 68.77% 68.78% - Complexity2811728118+1 = Files 2452 2452 Lines135033 135033 Branches 1637616376 = + Hits 9286992881 +12 + Misses3480134792-9 + Partials 7363 7360-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.78% <ø> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon%2Futil%2FSparkSchemaUtils.java&utm_med
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206162990 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.24%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 66.24% -2.53% + Complexity2811727076-1041 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286989459-3410 - Misses3480138032+3231 - Partials 7363 7542 +179 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommo
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206184964 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.71%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 68.71% -0.06% + Complexity2811728073 -44 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286992790 -79 - Misses3480134868 +67 - Partials 7363 7375 +12 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <ø> (-0.23%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206175955 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.93%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 67.93% -0.85% + Complexity2811727766 -351 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286991729-1140 - Misses3480135870+1069 - Partials 7363 7434 +71 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <ø> (-3.74%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommon
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206157382 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.15%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 66.15% -2.63% + Complexity2811727014-1103 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286989327-3542 - Misses3480138209+3408 - Partials 7363 7497 +134 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <ø> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommo
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206142653 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.03%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 66.03% -2.75% + Complexity2811726947-1170 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286989167-3702 - Misses3480138416+3615 - Partials 7363 7450 +87 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <ø> (-0.34%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommo
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206136672 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 66.03%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 66.03% -2.75% + Complexity2811726947-1170 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286989167-3702 - Misses3480138416+3615 - Partials 7363 7450 +87 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <ø> (-0.34%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2hpdmUvdXRpbC9IaXZlU2NoZW1hVXRpbC5qYXZh) | `86.39% <ø> (ø)` | | | [...apache/hudi/sync/common/util/SparkSchemaUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-sync-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsync%2Fcommo
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206100033 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.27%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 61.27% -7.50% + Complexity2811724989-3128 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286982742 -10127 - Misses3480145318 +10517 + Partials 7363 6973 -390 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <ø> (-16.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206097511 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.27%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 61.27% -7.50% + Complexity2811724989-3128 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286982742 -10127 - Misses3480145318 +10517 + Partials 7363 6973 -390 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <ø> (-16.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206096701 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 61.27%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## - Coverage 68.77% 61.27% -7.50% + Complexity2811724989-3128 Files 2452 2452 Lines135033 135033 Branches 1637616376 - Hits 9286982742 -10127 - Misses3480145318 +10517 + Partials 7363 6973 -390 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <ø> (-16.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <ø> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206092892 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.76%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 58.76% -10.02% + Complexity2811724022 -4095 = Files 2452 2452 Lines135033 135033 Branches 1637616376 = - Hits 9286979348-13521 - Misses3480148866+14065 + Partials 7363 6819 -544 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <ø> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.77% <ø> (-16.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `90.00% <ø> (ø)` | | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206079151 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.93%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 47.93% -20.85% + Complexity2811716411-11706 = Files 2452 2004 -448 Lines135033 112103-22930 Branches 1637614231 -2145 = - Hits 9286953735-39134 - Misses3480152705+17904 + Partials 7363 5663 -1700 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.54% <ø> (-15.33%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206075921 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 49.07%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 49.07% -19.71% + Complexity2811716037-12080 = Files 2452 1957 -495 Lines135033 107134-27899 Branches 1637613167 -3209 = - Hits 9286952575-40294 - Misses3480149204+14403 + Partials 7363 5355 -2008 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.54% <ø> (-15.33%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <ø> (-12.57%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206073956 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.17%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 46.17% -22.61% + Complexity2811715134-12983 = Files 2452 1957 -495 Lines135033 107134-27899 Branches 1637613167 -3209 = - Hits 9286949466-43403 - Misses3480152530+17729 + Partials 7363 5138 -2225 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <ø> (-12.57%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206071700 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.66%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 46.66% -22.12% + Complexity2811714972-13145 = Files 2452 1940 -512 Lines135033 104631-30402 Branches 1637612606 -3770 = - Hits 9286948823-44046 - Misses3480150788+15987 + Partials 7363 5020 -2343 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ø> (-12.40%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ache/hudi/gcp/bigquery/BigQuerySchemaResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-gcp%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fgcp%2Fbigquery%2FBigQuerySchemaResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1nY3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U2NoZW1hUmVzb2x2ZXIuamF2YQ==) | `0.00% <ø> (-90.00%)` | :arrow_down: | | [...java/org/apache/hudi/hive/util/HiveSchemaUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18483?src=pr&el=tree&filepath=hudi-sync%2Fhudi-hive-sync%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhive%2Futil%2FHiveSchemaUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zeW5jL2h1ZGktaGl2ZS1zeW5jL3NyYy9
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4206035011 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.91%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 53.91% -14.86% + Complexity2811712259-15858 = Files 2452 1425 -1027 Lines13503370882-64151 Branches 16376 7992 -8384 = - Hits 9286938218-54651 + Misses3480129246 - + Partials 7363 3418 -3945 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1802 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
codecov-commenter commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4205938730 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18483?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.86%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ff034ea`](https://app.codecov.io/gh/apache/hudi/commit/ff034ea0fb1454465b9a9001acf963aecaf40e56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (ff034ea). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (ff034ea) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18483 +/- ## = - Coverage 68.77% 44.86% -23.91% + Complexity28117 8473-19644 = Files 2452 1196 -1256 Lines13503361894-73139 Branches 16376 6659 -9717 = - Hits 9286927769-65100 + Misses3480131095 -3706 + Partials 7363 3030 -4333 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18483/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2055 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18483/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
yihua commented on code in PR #18483: URL: https://github.com/apache/hudi/pull/18483#discussion_r3050999268 ## hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySchemaResolver.java: ## @@ -146,6 +146,7 @@ private Field getField(HoodieSchema fieldSchema, String name, boolean nullable) standardSQLTypeName = StandardSQLTypeName.NUMERIC; break; case RECORD: + case VARIANT: Review Comment: 🤖 Now that VARIANT is handled here, it might be worth also adding `case BLOB:` in this same switch — `SparkSchemaUtils` and `HiveSchemaUtil` already cover BLOB, so BigQuery is currently the odd one out and would still throw `RuntimeException` for BLOB fields. Happy to leave it as a follow-up if out of scope, just flagging the asymmetry. 🤖 *This review comment was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
voonhous opened a new pull request, #18483: URL: https://github.com/apache/hudi/pull/18483 ### Describe the issue this Pull Request addresses Map VARIANT type to struct in Hive, Spark, and BigQuery sync: - VARIANT columns were not handled in HiveSchemaUtil, SparkSchemaUtils, and BigQuerySchemaResolver, causing UnsupportedOperationException when syncing tables with variant columns. - Map VARIANT to its underlying physical type (struct) so external engines can read via metastore. ### Summary and Changelog Add metasync support for **BLOB** logical type for: 1. BigQuerySchemaResolver 2. SparkSchemaUtils 3. HiveSchemaUtil ### Impact Users are able to perform metasync for **VARIANT** logical types. ### Risk Level Low. ### Documentation Update None. ### Contributor's checklist - [X] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [X] Enough context is provided in the sections above - [X] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4205874333 ## CI report: * ff034ea0fb1454465b9a9001acf963aecaf40e56 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13149) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(sync): Map VARIANT type to struct in Hive, Spark, and BigQuery sync [hudi]
hudi-bot commented on PR #18483: URL: https://github.com/apache/hudi/pull/18483#issuecomment-4205859326 ## CI report: * ff034ea0fb1454465b9a9001acf963aecaf40e56 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
