Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655989419 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.25%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 14 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.25% -0.53% - Complexity2908729472 +385 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 + Hits 9616997313+1144 - Misses3588037252+1372 - Partials 7773 8015 +242 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <79.03%> (-0.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <58.06%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
danny0405 merged PR #18909: URL: https://github.com/apache/hudi/pull/18909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655945231 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.24%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.24% -0.54% - Complexity2908729472 +385 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 + Hits 9616997309+1140 - Misses3588037255+1375 - Partials 7773 8016 +243 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <79.03%> (-0.55%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <58.06%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655939394 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.21%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.21% -0.57% - Complexity2908729449 +362 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 + Hits 9616997259+1090 - Misses3588037312+1432 - Partials 7773 8009 +236 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <79.03%> (-0.55%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <58.06%> (-0.46%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655934588 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.12% -0.66% - Complexity2908729395 +308 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 + Hits 9616997128 +959 - Misses3588037451+1571 - Partials 7773 8001 +228 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.48% <79.03%> (-0.83%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <58.06%> (-0.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655929017 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.33%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.33% -1.45% + Complexity2908729063 -24 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616996003 -166 - Misses3588038532+2652 - Partials 7773 8045 +272 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <67.74%> (-4.28%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <58.06%> (-0.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655926397 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.24%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.24% -1.54% + Complexity2908729010 -77 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616995876 -293 - Misses3588038687+2807 - Partials 7773 8017 +244 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <67.74%> (-4.49%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <58.06%> (-0.64%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655912542 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.12%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.12% -1.66% + Complexity2908728939 -148 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616995704 -465 - Misses3588038872+2992 - Partials 7773 8004 +231 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <67.74%> (-4.84%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.58% <58.06%> (-0.64%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655910642 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.08%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.08% -1.70% + Complexity2908728936 -151 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616995655 -514 - Misses3588038906+3026 - Partials 7773 8019 +246 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <67.74%> (-4.84%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <58.06%> (-0.70%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655909857 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.08%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.08% -1.70% + Complexity2908728936 -151 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616995655 -514 - Misses3588038906+3026 - Partials 7773 8019 +246 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <67.74%> (-4.84%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <58.06%> (-0.70%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655904578 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.99%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 66.99% -1.79% + Complexity2908728880 -207 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616995519 -650 - Misses3588039061+3181 - Partials 7773 8000 +227 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.19% <67.74%> (-5.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <58.06%> (-0.81%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655861713 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.96%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 12 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|6| >|spark-java-tests|15|7| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 62.96% -5.82% + Complexity2908727151-1936 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616989782-6387 - Misses3588045208+9328 + Partials 7773 7590 -183 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.19% <67.74%> (-5.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.50% <58.06%> (-12.72%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655853619 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.65%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 14 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|7| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 62.65% -6.13% + Complexity2908726933-2154 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616989328-6841 - Misses3588045796+9916 + Partials 7773 7456 -317 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.19% <67.74%> (-5.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.83% <58.06%> (-12.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655860894 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.96%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 12 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|6| >|spark-java-tests|15|7| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 62.96% -5.82% + Complexity2908727151-1936 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616989782-6387 - Misses3588045208+9328 + Partials 7773 7590 -183 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.19% <67.74%> (-5.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.50% <58.06%> (-12.72%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655841695 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.39%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|7| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 62.39% -6.39% + Complexity2908726773-2314 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616988965-7204 - Misses3588046263 +10383 + Partials 7773 7352 -421 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.19% <67.74%> (-5.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <58.06%> (-12.35%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655842695 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.39%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|7| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 62.39% -6.39% + Complexity2908726773-2314 Files 2517 2542 +25 Lines139822 142580+2758 Branches 1720917784 +575 - Hits 9616988965-7204 - Misses3588046263 +10383 + Partials 7773 7352 -421 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <66.12%> (+0.48%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.19% <67.74%> (-5.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <58.06%> (-12.35%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <58.06%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655832638 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 52.85%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|6| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 52.85% -15.93% + Complexity2908719267 -9820 = Files 2517 2065 -452 Lines139822 118096-21726 Branches 1720915452 -1757 = - Hits 9616962414-33755 - Misses3588049830+13950 + Partials 7773 5852 -1921 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <67.74%> (-4.48%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <58.06%> (-12.35%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655831876 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.70968%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 52.85%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|6| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 52.85% -15.93% + Complexity2908719267 -9820 = Files 2517 2065 -452 Lines139822 118096-21726 Branches 1720915452 -1757 = - Hits 9616962414-33755 - Misses3588049830+13950 + Partials 7773 5852 -1921 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <67.74%> (-4.48%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <58.06%> (-12.35%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655818741 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.64%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 46.64% -22.14% + Complexity2908716671-12416 = Files 2517 2065 -452 Lines139822 118096-21726 Branches 1720915452 -1757 = - Hits 9616955091-41078 - Misses3588057080+21200 + Partials 7773 5925 -1848 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.62% <58.06%> (-17.69%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655815637 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.64%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 46.64% -22.14% + Complexity2908716671-12416 = Files 2517 2065 -452 Lines139822 118096-21726 Branches 1720915452 -1757 = - Hits 9616955091-41078 - Misses3588057080+21200 + Partials 7773 5925 -1848 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.62% <58.06%> (-17.69%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655817776 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.64%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 46.64% -22.14% + Complexity2908716671-12416 = Files 2517 2065 -452 Lines139822 118096-21726 Branches 1720915452 -1757 = - Hits 9616955091-41078 - Misses3588057080+21200 + Partials 7773 5925 -1848 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.62% <58.06%> (-17.69%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655814760 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.61%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 46.61% -22.17% + Complexity2908716660-12427 = Files 2517 2065 -452 Lines139822 118096-21726 Branches 1720915452 -1757 = - Hits 9616955048-41121 - Misses3588057120+21240 + Partials 7773 5928 -1845 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.95% <58.06%> (-17.36%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655806523 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.03%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 48.03% -20.75% + Complexity2908716481-12606 = Files 2517 2023 -494 Lines139822 112994-26828 Branches 1720914356 -2853 = - Hits 9616954275-41894 - Misses3588052944+17064 + Partials 7773 5775 -1998 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <58.06%> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655800379 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.54%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 48.54% -20.24% + Complexity2908716274-12813 = Files 2517 2006 -511 Lines139822 110622-29200 Branches 1720913847 -3362 = - Hits 9616953697-42472 - Misses3588051339+15459 + Partials 7773 5586 -2187 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <58.06%> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655770719 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.25806%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.27%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 87.71% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 45.27% -23.51% + Complexity2908714908-14179 = Files 2517 1979 -538 Lines139822 107861-31961 Branches 1720913236 -3973 = - Hits 9616948829-47340 - Misses3588053976+18096 + Partials 7773 5056 -2717 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.25%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <58.06%> (-16.52%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=git
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655640941 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `58.06452%` with `26 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.74%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7bcdba9`](https://app.codecov.io/gh/apache/hudi/commit/7bcdba9d11014911e146fe977beccae5bfedfd4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 13 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 63.15% | [17 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/hudi/exception/ExceptionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fexception%2FExceptionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0V4Y2VwdGlvblV0aWwuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7bcdba9). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7bcdba9) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 44.74% -24.04% + Complexity29087 8526-20561 = Files 2517 1202 -1315 Lines13982262839-76983 Branches 17209 6869-10340 = - Hits 9616928119-68050 + Misses3588031593 -4287 + Partials 7773 3127 -4646 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.06%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
hudi-bot commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655599398 ## CI report: * 41165679ea25724539101527f925689915e1f11c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14479) * 7bcdba9d11014911e146fe977beccae5bfedfd4f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14524) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
hudi-bot commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4655571737 ## CI report: * 41165679ea25724539101527f925689915e1f11c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14479) * 7bcdba9d11014911e146fe977beccae5bfedfd4f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
fhan688 commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646886761 please help review again, thanks! @danny0405 @voonhous @cshuo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646367358 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.32%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.32% -0.46% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998344+2175 - Misses3588037529+1649 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.88% <68.33%> (-0.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646365611 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.32%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.32% -0.46% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998344+2175 - Misses3588037529+1649 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.88% <68.33%> (-0.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646344348 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.31%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.31% -0.47% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998342+2173 - Misses3588037531+1651 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <68.33%> (-0.43%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646284834 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.31%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.31% -0.47% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998342+2173 - Misses3588037531+1651 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <68.33%> (-0.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646274679 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.31%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.31% -0.47% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998342+2173 - Misses3588037531+1651 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <68.33%> (-0.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646266648 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.31%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.31% -0.47% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998342+2173 - Misses3588037531+1651 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <68.33%> (-0.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646254954 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.31%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.31% -0.47% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998339+2170 - Misses3588037534+1654 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <68.33%> (-0.49%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646252468 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.31%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.31% -0.47% - Complexity2908729740 +653 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998338+2169 - Misses3588037535+1655 - Partials 7773 8072 +299 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <68.33%> (-0.49%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646248355 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.28%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.28% -0.50% - Complexity2908729721 +634 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998289+2120 - Misses3588037598+1718 - Partials 7773 8058 +285 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646235423 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.28%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.28% -0.50% - Complexity2908729721 +634 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998289+2120 - Misses3588037598+1718 - Partials 7773 8058 +285 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646197694 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.27%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.27% -0.51% - Complexity2908729721 +634 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998284+2115 - Misses3588037603+1723 - Partials 7773 8058 +285 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <56.66%> (-0.28%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646184362 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.23%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.23% -0.55% - Complexity2908729690 +603 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998219+2050 - Misses3588037681+1801 - Partials 7773 8045 +272 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <56.66%> (-0.36%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646174956 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.99%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.99% -0.79% - Complexity2908729540 +453 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997870+1701 - Misses3588038129+2249 - Partials 7773 7946 +173 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.03%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/1890
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646178727 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.22%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.22% -0.56% - Complexity2908729690 +603 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616998209+2040 - Misses3588037691+1811 - Partials 7773 8045 +272 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.84% <56.66%> (-0.38%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646176640 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.01%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.01% -0.77% - Complexity2908729540 +453 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997899+1730 - Misses3588038104+2224 - Partials 7773 7942 +169 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <56.66%> (+0.07%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.32% <56.66%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/1890
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646156450 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.98%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.98% -0.80% - Complexity2908729538 +451 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997867+1698 - Misses3588038131+2251 - Partials 7773 7947 +174 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.61% <68.33%> (-0.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.03%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646154592 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.98%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.98% -0.80% - Complexity2908729538 +451 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997863+1694 - Misses3588038135+2255 - Partials 7773 7947 +174 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <68.33%> (-0.71%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.03%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646146932 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.94%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.94% -0.84% - Complexity2908729523 +436 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997805+1636 - Misses3588038195+2315 - Partials 7773 7945 +172 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <68.33%> (-0.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.03%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646145429 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.94%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.94% -0.84% - Complexity2908729522 +435 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997802+1633 - Misses3588038196+2316 - Partials 7773 7947 +174 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <68.33%> (-0.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.03%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646135972 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.94%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.94% -0.84% - Complexity2908729522 +435 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997799+1630 - Misses3588038198+2318 - Partials 7773 7948 +175 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <68.33%> (-0.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.02%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646138349 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.94%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 67.94% -0.84% - Complexity2908729522 +435 Files 2517 2542 +25 Lines139822 143945+4123 Branches 1720918158 +949 + Hits 9616997799+1630 - Misses3588038198+2318 - Partials 7773 7948 +175 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <56.66%> (+0.59%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <68.33%> (-0.80%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.02%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4646130563 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.77% -0.01% - Complexity2908729123 +36 Files 2517 2518 +1 Lines139822 140243 +421 Branches 1720917385 +176 + Hits 9616996457 +288 - Misses3588035984 +104 - Partials 7773 7802 +29 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.90% <80.00%> (-0.15%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <68.33%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <56.66%> (+0.02%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/1890
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4645988907 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.80%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 11 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## + Coverage 68.77% 68.80% +0.03% - Complexity2908729097 +10 Files 2517 2518 +1 Lines139822 139874 +52 Branches 1720917217 +8 + Hits 9616996247 +78 + Misses3588035848 -32 - Partials 7773 7779 +6 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <56.66%> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <68.33%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <56.66%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/1890
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
fhan688 closed pull request #18909: fix(common): Close log writer output stream on append failure URL: https://github.com/apache/hudi/pull/18909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
hudi-bot commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629371143 ## CI report: * 41165679ea25724539101527f925689915e1f11c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14479) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629259468 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## + Coverage 68.77% 68.82% +0.04% - Complexity2908729097 +10 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 + Hits 9616996243 +74 + Misses3588035820 -60 - Partials 7773 7779 +6 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <68.33%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <56.66%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629255077 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.82%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## + Coverage 68.77% 68.82% +0.04% - Complexity2908729097 +10 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 + Hits 9616996243 +74 + Misses3588035820 -60 - Partials 7773 7779 +6 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <68.33%> (+<0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <56.66%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629211192 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## + Coverage 68.77% 68.81% +0.04% - Complexity2908729096 +9 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 + Hits 9616996239 +70 + Misses3588035823 -57 - Partials 7773 7780 +7 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.27% <68.33%> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <56.66%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629181621 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.76%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.76% -0.02% + Complexity2908729073 -14 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616996162 -7 - Misses3588035907 +27 Partials 7773 7773 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.27% <68.33%> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <56.66%> (-0.13%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629176335 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.75%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.75% -0.03% + Complexity2908729067 -20 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616996149 -20 - Misses3588035925 +45 + Partials 7773 7768 -5 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.25% <68.33%> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <56.66%> (-0.13%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629174411 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.75%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.75% -0.03% + Complexity2908729067 -20 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616996149 -20 - Misses3588035925 +45 + Partials 7773 7768 -5 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.25% <68.33%> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.09% <56.66%> (-0.13%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629168084 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.68%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.68% -0.10% + Complexity2908729032 -55 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616996054 -115 - Misses3588036018 +138 + Partials 7773 7770 -3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.22% <68.33%> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <56.66%> (-0.26%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629166389 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.68%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.68% -0.10% + Complexity2908729032 -55 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616996052 -117 - Misses3588036019 +139 + Partials 7773 7771 -2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.21% <68.33%> (-0.10%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <56.66%> (-0.26%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629161645 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.65%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.65% -0.13% + Complexity2908729010 -77 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616996002 -167 - Misses3588036083 +203 + Partials 7773 7757 -16 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.00% <68.33%> (-0.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <56.66%> (-0.26%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629156198 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.56%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.56% -0.22% + Complexity2908728967 -120 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616995886 -283 - Misses3588036226 +346 + Partials 7773 7730 -43 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <68.33%> (-0.55%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <56.66%> (-0.35%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629079753 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.65%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 14 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 63.65% -5.13% + Complexity2908726905-2182 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616989010-7159 - Misses3588043463+7583 + Partials 7773 7369 -404 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <56.66%> (-4.24%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <56.66%> (-12.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](htt
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629072382 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.57%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 63.57% -5.21% + Complexity2908726846-2241 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616988904-7265 - Misses3588043601+7721 + Partials 7773 7337 -436 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <56.66%> (-4.24%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <56.66%> (-12.36%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](htt
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629070208 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.57%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 63.57% -5.21% + Complexity2908726846-2241 Files 2517 2517 Lines139822 139842 +20 Branches 1720917207 -2 - Hits 9616988904-7265 - Misses3588043601+7721 + Partials 7773 7337 -436 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <56.66%> (+0.25%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <56.66%> (-4.24%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <56.66%> (-12.36%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](htt
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629055255 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.83%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 53.83% -14.95% + Complexity2908718705-10382 = Files 2517 2043 -474 Lines139822 115528-24294 Branches 1720914904 -2305 = - Hits 9616962196-33973 - Misses3588046776+10896 + Partials 7773 6556 -1217 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.13% <56.66%> (-17.18%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <56.66%> (-12.36%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with miss
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629057427 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.86%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|5| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 53.86% -14.92% + Complexity2908718714-10373 = Files 2517 2043 -474 Lines139822 115528-24294 Branches 1720914904 -2305 = - Hits 9616962228-33941 - Misses3588046747+10867 + Partials 7773 6553 -1220 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <56.66%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <56.66%> (-12.36%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with miss
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629054422 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.81%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 53.81% -14.97% + Complexity2908718705-10382 = Files 2517 2043 -474 Lines139822 115528-24294 Branches 1720914904 -2305 = - Hits 9616962166-34003 - Misses3588046802+10922 + Partials 7773 6560 -1213 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.13% <56.66%> (-17.18%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <56.66%> (-12.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with miss
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629047468 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.81%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 53.81% -14.97% + Complexity2908718705-10382 = Files 2517 2043 -474 Lines139822 115528-24294 Branches 1720914904 -2305 = - Hits 9616962166-34003 - Misses3588046802+10922 + Partials 7773 6560 -1213 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.13% <56.66%> (-17.18%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <56.66%> (-12.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with miss
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629031890 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.77%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 53.77% -15.01% + Complexity2908718696-10391 = Files 2517 2043 -474 Lines139822 115528-24294 Branches 1720914904 -2305 = - Hits 9616962128-34041 - Misses3588046833+10953 + Partials 7773 6567 -1206 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.50% <56.66%> (-16.81%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <56.66%> (-12.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <56.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with miss
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629028549 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.44%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 48.44% -20.34% + Complexity290871-12421 = Files 2517 2021 -496 Lines139822 112998-26824 Branches 1720914356 -2853 = - Hits 9616954742-41427 - Misses3588052382+16502 + Partials 7773 5874 -1899 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <56.66%> (-16.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <56.66%> (-12.43%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](htt
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629023568 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.96%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 48.96% -19.82% + Complexity2908716459-12628 = Files 2517 2004 -513 Lines139822 110626-29196 Branches 1720913847 -3362 = - Hits 9616954164-42005 - Misses3588050776+14896 + Partials 7773 5686 -2087 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <56.66%> (-16.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.97% <56.66%> (-12.25%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](htt
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4629019988 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.39%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 49.39% -19.39% + Complexity2908716179-12908 = Files 2517 1974 -543 Lines139822 107918-31904 Branches 1720913277 -3932 = - Hits 9616953303-42866 - Misses3588049137+13257 + Partials 7773 5478 -2295 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <56.66%> (-16.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <56.66%> (-12.27%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](htt
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4628995460 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.0%` with `12 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.28%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 80.00% | [10 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 45.28% -23.50% + Complexity2908714908-14179 = Files 2517 1974 -543 Lines139822 107763-32059 Branches 1720913210 -3999 = - Hits 9616948802-47367 - Misses3588053901+18021 + Partials 7773 5060 -2713 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.06% <80.00%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <56.66%> (-16.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pu
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
fhan688 commented on code in PR #18909:
URL: https://github.com/apache/hudi/pull/18909#discussion_r3360912920
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -245,14 +250,59 @@ public void close() throws IOException {
}
private void closeStream() throws IOException {
-if (outputStream != null) {
+if (outputStream == null) {
+ return;
+}
+
+Exception syncException = null;
+try {
// Persist all buffered data to DataNodes before closing so downstream
// readers can observe a fully-written log file at commit-level
visibility.
sync();
- outputStream.close();
- outputStream = null;
- closed = true;
+} catch (Exception e) {
+ syncException = e;
+}
+
+try {
+ closeOutputStream();
+} catch (IOException | RuntimeException closeException) {
+ if (syncException != null) {
+syncException.addSuppressed(closeException);
+rethrow(syncException);
+ }
+ rethrow(closeException);
+}
+
+if (syncException != null) {
+ rethrow(syncException);
+}
+ }
+
+ private void closeOutputStreamOnAppendFailure(Throwable failure) {
+try {
+ closeOutputStream();
+} catch (IOException | RuntimeException closeException) {
+ failure.addSuppressed(closeException);
+ log.warn("Failed to close output stream after append failure for log
file {}", logFile, closeException);
+}
+ }
+
+ private void closeOutputStream() throws IOException {
+if (outputStream != null) {
+ try {
+outputStream.close();
+ } finally {
+outputStream = null;
+closed = true;
+ }
+}
+ }
+
+ private void rethrow(Exception exception) throws IOException {
Review Comment:
> is this right? the method does not always throw IOException now?
Good point. I used `Exception` to simplify the catch path, but made rethrow
handle generic checked exceptions safely by preserving `IOException` and
`RuntimeException`, and wrapping any other checked exception as `IOException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4628968186 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `56.7%` with `26 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 38.82%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 56.66% | [23 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 38.82% -29.96% + Complexity2908712392-16695 = Files 2517 1974 -543 Lines139822 107743-32079 Branches 1720913189 -4020 = - Hits 9616941832-54337 - Misses3588060910+25030 + Partials 7773 5001 -2772 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <56.66%> (-16.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4628870566 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `56.7%` with `26 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.75%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4116567`](https://app.codecov.io/gh/apache/hudi/commit/41165679ea25724539101527f925689915e1f11c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 56.66% | [23 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (4116567). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (4116567) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 44.75% -24.03% + Complexity29087 8524-20563 = Files 2517 1201 -1316 Lines13982262814-77008 Branches 17209 6864-10345 = - Hits 9616928112-68057 + Misses3588031573 -4307 + Partials 7773 3129 -4644 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <56.66%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
hudi-bot commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4628840105 ## CI report: * 7864c76131299f3984024efb0e9fe2f94ab9e214 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14466) * 41165679ea25724539101527f925689915e1f11c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14479) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
hudi-bot commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4628818085 ## CI report: * 7864c76131299f3984024efb0e9fe2f94ab9e214 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14466) * 41165679ea25724539101527f925689915e1f11c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
danny0405 commented on code in PR #18909:
URL: https://github.com/apache/hudi/pull/18909#discussion_r3360121227
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -245,14 +250,59 @@ public void close() throws IOException {
}
private void closeStream() throws IOException {
-if (outputStream != null) {
+if (outputStream == null) {
+ return;
+}
+
+Exception syncException = null;
+try {
// Persist all buffered data to DataNodes before closing so downstream
// readers can observe a fully-written log file at commit-level
visibility.
sync();
- outputStream.close();
- outputStream = null;
- closed = true;
+} catch (Exception e) {
+ syncException = e;
+}
+
+try {
+ closeOutputStream();
+} catch (IOException | RuntimeException closeException) {
+ if (syncException != null) {
+syncException.addSuppressed(closeException);
+rethrow(syncException);
+ }
+ rethrow(closeException);
+}
+
+if (syncException != null) {
+ rethrow(syncException);
+}
+ }
+
+ private void closeOutputStreamOnAppendFailure(Throwable failure) {
+try {
+ closeOutputStream();
+} catch (IOException | RuntimeException closeException) {
+ failure.addSuppressed(closeException);
+ log.warn("Failed to close output stream after append failure for log
file {}", logFile, closeException);
+}
+ }
+
+ private void closeOutputStream() throws IOException {
+if (outputStream != null) {
+ try {
+outputStream.close();
+ } finally {
+outputStream = null;
+closed = true;
+ }
+}
+ }
+
+ private void rethrow(Exception exception) throws IOException {
Review Comment:
is this right? the method does not always throw IOException now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
hudi-bot commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623826561 ## CI report: * 7864c76131299f3984024efb0e9fe2f94ab9e214 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14466) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623657555 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.77% -0.01% - Complexity2908729096 +9 Files 2517 2517 Lines139822 139835 +13 Branches 1720917209 + Hits 9616996171 +2 - Misses3588035895 +15 + Partials 7773 7769 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.25% <58.62%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.29% <70.68%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <58.62%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <58.62%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623655590 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.77% -0.01% - Complexity2908729096 +9 Files 2517 2517 Lines139822 139835 +13 Branches 1720917209 + Hits 9616996171 +2 - Misses3588035895 +15 + Partials 7773 7769 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.25% <58.62%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <70.68%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <58.62%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <58.62%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623629504 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 68.77% -0.01% - Complexity2908729096 +9 Files 2517 2517 Lines139822 139835 +13 Branches 1720917209 Hits 9616996169 - Misses3588035897 +17 + Partials 7773 7769 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.25% <58.62%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <70.68%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <58.62%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <58.62%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623484577 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.91%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 66.91% -1.87% + Complexity2908728261 -826 Files 2517 2517 Lines139822 139835 +13 Branches 1720917209 - Hits 9616993576-2593 - Misses3588038470+2590 - Partials 7773 7789 +16 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.25% <58.62%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.83% <70.68%> (-9.48%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <58.62%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <58.62%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/189
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623393306 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.80%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 65.80% -2.98% + Complexity2908727823-1264 Files 2517 2517 Lines139822 139835 +13 Branches 1720917209 - Hits 9616992017-4152 - Misses3588039964+4084 - Partials 7773 7854 +81 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.25% <58.62%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <58.62%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <58.62%> (-0.35%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.27% <58.62%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623366274 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.54%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|5| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 54.54% -14.24% + Complexity2908719146 -9941 = Files 2517 2043 -474 Lines139822 115538-24284 Branches 1720914906 -2303 = - Hits 9616963023-33146 - Misses3588046059+10179 + Partials 7773 6456 -1317 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <58.62%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.66% <58.62%> (+0.44%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:/
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623374544 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.29%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## - Coverage 68.77% 63.29% -5.49% + Complexity2908726697-2390 Files 2517 2517 Lines139822 139835 +13 Branches 1720917209 - Hits 9616988509-7660 - Misses3588043763+7883 + Partials 7773 7563 -210 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.25% <58.62%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <58.62%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.66% <58.62%> (+0.44%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623347484 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.46%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 55.46% -13.32% + Complexity2908719061-10026 = Files 2517 2022 -495 Lines139822 112987-26835 Branches 1720914362 -2847 = - Hits 9616962672-33497 - Misses3588043945 +8065 + Partials 7773 6370 -1403 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.12% <58.62%> (-17.18%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.66% <58.62%> (+0.44%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:/
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623356210 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.54%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 54.54% -14.24% + Complexity2908719146 -9941 = Files 2517 2043 -474 Lines139822 115538-24284 Branches 1720914906 -2303 = - Hits 9616963022-33147 - Misses3588046059+10179 + Partials 7773 6457 -1316 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <58.62%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.66% <58.62%> (+0.44%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:/
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623352631 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.54%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 54.54% -14.24% + Complexity2908719146 -9941 = Files 2517 2043 -474 Lines139822 115538-24284 Branches 1720914906 -2303 = - Hits 9616963022-33147 - Misses3588046059+10179 + Partials 7773 6457 -1316 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <58.62%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.66% <58.62%> (+0.44%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:/
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623349006 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.54%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 54.54% -14.24% + Complexity2908719146 -9941 = Files 2517 2043 -474 Lines139822 115538-24284 Branches 1720914906 -2303 = - Hits 9616963022-33147 - Misses3588046059+10179 + Partials 7773 6457 -1316 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <58.62%> (-17.59%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.66% <58.62%> (+0.44%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:/
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623341238 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.38%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|3| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 56.38% -12.40% + Complexity2908718951-10136 = Files 2517 1991 -526 Lines139822 110300-29522 Branches 1720913788 -3421 = - Hits 9616962197-33972 - Misses3588041826 +5946 + Partials 7773 6277 -1496 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <58.62%> (-16.63%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.65% <58.62%> (+0.43%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https:/
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623335836 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.75%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 48.75% -20.03% + Complexity2908716387-12700 = Files 2517 1991 -526 Lines139822 110282-29540 Branches 1720913696 -3513 = - Hits 9616953764-42405 - Misses3588050823+14943 + Partials 7773 5695 -2078 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <58.62%> (-16.63%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.77% <58.62%> (-12.45%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623302332 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.75862%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.27%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 49.27% -19.51% + Complexity2908716176-12911 = Files 2517 1974 -543 Lines139822 107836-31986 Branches 1720913162 -4047 = - Hits 9616953139-43030 - Misses3588049183+13303 + Partials 7773 5514 -2259 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <82.75%> (+0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <58.62%> (-16.63%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <58.62%> (-12.31%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](http
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623280854 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `58.62069%` with `24 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.24%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 58.62% | [21 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|1| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 43.24% -25.53% + Complexity2908713854-15233 = Files 2517 1974 -543 Lines139822 107836-31986 Branches 1720913162 -4047 = - Hits 9616946639-49530 - Misses3588055720+19840 + Partials 7773 5477 -2296 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <58.62%> (-16.63%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <58.62%> (-12.31%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623256200 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `58.62069%` with `24 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.57%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 58.62% | [21 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 39.57% -29.21% + Complexity2908712598-16489 = Files 2517 1974 -543 Lines139822 107836-31986 Branches 1720913162 -4047 = - Hits 9616942675-53494 - Misses3588059943+24063 + Partials 7773 5218 -2555 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <58.62%> (-12.31%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi
Re: [PR] fix(common): Close log writer output stream on append failure [hudi]
codecov-commenter commented on PR #18909: URL: https://github.com/apache/hudi/pull/18909#issuecomment-4623095772 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `58.62069%` with `24 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.74%. Comparing base ([`163a15a`](https://app.codecov.io/gh/apache/hudi/commit/163a15a3c899130745071396171fe451e6e62ab1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7864c76`](https://app.codecov.io/gh/apache/hudi/commit/7864c76131299f3984024efb0e9fe2f94ab9e214?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 58.62% | [21 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (163a15a) and HEAD (7864c76). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (163a15a) | HEAD (7864c76) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18909 +/- ## = - Coverage 68.77% 44.74% -24.04% + Complexity29087 8520-20567 = Files 2517 1201 -1316 Lines13982262816-77006 Branches 17209 6864-10345 = - Hits 9616928108-68061 + Misses3588031577 -4303 + Partials 7773 3131 -4642 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <58.62%> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18909?dropdown=coverage&src=pr&
