Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
cshuo commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3245310797
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##
@@ -49,6 +49,17 @@
/**
* Schema converter converts Parquet schema to and from Flink internal types.
*
+ * On reads, this converter performs best-effort physical type mapping. It
detects the
+ * Parquet {@code VARIANT} annotation and will reject shredded variants. Blob
and Vector types
+ * cannot be distinguished from ordinary binary columns via Parquet schema
alone.
+ *
+ * On writes, this converter maps Flink {@code VariantType} to the
canonical unshredded Parquet
+ * layout (group with binary metadata + value fields). The VARIANT logical
type annotation is
+ * resolved by {@link DataTypeAdapter#variantParquetAnnotation()} — on Flink
2.1+ with
+ * parquet-java 1.16.0+ the annotation is attached automatically; on pre-2.1
Flink or with
Review Comment:
1.16 or 1.15.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
danny0405 commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3245247591
##
hudi-flink-datasource/hudi-flink2.1.x/src/main/java/org/apache/hudi/adapter/DataTypeAdapter.java:
##
@@ -25,11 +25,46 @@
import org.apache.flink.table.types.logical.LogicalTypeRoot;
import org.apache.flink.types.variant.BinaryVariant;
import org.apache.flink.types.variant.Variant;
+import org.apache.hudi.common.util.Option;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+
+import java.lang.reflect.Method;
/**
* Adapter utils to provide {@code DataType} utilities.
*/
public class DataTypeAdapter {
+
+ /**
+ * The Parquet Variant binary format specification version passed to
+ * {@code LogicalTypeAnnotation.variantType(byte)}. Version 1 is the initial
spec
+ * defined by the Parquet Variant proposal (parquet-format 2.11.0 /
parquet-java 1.16.0).
+ */
+ private static final byte VARIANT_SPEC_VERSION = 1;
+
+ /**
+ * Cached VARIANT annotation resolved via reflection. Empty if parquet-java
+ * on the classpath predates {@code LogicalTypeAnnotation.variantType()} (<
1.16.0).
+ */
+ private static final Option VARIANT_ANNOTATION =
resolveVariantAnnotation();
+
+ private static Option resolveVariantAnnotation() {
+try {
+ Method factory = LogicalTypeAnnotation.class.getMethod("variantType",
byte.class);
Review Comment:
we could use method call directly in the repo since the parquet version is
1.15.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
danny0405 commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3245250511
##
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestVariantCrossEngineCompatibility.java:
##
@@ -56,7 +57,6 @@ public class ITTestVariantCrossEngineCompatibility {
private void verifyFlinkCanReadSparkVariantTable(String tablePath, String
tableType, String testDescription) throws Exception {
TableEnvironment tableEnv = TestTableEnvs.getBatchTableEnv();
-// Create a Hudi table pointing to the Spark-written data
Review Comment:
In ITTestHoodieDataSource, can we add a Flink e2e test to write/read the
variant type to validate it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454819818 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 9208c409614f041af069bd0d4292f557af722438 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13980) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454561725 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.12% -0.03% + Complexity2905129047 -4 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 + Hits 9604796057 +10 - Misses3699337074 +81 + Partials 7895 7875 -20 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <ø> (-0.22%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=t
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454525753 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.10%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.10% -0.05% + Complexity2905129041 -10 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604796035 -12 - Misses3699337099 +106 + Partials 7895 7872 -23 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.75% <ø> (-0.27%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=t
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454493095 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.10%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.10% -0.05% + Complexity2905129041 -10 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604796032 -15 - Misses3699337101 +108 + Partials 7895 7873 -22 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.71% <ø> (-0.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=t
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454385895 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.01%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.01% -1.14% + Complexity2905128549 -502 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604794502-1545 - Misses3699338590+1597 - Partials 7895 7914 +19 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.87% <ø> (-7.15%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=t
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454376467 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.43%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.43% -2.72% + Complexity2905127900-1151 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604792270-3777 - Misses3699340778+3785 - Partials 7895 7958 +63 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <ø> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454340319 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.25%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.25% -2.90% + Complexity2905127788-1263 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604792016-4031 - Misses3699341084+4091 - Partials 7895 7906 +11 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.56% <ø> (-0.34%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454324917 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.22%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.22% -2.93% + Complexity2905127788-1263 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604791970-4077 - Misses3699341098+4105 - Partials 7895 7938 +43 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.47%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <ø> (-0.39%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454303728 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.86%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|spark-java-tests|18|5| >|spark-scala-tests|12|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.86% -7.29% + Complexity2905125931-3120 Files 2516 2516 Lines140935 141006 +71 Branches 1747217487 +15 - Hits 9604785826 -10221 - Misses3699347665 +10672 + Partials 7895 7515 -380 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <ø> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.co
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454288945 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.86%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|4| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.86% -20.29% + Complexity2905117126-11925 = Files 2516 2049 -467 Lines140935 117212-23723 Branches 1747215243 -2229 = - Hits 9604756105-39942 - Misses3699354929+17936 + Partials 7895 6178 -1717 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.94% <ø> (-17.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <ø> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454297157 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.86%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|5| >|spark-scala-tests|12|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 53.86% -14.29% + Complexity2905119073 -9978 = Files 2516 2049 -467 Lines140935 117226-23709 Branches 1747215245 -2227 = - Hits 9604763147-32900 - Misses3699347294+10301 + Partials 7895 6785 -1110 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <ø> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1426 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454287437 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.86%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|4| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.86% -20.29% + Complexity2905117126-11925 = Files 2516 2049 -467 Lines140935 117212-23723 Branches 1747215243 -2229 = - Hits 9604756105-39942 - Misses3699354929+17936 + Partials 7895 6178 -1717 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.94% <ø> (-17.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <ø> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454281029 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.83%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|3| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.83% -20.32% + Complexity2905117117-11934 = Files 2516 2049 -467 Lines140935 117198-23737 Branches 1747215241 -2231 = - Hits 9604756063-39984 - Misses3699354950+17957 + Partials 7895 6185 -1710 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.66%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <ø> (-12.19%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454278058 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.83%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|3| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.83% -20.32% + Complexity2905117117-11934 = Files 2516 2049 -467 Lines140935 117198-23737 Branches 1747215241 -2231 = - Hits 9604756063-39984 - Misses3699354950+17957 + Partials 7895 6185 -1710 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.66%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <ø> (-12.19%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454276953 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.83%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|3| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.83% -20.32% + Complexity2905117117-11934 = Files 2516 2049 -467 Lines140935 117198-23737 Branches 1747215241 -2231 = - Hits 9604756063-39984 - Misses3699354950+17957 + Partials 7895 6185 -1710 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <ø> (-16.66%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <ø> (-12.19%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454261383 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.98%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 45.98% -22.17% + Complexity2905115757-13294 = Files 2516 2011 -505 Lines140935 112249-28686 Branches 1747214160 -3312 = - Hits 9604751615-44432 - Misses3699355036+18043 + Partials 7895 5598 -2297 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.00% <ø> (-11.90%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1631 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454259081 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.41%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|2| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 46.41% -21.74% + Complexity2905115547-13504 = Files 2516 1994 -522 Lines140935 109877-31058 Branches 1747213651 -3821 = - Hits 9604751002-45045 - Misses3699353468+16475 + Partials 7895 5407 -2488 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <ø> (-11.74%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1641 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454265110 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.98%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 45.98% -22.17% + Complexity2905115757-13294 = Files 2516 2011 -505 Lines140935 112249-28686 Branches 1747214160 -3312 = - Hits 9604751615-44432 - Misses3699355036+18043 + Partials 7895 5598 -2297 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.00% <ø> (-11.90%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1631 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454216110 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 150cfd13c4551cbe912bf9f3d2bf2932051553ba Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13978) * 9208c409614f041af069bd0d4292f557af722438 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13980) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454215538 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.03%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 54.03% -14.12% + Complexity2905112453-16598 = Files 2516 1434 -1082 Lines14093572134-68801 Branches 17472 8238 -9234 = - Hits 9604738977-57070 + Misses3699329657 -7336 + Partials 7895 3500 -4395 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ø> (ø)` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1863 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454074256 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.01%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9208c40`](https://app.codecov.io/gh/apache/hudi/commit/9208c409614f041af069bd0d4292f557af722438?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (9208c40). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (9208c40) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 45.01% -23.14% + Complexity29051 8573-20478 = Files 2516 1202 -1314 Lines14093562805-78130 Branches 17472 6809-10663 = - Hits 9604728269-67778 + Misses3699331422 -5571 + Partials 7895 3114 -4781 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2113 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4454003101 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 150cfd13c4551cbe912bf9f3d2bf2932051553ba Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13978) * 9208c409614f041af069bd0d4292f557af722438 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453869113 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 150cfd13c4551cbe912bf9f3d2bf2932051553ba Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13978) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-agent commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3243506412
##
hudi-flink-datasource/hudi-flink2.1.x/src/main/java/org/apache/hudi/adapter/DataTypeAdapter.java:
##
@@ -25,11 +25,39 @@
import org.apache.flink.table.types.logical.LogicalTypeRoot;
import org.apache.flink.types.variant.BinaryVariant;
import org.apache.flink.types.variant.Variant;
+import org.apache.hudi.common.util.Option;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+
+import java.lang.reflect.Method;
/**
* Adapter utils to provide {@code DataType} utilities.
*/
public class DataTypeAdapter {
+
+ /**
+ * Cached VARIANT annotation resolved via reflection. Empty if parquet-java
+ * on the classpath predates {@code LogicalTypeAnnotation.variantType()} (<
1.16.0).
+ */
+ private static final Option VARIANT_ANNOTATION =
resolveVariantAnnotation();
+
+ private static Option resolveVariantAnnotation() {
+try {
+ Method factory = LogicalTypeAnnotation.class.getMethod("variantType",
byte.class);
+ return Option.of((LogicalTypeAnnotation) factory.invoke(null, (byte) 1));
Review Comment:
🤖 nit: the bare `(byte) 1` here is a magic value — could you pull it into a
named constant (e.g. `VARIANT_SPEC_VERSION`) or add a brief comment noting what
it represents? Otherwise a future reader has to dig into parquet-java to
understand why we pass `1`.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453605502 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.13% -0.02% - Complexity2905129062 +11 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 + Hits 9604796070 +23 - Misses3699337046 +53 + Partials 7895 7890 -5 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.98% <ø> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453575243 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.13% -0.02% - Complexity2905129062 +11 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 + Hits 9604796069 +22 - Misses3699337046 +53 + Partials 7895 7891 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.97% <ø> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453542692 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.13% -0.02% - Complexity2905129062 +11 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 + Hits 9604796069 +22 - Misses3699337046 +53 + Partials 7895 7891 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.94% <ø> (-0.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453480907 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.12% -0.03% - Complexity2905129062 +11 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 + Hits 9604796067 +20 - Misses3699337048 +55 + Partials 7895 7891 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.91% <ø> (-0.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453469858 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.12% -0.03% - Complexity2905129062 +11 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 + Hits 9604796065 +18 - Misses3699337049 +56 + Partials 7895 7892 -3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.91% <ø> (-0.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453448973 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.07%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.07% -0.08% + Complexity2905129032 -19 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604795995 -52 - Misses3699337122 +129 + Partials 7895 7889 -6 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <ø> (-0.34%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453438249 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.06%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.06% -0.09% + Complexity2905129027 -24 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604795973 -74 - Misses3699337148 +155 + Partials 7895 7885 -10 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <ø> (-0.39%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453428001 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.06%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 68.06% -0.09% + Complexity2905129027 -24 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604795973 -74 - Misses3699337148 +155 + Partials 7895 7885 -10 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <ø> (-0.42%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453415366 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.31%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.31% -0.84% + Complexity2905128722 -329 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604794913-1134 - Misses3699338149+1156 - Partials 7895 7944 +49 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <ø> (-3.77%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453408541 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.28%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.28% -0.87% + Complexity2905128710 -341 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604794872-1175 - Misses3699338203+1210 - Partials 7895 7931 +36 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <ø> (-3.97%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453399471 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.23%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.23% -0.92% + Complexity2905128672 -379 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604794802-1245 - Misses3699338278+1285 - Partials 7895 7926 +31 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (-4.22%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453388629 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.39%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.39% -2.76% + Complexity2905127878-1173 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604792208-3839 - Misses3699340846+3853 - Partials 7895 7952 +57 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <ø> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453397922 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.23%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.23% -0.92% + Complexity2905128672 -379 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604794802-1245 - Misses3699338278+1285 - Partials 7895 7926 +31 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (-4.22%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <ø> (-0.02%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453392967 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.16%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.16% -0.99% + Complexity2905128632 -419 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604794703-1344 - Misses3699338395+1402 - Partials 7895 7908 +13 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.56% <ø> (-4.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <ø> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453379606 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.35%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.35% -2.80% + Complexity2905127848-1203 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604792154-3893 - Misses3699340912+3919 - Partials 7895 7940 +45 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <ø> (-0.16%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453378102 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.30%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.30% -2.85% + Complexity2905127816-1235 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604792086-3961 - Misses3699340991+3998 - Partials 7895 7929 +34 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.65% <ø> (-0.25%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453372650 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.23%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.23% -2.92% + Complexity2905127791-1260 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604791992-4055 - Misses3699341075+4082 - Partials 7895 7939 +44 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.50% <ø> (-0.40%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-445388 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.86%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|spark-java-tests|18|6| >|spark-scala-tests|12|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.86% -7.29% + Complexity2905125934-3117 Files 2516 2516 Lines140935 141006 +71 Branches 1747217484 +12 - Hits 9604785820 -10227 - Misses3699347667 +10674 + Partials 7895 7519 -376 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.72% <ø> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing line
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453325076 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.61%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|spark-java-tests|18|6| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.61% -7.54% + Complexity2905125776-3275 Files 2516 2516 Lines140935 140992 +57 Branches 1747217482 +10 - Hits 9604785460 -10587 - Misses3699348126 +11133 + Partials 7895 7406 -489 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.55% <ø> (-17.46%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing line
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453316840 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.58%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|spark-java-tests|18|5| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.58% -7.56% + Complexity2905125767-3284 Files 2516 2516 Lines140935 140992 +57 Branches 1747217482 +10 - Hits 9604785427 -10620 - Misses3699348155 +11162 + Partials 7895 7410 -485 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.93% <ø> (-17.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing line
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453312603 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.58%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|spark-java-tests|18|4| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.58% -7.57% + Complexity2905125766-3285 Files 2516 2516 Lines140935 140992 +57 Branches 1747217482 +10 - Hits 9604785422 -10625 - Misses3699348161 +11168 + Partials 7895 7409 -486 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.42% <66.66%> (+<0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.93% <ø> (-17.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing line
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453294950 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.54%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|4| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.54% -20.61% + Complexity2905116964-12087 = Files 2516 2049 -467 Lines140935 117198-23737 Branches 1747215238 -2234 = - Hits 9604755721-40326 - Misses3699355412+18419 + Partials 7895 6065 -1830 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.93% <ø> (-17.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453305940 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.52%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|4| >|spark-scala-tests|12|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 53.52% -14.63% + Complexity2905118905-10146 = Files 2516 2049 -467 Lines140935 117198-23737 Branches 1747215238 -2234 = - Hits 9604762733-33314 - Misses3699347790+10797 + Partials 7895 6675 -1220 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.93% <ø> (-17.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1430 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453296286 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.54%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|4| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.54% -20.61% + Complexity2905116964-12087 = Files 2516 2049 -467 Lines140935 117198-23737 Branches 1747215238 -2234 = - Hits 9604755721-40326 - Misses3699355412+18419 + Partials 7895 6065 -1830 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.93% <ø> (-17.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453286946 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.48%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|2| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.48% -20.67% + Complexity2905116946-12105 = Files 2516 2049 -467 Lines140935 117184-23751 Branches 1747215236 -2236 = - Hits 9604755648-40399 - Misses3699355458+18465 + Partials 7895 6078 -1817 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <ø> (-16.31%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453280296 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.45%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|1| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.45% -20.70% + Complexity2905116935-12116 = Files 2516 2049 -467 Lines140935 117184-23751 Branches 1747215236 -2236 = - Hits 9604755605-40442 - Misses3699355498+18505 + Partials 7895 6081 -1814 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <ø> (-15.94%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453277283 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.45%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|1| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.45% -20.70% + Complexity2905116935-12116 = Files 2516 2049 -467 Lines140935 117184-23751 Branches 1747215236 -2236 = - Hits 9604755605-40442 - Misses3699355498+18505 + Partials 7895 6081 -1814 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <ø> (-15.94%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <ø> (-12.08%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453268301 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.43%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|1| >|spark-scala-tests|12|2| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 48.43% -19.72% + Complexity2905116504-12547 = Files 2516 2010 -506 Lines140935 112254-28681 Branches 1747214175 -3297 = - Hits 9604754369-41678 - Misses3699352173+15180 + Partials 7895 5712 -2183 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <ø> (-15.94%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <ø> (-11.78%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1590 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453237468 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 75444efd5952688c73ff56ef1dee544630feabf1 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13963) * 150cfd13c4551cbe912bf9f3d2bf2932051553ba Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13978) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453227122 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.91%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|1| >|spark-scala-tests|12|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 48.91% -19.24% + Complexity2905116297-12754 = Files 2516 1993 -523 Lines140935 109813-31122 Branches 1747213639 -3833 = - Hits 9604753717-42330 - Misses3699350554+13561 + Partials 7895 5542 -2353 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <ø> (-15.94%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <ø> (-11.72%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1601 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453224062 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 43.00%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|1| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 43.00% -25.15% + Complexity2905113979-15072 = Files 2516 1993 -523 Lines140935 109813-31122 Branches 1747213639 -3833 = - Hits 9604747226-48821 - Misses3699357077+20084 + Partials 7895 5510 -2385 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <ø> (-15.94%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <ø> (-11.72%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1807 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453198426 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 39.88%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 39.88% -28.27% + Complexity2905112622-16429 = Files 2516 1963 -553 Lines140935 107154-33781 Branches 1747212999 -4473 = - Hits 9604742742-53305 - Misses3699359232+22239 + Partials 7895 5180 -2715 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <ø> (-11.72%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1873 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4453037729 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.99%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`150cfd1`](https://app.codecov.io/gh/apache/hudi/commit/150cfd13c4551cbe912bf9f3d2bf2932051553ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (150cfd1). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (150cfd1) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 44.99% -23.16% + Complexity29051 8566-20485 = Files 2516 1202 -1314 Lines14093562805-78130 Branches 17472 6809-10663 = - Hits 9604728258-67789 + Misses3699331430 -5563 + Partials 7895 3117 -4778 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2115 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4452924524 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 75444efd5952688c73ff56ef1dee544630feabf1 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13963) * 150cfd13c4551cbe912bf9f3d2bf2932051553ba UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-agent commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3239609249
##
hudi-flink-datasource/hudi-flink2.1.x/src/main/java/org/apache/hudi/adapter/DataTypeAdapter.java:
##
@@ -25,11 +25,38 @@
import org.apache.flink.table.types.logical.LogicalTypeRoot;
import org.apache.flink.types.variant.BinaryVariant;
import org.apache.flink.types.variant.Variant;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+
+import java.lang.reflect.Method;
/**
* Adapter utils to provide {@code DataType} utilities.
*/
public class DataTypeAdapter {
+
+ /**
+ * Cached VARIANT annotation resolved via reflection, or {@code null} if
parquet-java
+ * on the classpath predates {@code LogicalTypeAnnotation.variantType()} (<
1.16.0).
+ */
+ private static final LogicalTypeAnnotation VARIANT_ANNOTATION =
resolveVariantAnnotation();
+
+ private static LogicalTypeAnnotation resolveVariantAnnotation() {
+try {
+ Method factory = LogicalTypeAnnotation.class.getMethod("variantType",
byte.class);
+ return (LogicalTypeAnnotation) factory.invoke(null, (byte) 1);
Review Comment:
🤖 nit: the bare `(byte) 1` is opaque — could you pull it into a named
constant (e.g. `VARIANT_SPEC_VERSION`) or add a short comment explaining it's
the variant spec version byte expected by `variantType(byte)`? Future readers
shouldn't have to dig into parquet-java to know what `1` means.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-client/hudi-flink-client/src/test/java/org/apache/hudi/io/storage/row/parquet/TestParquetSchemaConverter.java:
##
@@ -216,4 +228,117 @@ void testConvertTimestampTypes() {
+ "}\n";
assertThat(messageType.toString(), is(expected));
}
+
+ /**
+ * A Parquet group with metadata + value binary fields but NO VARIANT
annotation must be
+ * treated as a plain ROW. Only the Parquet {@code VARIANT} annotation
triggers variant
+ * detection in this converter; unannotated groups are never guessed as
variant.
+ */
+ @Test
+ void testVariantPhysicalLayoutTreatedAsRow() {
+MessageType variantParquet = new MessageType(
+"test",
+Types.primitive(PrimitiveType.PrimitiveTypeName.INT32,
+Type.Repetition.REQUIRED).named("id"),
+Types.buildGroup(Type.Repetition.REQUIRED)
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("metadata"))
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("value"))
+.named("data"));
+
+RowType rowType = ParquetSchemaConverter.convertToRowType(variantParquet);
+assertEquals(2, rowType.getFieldCount());
+assertEquals("ROW", rowType.getTypeAt(1).getTypeRoot().name());
+ }
+
+ /**
+ * Unannotated group with metadata + value + typed_value (3 fields) is
treated as a generic
+ * ROW when no annotation or schema hint is present.
+ */
+ @Test
+ void testUnannotatedShreddedGroupTreatedAsRow() {
+MessageType shreddedNoAnnotation = new MessageType(
+"test",
+Types.primitive(PrimitiveType.PrimitiveTypeName.INT32,
+Type.Repetition.REQUIRED).named("id"),
+Types.buildGroup(Type.Repetition.REQUIRED)
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("metadata"))
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("value"))
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.INT32,
+Type.Repetition.OPTIONAL).named("typed_value"))
+.named("data"));
+
+RowType rowType =
ParquetSchemaConverter.convertToRowType(shreddedNoAnnotation);
+assertEquals(2, rowType.getFieldCount());
+assertEquals("ROW", rowType.getTypeAt(1).getTypeRoot().name());
+ }
+
+ /**
+ * On Flink 2.1+, converting a RowType containing a Variant column to a
Parquet MessageType
+ * should produce a group with required binary {@code metadata} and {@code
value} fields.
+ * On pre-2.1 Flink this test is skipped since VariantType does not exist.
+ */
+ @Test
+ void testVariantWritePathProducesCorrectLayout() {
+LogicalType variantType;
+try {
+ variantType = DataTypeAdapter.createVariantType().getLogicalType();
+} catch (UnsupportedOperationException e) {
+ // Pre-2.1 Flink: VariantType doesn't exist, skip
+ return;
+}
+
+RowType rowType = RowType.of(
+new LogicalType[]{new IntType(), variantType},
+new String[]{"id", "data"});
+
+MessageType messageType =
ParquetSchemaConverter.convertToParquetMessageType("test", rowType);
+assertEquals(2, messageType.getFieldCount());
+
+Type variantField = messageType.getType("data");
+assertTrue(variantFiel
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447521601 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.16%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## + Coverage 68.14% 68.16% +0.01% + Complexity2905129042 -9 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 + Hits 9604796069 +22 + Misses3699336976 -17 + Partials 7895 7894 -1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.99% <ø> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447515252 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.16%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## + Coverage 68.14% 68.16% +0.01% + Complexity2905129041 -10 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 + Hits 9604796067 +20 + Misses3699336977 -16 Partials 7895 7895 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.99% <ø> (-0.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447479052 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.16%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## + Coverage 68.14% 68.16% +0.01% + Complexity2905129040 -11 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 + Hits 9604796066 +19 + Misses3699336977 -16 - Partials 7895 7896 +1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.96% <ø> (-0.06%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447473654 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 75444efd5952688c73ff56ef1dee544630feabf1 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13963) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447451632 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.15%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## + Coverage 68.14% 68.15% +0.01% + Complexity2905129040 -11 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 + Hits 9604796064 +17 + Misses3699336979 -14 - Partials 7895 7896 +1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <ø> (-0.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447441080 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.15%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18539 +/- ## = Coverage 68.14% 68.15% + Complexity2905129040 -11 = Files 2516 2516 Lines140935 140939+4 Branches 1747217476+4 = + Hits 9604796062 +15 + Misses3699336980 -13 - Partials 7895 7897+2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.91% <ø> (-0.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447431767 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.15%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18539 +/- ## = Coverage 68.14% 68.15% + Complexity2905129040 -11 = Files 2516 2516 Lines140935 140939+4 Branches 1747217476+4 = + Hits 9604796058 +11 + Misses3699336983 -10 - Partials 7895 7898+3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <ø> (-0.15%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447423804 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.40%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.40% -0.75% + Complexity2905128736 -315 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604795002-1045 - Misses3699337982 +989 - Partials 7895 7955 +60 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <ø> (-3.50%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447387937 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.04%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.04% -1.11% + Complexity2905128538 -513 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604794498-1549 - Misses3699338520+1527 - Partials 7895 7921 +26 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.89% <ø> (-7.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447396908 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.37%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 67.37% -0.78% + Complexity2905128724 -327 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604794961-1086 - Misses3699338036+1043 - Partials 7895 7942 +47 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <ø> (-3.70%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (+<0.01%)` | :arrow_up: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-clie
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447385398 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.37%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.37% -2.78% + Complexity2905127826-1225 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604792140-3907 - Misses3699340866+3873 - Partials 7895 7933 +38 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <ø> (-17.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.73% <ø> (-0.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-cl
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447381762 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.34%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.34% -2.81% + Complexity2905127826-1225 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604792097-3950 - Misses3699340877+3884 - Partials 7895 7965 +70 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <ø> (-17.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <ø> (-0.21%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-cl
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447355278 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.29%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 65.29% -2.86% + Complexity2905127795-1256 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604792032-4015 - Misses3699340955+3962 - Partials 7895 7952 +57 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <ø> (-17.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <ø> (-0.29%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-cl
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447339441 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.89%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|spark-java-tests|18|6| >|spark-scala-tests|12|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.89% -7.26% + Complexity2905125922-3129 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604785824 -10223 - Misses3699347595 +10602 + Partials 7895 7520 -375 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <ø> (-17.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdo
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447334053 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.89%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|spark-java-tests|18|5| >|spark-scala-tests|12|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## - Coverage 68.14% 60.89% -7.26% + Complexity2905125922-3129 Files 2516 2516 Lines140935 140939 +4 Branches 1747217476 +4 - Hits 9604785824 -10223 - Misses3699347595 +10602 + Partials 7895 7520 -375 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <60.00%> (+0.01%)` | :arrow_up: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <ø> (-17.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdo
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447321314 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.87%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|4| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.87% -20.28% + Complexity2905117122-11929 = Files 2516 2049 -467 Lines140935 117170-23765 Branches 1747215237 -2235 = - Hits 9604756097-39950 - Misses3699354891+17898 + Partials 7895 6182 -1713 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.94% <ø> (-17.07%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447325206 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.90%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|5| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.90% -20.24% + Complexity2905117134-11917 = Files 2516 2049 -467 Lines140935 117170-23765 Branches 1747215237 -2235 = - Hits 9604756136-39911 - Misses3699354860+17867 + Partials 7895 6174 -1721 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.56% <ø> (-17.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1559 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447308346 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.84%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|3| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.84% -20.31% + Complexity2905117113-11938 = Files 2516 2049 -467 Lines140935 117170-23765 Branches 1747215237 -2235 = - Hits 9604756057-39990 - Misses3699354922+17929 + Partials 7895 6191 -1704 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.29% <ø> (-16.73%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447312321 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.84%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|3| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.84% -20.31% + Complexity2905117113-11938 = Files 2516 2049 -467 Lines140935 117170-23765 Branches 1747215237 -2235 = - Hits 9604756057-39990 - Misses3699354922+17929 + Partials 7895 6191 -1704 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.29% <ø> (-16.73%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447295163 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.78%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|1| >|spark-scala-tests|12|6| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 47.78% -20.37% + Complexity2905117091-11960 = Files 2516 2049 -467 Lines140935 117170-23765 Branches 1747215237 -2235 = - Hits 9604755985-40062 - Misses3699354986+17993 + Partials 7895 6199 -1696 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ø> (-15.92%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ø> (-12.17%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1561 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447288217 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.57%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 45.57% -22.58% + Complexity2905115992-13059 = Files 2516 2032 -484 Lines140935 114798-26137 Branches 1747214728 -2744 = - Hits 9604752316-43731 - Misses3699356687+19694 + Partials 7895 5795 -2100 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <ø> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1620 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447284821 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.49%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 46.49% -21.66% + Complexity2905115566-13485 = Files 2516 1993 -523 Lines140935 109887-31048 Branches 1747213675 -3797 = - Hits 9604751097-44950 - Misses3699353375+16382 + Partials 7895 5415 -2480 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.26% <ø> (-11.64%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1642 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447271452 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.41%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|2| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 46.41% -21.74% + Complexity2905115566-13485 = Files 2516 1993 -523 Lines140935 109736-31199 Branches 1747213611 -3861 = - Hits 9604750932-45115 - Misses3699353353+16360 + Partials 7895 5451 -2444 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <ø> (-11.75%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1664 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447252933 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.85%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-scala-tests|12|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 46.85% -21.30% + Complexity2905115322-13729 = Files 2516 1966 -550 Lines140935 107135-33800 Branches 1747213058 -4414 = - Hits 9604750193-45854 - Misses3699351691+14698 + Partials 7895 5251 -2644 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.34% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.25% <ø> (-11.65%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1678 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447242627 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 39.93%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 39.93% -28.22% + Complexity2905112645-16406 = Files 2516 1966 -550 Lines140935 107111-33824 Branches 1747213037 -4435 = - Hits 9604742776-53271 - Misses3699359156+22163 + Partials 7895 5179 -2716 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.25% <ø> (-11.65%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1889 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447151318 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.99%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75444ef`](https://app.codecov.io/gh/apache/hudi/commit/75444efd5952688c73ff56ef1dee544630feabf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (75444ef). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (75444ef) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 44.99% -23.16% + Complexity29051 8565-20486 = Files 2516 1202 -1314 Lines14093562805-78130 Branches 17472 6809-10663 = - Hits 9604728256-67791 + Misses3699331431 -5562 + Partials 7895 3118 -4777 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2114 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447131801 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 8963a31f08bcb4892ffa313d1a4ad258b8fa2a7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13946) * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 75444efd5952688c73ff56ef1dee544630feabf1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13963) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447104318 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 8963a31f08bcb4892ffa313d1a4ad258b8fa2a7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13946) * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN * 75444efd5952688c73ff56ef1dee544630feabf1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
codecov-commenter commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4447005343 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.99%. Comparing base ([`f2fdca2`](https://app.codecov.io/gh/apache/hudi/commit/f2fdca26fef48d2d68a51d4ee98b03b2cbfbc93a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`16f7850`](https://app.codecov.io/gh/apache/hudi/commit/16f78504f1eccd50addcacec5f8cf9aae7de5ce6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f2fdca2) and HEAD (16f7850). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (f2fdca2) | HEAD (16f7850) | >|--|--|--| >|common-and-other-modules|1|0| >|spark-java-tests|18|0| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18539 +/- ## = - Coverage 68.14% 44.99% -23.16% + Complexity29051 8565-20486 = Files 2516 1202 -1314 Lines14093562805-78130 Branches 17472 6809-10663 = - Hits 9604728257-67790 + Misses3699331430 -5563 + Partials 7895 3118 -4777 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ø> (+0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2115 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-agent commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3238741771
##
hudi-flink-datasource/hudi-flink2.1.x/src/main/java/org/apache/hudi/adapter/DataTypeAdapter.java:
##
@@ -25,11 +25,37 @@
import org.apache.flink.table.types.logical.LogicalTypeRoot;
import org.apache.flink.types.variant.BinaryVariant;
import org.apache.flink.types.variant.Variant;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+
+import java.lang.reflect.Method;
/**
* Adapter utils to provide {@code DataType} utilities.
*/
public class DataTypeAdapter {
+
+ /**
+ * Cached VARIANT annotation resolved via reflection, or {@code null} if
parquet-java
+ * on the classpath predates {@code LogicalTypeAnnotation.variantType()} (<
1.16.0).
+ */
+ private static final LogicalTypeAnnotation VARIANT_ANNOTATION =
resolveVariantAnnotation();
+
+ private static LogicalTypeAnnotation resolveVariantAnnotation() {
+try {
+ Method factory = LogicalTypeAnnotation.class.getMethod("variantType",
byte.class);
+ return (LogicalTypeAnnotation) factory.invoke(null, (byte) 1);
Review Comment:
🤖 nit: the `(byte) 1` passed to `variantType()` is a magic number whose
meaning (shredding version) isn't obvious from the call site — could you
extract it as `private static final byte VARIANT_SHREDDING_VERSION = 1;` or at
least drop a short inline comment explaining what it represents?
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-client/hudi-flink-client/src/test/java/org/apache/hudi/io/storage/row/parquet/TestParquetSchemaConverter.java:
##
@@ -216,4 +228,117 @@ void testConvertTimestampTypes() {
+ "}\n";
assertThat(messageType.toString(), is(expected));
}
+
+ /**
+ * A Parquet group with metadata + value binary fields but NO VARIANT
annotation must be
+ * treated as a plain ROW. Only the Parquet {@code VARIANT} annotation
triggers variant
+ * detection in this converter; unannotated groups are never guessed as
variant.
+ */
+ @Test
+ void testVariantPhysicalLayoutTreatedAsRow() {
+MessageType variantParquet = new MessageType(
+"test",
+Types.primitive(PrimitiveType.PrimitiveTypeName.INT32,
+Type.Repetition.REQUIRED).named("id"),
+Types.buildGroup(Type.Repetition.REQUIRED)
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("metadata"))
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("value"))
+.named("data"));
+
+RowType rowType = ParquetSchemaConverter.convertToRowType(variantParquet);
+assertEquals(2, rowType.getFieldCount());
+assertEquals("ROW", rowType.getTypeAt(1).getTypeRoot().name());
+ }
+
+ /**
+ * Unannotated group with metadata + value + typed_value (3 fields) is
treated as a generic
+ * ROW when no annotation or schema hint is present.
+ */
+ @Test
+ void testUnannotatedShreddedGroupTreatedAsRow() {
+MessageType shreddedNoAnnotation = new MessageType(
+"test",
+Types.primitive(PrimitiveType.PrimitiveTypeName.INT32,
+Type.Repetition.REQUIRED).named("id"),
+Types.buildGroup(Type.Repetition.REQUIRED)
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("metadata"))
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.BINARY,
+Type.Repetition.REQUIRED).named("value"))
+.addField(Types.primitive(PrimitiveType.PrimitiveTypeName.INT32,
+Type.Repetition.OPTIONAL).named("typed_value"))
+.named("data"));
+
+RowType rowType =
ParquetSchemaConverter.convertToRowType(shreddedNoAnnotation);
+assertEquals(2, rowType.getFieldCount());
+assertEquals("ROW", rowType.getTypeAt(1).getTypeRoot().name());
+ }
+
+ /**
+ * On Flink 2.1+, converting a RowType containing a Variant column to a
Parquet MessageType
+ * should produce a group with required binary {@code metadata} and {@code
value} fields.
+ * On pre-2.1 Flink this test is skipped since VariantType does not exist.
+ */
+ @Test
+ void testVariantWritePathProducesCorrectLayout() {
+LogicalType variantType;
+try {
+ variantType = DataTypeAdapter.createVariantType().getLogicalType();
+} catch (UnsupportedOperationException e) {
+ // Pre-2.1 Flink: VariantType doesn't exist, skip
+ return;
+}
+
+RowType rowType = RowType.of(
+new LogicalType[]{new IntType(), variantType},
+new String[]{"id", "data"});
+
+MessageType messageType =
ParquetSchemaConverter.convertToParquetMessageType("test", rowType);
+assertEquals(2, messageType.getFieldCount());
+
+Type variantField = messageType.getType("data");
+assertTrue(variantField
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4446941086 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 8963a31f08bcb4892ffa313d1a4ad258b8fa2a7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13946) * 16f78504f1eccd50addcacec5f8cf9aae7de5ce6 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-agent commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3235347883
##
hudi-flink-datasource/hudi-flink2.1.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##
@@ -498,6 +509,23 @@ private static ColumnReader createColumnReader(
}
}
return new RowColumnReader(fieldReaders);
+ case VARIANT:
+// Top-level variant columns only. Nested variant (e.g.
ARRAY, ROW<..., VARIANT>)
+// is not yet supported — see ColumnarGroupRowData.getVariant() /
ColumnarGroupArrayData.getVariant().
+//
+// Variant is stored in Parquet as a group with binary "metadata" and
"value" fields.
+// VectorizedColumnBatch.getVariant() expects child order [value(0),
metadata(1)]
+// to match the BinaryVariant(value, metadata) constructor.
+GroupType variantGroup = physicalType.asGroupType();
Review Comment:
🤖 nit: `variantDescs` and `metaDescs` are each single-element lists whose
only purpose is the immediate `.get(0)` call — the MAP case in the same switch
inlines this as `descriptors.get(0)` directly. Could you collapse these to
`ColumnDescriptor valueDesc = filterDescriptors(depth + 1,
variantGroup.getType(valueIdx), columns).get(0);` (and same for `metaDesc`) to
make it obvious only one descriptor is expected per binary child?
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestVariantCrossEngineCompatibility.java:
##
@@ -72,8 +73,37 @@ private void verifyFlinkCanReadSparkVariantTable(String
tablePath, String tableT
+ " 'table.type' = '%s'"
+ ")",
tablePath, tableType);
+ }
-tableEnv.executeSql(createTableDdl);
+ /**
+ * On Flink 2.1+ verifies that Flink can fully read Spark 4.0 Variant tables.
+ * On pre-2.1 Flink verifies that reading fails with {@link
UnsupportedOperationException}
+ * because native VariantType is not available.
+ */
+ private void verifyFlinkCanReadSparkVariantTable(String tablePath, String
tableType, String testDescription) throws Exception {
+TableEnvironment tableEnv = TestTableEnvs.getBatchTableEnv();
+tableEnv.executeSql(createVariantTableDdl(tablePath, tableType));
+
+boolean variantSupported;
+try {
+ DataTypeAdapter.createVariantType();
+ variantSupported = true;
+} catch (UnsupportedOperationException e) {
+ variantSupported = false;
+}
+
+if (!variantSupported) {
+ assertThrows(
+ Exception.class,
Review Comment:
🤖 nit: this try/catch probe is duplicated verbatim from
`TestHoodieSchemaConverter.hasNativeVariantType()` — could you extract a
private static `hasNativeVariantType()` helper here as well so the two test
classes stay in sync if the detection logic ever changes?
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
danny0405 commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3233629693
##
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileReaderFactory.java:
##
@@ -70,7 +75,7 @@ public HoodieFileReader getFileReader(HoodieConfig
hoodieConfig, StoragePath pat
Option schemaOption)
throws IOException {
switch (format) {
case PARQUET:
-return newParquetFileReader(path);
+return newParquetFileReader(path, schemaOption);
Review Comment:
I guess there is also no need to add schema for COW write path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
danny0405 commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3233622437
##
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileReaderFactory.java:
##
@@ -70,7 +75,7 @@ public HoodieFileReader getFileReader(HoodieConfig
hoodieConfig, StoragePath pat
Option schemaOption)
throws IOException {
switch (format) {
case PARQUET:
-return newParquetFileReader(path);
+return newParquetFileReader(path, schemaOption);
Review Comment:
since we have assumption that Flink only supports variant on 2.1 release
with parquet 1.15.2+, do we still need to pass around these schemas? the
parquet data type already has the type annotation right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
danny0405 commented on code in PR #18539:
URL: https://github.com/apache/hudi/pull/18539#discussion_r3233608783
##
hudi-client/hudi-flink-client/src/test/java/org/apache/hudi/util/TestHoodieSchemaConverter.java:
##
@@ -692,27 +693,35 @@ public void testBlobInNestedStructures() {
assertEquals(HoodieSchemaType.BLOB, convertedMap.getValueType().getType());
}
+ private static boolean hasNativeVariantType() {
+try {
+ DataTypeAdapter.createVariantType();
+ return true;
+} catch (UnsupportedOperationException e) {
+ return false;
+}
+ }
+
@Test
@Disabled("disabled and reopen the tests for 1.3")
public void testVariantTypeConversion() {
-// Test direct Variant conversion
Review Comment:
is your code rebased based on latest master, the test should be enabled
already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4436021779 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * 8963a31f08bcb4892ffa313d1a4ad258b8fa2a7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13946) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4435609757 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * af3cac98573d3a144048dc85308fb9c80498992e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13934) * 8963a31f08bcb4892ffa313d1a4ad258b8fa2a7b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13946) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(flink): write/read (only unshredded) variant to Flink parquet file writers/readers using Flink's Variant type [hudi]
hudi-bot commented on PR #18539: URL: https://github.com/apache/hudi/pull/18539#issuecomment-4435575219 ## CI report: * 37f47b6752a0d7663856a8827175c964f9ef1eb4 UNKNOWN * 3b5ecebfd254b954f1eb39f27edb29e9b5ad1eae UNKNOWN * ed834057b5be021fbe01af374b563f853e2f391b UNKNOWN * 84cf72309dc9842750ab3ed0afc5f60d1c6ce400 UNKNOWN * 3e755b1e0d4792a878827fc7662e9d2814cde9dd UNKNOWN * 2d90b811d4b5bcc32e6d5f389a2b85f267ac69a6 UNKNOWN * b8529f2243eeddbd88f81522aef2d7688250d324 UNKNOWN * af3cac98573d3a144048dc85308fb9c80498992e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13934) * 8963a31f08bcb4892ffa313d1a4ad258b8fa2a7b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
