Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
voonhous commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4485726725 SG, let's closing this PR then. Variant is still not very mature now. Committing to something, then flip flopping after will only introduce migration hell in the future. Let's remove support for Lance + Variant support for now and iterate on the Spark path first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
voonhous closed pull request #18599: feat(lance): Add VariantType support to Lance base files URL: https://github.com/apache/hudi/pull/18599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
rahil-c commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4482942178 > > @voonhous @yihua I am thinking we should punt on this PR for now. The rational is that I am not sure if we should dictate how Lance will handle implementing VARIANT support within their file format. Currently this PR's implementation is essentially following the parquet spec, however there is a google doc proposal around the following variant spec in lance: https://docs.google.com/document/d/1aXEoVlRYUMTIQ290Th-sL0kFy0-zwKhe5AKuYzXwjDc/edit?tab=t.0 > > If Lance does not support variant type natively yet, let's add a simple guard to check write schema and fail fast if the schema contains a variant-typed column and the file format is Lance. In such a case, the user-friendly error message is thrown instead of failing at the Arrow conversion layer. I can take this up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
yihua commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4482928060 > @voonhous @yihua I am thinking we should punt on this PR for now. The rational is that I am not sure if we should dictate how Lance will handle implementing VARIANT support within their file format. Currently this PR's implementation is essentially following the parquet spec, however there is a google doc proposal around the following variant spec in lance: https://docs.google.com/document/d/1aXEoVlRYUMTIQ290Th-sL0kFy0-zwKhe5AKuYzXwjDc/edit?tab=t.0 If Lance does not support variant type natively yet, let's add a simple guard to check write schema and fail fast if the schema contains a variant-typed column and the file format is Lance. In such a case, the user-friendly error message is thrown instead of failing at the Arrow conversion layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4482285668 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.08%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 19 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-sp
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
yihua commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4479548021 @rahil-c could you take a first review pass of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4474875506 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.08%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 15 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-sp
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
yihua commented on code in PR #18599:
URL: https://github.com/apache/hudi/pull/18599#discussion_r3251099684
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -399,13 +460,59 @@ protected void updateRecordMetadata(InternalRow row,
row.update(FILENAME_METADATA_FIELD.ordinal(), fileName);
}
- @AllArgsConstructor(staticName = "of")
- private static class SparkArrowWriter implements ArrowWriter {
+ /**
+ * Forwards rows to the lance-spark {@link LanceArrowWriter}. When the schema
+ * has no {@code VariantType} columns, rows are passed through directly.
When it
+ * does, a single {@link VariantProjectedRow} instance is reused per row to
+ * delegate every accessor to the underlying input row except at variant
+ * ordinals, where it returns a pre-allocated {@code (metadata, value)}
struct
+ * populated by {@link
org.apache.spark.sql.hudi.SparkAdapter#createVariantValueWriter}.
Review Comment:
Does this projection introduce overhead? Does Lance library or writer
provide its own projection or adaptation for Variant Type?
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -293,6 +305,54 @@ private static Field rewriteBlobDataChild(Field
blobStructField) {
return new Field(blobStructField.getName(),
blobStructField.getFieldType(), rebuilt);
}
+ /**
+ * Single-pass walk that returns (a) the enriched schema with top-level
+ * {@code VariantType} fields replaced by Hudi's canonical
+ * {@code Struct[metadata: binary, value: binary]} (tagged {@code
hudi_type=VARIANT}
+ * so {@code HoodieSparkSchemaConverters} promotes it back on read), and (b)
the
+ * variant ordinals in ascending order. {@code LanceArrowUtils} has no
VariantType
+ * case, so we hand it a plain struct. Top-level only - nested variants are
not
+ * yet supported.
+ */
+ private static Pair enrichForLanceVariant(StructType
sparkSchema) {
Review Comment:
Could `enrichForLanceVariant` be incorporated into
`enrichSparkSchemaForLance`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456560065 ## CI report: * da560cd5f827ffc69286d102334965501755ad36 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13992) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456498479 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.08%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456481052 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.08%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456470032 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.08%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456427092 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.07%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456429680 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.08%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456424797 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.07%. Comparing base ([`071b3f1`](https://app.codecov.io/gh/apache/hudi/commit/071b3f125b410b3feb8ee90a2ee8073eec67e254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456419966 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.07%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456407039 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.07%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456388134 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.32%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456384606 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.23%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456381626 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.20%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456385747 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.30%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456380562 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.16%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456375620 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.12%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456373849 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.12%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456361959 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.00%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456349996 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.94%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456341858 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.06%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456342575 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.06%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456333258 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.91%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456326727 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.23%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fa
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456321130 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.74%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|15|3| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 48.74% -16.74% + Complexity2355116657 -6894 = Files 2050 1999 -51 Lines117336 112180 -5156 Branches 1526914158 - = - Hits 7682654680-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456325139 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `136 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.96%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456320106 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.66%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|15|2| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 48.66% -16.82% + Complexity2355116639 -6912 = Files 2050 1999 -51 Lines117336 112166 -5170 Branches 1526914156 -1113 = - Hits 7682654583-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456311719 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.60%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|15|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 48.60% -16.87% + Complexity2355116620 -6931 = Files 2050 1999 -51 Lines117336 112166 -5170 Branches 1526914156 -1113 = - Hits 7682654520-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456309082 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.12%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|15|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 49.12% -16.35% + Complexity2355116412 -7139 = Files 2050 1981 -69 Lines117336 109764 -7572 Branches 1526913642 -1627 = - Hits 7682653924-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456308387 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.12%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|14|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 49.12% -16.35% + Complexity2355116412 -7139 = Files 2050 1981 -69 Lines117336 109759 -7577 Branches 1526913636 -1633 = - Hits 7682453918-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456301073 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.77%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|13|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 48.77% -16.70% + Complexity2355116271 -7280 = Files 2050 1981 -69 Lines117336 109745 -7591 Branches 1526913634 -1635 = - Hits 7682353528-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456293555 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.47%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|12|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 45.47% -20.01% + Complexity2355114921 -8630 = Files 2050 1964 -86 Lines117336 107287-10049 Branches 1526913019 -2250 = - Hits 7682348785-2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456292199 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `98 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.93%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (e5afbba) and HEAD (da560cd). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (e5afbba) | HEAD (da560cd) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|12|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 65.47% 53.93% -11.54% + Complexity2355112456-11095 = Files 2050 1435 -615 Lines11733672255-45081 Branches 15269 8257 -7012 = - Hits 7682338973-37850 + Misses3352629786 -3740 + Partials 6987 3496 -3491 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=gi
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456188668 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.02%. Comparing base ([`e5afbba`](https://app.codecov.io/gh/apache/hudi/commit/e5afbba54f3e6162bb1a5ec3865404c342c57b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da560cd`](https://app.codecov.io/gh/apache/hudi/commit/da560cd5f827ffc69286d102334965501755ad36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## - Coverage 46.80% 45.02% -1.78% + Complexity15318 8578-6740 Files 1963 1202 -761 Lines10713262816 -44316 Branches 13057 6811-6246 - Hits 5014328285 -21858 + Misses5174931419 -20330 + Partials 5240 3112-2128 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <ø> (+0.03%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1309 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18599/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-agent commented on code in PR #18599:
URL: https://github.com/apache/hudi/pull/18599#discussion_r3245295431
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -293,6 +305,54 @@ private static Field rewriteBlobDataChild(Field
blobStructField) {
return new Field(blobStructField.getName(),
blobStructField.getFieldType(), rebuilt);
}
+ /**
+ * Single-pass walk that returns (a) the enriched schema with top-level
+ * {@code VariantType} fields replaced by Hudi's canonical
+ * {@code Struct[metadata: binary, value: binary]} (tagged {@code
hudi_type=VARIANT}
+ * so {@code HoodieSparkSchemaConverters} promotes it back on read), and (b)
the
+ * variant ordinals in ascending order. {@code LanceArrowUtils} has no
VariantType
+ * case, so we hand it a plain struct. Top-level only - nested variants are
not
+ * yet supported.
+ */
+ private static Pair enrichForLanceVariant(StructType
sparkSchema) {
+StructField[] fields = sparkSchema.fields();
+StructField[] newFields = null;
+List ordinals = null;
+for (int i = 0; i < fields.length; i++) {
+ StructField field = fields[i];
+ if
(!SparkAdapterSupport$.MODULE$.sparkAdapter().isVariantType(field.dataType())) {
+if (newFields != null) {
+ newFields[i] = field;
+}
+continue;
+ }
+ if (newFields == null) {
+newFields = new StructField[fields.length];
+System.arraycopy(fields, 0, newFields, 0, i);
+ordinals = new ArrayList<>();
+ }
+ ordinals.add(i);
+ StructField metaField = new StructField(
+ HoodieSchema.Variant.VARIANT_METADATA_FIELD, DataTypes.BinaryType,
false, Metadata.empty());
+ StructField valField = new StructField(
+ HoodieSchema.Variant.VARIANT_VALUE_FIELD, DataTypes.BinaryType,
false, Metadata.empty());
+ StructType variantStruct = new StructType(new StructField[] {metaField,
valField});
+ Metadata enriched = new MetadataBuilder()
+ .withMetadata(field.metadata())
+ .putString(HoodieSchema.TYPE_METADATA_FIELD,
HoodieSchemaType.VARIANT.name())
+ .build();
+ newFields[i] = new StructField(field.name(), variantStruct,
field.nullable(), enriched);
+}
+if (newFields == null) {
Review Comment:
🤖 nit: could you replace the manual unboxing loop with
`ordinals.stream().mapToInt(Integer::intValue).toArray()`? It expresses the
intent in one line.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -399,13 +460,59 @@ protected void updateRecordMetadata(InternalRow row,
row.update(FILENAME_METADATA_FIELD.ordinal(), fileName);
}
- @AllArgsConstructor(staticName = "of")
- private static class SparkArrowWriter implements ArrowWriter {
+ /**
+ * Forwards rows to the lance-spark {@link LanceArrowWriter}. When the schema
+ * has no {@code VariantType} columns, rows are passed through directly.
When it
+ * does, a single {@link VariantProjectedRow} instance is reused per row to
+ * delegate every accessor to the underlying input row except at variant
+ * ordinals, where it returns a pre-allocated {@code (metadata, value)}
struct
+ * populated by {@link
org.apache.spark.sql.hudi.SparkAdapter#createVariantValueWriter}.
+ */
+ private static final class SparkArrowWriter implements
ArrowWriter {
private final LanceArrowWriter lanceArrowWriter;
+private final VariantProjectedRow projectedRow;
+
+private SparkArrowWriter(LanceArrowWriter lanceArrowWriter,
VariantProjectedRow projectedRow) {
+ this.lanceArrowWriter = lanceArrowWriter;
+ this.projectedRow = projectedRow;
+}
+
+static SparkArrowWriter of(LanceArrowWriter lanceArrowWriter,
+ StructType inputSchema,
+ int[] variantOrdinals) {
+ if (variantOrdinals.length == 0) {
+return new SparkArrowWriter(lanceArrowWriter, null);
+ }
Review Comment:
🤖 nit: the two-step init (`new ArrayList<>(numFields)` + null-fill loop)
could be collapsed to `new ArrayList<>(Collections.nCopies(numFields, null))`,
which is a bit more declarative about what's happening.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456159912 ## CI report: * 11eb3c755f22f0001a1263d33f4c5a2306846710 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13901) * da560cd5f827ffc69286d102334965501755ad36 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13992) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4456142852 ## CI report: * 11eb3c755f22f0001a1263d33f4c5a2306846710 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13901) * da560cd5f827ffc69286d102334965501755ad36 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4410947724 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4409205829 ## CI report: * 11eb3c755f22f0001a1263d33f4c5a2306846710 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13901) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4409148768 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4409146476 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4409112602 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4409077376 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4409076184 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408959574 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.22%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408956193 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.08%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408932424 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.44%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408929183 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.85%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408939910 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.83%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408933783 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.44%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408927347 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.82%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408921005 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.79%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408915732 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.75%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408912945 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.75%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408905845 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `136 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.47%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.sc
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408897070 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `136 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.93%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.sc
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408894011 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `136 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.92%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.sc
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408893047 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.39%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (11eb3c7). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (11eb3c7) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 68.14% 46.39% -21.76% + Complexity2907715514-13563 = Files 2522 1982 -540 Lines141177 109722-31455 Branches 1751413631 -3883 = - Hits 9620850903-45305 - Misses
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408884056 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.77%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (11eb3c7). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (11eb3c7) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 68.14% 46.77% -21.38% + Complexity2907715305-13772 = Files 2522 1964 -558 Lines141177 107188-33989 Branches 1751413061 -4453 = - Hits 9620850138-46070 - Misses
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-agent commented on code in PR #18599:
URL: https://github.com/apache/hudi/pull/18599#discussion_r3210593217
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -293,6 +305,54 @@ private static Field rewriteBlobDataChild(Field
blobStructField) {
return new Field(blobStructField.getName(),
blobStructField.getFieldType(), rebuilt);
}
+ /**
+ * Single-pass walk that returns (a) the enriched schema with top-level
+ * {@code VariantType} fields replaced by Hudi's canonical
+ * {@code Struct[metadata: binary, value: binary]} (tagged {@code
hudi_type=VARIANT}
+ * so {@code HoodieSparkSchemaConverters} promotes it back on read), and (b)
the
+ * variant ordinals in ascending order. {@code LanceArrowUtils} has no
VariantType
+ * case, so we hand it a plain struct. Top-level only - nested variants are
not
+ * yet supported.
+ */
+ private static Pair enrichForLanceVariant(StructType
sparkSchema) {
+StructField[] fields = sparkSchema.fields();
+StructField[] newFields = null;
+List ordinals = null;
+for (int i = 0; i < fields.length; i++) {
+ StructField field = fields[i];
+ if
(!SparkAdapterSupport$.MODULE$.sparkAdapter().isVariantType(field.dataType())) {
+if (newFields != null) {
+ newFields[i] = field;
+}
+continue;
+ }
+ if (newFields == null) {
+newFields = new StructField[fields.length];
+System.arraycopy(fields, 0, newFields, 0, i);
+ordinals = new ArrayList<>();
+ }
+ ordinals.add(i);
+ StructField metaField = new StructField(
+ HoodieSchema.Variant.VARIANT_METADATA_FIELD, DataTypes.BinaryType,
false, Metadata.empty());
+ StructField valField = new StructField(
+ HoodieSchema.Variant.VARIANT_VALUE_FIELD, DataTypes.BinaryType,
false, Metadata.empty());
+ StructType variantStruct = new StructType(new StructField[] {metaField,
valField});
+ Metadata enriched = new MetadataBuilder()
+ .withMetadata(field.metadata())
+ .putString(HoodieSchema.TYPE_METADATA_FIELD,
HoodieSchemaType.VARIANT.name())
+ .build();
+ newFields[i] = new StructField(field.name(), variantStruct,
field.nullable(), enriched);
+}
+if (newFields == null) {
+ return Pair.of(sparkSchema, EMPTY_INT_ARRAY);
+}
+int[] ordinalArr = new int[ordinals.size()];
+for (int i = 0; i < ordinalArr.length; i++) {
Review Comment:
🤖 nit: could you simplify this to
`ordinals.stream().mapToInt(Integer::intValue).toArray()`? The three-line loop
is a bit ceremonial for what's really just a List→int[] conversion.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala:
##
@@ -437,6 +438,29 @@ trait SparkAdapter extends Serializable {
writeMetadata: Consumer[Array[Byte]]
): BiConsumer[SpecializedGetters, Integer]
+ /**
+ * Creates a [[VariantProjectedRow]] for the Lance writer's variant
projection.
+ * Spark 3.x throws (no VariantType support); Spark 4.x returns a row that
delegates
+ * accessors to the wrapped input row, except at the configured variant
ordinals where
+ * it returns the pre-allocated {@code (metadata, value)} struct populated
by the
+ * matching extractor.
+ *
+ * Kept on the adapter so the shared {@code hudi-spark-client} module never
needs to
+ * reference Spark-4-only types like {@code VariantVal} / {@code
InternalRow.getVariant}.
+ *
+ * @param numFieldstotal number of top-level fields in the
projection
+ * @param variantStructByOrdinal non-null only at variant ordinals;
pre-allocated
+ * {@code GenericInternalRow(new Object[2])}
+ * @param extractorByOrdinal non-null only at variant ordinals;
populates the
+ * corresponding entry in {@code
variantStructByOrdinal}
+ * @return a stateful [[VariantProjectedRow]] (Spark 4 only)
+ */
+ def createVariantProjectedRow(
+numFields: Int,
+variantStructByOrdinal: Array[GenericInternalRow],
+extractorByOrdinal: java.util.List[BiConsumer[SpecializedGetters,
java.lang.Integer]]
Review Comment:
🤖 nit: `variantStructByOrdinal` is an `Array` (random-access by ordinal) but
`extractorByOrdinal` is a `java.util.List` — both are indexed 0..numFields-1
and non-null only at variant positions. Could you make them the same type?
Using `Array` for both would let callers use consistent `[]` access, and would
also eliminate the null-fill loop in `SparkArrowWriter.of` (an array of
reference type is already null-initialized).
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408872405 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `98 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.96%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (11eb3c7). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (11eb3c7) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 68.14% 53.96% -14.19% + Complexity2907712454-16623 = Files 2522 1435 -1087 Lines14117772227-68950 Branches 17514 8250 -9264 = - Hits 9620838974-57234 + Misses3706129754 -7307 + Partials 7908 3499 -4409 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408747148 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.00%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`11eb3c7`](https://app.codecov.io/gh/apache/hudi/commit/11eb3c755f22f0001a1263d33f4c5a2306846710?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (11eb3c7). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (11eb3c7) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 68.14% 45.00% -23.15% + Complexity29077 8568-20509 = Files 2522 1202 -1320 Lines14117762804-78373 Branches 17514 6809-10705 = - Hits 9620828265-67943 + Misses3706131422 -5639 + Partials 7908 3117 -4791 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2120 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18599/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408694816 ## CI report: * e36ac9d0633a3a84fd906e717de17f2df25bea0b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13664) * 11eb3c755f22f0001a1263d33f4c5a2306846710 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13901) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4408672499 ## CI report: * e36ac9d0633a3a84fd906e717de17f2df25bea0b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13664) * 11eb3c755f22f0001a1263d33f4c5a2306846710 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
voonhous commented on code in PR #18599:
URL: https://github.com/apache/hudi/pull/18599#discussion_r3162856646
##
hudi-spark-datasource/hudi-spark4.1.x/src/main/java/org/apache/hudi/io/storage/Spark41VariantProjectedRow.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io.storage;
+
+import org.apache.spark.sql.catalyst.expressions.GenericInternalRow;
+import org.apache.spark.sql.catalyst.expressions.SpecializedGetters;
+import org.apache.spark.unsafe.types.GeographyVal;
+import org.apache.spark.unsafe.types.GeometryVal;
+
+import java.util.List;
+import java.util.function.BiConsumer;
+
+public final class Spark41VariantProjectedRow extends
Spark4VariantProjectedRow {
+
+ public Spark41VariantProjectedRow(int numFields,
+GenericInternalRow[]
variantStructByOrdinal,
Review Comment:
Yes. `getGeometry`/`getGeography` are not available in Spark4.0. The API
delta is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4331476221 ## CI report: * e36ac9d0633a3a84fd906e717de17f2df25bea0b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13664) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-agent commented on code in PR #18599:
URL: https://github.com/apache/hudi/pull/18599#discussion_r3150020640
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -278,6 +290,54 @@ private static Field rewriteBlobDataChild(Field
blobStructField) {
return new Field(blobStructField.getName(),
blobStructField.getFieldType(), rebuilt);
}
+ /**
+ * Single-pass walk that returns (a) the enriched schema with top-level
+ * {@code VariantType} fields replaced by Hudi's canonical
+ * {@code Struct[metadata: binary, value: binary]} (tagged {@code
hudi_type=VARIANT}
+ * so {@code HoodieSparkSchemaConverters} promotes it back on read), and (b)
the
+ * variant ordinals in ascending order. {@code LanceArrowUtils} has no
VariantType
+ * case, so we hand it a plain struct. Top-level only - nested variants are
not
+ * yet supported.
+ */
+ private static Pair enrichForLanceVariant(StructType
sparkSchema) {
+StructField[] fields = sparkSchema.fields();
+StructField[] newFields = null;
+List ordinals = null;
+for (int i = 0; i < fields.length; i++) {
+ StructField field = fields[i];
+ if
(!SparkAdapterSupport$.MODULE$.sparkAdapter().isVariantType(field.dataType())) {
+if (newFields != null) {
+ newFields[i] = field;
+}
+continue;
+ }
+ if (newFields == null) {
+newFields = new StructField[fields.length];
+System.arraycopy(fields, 0, newFields, 0, i);
+ordinals = new ArrayList<>();
+ }
+ ordinals.add(i);
+ StructField metaField = new StructField(
+ HoodieSchema.Variant.VARIANT_METADATA_FIELD, DataTypes.BinaryType,
false, Metadata.empty());
+ StructField valField = new StructField(
+ HoodieSchema.Variant.VARIANT_VALUE_FIELD, DataTypes.BinaryType,
false, Metadata.empty());
+ StructType variantStruct = new StructType(new StructField[] {metaField,
valField});
+ Metadata enriched = new MetadataBuilder()
+ .withMetadata(field.metadata())
+ .putString(HoodieSchema.TYPE_METADATA_FIELD,
HoodieSchemaType.VARIANT.name())
+ .build();
+ newFields[i] = new StructField(field.name(), variantStruct,
field.nullable(), enriched);
+}
+if (newFields == null) {
Review Comment:
🤖 nit: could you replace this manual unboxing loop with
`ordinals.stream().mapToInt(Integer::intValue).toArray()`? It's a bit more
idiomatic Java and saves a few lines.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -384,13 +445,59 @@ protected void updateRecordMetadata(InternalRow row,
row.update(FILENAME_METADATA_FIELD.ordinal(), fileName);
}
- @AllArgsConstructor(staticName = "of")
- private static class SparkArrowWriter implements ArrowWriter {
+ /**
+ * Forwards rows to the lance-spark {@link LanceArrowWriter}. When the schema
+ * has no {@code VariantType} columns, rows are passed through directly.
When it
+ * does, a single {@link VariantProjectedRow} instance is reused per row to
+ * delegate every accessor to the underlying input row except at variant
+ * ordinals, where it returns a pre-allocated {@code (metadata, value)}
struct
+ * populated by {@link
org.apache.spark.sql.hudi.SparkAdapter#createVariantValueWriter}.
+ */
+ private static final class SparkArrowWriter implements
ArrowWriter {
private final LanceArrowWriter lanceArrowWriter;
+private final VariantProjectedRow projectedRow;
+
+private SparkArrowWriter(LanceArrowWriter lanceArrowWriter,
VariantProjectedRow projectedRow) {
+ this.lanceArrowWriter = lanceArrowWriter;
+ this.projectedRow = projectedRow;
+}
+
+static SparkArrowWriter of(LanceArrowWriter lanceArrowWriter,
+ StructType inputSchema,
+ int[] variantOrdinals) {
+ if (variantOrdinals.length == 0) {
+return new SparkArrowWriter(lanceArrowWriter, null);
+ }
Review Comment:
🤖 nit: the `add(null)` loop could be replaced with `new
ArrayList<>(Collections.nCopies(numFields, null))` — same effect, more
expressive intent.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4330260912 ## CI report: * 93b69a3e014046b9a9f8206a2edd7445105edec6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13649) * e36ac9d0633a3a84fd906e717de17f2df25bea0b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13664) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4330242382 ## CI report: * 93b69a3e014046b9a9f8206a2edd7445105edec6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13649) * e36ac9d0633a3a84fd906e717de17f2df25bea0b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-agent commented on code in PR #18599:
URL: https://github.com/apache/hudi/pull/18599#discussion_r3148427115
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkLanceWriter.java:
##
@@ -142,7 +151,10 @@ private HoodieSparkLanceWriter(StoragePath file,
Option bloomFilterOpt,
long maxFileSize) {
super(file, DEFAULT_BATCH_SIZE,
bloomFilterOpt.map(HoodieBloomFilterRowWriteSupport::new));
-this.sparkSchema = enrichSparkSchemaForLance(sparkSchema);
+this.inputSparkSchema = sparkSchema;
+Pair variantPlan = enrichForLanceVariant(sparkSchema);
Review Comment:
🤖 nit: `variantPlan` reads like a query/execution plan, which isn't quite
what this is — it's just the result of schema enrichment (a transformed schema
+ ordinal list). Could you rename it to something like `variantEnriched` or
`schemaAndOrdinals` to make the content clearer at a glance?
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-spark-datasource/hudi-spark4-common/src/main/java/org/apache/hudi/io/storage/Spark4VariantProjectedRow.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io.storage;
+
+import org.apache.spark.sql.catalyst.InternalRow;
+import org.apache.spark.sql.catalyst.expressions.GenericInternalRow;
+import org.apache.spark.sql.catalyst.expressions.SpecializedGetters;
+import org.apache.spark.sql.catalyst.util.ArrayData;
+import org.apache.spark.sql.catalyst.util.MapData;
+import org.apache.spark.sql.types.DataType;
+import org.apache.spark.sql.types.Decimal;
+import org.apache.spark.unsafe.types.CalendarInterval;
+import org.apache.spark.unsafe.types.UTF8String;
+import org.apache.spark.unsafe.types.VariantVal;
+
+import java.util.List;
+import java.util.function.BiConsumer;
+
+/**
+ * Spark 4 implementation of {@link VariantProjectedRow}. Pass-through
+ * {@link InternalRow} that delegates every accessor to the wrapped input row
+ * except at variant ordinals, where it returns a pre-allocated
+ * {@code (metadata, value)} {@link GenericInternalRow} that the extractor
+ * populates on demand.
+ *
+ * Single-row, single-threaded; {@link #wrap(InternalRow)} mutates state.
+ * {@link #copy()} / {@link #update(int, Object)} / {@link #setNullAt(int)}
+ * throw - lance-spark consumes each row synchronously inside
+ * {@code LanceArrowWriter.write(InternalRow)}, so no copy is ever needed.
+ */
+public abstract class Spark4VariantProjectedRow extends InternalRow implements
VariantProjectedRow {
+
+ private final int numFields;
+ private final GenericInternalRow[] variantStructByOrdinal;
+ private final List>
extractorByOrdinal;
+ protected InternalRow input;
+
+ public Spark4VariantProjectedRow(int numFields,
+ GenericInternalRow[] variantStructByOrdinal,
+ List> extractorByOrdinal) {
+this.numFields = numFields;
+this.variantStructByOrdinal = variantStructByOrdinal;
+this.extractorByOrdinal = extractorByOrdinal;
+ }
+
+ @Override
+ public InternalRow wrap(InternalRow input) {
+this.input = input;
+return this;
+ }
+
+ @Override
+ public int numFields() {
+return numFields;
+ }
+
+ @Override
+ public boolean isNullAt(int ordinal) {
+return input.isNullAt(ordinal);
+ }
+
+ @Override
+ public InternalRow getStruct(int ordinal, int n) {
+GenericInternalRow variantStruct = variantStructByOrdinal[ordinal];
+if (variantStruct != null) {
+ // Populate metadata (slot 0) and value (slot 1) via the captured
lambdas.
+ extractorByOrdinal.get(ordinal).accept(input, ordinal);
+ return variantStruct;
+}
+return input.getStruct(ordinal, n);
+ }
+
+ @Override
+ public boolean getBoolean(int ordinal) {
+return input.getBoolean(ordinal);
+ }
+
+ @Override
+ public byte getByte(int ordinal) {
+return input.getByte(ordinal);
+ }
+
+ @Override
+ public short getShort(int ordinal) {
+return input.getShort(ordinal);
+ }
+
+ @Override
+ public int getInt(int ordinal) {
+return input.getIn
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
hudi-bot commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327968803 ## CI report: * 93b69a3e014046b9a9f8206a2edd7445105edec6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13649) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327803307 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.04%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327791668 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.04%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-432886 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.04%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327701465 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.03%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327682655 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.03%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327669214 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.28%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327660072 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.28%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327643867 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.18%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327636463 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.14%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327622069 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `15.82734%` with `117 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.93%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 32.78% | [36 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 20.00% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327616212 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.18%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327611395 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.14%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327608988 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.14%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327606127 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.09%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327595507 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.02%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327558144 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 64.95%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327548473 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 64.70%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327532230 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `139 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.67%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark41VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.1.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark41VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjEueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDFWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327525990 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `134 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.36%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjAueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDBWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.sc
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327515502 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 59.94%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (7ae0fd9) and HEAD (93b69a3). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (7ae0fd9) | HEAD (93b69a3) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|1| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## - Coverage 68.10% 59.94% -8.17% + Complexity2886424032-4832 Files 2513 2446 -67 Lines139909 132482-7427 Branches 1731915720-1599 - Hits 9529179413 -15878 - Misses3678546356+9571 + Part
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327524628 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `134 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.36%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/io/storage/Spark4VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark4VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNFZhcmlhbnRQcm9qZWN0ZWRSb3cuamF2YQ==) | 0.00% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/io/storage/Spark40VariantProjectedRow.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark4.0.x%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FSpark40VariantProjectedRow.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcms0LjAueC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9pby9zdG9yYWdlL1NwYXJrNDBWYXJpYW50UHJvamVjdGVkUm93LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.sc
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327499553 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.89%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (7ae0fd9) and HEAD (93b69a3). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (7ae0fd9) | HEAD (93b69a3) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 68.10% 46.89% -21.22% + Complexity2886415209-13655 = Files 2513 1957 -556 Lines139909 106480-33429 Branches 1731912994 -4325 = - Hits 9529149933-45358 - Misses
Re: [PR] feat(lance): Add VariantType support to Lance base files [hudi]
codecov-commenter commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4327497897 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.89%. Comparing base ([`7ae0fd9`](https://app.codecov.io/gh/apache/hudi/commit/7ae0fd95b3a6d93ab6d1d6886392f0e43ca055f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93b69a3`](https://app.codecov.io/gh/apache/hudi/commit/93b69a3e014046b9a9f8206a2edd7445105edec6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18599?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/hudi/io/storage/HoodieSparkLanceWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FHoodieSparkLanceWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9Ib29kaWVTcGFya0xhbmNlV3JpdGVyLmphdmE=) | 0.00% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ache/hudi/io/storage/LanceVariantColumnVector.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceVariantColumnVector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVZhcmlhbnRDb2x1bW5WZWN0b3IuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/io/storage/LanceRecordIterator.java](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2FLanceRecordIterator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9MYW5jZVJlY29yZEl0ZXJhdG9yLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/spark/sql/adapter/BaseSpark3Adapter.scala](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark3-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fadapter%2FBaseSpark3Adapter.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmszLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3NwYXJrL3NxbC9hZGFwdGVyL0Jhc2VTcGFyazNBZGFwdGVyLnNjYWxh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (7ae0fd9) and HEAD (93b69a3). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (7ae0fd9) | HEAD (93b69a3) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18599 +/- ## = - Coverage 68.10% 46.89% -21.22% + Complexity2886415209-13655 = Files 2513 1957 -556 Lines139909 106480-33429 Branches 1731912994 -4325 = - Hits 9529149933-45358 - Misses
