Re: [PR] feat: add variant type adapter for Flink [hudi]
voonhous merged PR #18702: URL: https://github.com/apache/hudi/pull/18702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-bot commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411738245 ## CI report: * b8a86a149296d981206b2827f77fc47d0f33f536 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13906) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411723137 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411707169 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411702448 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.13%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411671746 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411669502 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411667144 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411666291 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.12%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411664442 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.37%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411663798 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.34%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411663003 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.30%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411660034 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.24%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411657669 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.24%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411655366 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.11%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411652591 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.43%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411649890 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.39%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411644325 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.26%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411638967 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.12%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411635271 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.87%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411630755 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.87%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411628700 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.42%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411625902 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.85%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 47.85% -20.30% + Complexity2907717118-11959 = Files 2522 2049 -473 Lines141177 117169-24008 Branches 1751415237 -2277 = - Hits 9620856069-40139 - Misses3706154915+17854 + Partials 7908 6185 -1723 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.34% <ΓΈ> (-16.66%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ΓΈ> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411621946 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.82%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 47.82% -20.33% + Complexity2907717108-11969 = Files 2522 2049 -473 Lines141177 117169-24008 Branches 1751415237 -2277 = - Hits 9620856036-40172 - Misses3706154944+17883 + Partials 7908 6189 -1719 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.71% <ΓΈ> (-16.29%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ΓΈ> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411620094 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.73%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 48.73% -19.41% + Complexity2907716616-12461 = Files 2522 1998 -524 Lines141177 112004-29173 Branches 1751414135 -3379 = - Hits 9620854588-41620 - Misses3706151626+14565 + Partials 7908 5790 -2118 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <ΓΈ> (-11.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1594 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411621141 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.78%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|6| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 47.78% -20.37% + Complexity2907717092-11985 = Files 2522 2049 -473 Lines141177 117169-24008 Branches 1751415237 -2277 = - Hits 9620855991-40217 - Misses3706154981+17920 + Partials 7908 6197 -1711 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.73% <ΓΈ> (-12.18%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411620677 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.30%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 48.30% -19.84% + Complexity2907716876-12201 = Files 2522 2028 -494 Lines141177 114646-26531 Branches 1751414696 -2818 = - Hits 9620855383-40825 - Misses3706153254+16193 + Partials 7908 6009 -1899 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <ΓΈ> (-11.99%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1578 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411618507 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.73%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 48.73% -19.42% + Complexity2907716616-12461 = Files 2522 1998 -524 Lines141177 111999-29178 Branches 1751414129 -3385 = - Hits 9620854582-41626 - Misses3706151624+14563 + Partials 7908 5793 -2115 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <ΓΈ> (-11.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1596 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411616103 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 49.70%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 49.70% -18.44% + Complexity2907716201-12876 = Files 2522 1963 -559 Lines141177 107093-34084 Branches 1751413049 -4465 = - Hits 9620853235-42973 - Misses3706148411+11350 + Partials 7908 5447 -2461 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <ΓΈ> (-11.71%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1640 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411612567 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.64%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 31 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 45.64% -22.50% + Complexity2907714929-14148 = Files 2522 1963 -559 Lines141177 107093-34084 Branches 1751413049 -4465 = - Hits 9620848887-47321 - Misses3706153194+16133 + Partials 7908 5012 -2896 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.35% <ΓΈ> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1718 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411605854 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 39.14%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 32 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 39.14% -29.01% + Complexity2907712414-16663 = Files 2522 1963 -559 Lines141177 107073-34104 Branches 1751413028 -4486 = - Hits 9620841914-54294 - Misses3706160202+23141 + Partials 7908 4957 -2951 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ΓΈ> (-15.90%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1928 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411565681 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.99%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8a86a1`](https://app.codecov.io/gh/apache/hudi/commit/b8a86a149296d981206b2827f77fc47d0f33f536?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (b8a86a1). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (b8a86a1) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 44.99% -23.16% + Complexity29077 8566-20511 = Files 2522 1202 -1320 Lines14117762804-78373 Branches 17514 6809-10705 = - Hits 9620828259-67949 + Misses3706131428 -5633 + Partials 7908 3117 -4791 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <ΓΈ> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2120 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-bot commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411548332 ## CI report: * 969a4dab62f8a1e6c4385001c17174d1e165ed74 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13896) * b8a86a149296d981206b2827f77fc47d0f33f536 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13906) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-bot commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4411538826 ## CI report: * 969a4dab62f8a1e6c4385001c17174d1e165ed74 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13896) * b8a86a149296d981206b2827f77fc47d0f33f536 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
danny0405 commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3212447168
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##
@@ -190,6 +201,38 @@ public static MessageType
convertToParquetMessageType(String name, RowType rowTy
return new MessageType(name, types);
}
+ /**
+ * Checks whether the group carries the Parquet {@code VARIANT} logical type
annotation.
+ * Uses class-name matching so this compiles against parquet-java versions
that predate the
+ * {@code VariantLogicalTypeAnnotation} class (< 1.15.2).
+ */
+ private static boolean hasVariantAnnotation(LogicalTypeAnnotation
logicalType) {
Review Comment:
yeah, add a TODO to add variant on writer side first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
kbuci commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3211752597
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##
@@ -190,6 +201,38 @@ public static MessageType
convertToParquetMessageType(String name, RowType rowTy
return new MessageType(name, types);
}
+ /**
+ * Checks whether the group carries the Parquet {@code VARIANT} logical type
annotation.
+ * Uses class-name matching so this compiles against parquet-java versions
that predate the
+ * {@code VariantLogicalTypeAnnotation} class (< 1.15.2).
+ */
+ private static boolean hasVariantAnnotation(LogicalTypeAnnotation
logicalType) {
Review Comment:
Yeah based on my understanding, in order to make sure a Flink-written
variant field (or any variant field written without the parquet variant
annotation β which is all current Hudi writes since the code has a TODO to add
it like you pointed out) is re-read as variant in Flink, we would need a
subsequent PR like #18539 that add HoodieSchema for detection or we need to
actually attach the annotation at write time.
Maybe we can add a TODO comment here, just so that readers know this state
of Flink variant integration (in case for some reason we don't fully "fix" this
by 1.3)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
cshuo commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3207392174
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/HoodieSchemaConverter.java:
##
@@ -553,23 +558,25 @@ private static DataType convertUnion(HoodieSchema schema)
{
}
/**
- * Converts a Variant schema to Flink's ROW type.
- * Variant is represented as ROW<`metadata` BYTES, `value` BYTES> in Flink.
+ * Converts a Variant HoodieSchema to the native Flink {@code VariantType}
DataType.
+ * Requires Flink 2.1+ at runtime; throws {@link
UnsupportedOperationException} on older versions.
*
* @param schema HoodieSchema to convert (must be a VARIANT type)
- * @return DataType representing the Variant as a ROW with binary fields
+ * @return native VariantType DataType
+ * @throws UnsupportedOperationException if Flink runtime is pre-2.1 or
variant is shredded
*/
private static DataType convertVariant(HoodieSchema schema) {
if (schema.getType() != HoodieSchemaType.VARIANT) {
throw new IllegalStateException("Expected HoodieSchema.Variant but got:
" + schema.getClass());
}
-// Variant is stored as a struct with two binary fields: metadata and
value.
-// Field order follows the Parquet spec and Iceberg convention (metadata
first, value second).
-return DataTypes.ROW(
-DataTypes.FIELD("metadata", DataTypes.BYTES().notNull()),
-DataTypes.FIELD("value", DataTypes.BYTES().notNull())
-).notNull();
+if (schema instanceof HoodieSchema.Variant
Review Comment:
can be removed, since line 569 ensures the type is VARIANT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
cshuo commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3207366760
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##
@@ -190,6 +201,38 @@ public static MessageType
convertToParquetMessageType(String name, RowType rowTy
return new MessageType(name, types);
}
+ /**
+ * Checks whether the group carries the Parquet {@code VARIANT} logical type
annotation.
+ * Uses class-name matching so this compiles against parquet-java versions
that predate the
+ * {@code VariantLogicalTypeAnnotation} class (< 1.15.2).
+ */
+ private static boolean hasVariantAnnotation(LogicalTypeAnnotation
logicalType) {
Review Comment:
https://github.com/apache/hudi/blob/47bf4e41342e4f1dab26a7fb1489f278fbd1226c/hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetReadSupport.scala#L113-L120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
cshuo commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3207198632
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:
##
@@ -190,6 +201,38 @@ public static MessageType
convertToParquetMessageType(String name, RowType rowTy
return new MessageType(name, types);
}
+ /**
+ * Checks whether the group carries the Parquet {@code VARIANT} logical type
annotation.
+ * Uses class-name matching so this compiles against parquet-java versions
that predate the
+ * {@code VariantLogicalTypeAnnotation} class (< 1.15.2).
+ */
+ private static boolean hasVariantAnnotation(LogicalTypeAnnotation
logicalType) {
Review Comment:
Since the writer does not attach the variant logical annotation (todo in
line 227), a Flink-written variant column will read back as a plain row and
HoodieSchemaConverter.convertToSchema() will lose the VARIANT type?
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java:
##
@@ -212,6 +217,25 @@ private static AvroToRowDataConverter
createMapConverter(LogicalType type, boole
};
}
+ /**
+ * Creates a converter for Flink 2.1+ VARIANT LogicalType. The converter
receives an Avro
+ * GenericRecord carrying metadata/value binary fields and produces a Flink
+ * {@code BinaryVariant}.
+ */
+ private static AvroToRowDataConverter createVariantConverter() {
+return avroObject -> {
+ IndexedRecord record = (IndexedRecord) avroObject;
+ byte[] metadata = convertToBytes(record.get(0));
+ byte[] value = convertToBytes(record.get(1));
+
+ try {
+return DataTypeAdapter.createVariant(value, metadata);
+ } catch (Exception e) {
+throw new RuntimeException("Failed to create Flink BinaryVariant via
reflection.", e);
Review Comment:
This is a direct constructor call, not reflection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404781609 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.37%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404754612 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.37%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404724369 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.37%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404674088 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.36%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404646359 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.36%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404628361 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.36%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404626444 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.32%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404624218 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.29%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404621883 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.25%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404612691 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.22%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404609836 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.18%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404606362 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.10%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404600470 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.06%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404578685 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.24%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404590437 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.28%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404537634 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 50.82%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404529741 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.59%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404527965 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.57%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404512776 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.54%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404515488 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.57%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404505064 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.51%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404499878 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.84%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404495028 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.42%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404487599 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.42%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404490781 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.42%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-bot commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404465132 ## CI report: * 969a4dab62f8a1e6c4385001c17174d1e165ed74 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13896) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404315106 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `42 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 32.53%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...io/storage/row/parquet/ParquetSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2Fstorage%2Frow%2Fparquet%2FParquetSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW8vc3RvcmFnZS9yb3cvcGFycXVldC9QYXJxdWV0U2NoZW1hQ29udmVydGVyLmphdmE=) | 0.00% | [14 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/AvroToRowDataConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FAvroToRowDataConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9BdnJvVG9Sb3dEYXRhQ29udmVydGVycy5qYXZh) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/hudi/util/RowDataToAvroConverters.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FRowDataToAvroConverters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Sb3dEYXRhVG9BdnJvQ29udmVydGVycy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/hudi/util/HoodieSchemaConverter.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FHoodieSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Ib29kaWVTY2hlbWFDb252ZXJ0ZXIuamF2YQ==) | 0.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/client/model/AbstractHoodieRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FAbstractHoodieRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L21vZGVsL0Fic3RyYWN0SG9vZGllUm93RGF0YS5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/hudi/client/model/BootstrapRowData.java](https://app.codecov.io/gh/apache/hudi/pull/18702?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fmodel%2FBootstrapRowData.java&utm_medium=referral&utm_source=github&utm_content=comment&u
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-agent commented on code in PR #18702:
URL: https://github.com/apache/hudi/pull/18702#discussion_r3206893208
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java:
##
@@ -212,6 +217,25 @@ private static AvroToRowDataConverter
createMapConverter(LogicalType type, boole
};
}
+ /**
+ * Creates a converter for Flink 2.1+ VARIANT LogicalType. The converter
receives an Avro
+ * GenericRecord carrying metadata/value binary fields and produces a Flink
+ * {@code BinaryVariant}.
+ */
+ private static AvroToRowDataConverter createVariantConverter() {
Review Comment:
π€ nit: `record.get(0)` and `record.get(1)` are opaque β could you cast to
`GenericRecord` and use `HoodieSchema.Variant.VARIANT_METADATA_FIELD` /
`VARIANT_VALUE_FIELD` for named access? The same constants are already used in
`ParquetSchemaConverter` in this PR.
- AI-generated; verify before applying. React π/π to flag
quality.
##
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/RowDataToAvroConverters.java:
##
@@ -357,5 +362,28 @@ public Object convert(HoodieSchema schema, Object object) {
}
};
}
+
+ /**
+ * Creates a converter for Flink 2.1+ VARIANT LogicalType. The converter
receives a Flink
+ * {@code Variant} object at runtime and extracts the raw metadata/value
byte arrays,
+ * then packs them into an Avro GenericRecord with the Variant schema.
+ *
+ * No shredded-variant check is needed here: {@code
HoodieSchemaConverter.convertVariant()}
+ * already rejects shredded variants before a Flink type or converter is
ever constructed,
+ * and Flink 2.1 itself only supports unshredded variants (FLIP-521).
+ */
+ private static RowDataToAvroConverter createVariantConverter() {
+return new RowDataToAvroConverter() {
+ private static final long serialVersionUID = 1L;
+
+ @Override
Review Comment:
π€ nit: the string literals `"metadata"` and `"value"` here could use
`HoodieSchema.Variant.VARIANT_METADATA_FIELD` / `VARIANT_VALUE_FIELD` to stay
consistent with how `ParquetSchemaConverter` references the same fields in this
PR.
- AI-generated; verify before applying. React π/π to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
codecov-commenter commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404249942 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.01%. Comparing base ([`47bf4e4`](https://app.codecov.io/gh/apache/hudi/commit/47bf4e41342e4f1dab26a7fb1489f278fbd1226c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`969a4da`](https://app.codecov.io/gh/apache/hudi/commit/969a4dab62f8a1e6c4385001c17174d1e165ed74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (47bf4e4) and HEAD (969a4da). Click for more details. > > HEAD has 33 uploads less than BASE > >| Flag | BASE (47bf4e4) | HEAD (969a4da) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|12|0| >|spark-java-tests|18|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18702 +/- ## = - Coverage 68.14% 45.01% -23.14% + Complexity29077 8572-20505 = Files 2522 1202 -1320 Lines14117762804-78373 Branches 17514 6809-10705 = - Hits 9620828271-67937 + Misses3706131420 -5641 + Partials 7908 3113 -4795 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <ΓΈ> (+<0.01%)` | :arrow_up: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18702/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2118 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18702/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-bot commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404193409 ## CI report: * 969a4dab62f8a1e6c4385001c17174d1e165ed74 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13896) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat: add variant type adapter for Flink [hudi]
hudi-bot commented on PR #18702: URL: https://github.com/apache/hudi/pull/18702#issuecomment-4404167773 ## CI report: * 969a4dab62f8a1e6c4385001c17174d1e165ed74 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
