Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
danny0405 merged PR #18477: URL: https://github.com/apache/hudi/pull/18477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211529034 ## CI report: * a5595510880c53fa1f426e817131ad0cc05e5c31 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13166) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211507918 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211499075 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211462301 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211461355 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211452580 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.71%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211447988 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.69%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211440812 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.89%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211439922 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.89%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211432118 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211428241 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.04%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211416779 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.89%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files `
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211405109 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.1%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.31%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.71% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 86.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pact/handler/DataTableCompactionCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvbkNvbW1pdEhhbmRsZXIuamF2YQ==) | 72.72% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports up
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211400563 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.36%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 54.36% -14.42% + Complexity2811718413 -9704 = Files 2452 2004 -448 Lines135033 112143-22890 Branches 1637614240 -2136 = - Hits 9286960965-31904 - Misses3480144907+10106 + Partials 7363 6271 -1092 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.36% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <ø> (-12.96%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1384 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211398074 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.04%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.04% -20.73% + Complexity2811716456-11661 = Files 2452 2004 -448 Lines135033 112143-22890 Branches 1637614240 -2136 = - Hits 9286953881-38988 - Misses3480152616+17815 + Partials 7363 5646 -1717 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.36% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <ø> (-12.96%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211393785 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.01%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.01% -20.76% + Complexity2811716446-11671 = Files 2452 2004 -448 Lines135033 112143-22890 Branches 1637614240 -2136 = - Hits 9286953848-39021 - Misses3480152645+17844 + Partials 7363 5650 -1713 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <ø> (-16.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <ø> (-12.96%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211392327 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.01%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.01% -20.76% + Complexity2811716446-11671 = Files 2452 2004 -448 Lines135033 112143-22890 Branches 1637614240 -2136 = - Hits 9286953848-39021 - Misses3480152645+17844 + Partials 7363 5650 -1713 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <ø> (-16.09%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <ø> (-12.96%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211388432 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.94%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 47.94% -20.84% + Complexity2811716422-11695 = Files 2452 2004 -448 Lines135033 112143-22890 Branches 1637614240 -2136 = - Hits 9286953766-39103 - Misses3480152713+17912 + Partials 7363 5664 -1699 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.56% <ø> (-15.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <ø> (-12.96%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1521 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211386830 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.61%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 45.61% -23.16% + Complexity2811715299-12818 = Files 2452 1975 -477 Lines135033 109526-25507 Branches 1637613684 -2692 = - Hits 9286949961-42908 - Misses3480154284+19483 + Partials 7363 5281 -2082 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <ø> (-12.83%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1586 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211381016 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.16%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.16% -22.61% + Complexity2811715137-12980 = Files 2452 1957 -495 Lines135033 107146-27887 Branches 1637613172 -3204 = - Hits 9286949467-43402 - Misses3480152541+17740 + Partials 7363 5138 -2225 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <ø> (-12.57%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1598 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211377032 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.65%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.65% -22.12% + Complexity2811714974-13143 = Files 2452 1940 -512 Lines135033 104643-30390 Branches 1637612611 -3765 = - Hits 9286948822-44047 - Misses3480150800+15999 + Partials 7363 5021 -2342 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <ø> (-12.41%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1627 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211375131 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.65%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.65% -22.12% + Complexity2811714974-13143 = Files 2452 1940 -512 Lines135033 104643-30390 Branches 1637612611 -3765 = - Hits 9286948822-44047 - Misses3480150800+15999 + Partials 7363 5021 -2342 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.39% <ø> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.09% <ø> (-12.41%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1627 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211307534 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.85%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a559551`](https://app.codecov.io/gh/apache/hudi/commit/a5595510880c53fa1f426e817131ad0cc05e5c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 4 commits behind head on master. > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (a559551). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (a559551) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 44.85% -23.92% + Complexity28117 8475-19642 = Files 2452 1196 -1256 Lines13503361906-73127 Branches 16376 6664 -9712 = - Hits 9286927770-65099 + Misses3480131105 -3696 + Partials 7363 3031 -4332 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <ø> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2055 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211261784 ## CI report: * c39bf05869062d106967b473ba5feb1f27928b72 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13141) * a5595510880c53fa1f426e817131ad0cc05e5c31 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13166) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4211245020 ## CI report: * c39bf05869062d106967b473ba5feb1f27928b72 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13141) * a5595510880c53fa1f426e817131ad0cc05e5c31 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
cshuo commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3055307828
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionPlanOperator.java:
##
@@ -109,10 +97,7 @@ public void processElement(StreamRecord
streamRecord) {
public void notifyCheckpointComplete(long checkpointId) {
// comment out: do we really need the timeout rollback ?
// CompactionUtil.rollbackEarliestCompaction(table, conf);
-// schedule data table compaction if enabled
-this.compactionPlanHandler.ifPresent(handler ->
handler.collectCompactionOperations(checkpointId, compactionMetrics, output));
-// Also schedule metadata table compaction if enabled
-this.mdtCompactionPlanHandler.ifPresent(handler ->
handler.collectCompactionOperations(checkpointId, compactionMetrics, output));
+this.compactionPlanHandler.collectCompactionOperations(checkpointId,
compactionMetrics, output);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
danny0405 commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3055003037
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionPlanOperator.java:
##
@@ -109,10 +97,7 @@ public void processElement(StreamRecord
streamRecord) {
public void notifyCheckpointComplete(long checkpointId) {
// comment out: do we really need the timeout rollback ?
// CompactionUtil.rollbackEarliestCompaction(table, conf);
-// schedule data table compaction if enabled
-this.compactionPlanHandler.ifPresent(handler ->
handler.collectCompactionOperations(checkpointId, compactionMetrics, output));
-// Also schedule metadata table compaction if enabled
-this.mdtCompactionPlanHandler.ifPresent(handler ->
handler.collectCompactionOperations(checkpointId, compactionMetrics, output));
+this.compactionPlanHandler.collectCompactionOperations(checkpointId,
compactionMetrics, output);
Review Comment:
The metrics is updated from both metadata table and data table, which is
incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
cshuo commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3049659757
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionCommitSink.java:
##
@@ -69,9 +62,7 @@ public CompactionCommitSink(Configuration conf) {
@Override
public void open(Configuration parameters) throws Exception {
super.open(parameters);
-HoodieFlinkWriteClient writeClient =
FlinkWriteClients.createWriteClient(conf, getRuntimeContext());
-this.compactCommitHandler = Lazy.lazily(() -> new
CompactCommitHandler(conf, writeClient));
-this.mdtCompactCommitHandler = Lazy.lazily(() -> new
MetadataCompactCommitHandler(conf,
StreamerUtil.createMetadataWriteClient(writeClient)));
+this.compactCommitHandler = CompositeCompactCommitHandler.create(conf,
getRuntimeContext());
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4204283018 ## CI report: * c39bf05869062d106967b473ba5feb1f27928b72 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13141) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4204071082 ## CI report: * 60761bc58e373ac0ff85788daa6b7fc2480113df Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13140) * c39bf05869062d106967b473ba5feb1f27928b72 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13141) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4204031577 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## + Coverage 68.77% 68.79% +0.01% - Complexity2811728141 +24 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 + Hits 9286992922 +53 + Misses3480134796 -5 + Partials 7363 7355 -8 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4204028924 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## + Coverage 68.77% 68.79% +0.01% - Complexity2811728141 +24 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 + Hits 9286992922 +53 + Misses3480134796 -5 + Partials 7363 7355 -8 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4204027060 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## + Coverage 68.77% 68.79% +0.01% - Complexity2811728140 +23 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 + Hits 9286992921 +52 + Misses3480134797 -4 + Partials 7363 7355 -8 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203995939 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.79%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## + Coverage 68.77% 68.79% +0.01% - Complexity2811728140 +23 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 + Hits 9286992919 +50 + Misses3480134799 -2 + Partials 7363 7355 -8 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203993899 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## + Coverage 68.77% 68.78% +0.01% - Complexity2811728138 +21 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 + Hits 9286992913 +44 Misses3480134801 + Partials 7363 7359 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203993054 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## + Coverage 68.77% 68.78% +0.01% - Complexity2811728138 +21 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 + Hits 9286992913 +44 Misses3480134801 + Partials 7363 7359 -4 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203989331 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.01%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 68.01% -0.77% + Complexity2811727832 -285 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286991864-1005 - Misses3480135792 +991 - Partials 7363 7417 +54 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203985535 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13122) * 60761bc58e373ac0ff85788daa6b7fc2480113df Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13140) * c39bf05869062d106967b473ba5feb1f27928b72 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13141) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203978657 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.94%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.94% -0.84% + Complexity2811727787 -330 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286991773-1096 - Misses3480135868+1067 - Partials 7363 7432 +69 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203971539 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.91%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.91% -0.86% + Complexity2811727779 -338 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286991740-1129 - Misses3480135900+1099 - Partials 7363 7433 +70 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203970878 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.81%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.81% -0.96% + Complexity2811727717 -400 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286991605-1264 - Misses3480136078+1277 - Partials 7363 7390 +27 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203968946 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.68%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.68% -1.09% + Complexity2811727654 -463 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286991428-1441 - Misses3480136275+1474 - Partials 7363 7370 +7 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203968249 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.64%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.64% -1.13% + Complexity2811727645 -472 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286991376-1493 - Misses3480136320+1519 - Partials 7363 7377 +14 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203963620 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.02%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 66.02% -2.76% + Complexity2811726969-1148 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286989176-3693 - Misses3480138424+3623 - Partials 7363 7473 +110 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203956601 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.90%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 65.90% -2.88% + Complexity2811726902-1215 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 - Hits 9286989016-3853 - Misses3480138631+3830 - Partials 7363 7426 +63 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203936429 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.90566%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.31%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...hudi/sink/compact/handler/DefaultCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDefaultCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGVmYXVsdENsZWFuSGFuZGxlci5qYXZh) | 48.38% | [15 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ompact/handler/DataTableCompactionPlanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactionPlanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdGlvblBsYW5IYW5kbGVyLmphdmE=) | 87.03% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/DataTableCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FDataTableCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvRGF0YVRhYmxlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 85.36% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 50.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 61.31% -7.47% + Complexity2811725021-3096 Files 2452 2458 +6 Lines135033 135073 +40 Branches 1637616374 -2 ===
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203935449 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.38%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 54.38% -14.40% + Complexity2811718416 -9701 = Files 2452 2004 -448 Lines135033 112131-22902 Branches 1637614235 -2141 = - Hits 9286960980-31889 - Misses3480144888+10087 + Partials 7363 6263 -1100 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.36% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.22% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1383 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203931587 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.05%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.05% -20.72% + Complexity2811716457-11660 = Files 2452 2004 -448 Lines135033 112131-22902 Branches 1637614235 -2141 = - Hits 9286953889-38980 - Misses3480152600+17799 + Partials 7363 5642 -1721 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.36% <ø> (-16.51%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1518 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203930026 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.02%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.02% -20.75% + Complexity2811716444-11673 = Files 2452 2004 -448 Lines135033 112131-22902 Branches 1637614235 -2141 = - Hits 9286953853-39016 - Misses3480152632+17831 + Partials 7363 5646 -1717 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <ø> (-16.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203923682 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.99%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|2| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 47.99% -20.79% + Complexity2811716433-11684 = Files 2452 2004 -448 Lines135033 112131-22902 Branches 1637614235 -2141 = - Hits 9286953816-39053 - Misses3480152664+17863 + Partials 7363 5651 -1712 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.17% <ø> (-15.69%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203918058 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.49%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.49% -20.29% + Complexity2811716210-11907 = Files 2452 1975 -477 Lines135033 109500-25533 Branches 1637613677 -2699 = - Hits 9286953099-39770 - Misses3480150905+16104 + Partials 7363 5496 -1867 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <ø> (-15.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <ø> (-12.82%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1535 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203917229 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 49.11%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 24 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 49.11% -19.67% + Complexity2811716049-12068 = Files 2452 1958 -494 Lines135033 107136-27897 Branches 1637613167 -3209 = - Hits 9286952615-40254 - Misses3480149164+14363 + Partials 7363 5357 -2006 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <ø> (-15.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1551 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203918984 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.95%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 47.95% -20.83% + Complexity2811716422-11695 = Files 2452 2004 -448 Lines135033 112117-22916 Branches 1637614233 -2143 = - Hits 9286953765-39104 - Misses3480152691+17890 + Partials 7363 5661 -1702 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <ø> (-15.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <ø> (-12.95%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203908616 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.18%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.18% -22.60% + Complexity2811715137-12980 = Files 2452 1958 -494 Lines135033 107136-27897 Branches 1637613167 -3209 = - Hits 9286949480-43389 - Misses3480152516+17715 + Partials 7363 5140 -2223 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <ø> (-12.55%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1599 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203904413 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.66%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.66% -22.11% + Complexity2811714974-13143 = Files 2452 1940 -512 Lines135033 104631-30402 Branches 1637612606 -3770 = - Hits 9286948827-44042 - Misses3480150786+15985 + Partials 7363 5018 -2345 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ø> (-12.40%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1624 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203902133 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.92%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 53.92% -14.86% + Complexity2811712260-15857 = Files 2452 1425 -1027 Lines13503370882-64151 Branches 16376 7992 -8384 = - Hits 9286938221-54648 + Misses3480129245 -5556 + Partials 7363 3416 -3947 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1799 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203828857 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.87%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c39bf05`](https://app.codecov.io/gh/apache/hudi/commit/c39bf05869062d106967b473ba5feb1f27928b72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (c39bf05). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (0591933) | HEAD (c39bf05) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|common-and-other-modules|1|0| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 44.87% -23.91% + Complexity28117 8475-19642 = Files 2452 1196 -1256 Lines13503361894-73139 Branches 16376 6659 -9717 = - Hits 9286927772-65097 + Misses3480131094 -3707 + Partials 7363 3028 -4335 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2052 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203789799 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13122) * 60761bc58e373ac0ff85788daa6b7fc2480113df Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13140) * c39bf05869062d106967b473ba5feb1f27928b72 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203766647 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13122) * 60761bc58e373ac0ff85788daa6b7fc2480113df Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13140) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4203753586 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13122) * 60761bc58e373ac0ff85788daa6b7fc2480113df UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
danny0405 commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3048786221
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionCommitSink.java:
##
@@ -69,9 +62,7 @@ public CompactionCommitSink(Configuration conf) {
@Override
public void open(Configuration parameters) throws Exception {
super.open(parameters);
-HoodieFlinkWriteClient writeClient =
FlinkWriteClients.createWriteClient(conf, getRuntimeContext());
-this.compactCommitHandler = Lazy.lazily(() -> new
CompactCommitHandler(conf, writeClient));
-this.mdtCompactCommitHandler = Lazy.lazily(() -> new
MetadataCompactCommitHandler(conf,
StreamerUtil.createMetadataWriteClient(writeClient)));
+this.compactCommitHandler = CompositeCompactCommitHandler.create(conf,
getRuntimeContext());
Review Comment:
wondering if we could have a factory class named `CompactionCommitHandlers`
to create handle based on configuration: either single or composition handler
when necesssary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-428118 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.99%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.99% -0.78% + Complexity2811927843 -276 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283491815-1019 - Misses3480735792 +985 - Partials 7345 7417 +72 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4200169834 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13122) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4200121036 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18477 +/- ## = Coverage 68.77% 68.78% - Complexity2811928152 +33 = Files 2451 2456+5 Lines134986 135024 +38 Branches 1636416357-7 = + Hits 9283492873 +39 + Misses3480734797 -10 - Partials 7345 7354+9 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|--
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4200110716 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18477 +/- ## = Coverage 68.77% 68.78% - Complexity2811928152 +33 = Files 2451 2456+5 Lines134986 135024 +38 Branches 1636416357-7 = + Hits 9283492873 +39 + Misses3480734797 -10 - Partials 7345 7354+9 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|--
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4200084440 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.78%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18477 +/- ## = Coverage 68.77% 68.78% - Complexity2811928152 +33 = Files 2451 2456+5 Lines134986 135024 +38 Branches 1636416357-7 = + Hits 9283492872 +38 + Misses3480734797 -10 - Partials 7345 7355 +10 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|--
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4200011568 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18477 +/- ## = Coverage 68.77% 68.77% - Complexity2811928149 +30 = Files 2451 2456+5 Lines134986 135024 +38 Branches 1636416357-7 = + Hits 9283492866 +32 + Misses3480734801-6 - Partials 7345 7357 +12 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|--
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4200017255 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #18477 +/- ## = Coverage 68.77% 68.77% - Complexity2811928150 +31 = Files 2451 2456+5 Lines134986 135024 +38 Branches 1636416357-7 = + Hits 9283492868 +34 + Misses3480734799-8 - Partials 7345 7357 +12 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|--
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-424783 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.99%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.99% -0.78% + Complexity2811927843 -276 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283491814-1020 - Misses3480735793 +986 - Partials 7345 7417 +72 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199987781 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.93%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.93% -0.85% + Complexity2811927798 -321 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283491724-1110 - Misses3480735868+1061 - Partials 7345 7432 +87 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199966924 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.90%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 67.90% -0.87% + Complexity2811927791 -328 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283491694-1140 - Misses3480735897+1090 - Partials 7345 7433 +88 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199962183 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.24%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 66.24% -2.53% + Complexity2811927108-1011 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283489451-3383 - Misses3480738032+3225 - Partials 7345 7541 +196 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199940542 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.03%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 66.03% -2.75% + Complexity2811926979-1140 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283489159-3675 - Misses3480738416+3609 - Partials 7345 7449 +104 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199944727 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.13%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 66.13% -2.65% + Complexity2811927041-1078 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283489294-3540 - Misses3480738236+3429 - Partials 7345 7494 +149 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199901872 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.88%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 65.88% -2.89% + Complexity2811926904-1215 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits 9283488964-3870 - Misses3480738632+3825 - Partials 7345 7428 +83 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199871197 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.29%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 61.29% -7.48% + Complexity2811925025-3094 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199870010 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.36145%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.29%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/java/org/apache/hudi/sink/CleanFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2FCleanFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9DbGVhbkZ1bmN0aW9uLmphdmE=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...di/sink/compact/handler/CompositeCleanHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCleanHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ2xlYW5IYW5kbGVyLmphdmE=) | 88.23% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...compact/handler/CompositeCompactCommitHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactCommitHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdENvbW1pdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../sink/compact/handler/CompositeCompactHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fcompact%2Fhandler%2FCompositeCompactHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9jb21wYWN0L2hhbmRsZXIvQ29tcG9zaXRlQ29tcGFjdEhhbmRsZXIuamF2YQ==) | 84.61% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 15 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## - Coverage 68.77% 61.29% -7.48% + Complexity2811925025-3094 Files 2451 2456 +5 Lines134986 135024 +38 Branches 1636416357 -7 - Hits
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199865481 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.04%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|5| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.04% -20.74% + Complexity2811916461-11658 = Files 2451 2003 -448 Lines134986 112084-22902 Branches 1636414220 -2144 = - Hits 9283453848-38986 - Misses3480752601+17794 + Partials 7345 5635 -1710 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.33% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199851083 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.04%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.04% -20.74% + Complexity2811916461-11658 = Files 2451 2003 -448 Lines134986 112084-22902 Branches 1636414220 -2144 = - Hits 9283453847-38987 - Misses3480752601+17794 + Partials 7345 5636 -1709 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.33% <ø> (-16.53%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199848612 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.01%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.01% -20.77% + Complexity2811916451-11668 = Files 2451 2003 -448 Lines134986 112084-22902 Branches 1636414220 -2144 = - Hits 9283453814-39020 - Misses3480752630+17823 + Partials 7345 5640 -1705 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <ø> (-16.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199849691 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 48.01%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|3| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 48.01% -20.77% + Complexity2811916451-11668 = Files 2451 2003 -448 Lines134986 112084-22902 Branches 1636414220 -2144 = - Hits 9283453814-39020 - Misses3480752630+17823 + Partials 7345 5640 -1705 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <ø> (-16.11%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1519 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199840378 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 47.93%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 47.93% -20.84% + Complexity2811916427-11692 = Files 2451 2003 -448 Lines134986 112084-22902 Branches 1636414220 -2144 = - Hits 9283453732-39102 - Misses3480752698+17891 + Partials 7345 5654 -1691 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <ø> (-15.30%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199828457 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.14%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|5| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 45.14% -23.63% + Complexity2811915519-12600 = Files 2451 2003 -448 Lines134986 112084-22902 Branches 1636414220 -2144 = - Hits 9283450599-42235 - Misses3480756048+21241 + Partials 7345 5437 -1908 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.53% <ø> (-12.94%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1569 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199820809 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 45.61%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|4| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 45.61% -23.17% + Complexity2811915304-12815 = Files 2451 1974 -477 Lines134986 109467-25519 Branches 1636413664 -2700 = - Hits 9283449931-42903 - Misses3480754263+19456 + Partials 7345 5273 -2072 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.66% <ø> (-12.81%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1585 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199807734 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.16%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 25 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|2| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.16% -22.61% + Complexity2811915143-12976 = Files 2451 1957 -494 Lines134986 107103-27883 Branches 1636413154 -3210 = - Hits 9283449449-43385 - Misses3480752521+17714 + Partials 7345 5133 -2212 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <ø> (-12.54%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1600 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199786028 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.67%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 46.67% -22.10% + Complexity2811914966-13153 = Files 2451 1940 -511 Lines134986 104658-30328 Branches 1636412548 -3816 = - Hits 9283448850-43984 - Misses3480750785+15978 + Partials 7345 5023 -2322 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (+<0.01%)` | :arrow_up: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ø> (-12.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1613 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199757388 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 39.86%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|1| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 39.86% -28.91% + Complexity2811912379-15740 = Files 2451 1940 -511 Lines134986 104657-30329 Branches 1636412548 -3816 = - Hits 9283441723-5 - Misses3480757977+23170 + Partials 7345 4957 -2388 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <ø> (-12.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1822 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
codecov-commenter commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199634193 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 44.87%. Comparing base ([`1582d60`](https://app.codecov.io/gh/apache/hudi/commit/1582d602b0c5366056bb3bb46304a5bafba3a551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4de1220`](https://app.codecov.io/gh/apache/hudi/commit/4de122017189da317cba96f6bfc5d2384d48b16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (1582d60) and HEAD (4de1220). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (1582d60) | HEAD (4de1220) | >|--|--|--| >|spark-client-hadoop-common|1|0| >|spark-scala-tests|10|0| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18477 +/- ## = - Coverage 68.77% 44.87% -23.91% + Complexity28119 8477-19642 = Files 2451 1196 -1255 Lines13498661894-73092 Branches 16364 6659 -9705 = - Hits 9283427773-65061 + Misses3480731094 -3713 + Partials 7345 3027 -4318 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2054 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
yihua commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3045565009
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/handler/CompositeTableServiceHandler.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.compact.handler;
+
+import org.apache.hudi.common.util.Option;
+
+import java.io.Closeable;
+import java.util.function.Consumer;
+
+/**
+ * Base class for composite handlers that encapsulate data table and metadata
table service handlers.
+ *
+ * The composite subclasses expose a single entry point to Flink operators
while keeping the
+ * specific handler references, and routing inside the handler layer.
+ *
+ * @param table service handler type
+ */
+public abstract class CompositeTableServiceHandler implements Closeable {
+ protected final Option dataTableHandler;
+ protected final Option metadataTableHandler;
+
+ protected CompositeTableServiceHandler(Option dataTableHandler, Option
metadataTableHandler) {
+this.dataTableHandler = dataTableHandler;
+this.metadataTableHandler = metadataTableHandler;
+ }
+
+ protected H getHandler(boolean isMetadataTable) {
+return isMetadataTable ? metadataTableHandler.get() :
dataTableHandler.get();
+ }
+
+ protected void forEachHandler(Consumer consumer) {
Review Comment:
🤖 Could this throw `NoSuchElementException` at runtime? If a subclass calls
`getHandler(true)` but `metadataTableHandler` is `Option.empty()` (e.g.
metadata table is disabled), the unconditional `.get()` will blow up with a
confusing exception. Would it be safer to guard this with a presence check and
throw a descriptive `IllegalStateException`, or have each subclass validate
before delegating?
##
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/compact/handler/TestCompositeHandlers.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.compact.handler;
+
+import org.apache.hudi.client.WriteStatus;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.metrics.FlinkCompactionMetrics;
+import org.apache.hudi.sink.compact.CompactionCommitEvent;
+import org.apache.hudi.sink.compact.CompactionPlanEvent;
+import org.apache.hudi.util.Lazy;
+
+import org.apache.flink.streaming.api.operators.Output;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.junit.jupiter.api.Test;
+import org.mockito.InOrder;
+
+import java.util.Collections;
+
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
+import static org.mockito.Mockito.same;
+
+class TestCompositeHandlers {
+
+ @Test
+ void testCommitHandlerRoutesEventsToMatchingTableServiceHandler() {
+CompactCommitHandler dataHandler = mock(CompactCommitHandler.class);
+CompactCommitHandler metadataHandler = mock(CompactCommitHandler.class);
+CompositeCompactCommitHandler handler = new CompositeCompactCommitHandler(
+Option.of(Lazy.eagerly(dataHandler)),
+Option.of(Lazy.eagerly(metadataHandler)));
+FlinkCompactionMetrics metrics = mock(FlinkCompactionMetrics.class);
+CompactionCommitEvent dataEvent =
+new CompactionCommitEvent("001"
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199558563 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13122) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
yihua commented on code in PR #18477:
URL: https://github.com/apache/hudi/pull/18477#discussion_r3045531216
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/handler/CompositeCompactHandler.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.compact.handler;
+
+import org.apache.hudi.client.HoodieFlinkWriteClient;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.metrics.FlinkCompactionMetrics;
+import org.apache.hudi.sink.compact.CompactionCommitEvent;
+import org.apache.hudi.sink.compact.CompactionPlanEvent;
+import org.apache.hudi.sink.utils.NonThrownExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.Lazy;
+import org.apache.hudi.util.StreamerUtil;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.util.Collector;
+
+import javax.annotation.Nullable;
+
+/**
+ * Composite handler for compaction execution services of the data table and
metadata table.
+ */
+public class CompositeCompactHandler extends
CompositeTableServiceHandler> {
+
+ CompositeCompactHandler(Option> dataTableHandler,
Option> metadataTableHandler) {
+super(dataTableHandler, metadataTableHandler);
+ }
+
+ public static CompositeCompactHandler create(Configuration conf,
RuntimeContext runtimeContext, int taskId) {
+HoodieFlinkWriteClient writeClient =
FlinkWriteClients.createWriteClient(conf, runtimeContext);
+return new CompositeCompactHandler(
+Option.of(Lazy.lazily(() -> new CompactHandler(writeClient, taskId))),
+Option.of(Lazy.lazily(() -> new
MetadataCompactHandler(StreamerUtil.createMetadataWriteClient(writeClient),
taskId;
+ }
+
+ public void compact(@Nullable NonThrownExecutor executor,
+ CompactionPlanEvent event,
+ Collector collector,
+ boolean needReloadMetaClient,
+ FlinkCompactionMetrics compactionMetrics) throws
Exception {
+getHandler(event.isMetadataTable()).get().compact(executor, event,
collector, needReloadMetaClient, compactionMetrics);
+ }
+
+ @Override
+ public void close() {
+if (dataTableHandler.isPresent() &&
dataTableHandler.get().isInitialized()) {
Review Comment:
🤖 nit: consider using `ifPresent()` with a lambda here to avoid calling
`.get()` twice on the Option.
##
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/handler/CompositeCompactCommitHandler.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.compact.handler;
+
+import org.apache.hudi.client.HoodieFlinkWriteClient;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.metrics.FlinkCompactionMetrics;
+import org.apache.hudi.sink.compact.CompactionCommitEvent;
+import org.apache.hudi.util.FlinkWriteClients;
+import org.apache.hudi.util.Lazy;
+import org.apache.hudi.util.StreamerUtil;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.configuration.Configuration;
+
+/**
+ * Composite handler for compaction commit services of the data table and
metadata table.
+ */
+public class CompositeCompactCommitHandler extends
CompositeTableServiceHandler> {
+
+ CompositeCompactCommitHandler(Option>
dataTableHan
Re: [PR] refactor(flink): Refactor Flink compaction/clean pipeline with compos… [hudi]
hudi-bot commented on PR #18477: URL: https://github.com/apache/hudi/pull/18477#issuecomment-4199537422 ## CI report: * 4de122017189da317cba96f6bfc5d2384d48b16e UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
