Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4612129518 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.80%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.80% -0.01% - Complexity2916029163 +3 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637396346 -27 + Misses3590935906 -3 - Partials 7774 7776 +2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.36% <84.09%> (+0.01%)` | :arrow_up: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <63.63%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4612120786 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.80%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.80% -0.01% - Complexity2916029163 +3 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637396346 -27 + Misses3590935906 -3 - Partials 7774 7776 +2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <84.09%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <63.63%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous merged PR #17785: URL: https://github.com/apache/hudi/pull/17785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4611193276 ## CI report: * fd550363f399da4b377234cae056e1257d84605e Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14436) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610967901 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.80%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.80% -0.01% - Complexity2916029163 +3 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637396344 -29 Misses3590935909 - Partials 7774 7775 +1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <84.09%> (-0.04%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <63.63%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610919351 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.26%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.26% -0.55% + Complexity2916028909 -251 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395591 -782 - Misses3590936605 +696 - Partials 7774 7832 +58 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.41% <80.68%> (-2.95%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <63.63%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610907824 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.22%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.22% -0.59% + Complexity2916028880 -280 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395528 -845 - Misses3590936680 +771 - Partials 7774 7820 +46 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.41% <80.68%> (-2.95%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <63.63%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610890287 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.16%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.16% -0.65% + Complexity2916028849 -311 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395452 -921 - Misses3590936770 +861 - Partials 7774 7806 +32 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.41% <80.68%> (-2.95%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <63.63%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610882122 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.16%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.16% -0.65% + Complexity2916028849 -311 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395451 -922 - Misses3590936770 +861 - Partials 7774 7807 +33 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.41% <80.68%> (-2.95%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <63.63%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610868328 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.05%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.05% -0.76% + Complexity2916028791 -369 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395297-1076 - Misses3590936935+1026 - Partials 7774 7796 +22 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.21% <80.68%> (-3.15%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610855891 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.05%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.05% -0.76% + Complexity2916028791 -369 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395297-1076 - Misses3590936935+1026 - Partials 7774 7796 +22 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.21% <80.68%> (-3.15%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610853101 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.97%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.97% -0.84% + Complexity2916028737 -423 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637395179-1194 - Misses3590937053+1144 - Partials 7774 7796 +22 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.91% <80.68%> (-3.45%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610848054 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.74%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.74% -1.07% + Complexity2916028677 -483 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637394857-1516 - Misses3590937374+1465 - Partials 7774 7797 +23 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <80.68%> (-4.01%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610809970 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.59%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.59% -1.23% + Complexity2916028580 -580 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637394645-1728 - Misses3590937571+1662 - Partials 7774 7812 +38 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.47% <80.68%> (-6.89%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610777260 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.89%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 19 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|4| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 58.89% -9.92% + Complexity2916025004-4156 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637382467 -13906 - Misses3590950302 +14393 + Partials 7774 7259 -515 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610802576 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.84%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 65.84% -2.97% + Complexity2916027890-1270 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637392200-4173 - Misses3590939979+4070 - Partials 7774 7849 +75 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.37% <70.45%> (-0.01%)` | :arrow_down: | Flags with carried forward
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610799278 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.82%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 63.82% -4.99% + Complexity2916027074-2086 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637389373-7000 - Misses3590942892+6983 + Partials 7774 7763 -11 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <63.63%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click her
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610782338 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 58.89%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 58.89% -9.92% + Complexity2916025004-4156 Files 2520 2520 Lines140056 140028 -28 Branches 1720917210 +1 - Hits 9637382468 -13905 - Misses3590950302 +14393 + Partials 7774 7258 -516 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.27%> (-0.01%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610754841 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.10%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 20 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 48.10% -20.71% + Complexity2916016979-12181 = Files 2520 2046 -474 Lines140056 115727-24329 Branches 1720914905 -2304 = - Hits 9637355669-40704 - Misses3590954015+18106 + Partials 7774 6043 -1731 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610738245 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.10%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 48.10% -20.71% + Complexity2916016979-12181 = Files 2520 2046 -474 Lines140056 115722-24334 Branches 1720914899 -2310 = - Hits 9637355663-40710 - Misses3590954013+18104 + Partials 7774 6046 -1728 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610740696 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.5%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.10%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.36% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 21 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|4| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 48.10% -20.71% + Complexity2916016979-12181 = Files 2520 2046 -474 Lines140056 115722-24334 Branches 1720914899 -2310 = - Hits 9637355663-40710 - Misses3590954013+18104 + Partials 7774 6046 -1728 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <59.09%> (-0.03%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.22%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.79% <60.22%> (-17.57%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610677234 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `64.77273%` with `31 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.87%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 65.85% | [6 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-client-hadoop-common|1|0| >|spark-java-tests|15|2| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 41.87% -26.94% + Complexity2916014351-14809 = Files 2520 2046 -474 Lines140056 115722-24334 Branches 1720914899 -2310 = - Hits 9637348459-47914 - Misses3590961448+25539 + Partials 7774 5815 -1959 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_sour
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610673094 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `64.77273%` with `31 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.87%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 65.85% | [6 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-client-hadoop-common|1|0| >|spark-java-tests|15|2| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 41.87% -26.94% + Complexity2916014351-14809 = Files 2520 2046 -474 Lines140056 115722-24334 Branches 1720914899 -2310 = - Hits 9637348459-47914 - Misses3590961448+25539 + Partials 7774 5815 -1959 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_sour
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610661867 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `61.36364%` with `34 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.52%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 65.85% | [6 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/rollback/RollbackHelperV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FRollbackHelperV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9Sb2xsYmFja0hlbHBlclYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-client-hadoop-common|1|0| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 39.52% -29.29% + Complexity2916012943-16217 = Files 2520 2007 -513 Lines140056 110751-29305 Branches 1720913815 -3394 = - Hits
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610654158 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `61.36364%` with `34 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.71%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 65.85% | [6 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/rollback/RollbackHelperV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FRollbackHelperV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9Sb2xsYmFja0hlbHBlclYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-client-hadoop-common|1|0| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 39.71% -29.10% + Complexity2916012693-16467 = Files 2520 1980 -540 Lines140056 108026-32030 Branches 1720913209 -4000 = - Hits
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610496129 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `59.09091%` with `36 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.85%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fd55036`](https://app.codecov.io/gh/apache/hudi/commit/fd550363f399da4b377234cae056e1257d84605e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 60.97% | [7 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/rollback/RollbackHelperV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FRollbackHelperV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9Sb2xsYmFja0hlbHBlclYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (fd55036). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (fd55036) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-client-hadoop-common|1|0| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 44.85% -23.96% + Complexity29160 8573-20587 = Files 2520 1203 -1317 Lines14005662963-77093 Branches 17209 6863-10346 = - Hits
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610308514 ## CI report: * 75dc03bfe3528ff735f12d65b10cc823f1888c19 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14429) * fd550363f399da4b377234cae056e1257d84605e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14436) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610277569 ## CI report: * 75dc03bfe3528ff735f12d65b10cc823f1888c19 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14429) * fd550363f399da4b377234cae056e1257d84605e UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r3346814188
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -207,23 +206,29 @@ private int getLogBlockLength(int contentLength, int
headerLength, int footerLen
private void rolloverIfNeeded() throws IOException {
// Roll over if the size is past the threshold
-if (getCurrentSize() > sizeThreshold) {
- log.info("CurrentSize {} has reached threshold {}. Rolling over to the
next version", getCurrentSize(), sizeThreshold);
+if (getCurrentSize() > getSizeThreshold()) {
+ log.info("CurrentSize {} has reached threshold {}. Rolling over to the
next version", getCurrentSize(), getSizeThreshold());
rollOver();
}
}
private void rollOver() throws IOException {
closeStream();
-this.logFile = logFile.rollOver(rolloverLogWriteToken);
+this.logFile = getLogFile().rollOver(getLogWriteToken());
this.closed = false;
}
private void createNewFile() throws IOException {
-fileCreationHook.preFileCreation(this.logFile);
-this.output = new FSDataOutputStream(
-storage.create(this.logFile.getPath(), false, bufferSize, replication,
WriterBuilder.DEFAULT_SIZE_THRESHOLD),
-new FileSystem.Statistics(storage.getScheme())
+getFileCreationCallback().preFileCreation(this.getLogFile());
+this.outputStream = new FSDataOutputStream(
+getStorage().create(
+this.getLogFile().getPath(),
+false,
+getBufferSize(),
+getReplication(),
Review Comment:
Good catch, confirmed this was a behavioral change. Restored the fixed
`DEFAULT_SIZE_THRESHOLD` (512 MB) as the block-size argument to `create()`,
since the HDFS block size is a separate concept from the log rollover
threshold. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r3346814589
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelperV1.java:
##
@@ -311,9 +312,9 @@ List>
maybeDeleteAndCollectStats(HoodieEngineCo
// Let's emit markers for rollback as well. markers are emitted
under rollback instant time.
WriteMarkers writeMarkers =
WriteMarkersFactory.get(config.getMarkersType(), table, instantTime);
- HoodieLogFormat.WriterBuilder writerBuilder =
HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbsolutePath(metaClient.getBasePath(),
partitionPath))
- .withFileId(fileId)
+ HoodieLogFormatWriter.HoodieLogFormatWriterBuilder writerBuilder =
HoodieLogFormatWriter.builder()
Review Comment:
I follow the concern about the Lombok-generated name, but I'd prefer to keep
it as-is. The builder belongs to `HoodieLogFormatWriter`, which lives in
`hudi-hadoop-common` and references hadoop types (`FSDataOutputStream`). The
old `HoodieLogFormat.WriterBuilder` only lived in `hudi-common` by loading the
writer reflectively via `ReflectionUtils`, the brittleness this PR removes
(#11207). Re-adding a named builder type in `HoodieLogFormat` would mean either
bringing back that reflection or re-coupling `hudi-common` to hadoop. The
generated type is referenced in exactly one internal call site
(`RollbackHelperV1`), where we hold the builder to conditionally set the
pre-computed log version before `build()`, so the leak is contained to a single
internal caller.
##
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java:
##
@@ -60,31 +60,140 @@ public interface HoodieLogFormat {
String DEFAULT_WRITE_TOKEN = "0-0-0";
- String DEFAULT_LOG_FORMAT_WRITER =
"org.apache.hudi.common.table.log.HoodieLogFormatWriter";
-
/**
- * Writer interface to allow appending block to this file format.
+ * Abstract base class for appending blocks to the Hoodie log format.
+ * Subclasses provide specific implementations for writing to different
storage layers.
*/
- interface Writer extends Closeable {
+ @Getter
+ @Slf4j
+ abstract class Writer implements Closeable {
+
+// Default max log file size 512 MB
+public static final long DEFAULT_SIZE_THRESHOLD = 512 * 1024 * 1024L;
+
+// Buffer size
+protected Integer bufferSize;
+// FileSystem
+protected HoodieStorage storage;
+// Size threshold for the log file. Useful when used with a rolling log
appender
+protected Long sizeThreshold;
+// Log File extension. Could be .avro.delta or .avro.commits etc
+protected String fileExtension;
+// File Id
+protected String logFileId;
+// File Commit Time stamp
+protected String instantTime;
+// version number for this log file. If not specified, then the current
version will be
+// computed by inspecting the file system
+protected Integer logVersion;
+// file len of this log file
Review Comment:
Done, updated the comment to "file size" and removed the redundant `= 0L`
inline initializer; the default is set in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610245964 ## CI report: * 75dc03bfe3528ff735f12d65b10cc823f1888c19 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14429) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r3346814188
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -207,23 +206,29 @@ private int getLogBlockLength(int contentLength, int
headerLength, int footerLen
private void rolloverIfNeeded() throws IOException {
// Roll over if the size is past the threshold
-if (getCurrentSize() > sizeThreshold) {
- log.info("CurrentSize {} has reached threshold {}. Rolling over to the
next version", getCurrentSize(), sizeThreshold);
+if (getCurrentSize() > getSizeThreshold()) {
+ log.info("CurrentSize {} has reached threshold {}. Rolling over to the
next version", getCurrentSize(), getSizeThreshold());
rollOver();
}
}
private void rollOver() throws IOException {
closeStream();
-this.logFile = logFile.rollOver(rolloverLogWriteToken);
+this.logFile = getLogFile().rollOver(getLogWriteToken());
this.closed = false;
}
private void createNewFile() throws IOException {
-fileCreationHook.preFileCreation(this.logFile);
-this.output = new FSDataOutputStream(
-storage.create(this.logFile.getPath(), false, bufferSize, replication,
WriterBuilder.DEFAULT_SIZE_THRESHOLD),
-new FileSystem.Statistics(storage.getScheme())
+getFileCreationCallback().preFileCreation(this.getLogFile());
+this.outputStream = new FSDataOutputStream(
+getStorage().create(
+this.getLogFile().getPath(),
+false,
+getBufferSize(),
+getReplication(),
Review Comment:
Good catch — confirmed this was a behavioral change. Restored the fixed
`DEFAULT_SIZE_THRESHOLD` (512 MB) as the block-size argument to `create()`,
since the HDFS block size is a separate concept from the log rollover
threshold. Thanks!
##
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java:
##
@@ -60,31 +60,140 @@ public interface HoodieLogFormat {
String DEFAULT_WRITE_TOKEN = "0-0-0";
- String DEFAULT_LOG_FORMAT_WRITER =
"org.apache.hudi.common.table.log.HoodieLogFormatWriter";
-
/**
- * Writer interface to allow appending block to this file format.
+ * Abstract base class for appending blocks to the Hoodie log format.
+ * Subclasses provide specific implementations for writing to different
storage layers.
*/
- interface Writer extends Closeable {
+ @Getter
+ @Slf4j
+ abstract class Writer implements Closeable {
+
+// Default max log file size 512 MB
+public static final long DEFAULT_SIZE_THRESHOLD = 512 * 1024 * 1024L;
+
+// Buffer size
+protected Integer bufferSize;
+// FileSystem
+protected HoodieStorage storage;
+// Size threshold for the log file. Useful when used with a rolling log
appender
+protected Long sizeThreshold;
+// Log File extension. Could be .avro.delta or .avro.commits etc
+protected String fileExtension;
+// File Id
+protected String logFileId;
+// File Commit Time stamp
+protected String instantTime;
+// version number for this log file. If not specified, then the current
version will be
+// computed by inspecting the file system
+protected Integer logVersion;
+// file len of this log file
Review Comment:
Done — updated the comment to "file size" and removed the redundant `= 0L`
inline initializer; the default is set in the constructor.
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelperV1.java:
##
@@ -311,9 +312,9 @@ List>
maybeDeleteAndCollectStats(HoodieEngineCo
// Let's emit markers for rollback as well. markers are emitted
under rollback instant time.
WriteMarkers writeMarkers =
WriteMarkersFactory.get(config.getMarkersType(), table, instantTime);
- HoodieLogFormat.WriterBuilder writerBuilder =
HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbsolutePath(metaClient.getBasePath(),
partitionPath))
- .withFileId(fileId)
+ HoodieLogFormatWriter.HoodieLogFormatWriterBuilder writerBuilder =
HoodieLogFormatWriter.builder()
Review Comment:
Thanks — I follow the concern about the Lombok-generated name, but I'd
prefer to keep it as-is. The builder belongs to `HoodieLogFormatWriter`, which
lives in `hudi-hadoop-common` and references hadoop types
(`FSDataOutputStream`). The old `HoodieLogFormat.WriterBuilder` only lived in
`hudi-common` by loading the writer reflectively via `ReflectionUtils` — the
brittleness this PR removes (#11207). Re-adding a named builder type in
`HoodieLogFormat` would mean either bringing back that reflection or
re-coupling `hudi-common` to hadoop. The generated type is referenced in
exactly one internal call site (`RollbackHelperV1`), where we hold the builder
to conditionally set the pre-c
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610159678 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #17785 +/- ## = Coverage 68.81% 68.81% - Complexity2916029175 +15 = Files 2520 2520 Lines140056 140029 -27 Branches 1720917207-2 = - Hits 9637396363 -10 + Misses3590935895 -14 + Partials 7774 7771-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <84.26%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <64.04%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](htt
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610136149 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #17785 +/- ## = Coverage 68.81% 68.81% - Complexity2916029175 +15 = Files 2520 2520 Lines140056 140029 -27 Branches 1720917207-2 = - Hits 9637396363 -10 + Misses3590935895 -14 + Partials 7774 7771-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <84.26%> (-0.02%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <64.04%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](htt
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610085859 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #17785 +/- ## = Coverage 68.81% 68.81% - Complexity2916029175 +15 = Files 2520 2520 Lines140056 140029 -27 Branches 1720917207-2 = - Hits 9637396361 -12 + Misses3590935897 -12 + Partials 7774 7771-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <84.26%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <64.04%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](htt
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610081521 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #17785 +/- ## = Coverage 68.81% 68.81% - Complexity2916029175 +15 = Files 2520 2520 Lines140056 140029 -27 Branches 1720917207-2 = - Hits 9637396361 -12 + Misses3590935897 -12 + Partials 7774 7771-3 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <84.26%> (-0.05%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <64.04%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](htt
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610072687 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #17785 +/- ## = Coverage 68.81% 68.81% - Complexity2916029173 +13 = Files 2520 2520 Lines140056 140029 -27 Branches 1720917207-2 = - Hits 9637396357 -16 + Misses3590935900-9 + Partials 7774 7772-2 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.24% <84.26%> (-0.12%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <64.04%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](htt
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610067871 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.81%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## master #17785 +/- ## = Coverage 68.81% 68.81% - Complexity2916029173 +13 = Files 2520 2520 Lines140056 140029 -27 Branches 1720917207-2 = - Hits 9637396355 -18 + Misses3590935901-8 + Partials 7774 7773-1 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.23% <84.26%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <64.04%> (-0.01%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](htt
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610064466 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.76%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.76% -0.05% + Complexity2916029144 -16 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637396292 -81 - Misses3590935976 +67 + Partials 7774 7761 -13 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.23% <84.26%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <64.04%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610062557 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.76%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.76% -0.05% + Complexity2916029144 -16 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637396292 -81 - Misses3590935976 +67 + Partials 7774 7761 -13 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.23% <84.26%> (-0.13%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <64.04%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610059050 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.69%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 68.69% -0.12% + Complexity2916029107 -53 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637396190 -183 - Misses3590936084 +175 + Partials 7774 7755 -19 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.96% <84.26%> (-0.40%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <64.04%> (-0.09%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610054483 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.87%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.87% -0.94% + Complexity2916028766 -394 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637395047-1326 - Misses3590937182+1273 - Partials 7774 7800 +26 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <80.89%> (-3.79%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <64.04%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610046313 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.82%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.82% -0.99% + Complexity2916028726 -434 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637394977-1396 - Misses3590937261+1352 - Partials 7774 7791 +17 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.33% <80.89%> (-4.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <64.04%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610043169 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.82%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.82% -0.99% + Complexity2916028726 -434 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637394977-1396 - Misses3590937261+1352 - Partials 7774 7791 +17 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.33% <80.89%> (-4.03%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <64.04%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610039829 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.68%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 67.68% -1.13% + Complexity2916028633 -527 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637394777-1596 - Misses3590937452+1543 - Partials 7774 7800 +26 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.47% <80.89%> (-6.89%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <64.04%> (-0.20%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward cov
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4610030880 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.89%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 65.89% -2.92% + Complexity2916027940-1220 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637392277-4096 - Misses3590939894+3985 - Partials 7774 7858 +84 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <64.04%> (-0.26%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward co
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609996212 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.85%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 65.85% -2.96% + Complexity2916027904-1256 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637392213-4160 - Misses3590939969+4060 - Partials 7774 7847 +73 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <64.04%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <70.78%> (+0.02%)` | :arrow_up: | Flags with carried forward co
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609963709 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.82%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 63.82% -4.99% + Complexity2916027086-2074 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637389374-6999 - Misses3590942893+6984 + Partials 7774 7762 -12 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <64.04%> (-0.37%)` | :arrow_down: | | [utilities](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click her
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609961431 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.58%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|5| >|utilities|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## - Coverage 68.81% 63.58% -5.23% + Complexity2916026930-2230 Files 2520 2520 Lines140056 140029 -27 Branches 1720917207 -2 - Hits 9637389036-7337 - Misses3590943330+7421 + Partials 7774 7663 -111 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <77.52%> (-0.02%)` | :arrow_down: | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609947033 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.45%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 22 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 47.45% -21.36% + Complexity2916016654-12506 = Files 2520 2046 -474 Lines140056 115728-24328 Branches 1720914902 -2307 = - Hits 9637354920-41453 - Misses3590954986+19077 + Partials 7774 5822 -1952 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609929908 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.42%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 47.42% -21.39% + Complexity2916016652-12508 = Files 2520 2046 -474 Lines140056 115728-24328 Branches 1720914902 -2307 = - Hits 9637354880-41493 - Misses3590955011+19102 + Partials 7774 5837 -1937 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609933974 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.42%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 23 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|2| >|spark-java-tests|15|4| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 47.42% -21.39% + Complexity2916016652-12508 = Files 2520 2046 -474 Lines140056 115728-24328 Branches 1720914902 -2307 = - Hits 9637354880-41493 - Misses3590955011+19102 + Partials 7774 5837 -1937 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.74% <60.67%> (-17.62%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609923787 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.66%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 26 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|15|2| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 48.66% -20.15% + Complexity2916016318-12842 = Files 2520 1994 -526 Lines140056 110485-29571 Branches 1720913778 -3431 = - Hits 9637353772-42601 - Misses3590951154+15245 + Partials 7774 5559 -2215 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.51% <60.67%> (-16.85%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609916465 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.64045%` with `11 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.33%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 85.71% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 27 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|1| >|spark-java-tests|15|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 49.33% -19.48% + Complexity2916016228-12932 = Files 2520 1977 -543 Lines140056 108026-32030 Branches 1720913159 -4050 = - Hits 9637353296-43077 - Misses3590949212+13303 + Partials 7774 5518 -2256 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <60.67%> (-16.60%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609894032 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.39326%` with `13 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.23%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 80.95% | [1 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 28 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|15|1| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 45.23% -23.58% + Complexity2916014954-14206 = Files 2520 1977 -543 Lines140056 108026-32030 Branches 1720913159 -4050 = - Hits 9637348866-47507 - Misses3590954082+18173 + Partials 7774 5078 -2696 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <60.67%> (-16.60%)` | :arrow_down: | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609881543 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.39326%` with `13 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.84%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 80.95% | [1 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 82.75% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 29 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 53.84% -14.97% + Complexity2916012468-16692 = Files 2520 1435 -1085 Lines14005672357-67699 Branches 17209 8307 -8902 = - Hits 9637338961-57412 + Misses3590929880 -6029 + Partials 7774 3516 -4258 ``` | [Flag](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <59.55%> (-0.02%)` | :arrow_down: | | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.15% <85.39%> (-0.01%)` | :arrow_down: | | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17785/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609762301 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `59.55056%` with `36 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.86%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`75dc03b`](https://app.codecov.io/gh/apache/hudi/commit/75dc03bfe3528ff735f12d65b10cc823f1888c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 61.90% | [7 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/rollback/RollbackHelperV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FRollbackHelperV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9Sb2xsYmFja0hlbHBlclYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (75dc03b). Click for more details. > > HEAD has 30 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (75dc03b) | >|--|--|--| >|spark-scala-tests|12|0| >|spark-client-hadoop-common|1|0| >|spark-java-tests|15|0| >|utilities|1|0| >|common-and-other-modules|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17785 +/- ## = - Coverage 68.81% 44.86% -23.95% + Complexity29160 8578-20582 = Files 2520 1203 -1317 Lines14005662964-77092 Branches 17209 6863-10346 = - Hits
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-agent commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r3346422725
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -207,23 +206,29 @@ private int getLogBlockLength(int contentLength, int
headerLength, int footerLen
private void rolloverIfNeeded() throws IOException {
// Roll over if the size is past the threshold
-if (getCurrentSize() > sizeThreshold) {
- log.info("CurrentSize {} has reached threshold {}. Rolling over to the
next version", getCurrentSize(), sizeThreshold);
+if (getCurrentSize() > getSizeThreshold()) {
+ log.info("CurrentSize {} has reached threshold {}. Rolling over to the
next version", getCurrentSize(), getSizeThreshold());
rollOver();
}
}
private void rollOver() throws IOException {
closeStream();
-this.logFile = logFile.rollOver(rolloverLogWriteToken);
+this.logFile = getLogFile().rollOver(getLogWriteToken());
this.closed = false;
}
private void createNewFile() throws IOException {
-fileCreationHook.preFileCreation(this.logFile);
-this.output = new FSDataOutputStream(
-storage.create(this.logFile.getPath(), false, bufferSize, replication,
WriterBuilder.DEFAULT_SIZE_THRESHOLD),
-new FileSystem.Statistics(storage.getScheme())
+getFileCreationCallback().preFileCreation(this.getLogFile());
+this.outputStream = new FSDataOutputStream(
+getStorage().create(
+this.getLogFile().getPath(),
+false,
+getBufferSize(),
+getReplication(),
Review Comment:
🤖 Heads-up: this changes the HDFS block size argument from the previous
fixed `WriterBuilder.DEFAULT_SIZE_THRESHOLD` (512 MB) to the user-configurable
`getSizeThreshold()`. Since `HoodieHadoopStorage.create()` passes this through
to `FileSystem.create(..., blockSize, ...)`, a user (or test) setting a small
`withSizeThreshold(...)` would now create the underlying file with that tiny
block size, which HDFS rejects when it falls below
`dfs.namenode.fs-limits.min-block-size` (default 1 MB). Could you keep using
the 512 MB constant here as the block size, since that's a different concept
from the log rollover threshold? @yihua
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java:
##
@@ -60,31 +60,140 @@ public interface HoodieLogFormat {
String DEFAULT_WRITE_TOKEN = "0-0-0";
- String DEFAULT_LOG_FORMAT_WRITER =
"org.apache.hudi.common.table.log.HoodieLogFormatWriter";
-
/**
- * Writer interface to allow appending block to this file format.
+ * Abstract base class for appending blocks to the Hoodie log format.
+ * Subclasses provide specific implementations for writing to different
storage layers.
*/
- interface Writer extends Closeable {
+ @Getter
+ @Slf4j
+ abstract class Writer implements Closeable {
+
+// Default max log file size 512 MB
+public static final long DEFAULT_SIZE_THRESHOLD = 512 * 1024 * 1024L;
+
+// Buffer size
+protected Integer bufferSize;
+// FileSystem
+protected HoodieStorage storage;
+// Size threshold for the log file. Useful when used with a rolling log
appender
+protected Long sizeThreshold;
+// Log File extension. Could be .avro.delta or .avro.commits etc
+protected String fileExtension;
+// File Id
+protected String logFileId;
+// File Commit Time stamp
+protected String instantTime;
+// version number for this log file. If not specified, then the current
version will be
+// computed by inspecting the file system
+protected Integer logVersion;
+// file len of this log file
Review Comment:
🤖 nit: the comment just above (`// file len of this log file`) is a leftover
from when this field was called `fileLen` — could you update it to match the
new `fileSize` name? On the same line, the `= 0L` inline initializer is
redundant since the constructor always assigns `this.fileSize = fileSize !=
null ? fileSize : 0L;`; all other fields in this class have no inline default,
so this one stands out and could mislead a reader into thinking the default is
set here rather than in the constructor.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelperV1.java:
##
@@ -311,9 +312,9 @@ List>
maybeDeleteAndCollectStats(HoodieEngineCo
// Let's emit markers for rollback as well. markers are emitted
under rollback instant time.
WriteMarkers writeMarkers =
WriteMarkersFactory.get(config.getMarkersType(), table, instantTime);
- HoodieLogFormat.WriterBuilder writerBuilder =
HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbs
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609703497 ## CI report: * f746c88417cd877ea8a6232be7eb78fc0bcc53a1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12211) * 75dc03bfe3528ff735f12d65b10cc823f1888c19 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14429) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-4609680655 ## CI report: * f746c88417cd877ea8a6232be7eb78fc0bcc53a1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12211) * 75dc03bfe3528ff735f12d65b10cc823f1888c19 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous closed pull request #17785: refactor: Add Lombok Builder annotation to HoodieLogFormat URL: https://github.com/apache/hudi/pull/17785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3944231649 ## CI report: * f746c88417cd877ea8a6232be7eb78fc0bcc53a1 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12211) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
codecov-commenter commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3944014477 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `52.2%` with `43 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 33.14%. Comparing base ([`ec04479`](https://app.codecov.io/gh/apache/hudi/commit/ec044790fe71f04710472ad63e7859f1b29e3985?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f746c88`](https://app.codecov.io/gh/apache/hudi/commit/f746c88417cd877ea8a6232be7eb78fc0bcc53a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 988 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/hudi/common/table/log/HoodieLogFormat.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormat.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXQuamF2YQ==) | 54.05% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-hadoop-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Flog%2FHoodieLogFormatWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NvbW1vbi90YWJsZS9sb2cvSG9vZGllTG9nRm9ybWF0V3JpdGVyLmphdmE=) | 62.06% | [7 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/table/action/rollback/RollbackHelper.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FRollbackHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9Sb2xsYmFja0hlbHBlci5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/rollback/RollbackHelperV1.java](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FRollbackHelperV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9Sb2xsYmFja0hlbHBlclYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (ec04479) and HEAD (f746c88). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (ec04479) | HEAD
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3943811591 ## CI report: * a6820fec73f5c58acf656c742a90998d3b7dc7f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11821) * f746c88417cd877ea8a6232be7eb78fc0bcc53a1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12211) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3943799700 ## CI report: * a6820fec73f5c58acf656c742a90998d3b7dc7f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11821) * f746c88417cd877ea8a6232be7eb78fc0bcc53a1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r2839918401
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -42,47 +43,45 @@
/**
* HoodieLogFormatWriter can be used to append blocks to a log file Use
HoodieLogFormat.WriterBuilder to construct.
*/
+@Getter
@Slf4j
-public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
+public class HoodieLogFormatWriter extends HoodieLogFormat.Writer {
- @Getter
- private HoodieLogFile logFile;
- private FSDataOutputStream output;
-
- private final HoodieStorage storage;
- @Getter
- private final long sizeThreshold;
- private final Integer bufferSize;
private final Short replication;
- private final String rolloverLogWriteToken;
- private final LogFileCreationCallback fileCreationHook;
+ private FSDataOutputStream outputStream;
private boolean closed = false;
private transient Thread shutdownThread = null;
- public HoodieLogFormatWriter(
- HoodieStorage storage,
- HoodieLogFile logFile,
+ @Builder(setterPrefix = "with")
+ private HoodieLogFormatWriter(
Integer bufferSize,
- Short replication,
+ HoodieStorage storage,
+ StoragePath parentPath,
+ String logFileId,
+ String fileExtension,
+ String instantTime,
+ Integer logVersion,
+ String logWriteToken,
+ String suffix,
+ Long fileLen,
Long sizeThreshold,
- String rolloverLogWriteToken,
- LogFileCreationCallback fileCreationHook) {
-this.storage = storage;
-this.logFile = logFile;
-this.sizeThreshold = sizeThreshold;
-this.bufferSize = bufferSize != null ? bufferSize :
storage.getDefaultBufferSize();
+ LogFileCreationCallback fileCreationCallback,
+ HoodieTableVersion tableVersion,
+ Short replication
+ ) throws IOException {
+super(bufferSize, storage, parentPath, logFileId, fileExtension,
instantTime, logVersion, logWriteToken,
+suffix, fileLen, sizeThreshold, fileCreationCallback, tableVersion);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r2839911257
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##
@@ -288,11 +289,11 @@ protected HoodieLogFormat.Writer createLogWriter(String
instantTime, Option fileSliceOpt) {
try {
if
(config.getWriteVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT)) {
-return HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
-.withFileId(fileId)
+return HoodieLogFormatWriter.builder()
+
.withParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
+.withLogFileId(fileId)
.withInstantTime(instantTime)
-.withFileSize(0L)
+.withFileLen(0L)
Review Comment:
Done
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##
@@ -305,12 +306,12 @@ protected HoodieLogFormat.Writer createLogWriter(String
instantTime, String file
Option latestLogFile = fileSliceOpt.isPresent()
? fileSliceOpt.get().getLatestLogFile()
: Option.empty();
-return HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
-.withFileId(fileId)
+return HoodieLogFormatWriter.builder()
+
.withParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
+.withLogFileId(fileId)
.withInstantTime(instantTime)
.withLogVersion(latestLogFile.map(HoodieLogFile::getLogVersion).orElse(HoodieLogFile.LOGFILE_BASE_VERSION))
-
.withFileSize(latestLogFile.map(HoodieLogFile::getFileSize).orElse(0L))
+
.withFileLen(latestLogFile.map(HoodieLogFile::getFileSize).orElse(0L))
Review Comment:
Done
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -42,47 +43,45 @@
/**
* HoodieLogFormatWriter can be used to append blocks to a log file Use
HoodieLogFormat.WriterBuilder to construct.
*/
+@Getter
@Slf4j
-public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
+public class HoodieLogFormatWriter extends HoodieLogFormat.Writer {
- @Getter
- private HoodieLogFile logFile;
- private FSDataOutputStream output;
-
- private final HoodieStorage storage;
- @Getter
- private final long sizeThreshold;
- private final Integer bufferSize;
private final Short replication;
- private final String rolloverLogWriteToken;
- private final LogFileCreationCallback fileCreationHook;
+ private FSDataOutputStream outputStream;
private boolean closed = false;
private transient Thread shutdownThread = null;
- public HoodieLogFormatWriter(
- HoodieStorage storage,
- HoodieLogFile logFile,
+ @Builder(setterPrefix = "with")
+ private HoodieLogFormatWriter(
Integer bufferSize,
- Short replication,
+ HoodieStorage storage,
+ StoragePath parentPath,
+ String logFileId,
+ String fileExtension,
+ String instantTime,
+ Integer logVersion,
+ String logWriteToken,
+ String suffix,
+ Long fileLen,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3874773416 ## CI report: * a6820fec73f5c58acf656c742a90998d3b7dc7f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11821) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3874752447 ## CI report: * a6820fec73f5c58acf656c742a90998d3b7dc7f9 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
CTTY commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r2785073571
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -42,47 +43,45 @@
/**
* HoodieLogFormatWriter can be used to append blocks to a log file Use
HoodieLogFormat.WriterBuilder to construct.
*/
+@Getter
@Slf4j
-public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
+public class HoodieLogFormatWriter extends HoodieLogFormat.Writer {
- @Getter
- private HoodieLogFile logFile;
- private FSDataOutputStream output;
-
- private final HoodieStorage storage;
- @Getter
- private final long sizeThreshold;
- private final Integer bufferSize;
private final Short replication;
- private final String rolloverLogWriteToken;
- private final LogFileCreationCallback fileCreationHook;
+ private FSDataOutputStream outputStream;
private boolean closed = false;
private transient Thread shutdownThread = null;
- public HoodieLogFormatWriter(
- HoodieStorage storage,
- HoodieLogFile logFile,
+ @Builder(setterPrefix = "with")
+ private HoodieLogFormatWriter(
Integer bufferSize,
- Short replication,
+ HoodieStorage storage,
+ StoragePath parentPath,
+ String logFileId,
+ String fileExtension,
+ String instantTime,
+ Integer logVersion,
+ String logWriteToken,
+ String suffix,
+ Long fileLen,
Review Comment:
Same here
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##
@@ -288,11 +289,11 @@ protected HoodieLogFormat.Writer createLogWriter(String
instantTime, Option fileSliceOpt) {
try {
if
(config.getWriteVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT)) {
-return HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
-.withFileId(fileId)
+return HoodieLogFormatWriter.builder()
+
.withParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
+.withLogFileId(fileId)
.withInstantTime(instantTime)
-.withFileSize(0L)
+.withFileLen(0L)
Review Comment:
Should we change these names back to `FileSize` as well
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##
@@ -305,12 +306,12 @@ protected HoodieLogFormat.Writer createLogWriter(String
instantTime, String file
Option latestLogFile = fileSliceOpt.isPresent()
? fileSliceOpt.get().getLatestLogFile()
: Option.empty();
-return HoodieLogFormat.newWriterBuilder()
-
.onParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
-.withFileId(fileId)
+return HoodieLogFormatWriter.builder()
+
.withParentPath(FSUtils.constructAbsolutePath(hoodieTable.getMetaClient().getBasePath(),
partitionPath))
+.withLogFileId(fileId)
.withInstantTime(instantTime)
.withLogVersion(latestLogFile.map(HoodieLogFile::getLogVersion).orElse(HoodieLogFile.LOGFILE_BASE_VERSION))
-
.withFileSize(latestLogFile.map(HoodieLogFile::getFileSize).orElse(0L))
+
.withFileLen(latestLogFile.map(HoodieLogFile::getFileSize).orElse(0L))
Review Comment:
Same here
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -42,47 +43,45 @@
/**
* HoodieLogFormatWriter can be used to append blocks to a log file Use
HoodieLogFormat.WriterBuilder to construct.
*/
+@Getter
@Slf4j
-public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
+public class HoodieLogFormatWriter extends HoodieLogFormat.Writer {
- @Getter
- private HoodieLogFile logFile;
- private FSDataOutputStream output;
-
- private final HoodieStorage storage;
- @Getter
- private final long sizeThreshold;
- private final Integer bufferSize;
private final Short replication;
- private final String rolloverLogWriteToken;
- private final LogFileCreationCallback fileCreationHook;
+ private FSDataOutputStream outputStream;
private boolean closed = false;
private transient Thread shutdownThread = null;
- public HoodieLogFormatWriter(
- HoodieStorage storage,
- HoodieLogFile logFile,
+ @Builder(setterPrefix = "with")
+ private HoodieLogFormatWriter(
Integer bufferSize,
- Short replication,
+ HoodieStorage storage,
+ StoragePath parentPath,
+ String logFileId,
+ String fileExtension,
+ String instantTime,
+ Integer logVersion,
+ String logWriteToken,
+ String suffix,
+ Long fileLen,
Long sizeThreshold,
- String rolloverLogWriteToken,
- LogFileCreation
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3866072564 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 156968af152bc8e6058553e0b0faa3968553f0b0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11076) * a6820fec73f5c58acf656c742a90998d3b7dc7f9 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r2692917096
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -42,47 +43,46 @@
/**
* HoodieLogFormatWriter can be used to append blocks to a log file Use
HoodieLogFormat.WriterBuilder to construct.
*/
+@Getter
@Slf4j
-public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
+public class HoodieLogFormatWriter extends HoodieLogFormat.Writer {
- @Getter
- private HoodieLogFile logFile;
- private FSDataOutputStream output;
-
- private final HoodieStorage storage;
- @Getter
- private final long sizeThreshold;
- private final Integer bufferSize;
private final Short replication;
- private final String rolloverLogWriteToken;
- private final LogFileCreationCallback fileCreationHook;
+ private FSDataOutputStream outputStream;
private boolean closed = false;
private transient Thread shutdownThread = null;
- public HoodieLogFormatWriter(
- HoodieStorage storage,
- HoodieLogFile logFile,
+ @Builder(setterPrefix = "with")
+ private HoodieLogFormatWriter(
Integer bufferSize,
- Short replication,
+ HoodieStorage storage,
+ StoragePath parentPath,
+ String logFileId,
+ String fileExtension,
+ String instantTime,
+ Integer logVersion,
+ String logWriteToken,
+ String suffix,
+ Long fileLen,
Long sizeThreshold,
- String rolloverLogWriteToken,
- LogFileCreationCallback fileCreationHook) {
-this.storage = storage;
-this.logFile = logFile;
-this.sizeThreshold = sizeThreshold;
-this.bufferSize = bufferSize != null ? bufferSize :
storage.getDefaultBufferSize();
+ LogFileCreationCallback fileCreationCallback,
+ HoodieTableVersion tableVersion,
+ FSDataOutputStream outputStream,
+ Short replication
+ ) throws IOException {
+super(bufferSize, storage, parentPath, logFileId, fileExtension,
instantTime, logVersion, logWriteToken,
+suffix, fileLen, sizeThreshold, fileCreationCallback, tableVersion);
+this.outputStream = outputStream;
Review Comment:
Oh good catch. Removed this and added a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3753003553 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 156968af152bc8e6058553e0b0faa3968553f0b0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11076) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3752807335 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 857cb708e35d6257baa41733686ba39ab6029843 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10934) * 156968af152bc8e6058553e0b0faa3968553f0b0 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3752862418 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 857cb708e35d6257baa41733686ba39ab6029843 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10934) * 156968af152bc8e6058553e0b0faa3968553f0b0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11076) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
voonhous commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r2692904987
##
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java:
##
@@ -60,241 +60,166 @@ public interface HoodieLogFormat {
String DEFAULT_WRITE_TOKEN = "0-0-0";
- String DEFAULT_LOG_FORMAT_WRITER =
"org.apache.hudi.common.table.log.HoodieLogFormatWriter";
-
- /**
- * Writer interface to allow appending block to this file format.
- */
- interface Writer extends Closeable {
-
-/**
- * @return the path to the current {@link HoodieLogFile} being written to.
- */
-HoodieLogFile getLogFile();
-
-/**
- * Append Block to a log file.
- * @return {@link AppendResult} containing result of the append.
- */
-AppendResult appendBlock(HoodieLogBlock block) throws IOException,
InterruptedException;
-
-/**
- * Appends the list of blocks to a logfile.
- * @return {@link AppendResult} containing result of the append.
- */
-AppendResult appendBlocks(List blocks) throws IOException,
InterruptedException;
-
-long getCurrentSize() throws IOException;
- }
-
- /**
- * Reader interface which is an Iterator of HoodieLogBlock.
- */
- interface Reader extends Closeable, Iterator {
-
-/**
- * @return the path to this {@link HoodieLogFormat}
- */
-HoodieLogFile getLogFile();
-
-/**
- * Read log file in reverse order and check if prev block is present.
- *
- * @return {@code true} if previous block is present, {@code false}
otherwise.
- */
-boolean hasPrev();
-
-/**
- * Read log file in reverse order and return prev block if present.
- *
- * @return {@link HoodieLogBlock} the previous block
- * @throws IOException
- */
-HoodieLogBlock prev() throws IOException;
- }
-
/**
- * Builder class to construct the default log format writer.
+ * Abstract base class for appending blocks to the Hoodie log format.
+ * Subclasses provide specific implementations for writing to different
storage layers.
*/
- class WriterBuilder {
+ @Getter
+ @Slf4j
+ abstract class Writer implements Closeable {
-private static final Logger LOG =
LoggerFactory.getLogger(WriterBuilder.class);
// Default max log file size 512 MB
public static final long DEFAULT_SIZE_THRESHOLD = 512 * 1024 * 1024L;
// Buffer size
-private Integer bufferSize;
+protected Integer bufferSize;
// FileSystem
-private HoodieStorage storage;
+protected HoodieStorage storage;
// Size threshold for the log file. Useful when used with a rolling log
appender
-private Long sizeThreshold;
+protected Long sizeThreshold;
// Log File extension. Could be .avro.delta or .avro.commits etc
-private String fileExtension;
+protected String fileExtension;
// File Id
-private String logFileId;
+protected String logFileId;
// File Commit Time stamp
-private String instantTime;
+protected String instantTime;
// version number for this log file. If not specified, then the current
version will be
// computed by inspecting the file system
-private Integer logVersion;
+protected Integer logVersion;
// file len of this log file
-private Long fileLen = 0L;
+protected Long fileLen = 0L;
Review Comment:
Yeap, we should standardise the naming. In the other `hudi-common` Lombok
refactoring, i've changed them to `getFileSize` too, so this makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
CTTY commented on code in PR #17785:
URL: https://github.com/apache/hudi/pull/17785#discussion_r2692466235
##
hudi-hadoop-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##
@@ -42,47 +43,46 @@
/**
* HoodieLogFormatWriter can be used to append blocks to a log file Use
HoodieLogFormat.WriterBuilder to construct.
*/
+@Getter
@Slf4j
-public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
+public class HoodieLogFormatWriter extends HoodieLogFormat.Writer {
- @Getter
- private HoodieLogFile logFile;
- private FSDataOutputStream output;
-
- private final HoodieStorage storage;
- @Getter
- private final long sizeThreshold;
- private final Integer bufferSize;
private final Short replication;
- private final String rolloverLogWriteToken;
- private final LogFileCreationCallback fileCreationHook;
+ private FSDataOutputStream outputStream;
private boolean closed = false;
private transient Thread shutdownThread = null;
- public HoodieLogFormatWriter(
- HoodieStorage storage,
- HoodieLogFile logFile,
+ @Builder(setterPrefix = "with")
+ private HoodieLogFormatWriter(
Integer bufferSize,
- Short replication,
+ HoodieStorage storage,
+ StoragePath parentPath,
+ String logFileId,
+ String fileExtension,
+ String instantTime,
+ Integer logVersion,
+ String logWriteToken,
+ String suffix,
+ Long fileLen,
Long sizeThreshold,
- String rolloverLogWriteToken,
- LogFileCreationCallback fileCreationHook) {
-this.storage = storage;
-this.logFile = logFile;
-this.sizeThreshold = sizeThreshold;
-this.bufferSize = bufferSize != null ? bufferSize :
storage.getDefaultBufferSize();
+ LogFileCreationCallback fileCreationCallback,
+ HoodieTableVersion tableVersion,
+ FSDataOutputStream outputStream,
+ Short replication
+ ) throws IOException {
+super(bufferSize, storage, parentPath, logFileId, fileExtension,
instantTime, logVersion, logWriteToken,
+suffix, fileLen, sizeThreshold, fileCreationCallback, tableVersion);
+this.outputStream = outputStream;
Review Comment:
This doesn't seem right, `outputStream` should be initialized lazily rather
than set like this
##
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormat.java:
##
@@ -60,241 +60,166 @@ public interface HoodieLogFormat {
String DEFAULT_WRITE_TOKEN = "0-0-0";
- String DEFAULT_LOG_FORMAT_WRITER =
"org.apache.hudi.common.table.log.HoodieLogFormatWriter";
-
- /**
- * Writer interface to allow appending block to this file format.
- */
- interface Writer extends Closeable {
-
-/**
- * @return the path to the current {@link HoodieLogFile} being written to.
- */
-HoodieLogFile getLogFile();
-
-/**
- * Append Block to a log file.
- * @return {@link AppendResult} containing result of the append.
- */
-AppendResult appendBlock(HoodieLogBlock block) throws IOException,
InterruptedException;
-
-/**
- * Appends the list of blocks to a logfile.
- * @return {@link AppendResult} containing result of the append.
- */
-AppendResult appendBlocks(List blocks) throws IOException,
InterruptedException;
-
-long getCurrentSize() throws IOException;
- }
-
- /**
- * Reader interface which is an Iterator of HoodieLogBlock.
- */
- interface Reader extends Closeable, Iterator {
-
-/**
- * @return the path to this {@link HoodieLogFormat}
- */
-HoodieLogFile getLogFile();
-
-/**
- * Read log file in reverse order and check if prev block is present.
- *
- * @return {@code true} if previous block is present, {@code false}
otherwise.
- */
-boolean hasPrev();
-
-/**
- * Read log file in reverse order and return prev block if present.
- *
- * @return {@link HoodieLogBlock} the previous block
- * @throws IOException
- */
-HoodieLogBlock prev() throws IOException;
- }
-
/**
- * Builder class to construct the default log format writer.
+ * Abstract base class for appending blocks to the Hoodie log format.
+ * Subclasses provide specific implementations for writing to different
storage layers.
*/
- class WriterBuilder {
+ @Getter
+ @Slf4j
+ abstract class Writer implements Closeable {
-private static final Logger LOG =
LoggerFactory.getLogger(WriterBuilder.class);
// Default max log file size 512 MB
public static final long DEFAULT_SIZE_THRESHOLD = 512 * 1024 * 1024L;
// Buffer size
-private Integer bufferSize;
+protected Integer bufferSize;
// FileSystem
-private HoodieStorage storage;
+protected HoodieStorage storage;
// Size threshold for the log file. Useful when used with a rolling log
appender
-private Long sizeThreshold;
+protected Long sizeThreshold;
// Log File extension. Could be .avro.delta or .av
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3734536650 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 857cb708e35d6257baa41733686ba39ab6029843 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10934) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3734448966 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 342a043134f020ff924ca04f80f377b808d25f7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10857) * 857cb708e35d6257baa41733686ba39ab6029843 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10934) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3734417296 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 342a043134f020ff924ca04f80f377b808d25f7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10857) * 857cb708e35d6257baa41733686ba39ab6029843 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3723432463 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * 342a043134f020ff924ca04f80f377b808d25f7b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10857) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3723031300 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * fee094e069219058256234f672fbff143f45d770 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10801) * 342a043134f020ff924ca04f80f377b808d25f7b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10857) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3723005361 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * fee094e069219058256234f672fbff143f45d770 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10801) * 342a043134f020ff924ca04f80f377b808d25f7b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3710242307 ## CI report: * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * fee094e069219058256234f672fbff143f45d770 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10801) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709860614 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10800) * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * fee094e069219058256234f672fbff143f45d770 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10801) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709734957 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10800) * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN * fee094e069219058256234f672fbff143f45d770 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709672851 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10800) * d21169cd882f0c4715c992406964105e3be4da48 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709645017 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10800) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709617875 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10800) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709617854 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10800) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok Builder annotation to HoodieLogFormat [hudi]
hudi-bot commented on PR #17785: URL: https://github.com/apache/hudi/pull/17785#issuecomment-3709610276 ## CI report: * 7b1a0281ad199bf72f8f4b4e1a74c1177af5945d UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
