Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous merged PR #17825: URL: https://github.com/apache/hudi/pull/17825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-agent commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r3348115610
##
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##
@@ -77,28 +81,53 @@
*and {@code RowData} in Flink.
*/
public abstract class HoodieReaderContext {
+
+ @Getter
private final StorageConfiguration storageConfiguration;
protected final HoodieFileFormat baseFileFormat;
// For general predicate pushdown.
+ @Getter
protected final Option keyFilterOpt;
protected final HoodieTableConfig tableConfig;
+ @Setter
private String tablePath = null;
+ @Getter
+ @Setter
private String latestCommitTime = null;
+ @Getter
+ @Setter
private Option recordMerger = null;
+ @Getter
+ @Setter
private Boolean hasLogFiles = null;
+ @Getter
+ @Setter
private Boolean hasBootstrapBaseFile = null;
+ @Getter
+ @Setter
private Boolean needsBootstrapMerge = null;
+ @Getter
+ @Setter
// should we do position based merging for mor
private Boolean shouldMergeUseRecordPosition = null;
protected Option instantRangeOpt;
+ @Getter
private RecordMergeMode mergeMode;
+ @Getter
protected RecordContext recordContext;
+ @Getter
+ @Setter
private FileGroupReaderSchemaHandler schemaHandler = null;
// the default iterator mode is engine-specific record mode
+ @Setter
private IteratorMode iteratorMode = IteratorMode.ENGINE_RECORD;
+ @Getter
protected final HoodieConfig hoodieReaderConfig;
- private boolean enableLogicalTimestampFieldRepair = true;
+ @Getter
+ @Setter
+ @Accessors(fluent = true)
+ private Boolean enableLogicalTimestampFieldRepair = true;
Review Comment:
🤖 nit: was there a reason to change this from primitive `boolean` to boxed
`Boolean`? It's defaulted to `true` and never appears to need a null state, so
keeping it `boolean` would avoid unnecessary autoboxing on the Scala caller
side and make the type as expressive as the original.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieBaseListData.java:
##
@@ -34,6 +35,7 @@
*
* @param Object value type.
*/
+@Slf4j
public abstract class HoodieBaseListData {
Review Comment:
🤖 nit: the outer class doesn't appear to use `log` anywhere — only the inner
`IteratorCloser` does (which has its own `@Slf4j`). Could you drop `@Slf4j`
from the outer class to avoid generating an unused logger?
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610882398 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029100 -60 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610862024 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029100 -60 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610742639 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029100 -60 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610748751 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029100 -60 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610371848 ## CI report: * 627a81f0197d55e423dde8b62163e15071079bf5 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14430) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610277255 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029100 -60 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610248878 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.76%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.76% -0.05% + Complexity2916029098 -62 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610161860 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.14%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.14% -0.67% + Complexity2916028816 -344 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610157648 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.14%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.14% -0.67% + Complexity2916028816 -344 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610152657 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.09%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.09% -0.72% + Complexity2916028787 -373 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610140441 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.03%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.03% -0.78% + Complexity2916028756 -404 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610134692 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.03%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.03% -0.78% + Complexity2916028756 -404 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610127506 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.88%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 67.88% -0.93% + Complexity2916028698 -462 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610121851 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.94%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 65.94% -2.87% + Complexity2916027855-1305 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610130990 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.91%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 67.91% -0.90% + Complexity2916028701 -459 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917208 -1 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-461000 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.36%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (627a81f). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (627a81f) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## ===
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610054533 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.36%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (627a81f). Click for more details. > > HEAD has 16 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (627a81f) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## ===
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610042500 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.84%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (627a81f). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (627a81f) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## ===
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610041061 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 60.84%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (627a81f). Click for more details. > > HEAD has 18 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (627a81f) | >|--|--|--| >|spark-scala-tests|12|3| >|spark-java-tests|15|6| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## ===
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610017455 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.54%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610014589 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 47.51%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610006704 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.26%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610005710 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.26%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4610002679 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 48.08%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-461418 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.33%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609996675 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.0%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 37.52%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609918874 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `63.3%` with `22 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 29.46%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609908168 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `63.3%` with `22 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 30.14%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609833820 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `64.40678%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`627a81f`](https://app.codecov.io/gh/apache/hudi/commit/627a81f0197d55e423dde8b62163e15071079bf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609824773 ## CI report: * bb6d446339916e52786db8220a1928d412f864b4 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14428) * 627a81f0197d55e423dde8b62163e15071079bf5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14430) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609774684 ## CI report: * 145d5d086f3220add03dcd0a2e1921d7fff16844 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14427) * bb6d446339916e52786db8220a1928d412f864b4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14428) * 627a81f0197d55e423dde8b62163e15071079bf5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14430) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609750442 ## CI report: * 145d5d086f3220add03dcd0a2e1921d7fff16844 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14427) * bb6d446339916e52786db8220a1928d412f864b4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14428) * 627a81f0197d55e423dde8b62163e15071079bf5 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r3346413314
##
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##
@@ -77,28 +81,53 @@
*and {@code RowData} in Flink.
*/
public abstract class HoodieReaderContext {
+
+ @Getter
private final StorageConfiguration storageConfiguration;
protected final HoodieFileFormat baseFileFormat;
// For general predicate pushdown.
+ @Getter
protected final Option keyFilterOpt;
protected final HoodieTableConfig tableConfig;
+ @Setter
private String tablePath = null;
+ @Getter
+ @Setter
private String latestCommitTime = null;
+ @Getter
+ @Setter
private Option recordMerger = null;
+ @Getter
+ @Setter
private Boolean hasLogFiles = null;
+ @Getter
+ @Setter
private Boolean hasBootstrapBaseFile = null;
+ @Getter
+ @Setter
private Boolean needsBootstrapMerge = null;
+ @Getter
+ @Setter
// should we do position based merging for mor
private Boolean shouldMergeUseRecordPosition = null;
protected Option instantRangeOpt;
+ @Getter
private RecordMergeMode mergeMode;
+ @Getter
protected RecordContext recordContext;
+ @Getter
+ @Setter
private FileGroupReaderSchemaHandler schemaHandler = null;
// the default iterator mode is engine-specific record mode
+ @Setter
private IteratorMode iteratorMode = IteratorMode.ENGINE_RECORD;
+ @Getter
protected final HoodieConfig hoodieReaderConfig;
- private boolean enableLogicalTimestampFieldRepair = true;
+ @Getter
Review Comment:
`isEnableLogicalTimestampFieldRepair` is not generated. without fluent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r3346404172
##
hudi-common/src/main/java/org/apache/hudi/common/HoodieCleanStat.java:
##
@@ -19,207 +19,45 @@
package org.apache.hudi.common;
import org.apache.hudi.common.model.HoodieCleaningPolicy;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
import org.apache.hudi.common.util.CollectionUtils;
-import org.apache.hudi.common.util.Option;
+
+import lombok.Builder;
+import lombok.Value;
import java.io.Serializable;
import java.util.List;
/**
* Collects stats about a single partition clean operation.
*/
+@Builder(setterPrefix = "with")
+@Value
public class HoodieCleanStat implements Serializable {
// Policy used
- private final HoodieCleaningPolicy policy;
+ HoodieCleaningPolicy policy;
// Partition path cleaned
- private final String partitionPath;
+ String partitionPath;
// The patterns that were generated for the delete operation
- private final List deletePathPatterns;
- private final List successDeleteFiles;
- // Files that could not be deleted
- private final List failedDeleteFiles;
- // Bootstrap Base Path patterns that were generated for the delete operation
- private final List deleteBootstrapBasePathPatterns;
- private final List successDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List deletePathPatterns = CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteFiles = CollectionUtils.createImmutableList();
// Files that could not be deleted
- private final List failedDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List failedDeleteFiles = CollectionUtils.createImmutableList();
// Earliest commit that was retained in this clean
- private final String earliestCommitToRetain;
+ String earliestCommitToRetain;
// Last completed commit timestamp before clean
- private final String lastCompletedCommitTimestamp;
+ String lastCompletedCommitTimestamp;
+ // Bootstrap Base Path patterns that were generated for the delete operation
+ @Builder.Default
+ List deleteBootstrapBasePathPatterns =
CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();
+ // Files that could not be deleted
+ @Builder.Default
+ List failedDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();
// set to true if partition is deleted
- private final boolean isPartitionDeleted;
-
- public HoodieCleanStat(HoodieCleaningPolicy policy, String partitionPath,
List deletePathPatterns,
- List successDeleteFiles, List failedDeleteFiles, String
earliestCommitToRetain,String lastCompletedCommitTimestamp) {
-this(policy, partitionPath, deletePathPatterns, successDeleteFiles,
failedDeleteFiles, earliestCommitToRetain,
-lastCompletedCommitTimestamp, CollectionUtils.createImmutableList(),
CollectionUtils.createImmutableList(),
-CollectionUtils.createImmutableList(), false);
- }
-
- public HoodieCleanStat(HoodieCleaningPolicy policy, String partitionPath,
List deletePathPatterns,
- List successDeleteFiles, List
failedDeleteFiles,
- String earliestCommitToRetain,String
lastCompletedCommitTimestamp,
- List deleteBootstrapBasePathPatterns,
- List successDeleteBootstrapBaseFiles,
- List failedDeleteBootstrapBaseFiles,
- boolean isPartitionDeleted) {
-this.policy = policy;
-this.partitionPath = partitionPath;
-this.deletePathPatterns = deletePathPatterns;
-this.successDeleteFiles = successDeleteFiles;
-this.failedDeleteFiles = failedDeleteFiles;
-this.earliestCommitToRetain = earliestCommitToRetain;
-this.lastCompletedCommitTimestamp = lastCompletedCommitTimestamp;
-this.deleteBootstrapBasePathPatterns = deleteBootstrapBasePathPatterns;
-this.successDeleteBootstrapBaseFiles = successDeleteBootstrapBaseFiles;
-this.failedDeleteBootstrapBaseFiles = failedDeleteBootstrapBaseFiles;
-this.isPartitionDeleted = isPartitionDeleted;
- }
-
- public HoodieCleaningPolicy getPolicy() {
-return policy;
- }
-
- public String getPartitionPath() {
-return partitionPath;
- }
-
- public List getDeletePathPatterns() {
-return deletePathPatterns;
- }
-
- public List getSuccessDeleteFiles() {
-return successDeleteFiles;
- }
-
- public List getFailedDeleteFiles() {
-return failedDeleteFiles;
- }
-
- public List getDeleteBootstrapBasePathPatterns() {
-return deleteBootstrapBasePathPatterns;
- }
-
- public List getSuccessDeleteBootstrapBaseFiles() {
-return successDeleteBootstrapBaseFiles;
- }
-
- public List getFailedDeleteBootstrapBaseFiles() {
-return failedDeleteBootstrapBaseFiles;
- }
-
- public String getEarliestCommitToRetain() {
-return earliestCommitToRetain;
- }
-
- public String
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-agent commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r3346346491
##
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##
@@ -77,28 +81,53 @@
*and {@code RowData} in Flink.
*/
public abstract class HoodieReaderContext {
+
+ @Getter
private final StorageConfiguration storageConfiguration;
protected final HoodieFileFormat baseFileFormat;
// For general predicate pushdown.
+ @Getter
protected final Option keyFilterOpt;
protected final HoodieTableConfig tableConfig;
+ @Setter
private String tablePath = null;
+ @Getter
+ @Setter
private String latestCommitTime = null;
+ @Getter
+ @Setter
private Option recordMerger = null;
+ @Getter
+ @Setter
private Boolean hasLogFiles = null;
+ @Getter
+ @Setter
private Boolean hasBootstrapBaseFile = null;
+ @Getter
+ @Setter
private Boolean needsBootstrapMerge = null;
+ @Getter
+ @Setter
// should we do position based merging for mor
private Boolean shouldMergeUseRecordPosition = null;
protected Option instantRangeOpt;
+ @Getter
private RecordMergeMode mergeMode;
+ @Getter
protected RecordContext recordContext;
+ @Getter
+ @Setter
private FileGroupReaderSchemaHandler schemaHandler = null;
// the default iterator mode is engine-specific record mode
+ @Setter
private IteratorMode iteratorMode = IteratorMode.ENGINE_RECORD;
+ @Getter
protected final HoodieConfig hoodieReaderConfig;
- private boolean enableLogicalTimestampFieldRepair = true;
+ @Getter
Review Comment:
🤖 nit: `@Accessors(fluent = true)` on this single field makes it the only
one in the class that doesn't use `get`/`set` naming — every other field here
uses standard accessor prefixes. A future caller has no way to know that this
flag needs `readerContext.enableLogicalTimestampFieldRepair(true)` while
everything else uses `readerContext.setXxx(...)`. Could you drop the fluent
annotation and use a straightforward `@Getter`/`@Setter` (which would generate
`isEnableLogicalTimestampFieldRepair()` /
`setEnableLogicalTimestampFieldRepair(...)`)? Renaming to
`logicalTimestampFieldRepairEnabled` might also read more naturally.
- AI-generated; verify before applying. React 👍/👎 to flag
quality.
##
hudi-common/src/main/java/org/apache/hudi/common/HoodieCleanStat.java:
##
@@ -19,207 +19,45 @@
package org.apache.hudi.common;
import org.apache.hudi.common.model.HoodieCleaningPolicy;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
import org.apache.hudi.common.util.CollectionUtils;
-import org.apache.hudi.common.util.Option;
+
+import lombok.Builder;
+import lombok.Value;
import java.io.Serializable;
import java.util.List;
/**
* Collects stats about a single partition clean operation.
*/
+@Builder(setterPrefix = "with")
+@Value
public class HoodieCleanStat implements Serializable {
// Policy used
- private final HoodieCleaningPolicy policy;
+ HoodieCleaningPolicy policy;
// Partition path cleaned
- private final String partitionPath;
+ String partitionPath;
// The patterns that were generated for the delete operation
- private final List deletePathPatterns;
- private final List successDeleteFiles;
- // Files that could not be deleted
- private final List failedDeleteFiles;
- // Bootstrap Base Path patterns that were generated for the delete operation
- private final List deleteBootstrapBasePathPatterns;
- private final List successDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List deletePathPatterns = CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteFiles = CollectionUtils.createImmutableList();
// Files that could not be deleted
- private final List failedDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List failedDeleteFiles = CollectionUtils.createImmutableList();
// Earliest commit that was retained in this clean
- private final String earliestCommitToRetain;
+ String earliestCommitToRetain;
// Last completed commit timestamp before clean
- private final String lastCompletedCommitTimestamp;
+ String lastCompletedCommitTimestamp;
+ // Bootstrap Base Path patterns that were generated for the delete operation
+ @Builder.Default
+ List deleteBootstrapBasePathPatterns =
CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();
+ // Files that could not be deleted
+ @Builder.Default
+ List failedDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();
// set to true if partition is deleted
- private final boolean isPartitionDeleted;
-
- public HoodieCleanStat(HoodieCleaningPolicy policy, String partitionPath,
List deletePathPatterns,
- List successDeleteFiles, List failedDeleteFiles, String
earliestCommitToRetain,String lastCompletedCommitTimestamp) {
-this(policy, partitionPath, delete
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609497674 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029110 -50 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609480866 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029109 -51 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609402009 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.77% -0.04% + Complexity2916029109 -51 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609392774 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.73%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.73% -0.08% + Complexity2916029086 -74 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609388678 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.72%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.72% -0.09% + Complexity2916029080 -80 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609379272 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.69%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.69% -0.12% + Complexity2916029068 -92 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609377073 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.69%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.69% -0.12% + Complexity2916029068 -92 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609373996 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.64%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.64% -0.17% + Complexity2916029042 -118 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609360128 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.63%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.63% -0.18% + Complexity2916029042 -118 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609358956 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.63%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.63% -0.18% + Complexity2916029042 -118 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609350052 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.45%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.45% -0.36% + Complexity2916028935 -225 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609354589 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.0%` with `6 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.54%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 68.54% -0.27% + Complexity2916028990 -170 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609347690 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.66%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 67.66% -1.15% + Complexity2916028612 -548 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609337968 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.80%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## - Coverage 68.81% 65.80% -3.01% + Complexity2916027839-1321 Files 2520 2518 -2 Lines140056 139887 -169 Branches 1720917205 -4 ==
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609301678 ## CI report: * 145d5d086f3220add03dcd0a2e1921d7fff16844 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14427) * bb6d446339916e52786db8220a1928d412f864b4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14428) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609301362 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.23%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (bb6d446). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (bb6d446) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## ===
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609300015 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.3%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.23%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (b7adecc) and HEAD (bb6d446). Click for more details. > > HEAD has 17 uploads less than BASE > >| Flag | BASE (b7adecc) | HEAD (bb6d446) | >|--|--|--| >|spark-scala-tests|12|5| >|spark-java-tests|15|5| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17825 +/- ## ===
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609285139 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.48%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609283731 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.48%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609279531 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.45%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609263948 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.41%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609262372 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.37%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609261456 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 54.25%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609257210 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.34%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609252017 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.04%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609249985 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.7%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 49.07%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609244750 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `86.44068%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 53.75%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2RhdGEvSG9vZGllQmFzZUxpc3REYXRhLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/java/org/apache/hudi/common/fs/FSUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFSUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZTVXRpbHMuamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/hudi/common/heartbeat/HoodieHeartbeatUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fheartbeat%2FHoodieHeartbeatUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2hlYXJ0YmVhdC9Ib29kaWVIZWFydGJlYXRVdGlscy5qYXZh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609121610 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `64.40678%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.77%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb6d446`](https://app.codecov.io/gh/apache/hudi/commit/bb6d446339916e52786db8220a1928d412f864b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609063950 ## CI report: * 145d5d086f3220add03dcd0a2e1921d7fff16844 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14427) * bb6d446339916e52786db8220a1928d412f864b4 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609044472 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `64.40678%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.78%. Comparing base ([`b7adecc`](https://app.codecov.io/gh/apache/hudi/commit/b7adeccfbb5ea6af5f41369bd452fdb326a37b04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`145d5d0`](https://app.codecov.io/gh/apache/hudi/commit/145d5d086f3220add03dcd0a2e1921d7fff16844?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4609015526 ## CI report: * 145d5d086f3220add03dcd0a2e1921d7fff16844 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14427) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4608998666 ## CI report: * b6059b1c54aa9a6cff0a88e74ce5c2f308b23887 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12197) * 145d5d086f3220add03dcd0a2e1921d7fff16844 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4341732450 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.87097%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.63%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 204 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4341731786 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.87097%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.63%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 204 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-4308109432 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.87097%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.63%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 178 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous closed pull request #17825: refactor: Add Lombok annotations to hudi-common module (part 3) URL: https://github.com/apache/hudi/pull/17825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941945269 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.0%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.22%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2h
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941474201 ## CI report: * b6059b1c54aa9a6cff0a88e74ce5c2f308b23887 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12197) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941458052 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.0%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.22%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2h
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941452624 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.0%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.21%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2h
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941450720 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `85.0%` with `9 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.20%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/hudi/common/data/HoodieBaseListData.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fdata%2FHoodieBaseListData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2h
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941436561 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `76.7%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.49%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941432540 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `76.7%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.42%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941432268 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `76.7%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.39%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941431988 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `76.7%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 51.81%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941431295 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `76.7%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 51.76%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941431170 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `76.7%` with `14 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 51.67%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4LmphdmE=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941417887 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `20 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.47%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941417717 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.7%` with `20 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.36%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...mon/bootstrap/index/hfile/HFileBootstrapIndex.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941413156 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `65.0%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 40.08%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941413475 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `65.0%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 39.64%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941412043 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `65.0%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 40.43%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
codecov-commenter commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941373873 ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `64.40678%` with `21 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.32%. Comparing base ([`057af9e`](https://app.codecov.io/gh/apache/hudi/commit/057af9e0694dd40ad0ec65128b18f93f4ee20c19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6059b1`](https://app.codecov.io/gh/apache/hudi/commit/b6059b1c54aa9a6cff0a88e74ce5c2f308b23887?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17825?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...otstrap/index/hfile/HFileBootstrapIndexWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4V3JpdGVyLmphdmE=) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/hudi/common/fs/FailSafeConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FFailSafeConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0ZhaWxTYWZlQ29uc2lzdGVuY3lHdWFyZC5qYXZh) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...otstrap/index/hfile/HFileBootstrapIndexReader.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fbootstrap%2Findex%2Fhfile%2FHFileBootstrapIndexReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2Jvb3RzdHJhcC9pbmRleC9oZmlsZS9IRmlsZUJvb3RzdHJhcEluZGV4UmVhZGVyLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../detection/DirectMarkerBasedDetectionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Fconflict%2Fdetection%2FDirectMarkerBasedDetectionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2NvbmZsaWN0L2RldGVjdGlvbi9EaXJlY3RNYXJrZXJCYXNlZERldGVjdGlvblN0cmF0ZWd5LmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/hudi/common/fs/OptimisticConsistencyGuard.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ffs%2FOptimisticConsistencyGuard.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL09wdGltaXN0aWNDb25zaXN0ZW5jeUd1YXJkLmphdmE=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/17825?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apa
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941359469 ## CI report: * e65ab593964bc7d5cea94f70be64592623a25259 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11818) * b6059b1c54aa9a6cff0a88e74ce5c2f308b23887 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12197) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3941356259 ## CI report: * e65ab593964bc7d5cea94f70be64592623a25259 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11818) * b6059b1c54aa9a6cff0a88e74ce5c2f308b23887 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3874687484 ## CI report: * e65ab593964bc7d5cea94f70be64592623a25259 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11818) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3866046882 ## CI report: * ccc6a1506c9c8f1f59bc235734f9f7e22245f0b8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11578) * e65ab593964bc7d5cea94f70be64592623a25259 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r2778418878
##
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##
@@ -75,12 +80,22 @@
* @param The type of engine-specific record representation, e.g.,{@code
InternalRow} in Spark
*and {@code RowData} in Flink.
*/
+@Getter
+@Setter
Review Comment:
It's a mix and match. I'll make the getter/setter field level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r2778417526
##
hudi-common/src/main/java/org/apache/hudi/common/HoodieCleanStat.java:
##
@@ -19,207 +19,45 @@
package org.apache.hudi.common;
import org.apache.hudi.common.model.HoodieCleaningPolicy;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
import org.apache.hudi.common.util.CollectionUtils;
-import org.apache.hudi.common.util.Option;
+
+import lombok.Builder;
+import lombok.Value;
import java.io.Serializable;
import java.util.List;
/**
* Collects stats about a single partition clean operation.
*/
+@Builder(setterPrefix = "with")
+@Value
public class HoodieCleanStat implements Serializable {
// Policy used
- private final HoodieCleaningPolicy policy;
+ HoodieCleaningPolicy policy;
// Partition path cleaned
- private final String partitionPath;
+ String partitionPath;
// The patterns that were generated for the delete operation
- private final List deletePathPatterns;
- private final List successDeleteFiles;
- // Files that could not be deleted
- private final List failedDeleteFiles;
- // Bootstrap Base Path patterns that were generated for the delete operation
- private final List deleteBootstrapBasePathPatterns;
- private final List successDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List deletePathPatterns = CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteFiles = CollectionUtils.createImmutableList();
// Files that could not be deleted
- private final List failedDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List failedDeleteFiles = CollectionUtils.createImmutableList();
// Earliest commit that was retained in this clean
- private final String earliestCommitToRetain;
+ String earliestCommitToRetain;
// Last completed commit timestamp before clean
- private final String lastCompletedCommitTimestamp;
+ String lastCompletedCommitTimestamp;
+ // Bootstrap Base Path patterns that were generated for the delete operation
+ @Builder.Default
+ List deleteBootstrapBasePathPatterns =
CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();;
Review Comment:
Fixed
##
hudi-common/src/main/java/org/apache/hudi/common/HoodieCleanStat.java:
##
@@ -19,207 +19,45 @@
package org.apache.hudi.common;
import org.apache.hudi.common.model.HoodieCleaningPolicy;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
import org.apache.hudi.common.util.CollectionUtils;
-import org.apache.hudi.common.util.Option;
+
+import lombok.Builder;
+import lombok.Value;
import java.io.Serializable;
import java.util.List;
/**
* Collects stats about a single partition clean operation.
*/
+@Builder(setterPrefix = "with")
+@Value
public class HoodieCleanStat implements Serializable {
// Policy used
- private final HoodieCleaningPolicy policy;
+ HoodieCleaningPolicy policy;
// Partition path cleaned
- private final String partitionPath;
+ String partitionPath;
// The patterns that were generated for the delete operation
- private final List deletePathPatterns;
- private final List successDeleteFiles;
- // Files that could not be deleted
- private final List failedDeleteFiles;
- // Bootstrap Base Path patterns that were generated for the delete operation
- private final List deleteBootstrapBasePathPatterns;
- private final List successDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List deletePathPatterns = CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteFiles = CollectionUtils.createImmutableList();
// Files that could not be deleted
- private final List failedDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List failedDeleteFiles = CollectionUtils.createImmutableList();
// Earliest commit that was retained in this clean
- private final String earliestCommitToRetain;
+ String earliestCommitToRetain;
// Last completed commit timestamp before clean
- private final String lastCompletedCommitTimestamp;
+ String lastCompletedCommitTimestamp;
+ // Bootstrap Base Path patterns that were generated for the delete operation
+ @Builder.Default
+ List deleteBootstrapBasePathPatterns =
CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();;
+ // Files that could not be deleted
+ @Builder.Default
+ List failedDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
voonhous commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r2778417355
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##
@@ -715,18 +715,30 @@ public void testCleanMetadataUpgradeDowngrade() {
List failedDeleteFiles1 = Collections.singletonList(filePath2);
// create partition1 clean stat.
-HoodieCleanStat cleanStat1 = new
HoodieCleanStat(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS,
-partition1, deletePathPatterns1, successDeleteFiles1,
-failedDeleteFiles1, instantTime, "");
+HoodieCleanStat cleanStat1 = HoodieCleanStat.builder()
+.withPolicy(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS)
+.withPartitionPath(partition1)
+.withDeletePathPatterns(deletePathPatterns1)
+.withSuccessDeleteFiles(successDeleteFiles1)
+.withFailedDeleteFiles(failedDeleteFiles1)
+.withEarliestCommitToRetain(instantTime)
+.withLastCompletedCommitTimestamp("")
+.build();
List deletePathPatterns2 = new ArrayList<>();
List successDeleteFiles2 = new ArrayList<>();
List failedDeleteFiles2 = new ArrayList<>();
// create partition2 empty clean stat.
-HoodieCleanStat cleanStat2 = new
HoodieCleanStat(HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
-partition2, deletePathPatterns2, successDeleteFiles2,
-failedDeleteFiles2, instantTime, "");
+HoodieCleanStat cleanStat2 = HoodieCleanStat.builder()
+.withPolicy(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS)
Review Comment:
Copy paste error, reverting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
CTTY commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r2756470429
##
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##
@@ -75,12 +80,22 @@
* @param The type of engine-specific record representation, e.g.,{@code
InternalRow} in Spark
*and {@code RowData} in Flink.
*/
+@Getter
+@Setter
Review Comment:
Do we really need class-level getter/setter if we need so many field level
getters
##
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##
@@ -715,18 +715,30 @@ public void testCleanMetadataUpgradeDowngrade() {
List failedDeleteFiles1 = Collections.singletonList(filePath2);
// create partition1 clean stat.
-HoodieCleanStat cleanStat1 = new
HoodieCleanStat(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS,
-partition1, deletePathPatterns1, successDeleteFiles1,
-failedDeleteFiles1, instantTime, "");
+HoodieCleanStat cleanStat1 = HoodieCleanStat.builder()
+.withPolicy(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS)
+.withPartitionPath(partition1)
+.withDeletePathPatterns(deletePathPatterns1)
+.withSuccessDeleteFiles(successDeleteFiles1)
+.withFailedDeleteFiles(failedDeleteFiles1)
+.withEarliestCommitToRetain(instantTime)
+.withLastCompletedCommitTimestamp("")
+.build();
List deletePathPatterns2 = new ArrayList<>();
List successDeleteFiles2 = new ArrayList<>();
List failedDeleteFiles2 = new ArrayList<>();
// create partition2 empty clean stat.
-HoodieCleanStat cleanStat2 = new
HoodieCleanStat(HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
-partition2, deletePathPatterns2, successDeleteFiles2,
-failedDeleteFiles2, instantTime, "");
+HoodieCleanStat cleanStat2 = HoodieCleanStat.builder()
+.withPolicy(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS)
Review Comment:
The policy was changed? Probably doesn't matter that much but needs
revisiting
```suggestion
.withPolicy(HoodieCleaningPolicy.KEEP_LATEST_COMMITS)
```
##
hudi-common/src/main/java/org/apache/hudi/common/HoodieCleanStat.java:
##
@@ -19,207 +19,45 @@
package org.apache.hudi.common;
import org.apache.hudi.common.model.HoodieCleaningPolicy;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
import org.apache.hudi.common.util.CollectionUtils;
-import org.apache.hudi.common.util.Option;
+
+import lombok.Builder;
+import lombok.Value;
import java.io.Serializable;
import java.util.List;
/**
* Collects stats about a single partition clean operation.
*/
+@Builder(setterPrefix = "with")
+@Value
public class HoodieCleanStat implements Serializable {
// Policy used
- private final HoodieCleaningPolicy policy;
+ HoodieCleaningPolicy policy;
// Partition path cleaned
- private final String partitionPath;
+ String partitionPath;
// The patterns that were generated for the delete operation
- private final List deletePathPatterns;
- private final List successDeleteFiles;
- // Files that could not be deleted
- private final List failedDeleteFiles;
- // Bootstrap Base Path patterns that were generated for the delete operation
- private final List deleteBootstrapBasePathPatterns;
- private final List successDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List deletePathPatterns = CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteFiles = CollectionUtils.createImmutableList();
// Files that could not be deleted
- private final List failedDeleteBootstrapBaseFiles;
+ @Builder.Default
+ List failedDeleteFiles = CollectionUtils.createImmutableList();
// Earliest commit that was retained in this clean
- private final String earliestCommitToRetain;
+ String earliestCommitToRetain;
// Last completed commit timestamp before clean
- private final String lastCompletedCommitTimestamp;
+ String lastCompletedCommitTimestamp;
+ // Bootstrap Base Path patterns that were generated for the delete operation
+ @Builder.Default
+ List deleteBootstrapBasePathPatterns =
CollectionUtils.createImmutableList();
+ @Builder.Default
+ List successDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();;
+ // Files that could not be deleted
+ @Builder.Default
+ List failedDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();;
Review Comment:
```suggestion
List failedDeleteBootstrapBaseFiles =
CollectionUtils.createImmutableList();
```
##
hudi-common/src/main/java/org/apache/hudi/common/HoodieCleanStat.java:
##
@@ -19,207 +19,45 @@
package org.apache.hudi.common;
import org.apache.hudi.common.model.HoodieCleaningPolicy;
-import org.apache.hudi.common.table.timeline.HoodieInstant;
import org.apache.hudi.common.util.CollectionUtils;
-import org.apache.hudi.common.util.Option;
+
+impor
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3829023081 ## CI report: * ccc6a1506c9c8f1f59bc235734f9f7e22245f0b8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11578) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] refactor: Add Lombok annotations to hudi-common module (part 3) [hudi]
hudi-bot commented on PR #17825: URL: https://github.com/apache/hudi/pull/17825#issuecomment-3828851584 ## CI report: * 356e9b315df2f561326b116f37614e4fe1093fd9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11326) * ccc6a1506c9c8f1f59bc235734f9f7e22245f0b8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11578) Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
