Re: [PR] NO-ISSUE: Add flags to allow for local overrides of the Kogito runtimes version [incubator-kie-tools]
thiagoelg commented on PR #3541: URL: https://github.com/apache/incubator-kie-tools/pull/3541#issuecomment-4262750992 > If I start with > > ``` > export KOGITO_RUNTIME_version=10.2.0 > export QUARKUS_PLATFORM_version=3.27.3 > ``` > > Then I change it to different values, will it continue working as expected? I'm concerned that writing those values to maven.config might make it impossible to change them without having to manually delete/update the maven.config file. As long as you run `pnpm bootstrap`, yes, it should work. The maven.config files will be automatically updated. Running `pnpm bootstrap` after changing the `KOGITO_RUNTIME_version` env var is already required, even without these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] NO-ISSUE: Add flags to allow for local overrides of the Kogito runtimes version [incubator-kie-tools]
tiagobento commented on PR #3541: URL: https://github.com/apache/incubator-kie-tools/pull/3541#issuecomment-4262730789 If I start with ``` export KOGITO_RUNTIME_version=10.2.0 export QUARKUS_PLATFORM_version=3.27.3 ``` Then I change it to different values, will it continue working as expected? I'm concerned that writing those values to maven.config might make it impossible to change them without having to manually delete/update the maven.config file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] NO-ISSUE: Add flags to allow for local overrides of the Kogito runtimes version [incubator-kie-tools]
thiagoelg opened a new pull request, #3541: URL: https://github.com/apache/incubator-kie-tools/pull/3541 Added two new env vars: - `KIE_TOOLS_BUILD__kogitoVersionSetPropertySkip` - `KIE_TOOLS_BUILD__quarkusVersionSetPropertySkip` Setting them to `true` allows developers to override the `KOGITO_RUNTIME_version` and `QUARKUS_PLATFORM_version` env vars values without changing the `packages/maven-base/pom.xml` file. This is important for quick (and ephemeral) tests of different Kogito or Quarkus versions, without generating unwanted changes. ### Usage example: ```sh export KIE_TOOLS_BUILD__kogitoVersionSetPropertySkip=true export KIE_TOOLS_BUILD__quarkusVersionSetPropertySkip=true export KOGITO_RUNTIME_version=10.2.0 export QUARKUS_PLATFORM_version=3.27.3 pnpm bootstrap pnpm -F @kie-tools/jbpm-quarkus-devui... build:dev ``` In this scenario, `@kie-tools/jbpm-quarkus-devui` will be built against a new Quarkus version and the published `10.2.0` version of Apache KIE Kogito Runtime, without changing the `packages/maven-base/pom.xml` file. --- The default behavior remains the same as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
