Re: [PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
danielzhe closed pull request #: kie-issues#2160: `I18nwrapped` content is not displaying in the UI URL: https://github.com/apache/incubator-kie-tools/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2160: I18nwrapped content is not displaying in the UI [incubator-kie-tools]
danielzhe merged PR #3344: URL: https://github.com/apache/incubator-kie-tools/pull/3344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] kie-issues#2160: I18nwrapped content is not displaying in the UI [incubator-kie-tools]
danielzhe opened a new pull request, #3344: URL: https://github.com/apache/incubator-kie-tools/pull/3344 Closes https://github.com/apache/incubator-kie-issues/issues/2160 I'm open this new PR to fix conflicts from https://github.com/apache/incubator-kie-tools/pull/ since the author is not available at this moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
danielzhe commented on PR #: URL: https://github.com/apache/incubator-kie-tools/pull/#issuecomment-3487511022 I'm working in the failing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
Kusuma04-dev commented on code in PR #:
URL:
https://github.com/apache/incubator-kie-tools/pull/#discussion_r248206
##
packages/webpack-base/webpack.common.config.js:
##
@@ -86,6 +86,7 @@ module.exports = (webpackEnv) => {
compilerOptions: {
...verbatimModuleSyntax,
sourceMap: sourceMaps,
+ jsx: "react-jsx",
Review Comment:
I got some jsx issue which i have tested by adding this in local Thaigo, Let
me remove it.Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
thiagoelg commented on code in PR #:
URL:
https://github.com/apache/incubator-kie-tools/pull/#discussion_r2481985592
##
packages/webpack-base/webpack.common.config.js:
##
@@ -86,6 +86,7 @@ module.exports = (webpackEnv) => {
compilerOptions: {
...verbatimModuleSyntax,
sourceMap: sourceMaps,
+ jsx: "react-jsx",
Review Comment:
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
thiagoelg commented on code in PR #:
URL:
https://github.com/apache/incubator-kie-tools/pull/#discussion_r2481984262
##
packages/i18n/src/core/I18nWrappedTemplate.tsx:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import * as React from "react";
+
+// component to replace placeholders in text with React components
+export const I18nWrappedTemplate = ({
+ text,
+ placeholders,
+}: {
+ text: string;
+ placeholders: Record;
Review Comment:
I think `interpolationMap` or `tokenMap` would be better names than
`placeholders`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
github-advanced-security[bot] commented on code in PR #:
URL:
https://github.com/apache/incubator-kie-tools/pull/#discussion_r2480470931
##
packages/i18n/src/core/I18nWrappedTemplate.tsx:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import * as React from "react";
+
+// component to replace placeholders in text with React components
+export const I18nWrappedTemplate = ({
+ text,
+ placeholders,
+}: {
+ text: string;
+ placeholders: Record;
+}) => (
+ <>
+{text.split(/\{([^}]+)\}/).map((value, index) =>
Review Comment:
## Polynomial regular expression used on uncontrolled data
This [regular expression](1) that depends on [library input](2) may run slow
on strings starting with '{{' and with many repetitions of '{{|'.
This [regular expression](1) that depends on [library input](3) may run slow
on strings starting with '{{' and with many repetitions of '{{|'.
[Show more
details](https://github.com/apache/incubator-kie-tools/security/code-scanning/1044)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[PR] kie-issues#2160: `I18nwrapped` content is not displaying in the UI [incubator-kie-tools]
Kusuma04-dev opened a new pull request, #: URL: https://github.com/apache/incubator-kie-tools/pull/ closes https://github.com/apache/incubator-kie-issues/issues/2160, Before fix: https://github.com/user-attachments/assets/588f6d9d-e0bf-48d7-bfdd-ed4a0b70c148"; /> After fix: https://github.com/user-attachments/assets/46a2f4cc-12c7-42a5-802e-13d80153f4f8"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
