Re: [I] review use of hibernate jar [incubator-kie-issues]
porcelli closed issue #1685: review use of hibernate jar URL: https://github.com/apache/incubator-kie-issues/issues/1685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
porcelli commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-4374535791 Has been addressed in the most recent release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
tiagobento commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-4373736828 So... can we close this!? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
yesamer commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-3943953343 Hi there, we updated HIbernate to version 7.1.14 in the Quarkus upgrade task https://github.com/apache/incubator-kie-issues/issues/2204. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
porcelli commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-3028359745 @pjfanning, yes, it's been released and has been included in Quarkus recently. I'm not sure how it's going with Spring Boot side (KIE supports both runtimes). It's expected that this will still take some time, as we need Hibernate 7 to be incorporated into an LTS version and also properly adopted and integrated into the SB ecosystem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
pjfanning commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-3028334728 Hibernate 7 is relaesed but it only supports Java 17 afaik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
ricardozanini commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2736710653 Oh this is great news! Thanks for sharing, @porcelli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
pjfanning commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2734623211 Sounds good. Just keep the DISCLAIMER-WIP until we have a Hibernate ASL release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
porcelli commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2734646050 Absolutely! No plans to change until properly solved! Thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
porcelli commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2734612330 @pjfanning a quick update as we are planning to release 10.1.0 soon-ish... Hibernate is officially relicensing https://in.relation.to/2025/03/14/orm-asl/ Although we won't be able to adopt it overnight, as it has to first being picked up by Quarkus, but this is in the make... just providing here an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
lucamolteni commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2590457179 As for Optaplanner, it uses Hibernate specific types such as `AbstractSingleColumnStandardBasicType` see [https://docs.optaplanner.org/8.34.0.Final/optaplanner-javadoc/org/optaplanner/persistence/jpa/impl/score/AbstractScoreHibernateType.html](url) so I don't see it possible to replace it with OpenJPA. I'm personally fine with removing the jar file from the zip and adding the instructions to readd it, hoping that soon Hibernate will support the Apache license -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
ricardozanini commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2575889509 @pjfanning thank you! I opened https://issues.apache.org/jira/browse/LEGAL-695. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
pjfanning commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2573576406 @ricardozanini maybe you raise a legal issue at https://issues.apache.org/jira/projects/LEGAL/issues Maybe it would be worth starting with an issue just about the docker images and if they can include the LGPL licensed Hibernate jar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
ricardozanini commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2573555259 @fjtirado @pjfanning @tkobayas @tiagobento If we use Hibernate only as a link in the POM (`provided`) and don't include it in the apps, we also have to stop publishing all the Kogito and SonataFlow images in our docker/apache repository since these JARs will be included there. Hence, we would distribute it. In this case, we need to update the CI and add instructions to users to build the images independently. Also, the SonataFlow operator won't be distributed since it depends on the images published on DockerHub. It will be a huge hit on our platform. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
fjtirado commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2561053051 What Im trying to say, beyond the technical point of view and the license legal thing is that this a decision that Im not empowered to take and should be further discussed with a broad audience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
fjtirado commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2561046653 @pjfanning Yes, I got that and that what I proposes. If the dependency scope is provided, everything will compile and tests as it does now but the hibernate jar wont be included in the final binary. Users will need to add it manually later. (I want to stress Im assuming this will be temporary till Hibernate folks update their license) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
pjfanning commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2561044636 > 2. Do as @pjfanning (mainly because Hibernate License will be eventually updated and this will be a temporary fix) proposed. Do not distribute the binary (set the dependency as provided in the pom) and include instructions to add it. > It's ok for a pom to link to an LGPL jar(not ideal, but ok). The issue is the zips and tar.gz files in https://downloads.apache.org/incubator/kie/10.0.0/ - these cannot include the LGPL jars. They can include scripts to download the LGPL jars if the jar is needed for the build, with instructions detailing the license issue. I would also like to highlight fat jars (often these are shaded jars) - these are jars that include many classes including 3rd party classes. If you include LGPL classes in these jars, then you have caused a copyleft issue with that fat jar. The licensing issue is that you can't ship classes or jars that are LGPL but you can link to jars (eg a pom dependency). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
fjtirado commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2561034028 @tkobayas @pjfanning Kogito runtimes do not use JPA but Kogito Apps heavily use it, both for data_index and audit components. Therefore removing JPA is not a viable option without basically redeveloping both components. On top of that, we recently start using Hibernate classes directly to allow querying ProcessInstance.variables property (which is json column in postgress) in postgresql. See [here](https://github.com/apache/incubator-kie-kogito-apps/blob/main/data-index/data-index-storage/data-index-storage-postgresql/src/main/java/org/kie/kogito/index/postgresql/ContainsSQLFunction.java#L24-L28) Therefore we have two options. 1) Replace Hibernate by OpenJPA, as was made in Drools (where this is not a problem because there is a JPA transaction manager, but not JPA entities) , and study how to achieve the custom function functionality. After a quick study of the OpenJPA documentation, it seems there might be a [way](https://openjpa.apache.org/builds/2.1.1/apache-openjpa/docs/ch13s03.html), but as you see the doc is sparse. 2) Do as as @pjfanning (mainly because Hibernate License will be eventually updated and this will be a temporary fix) proposed. Do not distribute the binary (move the dependency as provided in the pom) and include instructions to add it. I guess we can try OpenJPA as POC and if it works, go ahead, but @krisv, do we really want to get rid of Hibernate strategically? In any case, before moving forward, we should wait to discuss the alternatives further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] review use of hibernate jar [incubator-kie-issues]
tkobayas commented on issue #1685: URL: https://github.com/apache/incubator-kie-issues/issues/1685#issuecomment-2560688980 drools had removed hibernate dependencies by https://github.com/apache/incubator-kie-drools/pull/5764 Could someone please review other repos? optaplanner -> @lucamolteni kogito-runtimes -> @fjtirado ? kogito-apps -> @pefernan ? kie-tools (images, operator) -> @tiagobento @ricardozanini ? Feel free to involve appropriate persons. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
