Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822308412 ## addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/mapper/TaskInputsEntityMapper.java: ## @@ -64,7 +64,8 @@ public void mapInstanceToEntity(UserTaskInstance userTaskInstance, UserTaskInsta inputEntity.setValue(JSONUtils.valueToString(value).getBytes(StandardCharsets.UTF_8)); inputEntity.setJavaType(value.getClass().getName()); } -repository.persist(inputEntity); +// No explicit persist needed: parent has @OneToMany(cascade = CascadeType.ALL), +// so child entities are automatically persisted when the parent is saved. Review Comment: removed the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822307403 ## quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common-deployment/src/main/java/org/kie/kogito/quarkus/workflow/deployment/config/KogitoDevServicesBuildTimeConfig.java: ## @@ -20,10 +20,13 @@ import java.util.Optional; -import io.quarkus.runtime.annotations.ConfigGroup; import io.smallrye.config.WithDefault; -@ConfigGroup +/** + * Nested configuration group for Kogito DevServices build-time settings. Review Comment: removed the comment. ## quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common/src/main/java/org/kie/kogito/quarkus/workflow/config/KogitoPersistenceBuildTimeConfig.java: ## @@ -18,11 +18,14 @@ */ package org.kie.kogito.quarkus.workflow.config; -import io.quarkus.runtime.annotations.ConfigGroup; import io.smallrye.config.WithDefault; import io.smallrye.config.WithName; -@ConfigGroup +/** + * Nested configuration group for persistence build-time settings. Review Comment: removed the comment. ## quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common/src/main/java/org/kie/kogito/quarkus/workflow/config/KogitoPersistenceRuntimeConfig.java: ## @@ -20,11 +20,14 @@ import java.util.Optional; -import io.quarkus.runtime.annotations.ConfigGroup; import io.smallrye.config.WithDefault; import io.smallrye.config.WithName; -@ConfigGroup +/** + * Nested configuration group for persistence runtime settings. Review Comment: removed the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822304446
##
quarkus/addons/tracing-decision/deployment/src/main/java/org/kie/kogito/tracing/decision/quarkus/deployment/KogitoDevServicesBuildTimeConfig.java:
##
@@ -20,32 +20,33 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
-import io.quarkus.runtime.annotations.ConfigItem;
+import io.smallrye.config.WithDefault;
-@ConfigGroup
-public class KogitoDevServicesBuildTimeConfig {
+/**
+ * Nested configuration group for Kogito Trusty Service DevServices build-time
settings.
Review Comment:
removed the comment.
##
quarkus/extensions/kogito-quarkus-extension-common/kogito-quarkus-common/src/main/java/org/kie/kogito/quarkus/config/KogitoAuthRuntimeConfig.java:
##
@@ -21,11 +21,14 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for authentication runtime settings.
Review Comment:
removed the comment.
##
quarkus/extensions/kogito-quarkus-extension-common/kogito-quarkus-common/src/main/java/org/kie/kogito/quarkus/config/KogitoEventingRuntimeConfig.java:
##
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for eventing runtime settings.
Review Comment:
removed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822306404
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -180,6 +187,9 @@ void testAsyncApi() throws IOException {
test.addResourceFile("asyncPublisher.sw.json", new
String(Objects.requireNonNull(inputStream).readAllBytes()));
}
+// Add a small delay to allow Quarkus to complete the hot reload
+Thread.sleep(500);
Review Comment:
corrected to use the await()
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/java/org/kie/kogito/quarkus/serverless/workflow/config/KogitoServerlessWorkflowBuildTimeConfig.java:
##
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.serverless.workflow.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for serverless workflow build-time settings.
Review Comment:
removed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822302452 ## quarkus/addons/process-management/runtime/pom.xml: ## @@ -88,7 +88,7 @@ jakarta.xml.bind jakarta.xml.bind-api test - 4.0.1 + 4.0.4 Review Comment: removed version tag. ## quarkus/addons/rest-exception-handler/pom.xml: ## @@ -79,7 +79,7 @@ jakarta.xml.bind jakarta.xml.bind-api test - 4.0.1 + 4.0.4 Review Comment: removed version tag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822300573 ## quarkus/addons/flyway/runtime/src/main/java/org/kie/flyway/quarkus/KieQuarkusFlywayNamedModuleConfig.java: ## @@ -19,10 +19,13 @@ package org.kie.flyway.quarkus; -import io.quarkus.runtime.annotations.ConfigGroup; import io.smallrye.config.WithDefault; -@ConfigGroup +/** Review Comment: removed the comment ## quarkus/addons/knative/eventing/deployment/src/main/java/org/kie/kogito/addons/quarkus/knative/eventing/deployment/SinkConfiguration.java: ## @@ -20,10 +20,13 @@ import java.util.Optional; -import io.quarkus.runtime.annotations.ConfigGroup; import io.smallrye.config.WithDefault; -@ConfigGroup +/** + * Nested configuration group for Knative Sink settings. Review Comment: removed the comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822298424
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -190,5 +200,8 @@ void testAsyncApi() throws IOException {
.extract().path("id");
assertThat(id).isNotBlank();
+
+// Add a small delay before test cleanup to avoid
ConcurrentModificationException
+Thread.sleep(100);
Review Comment:
Fixed as per the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822081072 ## quarkus/addons/process-management/runtime/pom.xml: ## @@ -88,7 +88,7 @@ jakarta.xml.bind jakarta.xml.bind-api test - 4.0.1 + 4.0.4 Review Comment: This version was earlier upgraded to 4.0.4 with this [PR](https://github.com/apache/incubator-kie-kogito-runtimes/pull/4113 ) We have aligned the version in submodules as well. We will be removing this version tag, since override is not required now. ## quarkus/addons/rest-exception-handler/pom.xml: ## @@ -79,7 +79,7 @@ jakarta.xml.bind jakarta.xml.bind-api test - 4.0.1 + 4.0.4 Review Comment: This version was earlier upgraded to 4.0.4 with this [PR](https://github.com/apache/incubator-kie-kogito-runtimes/pull/4113 ) We have aligned the version in submodules as well. We will be removing this version tag, since override is not required now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821688901
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -47,20 +49,47 @@ public Optional apply(String id) {
}
private static AsyncInfo from(AsyncAPI asyncApi) {
-Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+Map channelIdToAddress =
buildChannelAddressMap(asyncApi);
+Map channelInfoByOperationId =
buildOperationChannelInfoMap(asyncApi, channelIdToAddress);
+return new AsyncInfo(channelInfoByOperationId);
+}
+
+// AsyncAPI v3.0.0: channels are separate top-level objects with addresses
+private static Map buildChannelAddressMap(AsyncAPI
asyncApi) {
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+if (ch.getValue() instanceof Channel channel) {
+String channelId = ch.getKey();
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
+return channelIdToAddress;
}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// AsyncAPI v3.0.0: operations reference channels via $ref, action is
SEND/RECEIVE
Review Comment:
moved out the migration based comments as pr comments
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -47,20 +49,47 @@ public Optional apply(String id) {
}
private static AsyncInfo from(AsyncAPI asyncApi) {
-Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+Map channelIdToAddress =
buildChannelAddressMap(asyncApi);
+Map channelInfoByOperationId =
buildOperationChannelInfoMap(asyncApi, channelIdToAddress);
+return new AsyncInfo(channelInfoByOperationId);
+}
+
+// AsyncAPI v3.0.0: channels are separate top-level objects with addresses
Review Comment:
moved out the migration based comments as pr comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2812196214
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -51,7 +54,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@Execution(SAME_THREAD)
+@Disabled("Disabled temporarly - when doing quarkus upgrade.")
Review Comment:
fixed the typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821653073
##
quarkus/addons/kubernetes/test-utils/src/main/java/org/kie/kogito/addons/quarkus/k8s/test/utils/KubernetesMockServerTestResource.java:
##
@@ -55,15 +75,20 @@ public Map start() {
@Override
public void stop() {
+if (client != null) {
+client.close();
+}
if (server != null) {
-server.after(); // Stop the mock server
+server.destroy();
+server = null;
}
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821513535
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -51,7 +54,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@Execution(SAME_THREAD)
+@Disabled("Disabled temporarly - when doing quarkus upgrade.")
public class LiveReloadProcessorTest {
Review Comment:
@jeejz @fjtirado Reported here
https://github.com/apache/incubator-kie-issues/issues/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821499963
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -51,7 +54,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@Execution(SAME_THREAD)
+@Disabled("Disabled temporarly - when doing quarkus upgrade.")
public class LiveReloadProcessorTest {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821369562 ## springboot/bom/pom.xml: ## @@ -42,8 +42,8 @@ 4.0.29 2.2-groovy-4.0 - - 2024.0.2 + + 2025.0.1 7.2.0 Review Comment: @jeejz @nrknithin Did you consider this comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821373303 ## addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/mapper/TaskInputsEntityMapper.java: ## @@ -64,7 +64,8 @@ public void mapInstanceToEntity(UserTaskInstance userTaskInstance, UserTaskInsta inputEntity.setValue(JSONUtils.valueToString(value).getBytes(StandardCharsets.UTF_8)); inputEntity.setJavaType(value.getClass().getName()); } -repository.persist(inputEntity); +// No explicit persist needed: parent has @OneToMany(cascade = CascadeType.ALL), +// so child entities are automatically persisted when the parent is saved. Review Comment: @pefernan @baldimir Not sure if we should keep those comments or just mention that in the PR's description, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821266832
##
quarkus/addons/knative/eventing/deployment/src/main/java/org/kie/kogito/addons/quarkus/knative/eventing/deployment/SinkConfiguration.java:
##
@@ -20,10 +20,13 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
-@ConfigGroup
+/**
+ * Nested configuration group for Knative Sink settings.
Review Comment:
Same
##
quarkus/addons/flyway/runtime/src/main/java/org/kie/flyway/quarkus/KieQuarkusFlywayNamedModuleConfig.java:
##
@@ -19,10 +19,13 @@
package org.kie.flyway.quarkus;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
-@ConfigGroup
+/**
Review Comment:
I'd cleanup this comment
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -180,6 +187,9 @@ void testAsyncApi() throws IOException {
test.addResourceFile("asyncPublisher.sw.json", new
String(Objects.requireNonNull(inputStream).readAllBytes()));
}
+// Add a small delay to allow Quarkus to complete the hot reload
+Thread.sleep(500);
Review Comment:
I'd use `awaitility` instead of Thread.sleep if possible. There are multiple
examples in the codebase
([ej](https://github.com/apache/incubator-kie-kogito-runtimes/blob/baea286b65db29e3cf7ca781375a784c9a6c3ee8/quarkus/addons/opentelemetry/integration-tests/src/test/java/org/kie/kogito/quarkus/serverless/workflow/opentelemetry/OpenTelemetryRestartIT.java#L207):
https://github.com/apache/incubator-kie-kogito-runtimes/blob/baea286b65db29e3cf7ca781375a784c9a6c3ee8/quarkus/addons/opentelemetry/integration-tests/src/test/java/org/kie/kogito/quarkus/serverless/workflow/opentelemetry/OpenTelemetryRestartIT.java#L207
)
##
quarkus/addons/rest-exception-handler/pom.xml:
##
@@ -79,7 +79,7 @@
jakarta.xml.bind
jakarta.xml.bind-api
test
- 4.0.1
+ 4.0.4
Review Comment:
same as before
##
quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common/src/main/java/org/kie/kogito/quarkus/workflow/config/KogitoPersistenceBuildTimeConfig.java:
##
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.workflow.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for persistence build-time settings.
Review Comment:
Comment
##
quarkus/addons/process-management/runtime/pom.xml:
##
@@ -88,7 +88,7 @@
jakarta.xml.bind
jakarta.xml.bind-api
test
- 4.0.1
+ 4.0.4
Review Comment:
Can we use a property for this version?
Looking at Quarkus bom they still use `4.0.2` can we align to that version?
https://github.com/quarkusio/quarkus/blob/3.27/bom/application/pom.xml#L82
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/java/org/kie/kogito/quarkus/serverless/workflow/config/KogitoServerlessWorkflowBuildTimeConfig.java:
##
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.serverless.workflow.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for serverless workflow build-time settings.
Review Comment:
Comment
##
quarkus/addons/tracing-decision/deployment/src/main/java/org/kie/kogito/tracing/decision/quarkus/deployment/KogitoDevServicesBuildTimeConfig.java:
##
@@ -20,32 +20,33 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
-import io.quarkus.runtime.annotations.ConfigItem;
+import io.smallrye.config.WithDefault;
-@ConfigGroup
-public class KogitoDevServicesBuildTimeConfig {
+/**
+ * Nested configuration group for Kogito Trusty Service DevServices build-time
settings.
Review Comment:
Maybe we don't need this too
##
quarkus/extensions/kogito-quarkus-extension-common/kogito-quarkus-common/src/main/java/org/kie/kogito/quarkus/config/KogitoEventingRuntimeConfig.java:
##
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for eventing runtime settings.
Review Comment:
Comment
##
quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common-deploymen
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3908861651
**PR job** `#24` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/24/display/redirect
**Test results:**
- PASSED: 3913
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/24/testReport/org.kie.kogito.integrationtests.quarkus/TaskIT/testUpdateTaskInfo/";>org.kie.kogito.integrationtests.quarkus.TaskIT.testUpdateTaskInfo
1 expectation failed.Expected status code <403> but was <200>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2812196214
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -51,7 +54,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@Execution(SAME_THREAD)
+@Disabled("Disabled temporarly - when doing quarkus upgrade.")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2812194639 ## quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java: ## @@ -27,9 +27,11 @@ import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfo; import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfoConverter; -import com.asyncapi.v2._6_0.model.AsyncAPI; -import com.asyncapi.v2._6_0.model.channel.ChannelItem; -import com.asyncapi.v2._6_0.model.channel.operation.Operation; +// Updated to AsyncAPI v3.0.0 (from v2.0.0) as part of Quarkus 3.27.2 upgrade Review Comment: moved out the migration based comments as pr comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2812193737 ## quarkus/addons/kubernetes/runtime/src/test/java/org/kie/kogito/addons/quarkus/k8s/config/KubeDiscoveryConfigCacheUpdaterTest.java: ## @@ -34,6 +34,13 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.kie.kogito.addons.quarkus.k8s.test.utils.KubeTestUtils.createKnativeServiceIfNotExists; +/** Review Comment: moved out the migration based comments as pr comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2812191920 ## quarkus/addons/kubernetes/test-utils/src/main/java/org/kie/kogito/addons/quarkus/k8s/test/utils/KubernetesMockServerTestResource.java: ## @@ -22,28 +22,48 @@ import java.util.Map; import io.fabric8.kubernetes.client.Config; -import io.fabric8.kubernetes.client.server.mock.KubernetesServer; +import io.fabric8.kubernetes.client.KubernetesClient; +import io.fabric8.kubernetes.client.server.mock.KubernetesCrudDispatcher; +import io.fabric8.kubernetes.client.server.mock.KubernetesMockServer; +import io.fabric8.mockwebserver.MockWebServer; import io.quarkus.test.common.QuarkusTestResourceLifecycleManager; /** * Quarkus test resource that provides a Fabric8 Kubernetes mock server with CRUD support. + * + * Quarkus 3.27.2 / Fabric8 7.3.1 upgrade: + * - Replaced KubernetesServer (Fabric8 6.x) with KubernetesMockServer (Fabric8 7.x). Review Comment: moved out the migration based comments as pr comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799601156 ## springboot/bom/pom.xml: ## @@ -42,8 +42,8 @@ 4.0.29 2.2-groovy-4.0 - - 2024.0.2 + + 2025.0.1 7.2.0 Review Comment: I think fabric should be updated too. Please check which fabric8 version has Spring Cloud in the 2025.0.1 version. It should be possible to find some pom.xml with the dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799537150 ## quarkus/addons/kubernetes/test-utils/src/main/java/org/kie/kogito/addons/quarkus/k8s/test/utils/KubernetesMockServerTestResource.java: ## @@ -22,28 +22,48 @@ import java.util.Map; import io.fabric8.kubernetes.client.Config; -import io.fabric8.kubernetes.client.server.mock.KubernetesServer; +import io.fabric8.kubernetes.client.KubernetesClient; +import io.fabric8.kubernetes.client.server.mock.KubernetesCrudDispatcher; +import io.fabric8.kubernetes.client.server.mock.KubernetesMockServer; +import io.fabric8.mockwebserver.MockWebServer; import io.quarkus.test.common.QuarkusTestResourceLifecycleManager; /** * Quarkus test resource that provides a Fabric8 Kubernetes mock server with CRUD support. + * + * Quarkus 3.27.2 / Fabric8 7.3.1 upgrade: + * - Replaced KubernetesServer (Fabric8 6.x) with KubernetesMockServer (Fabric8 7.x). Review Comment: Same as my previous comments - this description what was done part of the upgrade should be part of the PR, not code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799529547 ## quarkus/addons/kubernetes/runtime/src/test/java/org/kie/kogito/addons/quarkus/k8s/config/KubeDiscoveryConfigCacheUpdaterTest.java: ## @@ -34,6 +34,13 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.kie.kogito.addons.quarkus.k8s.test.utils.KubeTestUtils.createKnativeServiceIfNotExists; +/** Review Comment: Similar as my previous comments about comments - If you want to add a JavaDoc header to this class, please add proper content. The added comment describes what was done to upgrade, however the JavaDoc header of a class should contain information about what the class does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799517525
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -47,20 +49,47 @@ public Optional apply(String id) {
}
private static AsyncInfo from(AsyncAPI asyncApi) {
-Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+Map channelIdToAddress =
buildChannelAddressMap(asyncApi);
+Map channelInfoByOperationId =
buildOperationChannelInfoMap(asyncApi, channelIdToAddress);
+return new AsyncInfo(channelInfoByOperationId);
+}
+
+// AsyncAPI v3.0.0: channels are separate top-level objects with addresses
Review Comment:
If you want to document what a method does, please use standard JavaDoc
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799513645
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -47,20 +49,47 @@ public Optional apply(String id) {
}
private static AsyncInfo from(AsyncAPI asyncApi) {
-Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+Map channelIdToAddress =
buildChannelAddressMap(asyncApi);
+Map channelInfoByOperationId =
buildOperationChannelInfoMap(asyncApi, channelIdToAddress);
+return new AsyncInfo(channelInfoByOperationId);
+}
+
+// AsyncAPI v3.0.0: channels are separate top-level objects with addresses
+private static Map buildChannelAddressMap(AsyncAPI
asyncApi) {
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+if (ch.getValue() instanceof Channel channel) {
+String channelId = ch.getKey();
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
+return channelIdToAddress;
}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// AsyncAPI v3.0.0: operations reference channels via $ref, action is
SEND/RECEIVE
Review Comment:
If you want to document what a method does, please use standard JavaDoc
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799504895 ## quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java: ## @@ -27,9 +27,11 @@ import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfo; import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfoConverter; -import com.asyncapi.v2._6_0.model.AsyncAPI; -import com.asyncapi.v2._6_0.model.channel.ChannelItem; -import com.asyncapi.v2._6_0.model.channel.operation.Operation; +// Updated to AsyncAPI v3.0.0 (from v2.0.0) as part of Quarkus 3.27.2 upgrade Review Comment: I see a lot of similar comments on multiple places. Those are nice for the reviewers, however when written in the code, they may stay there forever. Please consider removing them and instead writing comments in the PRs to the actual lines. E.g. in a year no one would probably care that it was updated part of the Quarkus upgrade. And if yes, people can find it in git history. What do you think, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
baldimir commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799504895 ## quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java: ## @@ -27,9 +27,11 @@ import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfo; import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfoConverter; -import com.asyncapi.v2._6_0.model.AsyncAPI; -import com.asyncapi.v2._6_0.model.channel.ChannelItem; -import com.asyncapi.v2._6_0.model.channel.operation.Operation; +// Updated to AsyncAPI v3.0.0 (from v2.0.0) as part of Quarkus 3.27.2 upgrade Review Comment: I see a lot of similar comments on multiple places (I think also in the PRs in other repos). Those are nice for the reviewers, however when written in the code, they may stay there forever. Please consider removing them and instead writing comments in the PRs to the actual lines. E.g. in a year no one would probably care that it was updated part of the Quarkus upgrade. And if yes, people can find it in git history. What do you think, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2798563066
##
kogito-build/kogito-dependencies-bom/pom.xml:
##
@@ -40,78 +40,83 @@
-3.20.3
+3.27.2
${version.io.quarkus}
-6.2.12
-3.4.11
-3.9.1
+6.2.15
+3.5.10
+4.0.0
-
1.81
+
1.82
1.0.86
-2.18.4
-
2.18.4
+2.19.2
+
2.19.2
2.9.0
-2.1
+
+3.2
2.4.10
1.0.0-preview.20240207
-
2.2.0
+
2.4.0
2.11.0-lts
-0.3.0
+1.0.5
2.5.0-lts
0.7.2
1.5.2
3.26.4
-
2.18.2
+
2.19.2
Review Comment:
@jeejz Please update java parser to 3.27.0 as you did in the Drools's PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
Copilot commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2798330031
##
quarkus/addons/tracing-decision/deployment/src/main/java/org/kie/kogito/tracing/decision/quarkus/deployment/KogitoDevServicesBuildTimeConfig.java:
##
@@ -20,32 +20,33 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
-import io.quarkus.runtime.annotations.ConfigItem;
+import io.smallrye.config.WithDefault;
-@ConfigGroup
-public class KogitoDevServicesBuildTimeConfig {
+/**
+ * Nested configuration group for Kogito Trusty Service DevServices build-time
settings.
+ * Note: @ConfigGroup is not used here because this interface is nested within
a @ConfigMapping interface.
+ * In Quarkus 3.x, @ConfigGroup is only for legacy @ConfigRoot + @ConfigItem
style configurations.
+ */
+public interface KogitoDevServicesBuildTimeConfig {
/**
* If Dev Services for Kogito has been explicitly enabled or disabled. Dev
Services are generally enabled
* by default, unless there is an existing configuration present.
*/
-@ConfigItem
-public Optional enabled = Optional.empty();
+Optional enabled();
/**
* Optional fixed port the dev service will listen to.
*
* If not defined, 8081 will be used.
*/
-@ConfigItem(defaultValue = "8081")
-public Optional port;
+@WithDefault("8081")
+Optional port();
/**
* The TrustyService image to use.
*/
-@ConfigItem
-public String imageName;
+Optional imageName();
Review Comment:
`imageName()` is defined as `Optional` with no default. Since
DevServices container startup requires an image name, consider providing a
default via `@WithDefault` (and returning `String`) or ensure callers handle
the empty case explicitly (rather than propagating null and failing later).
##
quarkus/addons/kubernetes/test-utils/src/main/java/org/kie/kogito/addons/quarkus/k8s/test/utils/KubernetesMockServerTestResource.java:
##
@@ -55,15 +75,20 @@ public Map start() {
@Override
public void stop() {
+if (client != null) {
+client.close();
+}
if (server != null) {
-server.after(); // Stop the mock server
+server.destroy();
+server = null;
}
Review Comment:
`start()` sets the global system property
`Config.KUBERNETES_MASTER_SYSTEM_PROPERTY`, but `stop()` doesn’t restore/clear
it. This can affect other tests running in the same JVM after this resource
stops. Save the previous value in `start()` and restore it (or clear it) in
`stop()`.
##
quarkus/addons/tracing-decision/deployment/src/main/java/org/kie/kogito/tracing/decision/quarkus/deployment/KogitoDevServicesProcessor.java:
##
@@ -319,12 +319,12 @@ private static final class TrustyServiceDevServiceConfig {
private final int portUsedByTest;
public TrustyServiceDevServiceConfig(final
KogitoDevServicesBuildTimeConfig config) {
-this.devServicesEnabled = config.enabled.orElse(true);
-this.imageName = config.imageName;
-this.fixedExposedPort = config.port.orElse(0);
-this.shared = config.shared;
-this.serviceName = config.serviceName;
-this.portUsedByTest = config.portUsedByTest;
+this.devServicesEnabled = config.enabled().orElse(true);
+this.imageName = config.imageName().orElse(null);
+this.fixedExposedPort = config.port().orElse(0);
+this.shared = config.shared();
+this.serviceName = config.serviceName();
+this.portUsedByTest = config.portUsedByTest();
Review Comment:
`imageName` is now populated via `config.imageName().orElse(null)`. If the
property isn’t set, this will later cause a NullPointerException when
`DockerImageName.parse(config.imageName)` is called during container startup.
Consider making `imageName` required (non-Optional) or providing a safe default
/ explicit error when absent instead of storing null here.
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -51,7 +54,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@Execution(SAME_THREAD)
+@Disabled("Disabled temporarly - when doing quarkus upgrade.")
public class LiveReloadProcessorTest {
Review Comment:
Disabling the entire live-reload test class will hide regressions in
dev-mode hot reload behavior. If this is only to address upgrade
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2793283172
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
+// In v3, address holds the actual path/topic (key is just
an ID)
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
-}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// Iterate operations and map operation key -> AsyncChannelInfo
+if (asyncApi.getOperations() != null) {
+for (Entry opEntry :
asyncApi.getOperations().entrySet()) {
+String opKey = opEntry.getKey();
+if (!(opEntry.getValue() instanceof Operation)) {
+continue;
+}
+Operation op = (Operation) opEntry.getValue();
Review Comment:
@fjtirado addressed the review comment. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2793279980
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
Review Comment:
@fjtirado this is addressed. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3880287015
**PR job** `#20` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/20/display/redirect
**Test results:**
- PASSED: 3913
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/20/testReport/org.kie.kogito.it/JDBCOptimisticLockingIT/PR_check___Build_projects___testParallelPersistence/";>PR
check / Build projects /
org.kie.kogito.it.JDBCOptimisticLockingIT.testParallelPersistence
Assertion condition defined as a Lambda expression in
org.kie.kogito.it.OptimisticLockingTest 1 expectation failed.Expected
status code <404> but was <200>. within 10 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3877417951
**PR job** `#19` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/19/display/redirect
**Test results:**
- PASSED: 3908
- FAILED: 2
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/19/testReport/org.kie.kogito.it/JDBCOptimisticLockingIT/PR_check___Build_projects___testParallelPersistence/";>PR
check / Build projects /
org.kie.kogito.it.JDBCOptimisticLockingIT.testParallelPersistence
Assertion condition defined as a Lambda expression in
org.kie.kogito.it.OptimisticLockingTest 1 expectation failed.Expected
status code <404> but was <200>. within 10 seconds.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/19/testReport/org.kie.kogito.integrationtests.quarkus/TaskIT/testUpdateTaskInfo/";>org.kie.kogito.integrationtests.quarkus.TaskIT.testUpdateTaskInfo
1 expectation failed.Expected status code <403> but was <200>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2787225785 ## quarkus/bom/pom.xml: ## @@ -38,7 +38,7 @@ Review Comment: Updated ## quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/main/resources/specs/asyncAPI.yaml: ## @@ -17,34 +17,47 @@ # under the License. # -asyncapi: '2.0.0' -id: 'oneConsumer' +# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.6.0 to 3.0.0 Review Comment: Updated the comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2787229952
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
+// In v3, address holds the actual path/topic (key is just
an ID)
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
-}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// Iterate operations and map operation key -> AsyncChannelInfo
+if (asyncApi.getOperations() != null) {
+for (Entry opEntry :
asyncApi.getOperations().entrySet()) {
+String opKey = opEntry.getKey();
+if (!(opEntry.getValue() instanceof Operation)) {
+continue;
+}
+Operation op = (Operation) opEntry.getValue();
+
+// In v3.0.0, the operation key is the operation identifier
+String operationId = opKey;
+
+// Resolve the referenced channel ID from "$ref:
#/channels/"
+String channelId = null;
+if (op.getChannel() != null) {
+String ref = op.getChannel().getRef(); // expected form
+if (ref != null && ref.contains("/")) {
+channelId = ref.substring(ref.lastIndexOf('/') + 1);
+}
+}
+
+String address = channelId != null ?
channelIdToAddress.get(channelId) : null;
+OperationAction action = op.getAction();
+
+if (operationId != null && address != null && action != null) {
+// AsyncAPI v3.0.0: action is now OperationAction enum
(SEND/RECEIVE) instead of v2's publish/subscribe
+boolean publish = action == OperationAction.SEND; // send
-> we publish, receive -> we consume
+String channelName = publish ? address + "_out" : address;
+map.putIfAbsent(operationId, new
AsyncChannelInfo(channelName, publish));
+}
Review Comment:
Updated, please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2787227935
##
kogito-serverless-workflow/kogito-serverless-workflow-executor-tests/src/test/java/org/kie/kogito/serverless/workflow/executor/MockKafkaEventEmitterFactory.java:
##
@@ -28,7 +28,8 @@
public class MockKafkaEventEmitterFactory extends KafkaEventEmitterFactory {
-public static MockProducer producer = new
MockProducer<>(true, new ByteArraySerializer(), new CloudEventSerializer() {
+// null key serializer is used because this mock producer doesn't
serialize keys, only values (CloudEvents)
Review Comment:
Updated the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2787227064 ## quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/main/resources/specs/callbackResults.yaml: ## @@ -17,57 +17,91 @@ # under the License. # -asyncapi: '2.0.0' -id: 'callbackResults' +# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.6.0 to 3.0.0 Review Comment: Updated the comment ## quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/main/resources/specs/asyncAPI.yaml: ## @@ -17,34 +17,47 @@ # under the License. # -asyncapi: '2.0.0' -id: 'oneConsumer' +# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.6.0 to 3.0.0 Review Comment: Updated the comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2787224505
##
kogito-serverless-workflow/kogito-serverless-workflow-executor-kafka/src/test/java/org/kie/kogito/serverless/workflow/executor/MockKafkaEventEmitterFactory.java:
##
@@ -28,7 +28,8 @@
public class MockKafkaEventEmitterFactory extends KafkaEventEmitterFactory {
-public static MockProducer producer = new
MockProducer<>(true, new ByteArraySerializer(), new CloudEventSerializer() {
+// null key serializer is used because this mock producer doesn't
serialize keys, only values (CloudEvents)
Review Comment:
Updated the comment
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -1,3 +1,4 @@
+
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2787220408
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
Review Comment:
Made the changes, please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3860048608
**PR job** `#15` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/15/display/redirect
**Test results:**
- PASSED: 3887
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/15/testReport/org.kie.kogito.addons.quarkus.kubernetes/ConfigValueExpanderIT/test/";>org.kie.kogito.addons.quarkus.kubernetes.ConfigValueExpanderIT.test
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.3.4 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:258)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:874)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2651)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2630) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1622)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1589)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:501)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.3.4 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:431)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:459)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:205)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected].
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2773150609 ## kogito-build/kogito-dependencies-bom/pom.xml: ## @@ -131,22 +136,23 @@ 5.0.31 1.8.1 2.0.4 -15.9-alpine3.20 + +16.8-alpine3.21 1.12.0 3.27.7 4.0.6 2.9.0 2.2 4.13.2 -5.12.2 -1.12.2 -5.17.0 +5.13.4 Review Comment: Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2773148522 ## kogito-build/kogito-dependencies-bom/pom.xml: ## @@ -131,22 +136,23 @@ 5.0.31 1.8.1 2.0.4 -15.9-alpine3.20 + +16.8-alpine3.21 1.12.0 3.27.7 4.0.6 2.9.0 2.2 4.13.2 -5.12.2 -1.12.2 -5.17.0 +5.13.4 Review Comment: @yesamer updated for the new module as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2772964784 ## kogito-build/kogito-dependencies-bom/pom.xml: ## @@ -131,22 +136,23 @@ 5.0.31 1.8.1 2.0.4 -15.9-alpine3.20 + +16.8-alpine3.21 1.12.0 3.27.7 4.0.6 2.9.0 2.2 4.13.2 -5.12.2 -1.12.2 -5.17.0 +5.13.4 Review Comment: @jeejz Can you please update the junit version in the newly created module `kogito-gradle-plugin`? (it's a new module, you need to rebase to see it.) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3849791014
**PR job** `#10` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/10/display/redirect
**Test results:**
- PASSED: 3904
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/10/testReport/org.kie.kogito.it/JDBCOptimisticLockingIT/PR_check___Build_projects___testParallelPersistence/";>PR
check / Build projects /
org.kie.kogito.it.JDBCOptimisticLockingIT.testParallelPersistence
Assertion condition defined as a Lambda expression in
org.kie.kogito.it.OptimisticLockingTest 1 expectation failed.Expected
status code <404> but was <200>. within 10 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
pefernan commented on PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3848632949 sorry, marked it ready for review by mistake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3848556551
**PR job** `#7` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/7/display/redirect
**Test results:**
- PASSED: 2749
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/7/testReport/org.kie.kogito.mongodb/KogitoProcessInstancesFactoryIT/___/";>org.kie.kogito.mongodb.KogitoProcessInstancesFactoryIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/7/testReport/org.kie.kogito.mongodb/PersistentProcessInstancesIT/___/";>org.kie.kogito.mongodb.PersistentProcessInstancesIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/7/testReport/org.kie.kogito.mongodb.transaction/AbstractTransactionManagerIT/___/";>org.kie.kogito.mongodb.transaction.AbstractTransactionManagerIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
fjtirado commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2759813586
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
+// In v3, address holds the actual path/topic (key is just
an ID)
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
-}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// Iterate operations and map operation key -> AsyncChannelInfo
+if (asyncApi.getOperations() != null) {
+for (Entry opEntry :
asyncApi.getOperations().entrySet()) {
+String opKey = opEntry.getKey();
+if (!(opEntry.getValue() instanceof Operation)) {
+continue;
+}
+Operation op = (Operation) opEntry.getValue();
Review Comment:
and then you nest the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
fjtirado commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2759809219
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
Review Comment:
```suggestion
if (ch.getValue() instanceof Channel channel) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
fjtirado commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2759812433
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
+// In v3, address holds the actual path/topic (key is just
an ID)
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
-}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// Iterate operations and map operation key -> AsyncChannelInfo
+if (asyncApi.getOperations() != null) {
+for (Entry opEntry :
asyncApi.getOperations().entrySet()) {
+String opKey = opEntry.getKey();
+if (!(opEntry.getValue() instanceof Operation)) {
+continue;
+}
+Operation op = (Operation) opEntry.getValue();
Review Comment:
```suggestion
if (opEntry.getValue instanceof Operation op) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
fjtirado commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2759800568
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
+// AsyncAPI v3.0.0 migration: In v3, channels and operations are
separate top-level objects
+// v2: channels contained publish/subscribe operations directly
+// v3: operations reference channels via $ref, and channels have
addresses
+// Build a helper map: channelId -> address (topic/path)
+Map channelIdToAddress = new HashMap<>();
+if (asyncApi.getChannels() != null) {
+for (Entry ch : asyncApi.getChannels().entrySet())
{
+String channelId = ch.getKey();
+if (ch.getValue() instanceof Channel) {
+Channel channel = (Channel) ch.getValue();
+// In v3, address holds the actual path/topic (key is just
an ID)
+String address =
Optional.ofNullable(channel.getAddress()).orElse(channelId);
+channelIdToAddress.put(channelId, address);
+}
+}
}
-return new AsyncInfo(map);
-}
-private static void addChannel(Map map,
Operation operation, String channelName, boolean publish) {
-if (operation != null) {
-String operationId = operation.getOperationId();
-if (operationId != null) {
-map.putIfAbsent(operationId, new AsyncChannelInfo(channelName,
publish));
+// Iterate operations and map operation key -> AsyncChannelInfo
+if (asyncApi.getOperations() != null) {
+for (Entry opEntry :
asyncApi.getOperations().entrySet()) {
+String opKey = opEntry.getKey();
+if (!(opEntry.getValue() instanceof Operation)) {
+continue;
+}
+Operation op = (Operation) opEntry.getValue();
+
+// In v3.0.0, the operation key is the operation identifier
+String operationId = opKey;
+
+// Resolve the referenced channel ID from "$ref:
#/channels/"
+String channelId = null;
+if (op.getChannel() != null) {
+String ref = op.getChannel().getRef(); // expected form
+if (ref != null && ref.contains("/")) {
+channelId = ref.substring(ref.lastIndexOf('/') + 1);
+}
+}
+
+String address = channelId != null ?
channelIdToAddress.get(channelId) : null;
+OperationAction action = op.getAction();
+
+if (operationId != null && address != null && action != null) {
+// AsyncAPI v3.0.0: action is now OperationAction enum
(SEND/RECEIVE) instead of v2's publish/subscribe
+boolean publish = action == OperationAction.SEND; // send
-> we publish, receive -> we consume
+String channelName = publish ? address + "_out" : address;
+map.putIfAbsent(operationId, new
AsyncChannelInfo(channelName, publish));
+}
Review Comment:
I think this code should nested withint the previous if (that way you save a
couple of redudant if).
For example, if op.getChannel is null, channelId will be null, adrress will
be null, and the map.putIfAbsent block will never be executed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
gitgabrio commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2753004759
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -48,19 +51,57 @@ public Optional apply(String id) {
private static AsyncInfo from(AsyncAPI asyncApi) {
Map map = new HashMap<>();
-for (Entry entry :
asyncApi.getChannels().entrySet()) {
-addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
-addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+
Review Comment:
HI @jeejz , thanks for the PR!
About this method, could you please:
1. split it in two methods (one for `asyncApi.getChannels() != null` and the
other for `asyncApi.getOperations() != null`)
2. could you please rename that `Map map` to a
meaningfull name ?
Above suggestions are meant to improve readability/maintenabilit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
Copilot commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2753006312
##
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##
@@ -1,3 +1,4 @@
+
Review Comment:
This file now starts with a blank line before the ASF license header. With
the repo’s `license-maven-plugin` configuration
(kogito-build/kogito-build-no-bom-parent/pom.xml), headers are typically
expected at the very beginning of the file; the leading blank line can cause
license checks to fail. Remove the initial empty line so the header begins on
line 1.
```suggestion
```
##
kogito-serverless-workflow/kogito-serverless-workflow-executor-kafka/src/test/java/org/kie/kogito/serverless/workflow/executor/MockKafkaEventEmitterFactory.java:
##
@@ -28,7 +28,8 @@
public class MockKafkaEventEmitterFactory extends KafkaEventEmitterFactory {
-public static MockProducer producer = new
MockProducer<>(true, new ByteArraySerializer(), new CloudEventSerializer() {
+// null key serializer is used because this mock producer doesn't
serialize keys, only values (CloudEvents)
Review Comment:
The added comment says a “null key serializer” is being used, but the key
serializer passed here is `ByteArraySerializer`; the `null` is the additional
constructor argument. Please adjust the comment to describe the actual
parameter/behavior (or drop it) so it doesn’t mislead future readers.
```suggestion
// The mock producer uses ByteArraySerializer for keys and
CloudEventSerializer for values; tests ignore keys and operate only on
CloudEvent values.
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/main/resources/specs/asyncAPI.yaml:
##
@@ -17,34 +17,47 @@
# under the License.
#
-asyncapi: '2.0.0'
-id: 'oneConsumer'
+# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.6.0 to 3.0.0
Review Comment:
The new migration comment says “Migrated from AsyncAPI 2.6.0 to 3.0.0”, but
this file previously declared `asyncapi: '2.0.0'`. Consider updating the
comment to reflect the spec version actually being migrated (e.g., 2.0.0 →
3.0.0, or 2.x → 3.0.0) to avoid confusion.
```suggestion
# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.0.0 to 3.0.0
```
##
kogito-serverless-workflow/kogito-serverless-workflow-executor-tests/src/test/java/org/kie/kogito/serverless/workflow/executor/MockKafkaEventEmitterFactory.java:
##
@@ -28,7 +28,8 @@
public class MockKafkaEventEmitterFactory extends KafkaEventEmitterFactory {
-public static MockProducer producer = new
MockProducer<>(true, new ByteArraySerializer(), new CloudEventSerializer() {
+// null key serializer is used because this mock producer doesn't
serialize keys, only values (CloudEvents)
Review Comment:
The added comment says a “null key serializer” is being used, but the key
serializer passed here is `ByteArraySerializer`; the `null` is the additional
constructor argument. Please adjust the comment to describe the actual
parameter/behavior (or drop it) so it doesn’t mislead future readers.
```suggestion
// null transactional id is used; ByteArraySerializer is used for keys
and CloudEventSerializer for values
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/main/resources/specs/callbackResults.yaml:
##
@@ -17,57 +17,91 @@
# under the License.
#
-asyncapi: '2.0.0'
-id: 'callbackResults'
+# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.6.0 to 3.0.0
Review Comment:
The new migration comment says “Migrated from AsyncAPI 2.6.0 to 3.0.0”, but
this file previously declared `asyncapi: '2.0.0'`. Consider updating the
comment to reflect the spec version actually being migrated (e.g., 2.0.0 →
3.0.0, or 2.x → 3.0.0) to avoid confusion.
```suggestion
# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.0.0 to 3.0.0
```
##
quarkus/bom/pom.xml:
##
@@ -38,7 +38,7 @@
Review Comment:
The inline comment still references the Quarkus 3.20.1 BOM URL, but this PR
upgrades Quarkus-related deps. Please update the referenced Quarkus
version/link (or make it version-agnostic) so future maintainers can verify
alignment correctly.
```suggestion
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/main/resources/specs/asyncAPI.yaml:
##
@@ -17,34 +17,47 @@
# under the License.
#
-asyncapi: '2.0.0'
-id: 'oneConsumer'
+# Quarkus 3.27.2 upgrade: Migrated from AsyncAPI 2.6.0 to 3.0.0
Review Comment:
The new migration comment says “Migrated from AsyncAPI 2.6.0 to 3.0.0”, but
this file previously declared
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3822743906
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/display/redirect
**Test results:**
- PASSED: 3735
- FAILED: 145
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testMigrateSingle/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testMigrateSingle
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testSignalStorage/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testSignalStorage
Error finding all process instances, for processId
IntermediateCatchEventSignal
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testMigrateAll/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testMigrateAll
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testBasicFlow/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testBasicFlow
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testMultipleProcesses/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testMultipleProcesses
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testProcessWithDifferentVersion/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testProcessWithDifferentVersion
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testRemove/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testRemove
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesIT/testUpdate/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesIT.testUpdate
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesWithLockIT/testMigrateSingle/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesWithLockIT.testMigrateSingle
Error finding all process instances, for processId BPMN2_UserTask
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesWithLockIT/testSignalStorage/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesWithLockIT.testSignalStorage
Error finding all process instances, for processId
IntermediateCatchEventSignal
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/1/testReport/org.kie.persistence.postgresql/PostgresqlProcessInstancesWithLockIT/testMigrateAll/";>org.kie.persistence.postgresql.PostgresqlProcessInstancesWithLockIT.testMigrateAll
Error f
