Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
jeejz commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2801683793 ## build-parent/pom.xml: ## @@ -69,13 +69,13 @@ 4.0.5 1.4.21 0.18.0 -4.7.5 +4.7.7 1.14.12 -3.20.3 -4.1.128.Final +3.27.2 +4.1.130.Final Review Comment: @baldimir natty version is upgraded to 4.1.131.Final Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
baldimir commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2799427306 ## build-parent/pom.xml: ## @@ -69,13 +69,13 @@ 4.0.5 1.4.21 0.18.0 -4.7.5 +4.7.7 1.14.12 -3.20.3 -4.1.128.Final +3.27.2 +4.1.130.Final Review Comment: Hi, there is netty version 4.1.131.Final already available. Please consider updating it (also in other repos). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
yesamer commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2798507747 ## build-parent/pom.xml: ## @@ -222,8 +222,8 @@ 4.0.2 1.4.0 -4.5.22 -1.8.1 +4.5.23 +1.10.1 Review Comment: Not relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
Copilot commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2798299470 ## build-parent/pom.xml: ## @@ -222,8 +222,8 @@ 4.0.2 1.4.0 -4.5.22 -1.8.1 +4.5.23 +1.10.1 Review Comment: The version.at.yawk.lz4.java property is not in alphabetical order. According to the documented convention at lines 49-53, version properties must be sorted alphabetically. This property should be moved to appear before version.ch.qos.logback (currently at line 54), as "at" comes before "ch" alphabetically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
jeejz commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2772800909 ## build-parent/pom.xml: ## @@ -103,26 +103,26 @@ 15.0.21.Final 5.0.13.Final 3.26.0-GA - 7.0.2.Final + 7.2.2.Final 3.6.1.Final 8.0.0.Final 3.1.6.Final 3.1 - 4.0.1 + 4.1.0 2.0.3 2.1.4 2.0.1 -2.1.1 +3.0.0 2.0.1 -3.1.0 +3.2.0 4.0.4 -3.0.0 -1.1.5 +3.0.1 +1.1.7 2.1.3 4.0.0 1.6.4 -5.12.2 -1.12.2 +5.13.4 +1.13.4 2.5.2.Final 2.0.9 2.0.6 Review Comment: Synced to latest version in both repos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
jeejz commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2772798465 ## build-parent/pom.xml: ## Review Comment: Synced to optaplanner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
yesamer commented on code in PR #6575: URL: https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2754604146 ## build-parent/pom.xml: ## Review Comment: In Optaplanner you updated it to 2.3.34, why? Please try to keep consistency, when possible. ## build-parent/pom.xml: ## @@ -103,26 +103,26 @@ 15.0.21.Final 5.0.13.Final 3.26.0-GA - 7.0.2.Final + 7.2.2.Final 3.6.1.Final 8.0.0.Final 3.1.6.Final 3.1 - 4.0.1 + 4.1.0 2.0.3 2.1.4 2.0.1 -2.1.1 +3.0.0 2.0.1 -3.1.0 +3.2.0 4.0.4 -3.0.0 -1.1.5 +3.0.1 +1.1.7 2.1.3 4.0.0 1.6.4 -5.12.2 -1.12.2 +5.13.4 +1.13.4 2.5.2.Final 2.0.9 2.0.6 Review Comment: In Optaplanner you updated that to 2.24.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
gitgabrio commented on code in PR #6575:
URL:
https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2742294040
##
drools-quarkus-extension/drools-quarkus-ruleunits-deployment/pom.xml:
##
@@ -136,9 +136,6 @@
${version.io.quarkus}
-
--AlegacyConfigRoot=true
Review Comment:
Thx @jeejz 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
kie-ci3 commented on PR #6575:
URL:
https://github.com/apache/incubator-kie-drools/pull/6575#issuecomment-3818462119
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-drools -u
https://github.com/apache/incubator-kie-drools/pull/6575 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6575/2/display/redirect
**Test results:**
- PASSED: 24087
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6575/2/testReport/org.kie.scanner/KieModuleMavenTest/testKieModuleFromMavenWithDependenciesProperties/";>org.kie.scanner.KieModuleMavenTest.testKieModuleFromMavenWithDependenciesProperties
org.eclipse.aether.collection.DependencyCollectionException: Failed to
collect dependencies at org.kie.test:maven-test:jar:1.0-SNAPSHOT ->
org.kie.ci.test:kie-ci-test-jar-with-dep:jar:1.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
jeejz commented on code in PR #6575:
URL:
https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2742167007
##
drools-quarkus-extension/drools-quarkus-ruleunits-deployment/pom.xml:
##
@@ -136,9 +136,6 @@
${version.io.quarkus}
-
--AlegacyConfigRoot=true
Review Comment:
@gitgabrio
The `-AlegacyConfigRoot=true` flag is no longer available because the
underlying support for class-based @ConfigRoot has been completely removed in
the newer Quarkus version (3.27.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
gitgabrio commented on code in PR #6575:
URL:
https://github.com/apache/incubator-kie-drools/pull/6575#discussion_r2741868758
##
drools-quarkus-extension/drools-quarkus-ruleunits-deployment/pom.xml:
##
@@ -136,9 +136,6 @@
${version.io.quarkus}
-
--AlegacyConfigRoot=true
Review Comment:
Many thanks @jeejz !
Could you please explain why that arg is removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
jeejz closed pull request #6574: [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 URL: https://github.com/apache/incubator-kie-drools/pull/6574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 [incubator-kie-drools]
jeejz closed pull request #6574: [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 URL: https://github.com/apache/incubator-kie-drools/pull/6574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
