Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
pefernan commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2821546058
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/JPADynamicQuery.java:
##
@@ -112,7 +110,9 @@ private Object transform(GraphQLOutputType outputType,
Object source) {
if (outputType instanceof GraphQLScalarType) {
GraphQLScalarType scalarType = (GraphQLScalarType) outputType;
if ("DateTime".equals(scalarType.getName())) {
-target = OffsetDateTime.ofInstant(((Timestamp)
source).toInstant(), ZoneId.of("UTC"));
+// Hibernate 7 returns OffsetDateTime directly for temporal
columns in native queries,
+// not java.sql.Timestamp as in Hibernate 5/6. Use
DateTimeUtil for cross-version compatibility.
+target = DateTimeUtil.toDateTime(source);
Review Comment:
maybe use static import directly here. Also no need to have this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
pefernan commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2821474453
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/mapper/PojoMapper.java:
##
@@ -46,14 +51,60 @@ public PojoMapper(Class clazz) {
@Override
public List produce(List data) {
List transformed = new ArrayList<>();
+Class[] paramTypes = defaultConstructor.getParameterTypes();
for (Object[] row : data) {
try {
-transformed.add(defaultConstructor.newInstance(row));
+// Hibernate 7 changed default return types for native queries
+// (e.g. OffsetDateTime instead of java.util.Date, Long
instead of Integer).
+// Convert each value to match the constructor's declared
parameter types.
+Object[] convertedRow = convertTypes(row, paramTypes);
+transformed.add(defaultConstructor.newInstance(convertedRow));
} catch (InstantiationException | IllegalAccessException |
IllegalArgumentException | InvocationTargetException e) {
LOGGER.error("Could not transform data", e);
}
}
return transformed;
}
+private static Object[] convertTypes(Object[] row, Class[] paramTypes) {
+Object[] result = new Object[row.length];
+for (int i = 0; i < row.length; i++) {
+result[i] = (i < paramTypes.length) ? convertValue(row[i],
paramTypes[i]) : row[i];
+}
+return result;
+}
+
+private static Object convertValue(Object value, Class targetType) {
+if (value == null || targetType.isInstance(value)) {
+return value;
+}
+// Hibernate 7 returns java.time types instead of java.util.Date
+if (targetType == Date.class) {
+if (value instanceof OffsetDateTime) {
+return Date.from(((OffsetDateTime) value).toInstant());
+}
+if (value instanceof Instant) {
+return Date.from((Instant) value);
+}
+if (value instanceof LocalDateTime) {
+return Date.from(((LocalDateTime)
value).atZone(ZoneId.of("UTC")).toInstant());
+}
+}
+// Hibernate 7 may return different numeric types for native query
columns
+if (targetType == Integer.class || targetType == int.class) {
+if (value instanceof Number) {
+return ((Number) value).intValue();
+}
+}
+if (targetType == Long.class || targetType == long.class) {
+if (value instanceof Number) {
+return ((Number) value).longValue();
+}
+}
+if (targetType == String.class) {
+return value.toString();
Review Comment:
@jeejz is this really needed? is Hibernate wrapping strings values in a
custom type?
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/JPADynamicQuery.java:
##
@@ -112,7 +110,9 @@ private Object transform(GraphQLOutputType outputType,
Object source) {
if (outputType instanceof GraphQLScalarType) {
GraphQLScalarType scalarType = (GraphQLScalarType) outputType;
if ("DateTime".equals(scalarType.getName())) {
-target = OffsetDateTime.ofInstant(((Timestamp)
source).toInstant(), ZoneId.of("UTC"));
+// Hibernate 7 returns OffsetDateTime directly for temporal
columns in native queries,
+// not java.sql.Timestamp as in Hibernate 5/6. Use
DateTimeUtil for cross-version compatibility.
+target = DateTimeUtil.toDateTime(source);
Review Comment:
maybe use static import directly here.
##
data-index/data-index-springboot/kogito-addons-springboot-data-index-persistence/kogito-addons-springboot-data-index-persistence-jpa-parent/integration-tests-process/src/main/resources/application.properties:
##
@@ -24,5 +24,4 @@ kogito.persistence.type=jdbc
kie.flyway.enabled=true
# Disabling Spring-Boot Flyway to avoid unnecessary Data Base initialization
-spring.flyway.enabled=false
-
+spring.flyway.enabled=false
Review Comment:
Unnecessary change?
##
jobs/kogito-addons-springboot-embedded-jobs/src/main/java/org/kie/kogito/app/jobs/springboot/SpringbootJobServiceConfiguration.java:
##
@@ -39,6 +39,11 @@
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.ComponentScan;
+// Note: The Hibernate 7 + Spring ORM 6.2 EntityManagerFactory workaround
(BeanPostProcessor for
+// setEntityManagerFactoryInterface) is intentionally NOT in this class. This
module does not have
Review Comment:
Maybe we don't need this comment
##
jobs/kogito-addons-em
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#issuecomment-3909183045
**PR job** `#7` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2298
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/7/display/redirect
**Test results:**
- PASSED: 1724
- FAILED: 2
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/7/testReport/org.kie.kogito.it.jobs/CallbackStateTimeoutsIT/PR_check___Build_projects___callbackStateTimeoutsExceeded/";>PR
check / Build projects /
org.kie.kogito.it.jobs.CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.3.4 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:258)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:874)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2651)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2630) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1622)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1589)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:501)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.3.4 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:431)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:459)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:205)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/7/testReport/org.kie.kogito.app.jobs.jpa.quarkus/QuarkusJPAJobStoreTest/testBasicPersistence/";>org.kie.kogito.app.jobs.jpa.quarkus.QuarkusJPAJobStoreTest.testBasicPersistence
Expecting value to be true but was false
--
This is an automated message from the Apache G
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
jeejz commented on code in PR #2298: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812188308 ## data-index/data-index-springboot/kogito-addons-springboot-data-index-persistence/kogito-addons-springboot-data-index-persistence-jpa-parent/integration-tests-process/src/main/resources/application.properties: ## @@ -26,3 +26,4 @@ kie.flyway.enabled=true # Disabling Spring-Boot Flyway to avoid unnecessary Data Base initialization spring.flyway.enabled=false + Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
jeejz commented on code in PR #2298: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812179334 ## jobs-service/jobs-service-inmemory/src/main/resources/application.properties: ## @@ -20,6 +20,9 @@ #Flyway - It's safe to enable Flyway by default for in-memory storage quarkus.flyway.migrate-at-start=true quarkus.flyway.baseline-on-migrate=true +# Disable Flyway validation to avoid conflicts with data-index migrations applied +# to the shared dev-services PostgreSQL container by earlier modules in the build. +quarkus.flyway.validate-on-migrate=false Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
jeejz commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812177887
##
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/graphql/GraphQLProtoSchemaMapper.java:
##
@@ -118,6 +119,11 @@ public void onDomainModelRegisteredEvent(@Observes
DomainModelRegisteredEvent ev
codeBuilder.dataFetcher(coordinates("Query",
rootType.getName()),
schemaManager.getDomainModelDataFetcher(event.getProcessId()));
codeBuilder.dataFetcher(coordinates("Subscription",
rootType.getName() + "Added"),
schemaManager.getDomainModelAddedDataFetcher(event.getProcessId()));
codeBuilder.dataFetcher(coordinates("Subscription",
rootType.getName() + "Updated"),
schemaManager.getDomainModelUpdatedDataFetcher(event.getProcessId()));
+// graphql-java 24.x LightDataFetcher optimization bypasses
instrumentDataFetcher,
+// so PropertyDataFetcher is no longer intercepted for
JsonNode-based sources (MongoDB).
+// Set default data fetcher factory to JsonPropertyDataFetcher
which handles both
+// JsonNode (MongoDB) and POJO (PostgreSQL) sources.
+codeBuilder.defaultDataFetcher(env -> new
JsonPropertyDataFetcher());
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
jeejz commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812176699
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/mapper/PojoMapper.java:
##
@@ -46,14 +51,60 @@ public PojoMapper(Class clazz) {
@Override
public List produce(List data) {
List transformed = new ArrayList<>();
+Class[] paramTypes = defaultConstructor.getParameterTypes();
for (Object[] row : data) {
try {
-transformed.add(defaultConstructor.newInstance(row));
+// Hibernate 7 changed default return types for native queries
+// (e.g. OffsetDateTime instead of java.util.Date, Long
instead of Integer).
+// Convert each value to match the constructor's declared
parameter types.
+Object[] convertedRow = convertTypes(row, paramTypes);
+transformed.add(defaultConstructor.newInstance(convertedRow));
} catch (InstantiationException | IllegalAccessException |
IllegalArgumentException | InvocationTargetException e) {
LOGGER.error("Could not transform data", e);
}
}
return transformed;
}
+private static Object[] convertTypes(Object[] row, Class[] paramTypes) {
+Object[] result = new Object[row.length];
+for (int i = 0; i < row.length; i++) {
+result[i] = (i < paramTypes.length) ? convertValue(row[i],
paramTypes[i]) : row[i];
+}
+return result;
+}
+
+private static Object convertValue(Object value, Class targetType) {
+if (value == null || targetType.isInstance(value)) {
+return value;
+}
+// Hibernate 7 returns java.time types instead of java.util.Date
+if (targetType == Date.class) {
+if (value instanceof OffsetDateTime) {
+return Date.from(((OffsetDateTime) value).toInstant());
+}
+if (value instanceof Instant) {
+return Date.from((Instant) value);
+}
+if (value instanceof LocalDateTime) {
+return Date.from(((LocalDateTime)
value).atZone(ZoneId.systemDefault()).toInstant());
+}
Review Comment:
This is fixed. (the above snippet is is still referenced from a specific
commit not from the head of this branch.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
nrknithin commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812072359
##
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/graphql/GraphQLProtoSchemaMapper.java:
##
@@ -118,6 +119,11 @@ public void onDomainModelRegisteredEvent(@Observes
DomainModelRegisteredEvent ev
codeBuilder.dataFetcher(coordinates("Query",
rootType.getName()),
schemaManager.getDomainModelDataFetcher(event.getProcessId()));
codeBuilder.dataFetcher(coordinates("Subscription",
rootType.getName() + "Added"),
schemaManager.getDomainModelAddedDataFetcher(event.getProcessId()));
codeBuilder.dataFetcher(coordinates("Subscription",
rootType.getName() + "Updated"),
schemaManager.getDomainModelUpdatedDataFetcher(event.getProcessId()));
+// graphql-java 24.x LightDataFetcher optimization bypasses
instrumentDataFetcher,
+// so PropertyDataFetcher is no longer intercepted for
JsonNode-based sources (MongoDB).
+// Set default data fetcher factory to JsonPropertyDataFetcher
which handles both
+// JsonNode (MongoDB) and POJO (PostgreSQL) sources.
+codeBuilder.defaultDataFetcher(env -> new
JsonPropertyDataFetcher());
Review Comment:
Extracted private static final JsonPropertyDataFetcher
JSON_PROPERTY_DATA_FETCHER = new JsonPropertyDataFetcher(); and reference it in
the lambda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
nrknithin commented on code in PR #2298: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812070147 ## jobs-service/jobs-service-inmemory/src/main/resources/application.properties: ## @@ -20,6 +20,9 @@ #Flyway - It's safe to enable Flyway by default for in-memory storage quarkus.flyway.migrate-at-start=true quarkus.flyway.baseline-on-migrate=true +# Disable Flyway validation to avoid conflicts with data-index migrations applied +# to the shared dev-services PostgreSQL container by earlier modules in the build. +quarkus.flyway.validate-on-migrate=false Review Comment: coped to dev/test profiles only: %dev.quarkus.flyway.validate-on-migrate=false %test.quarkus.flyway.validate-on-migrate=false ## jobs-service/jobs-service-inmemory/src/main/resources/application.properties: ## @@ -20,6 +20,9 @@ #Flyway - It's safe to enable Flyway by default for in-memory storage quarkus.flyway.migrate-at-start=true quarkus.flyway.baseline-on-migrate=true +# Disable Flyway validation to avoid conflicts with data-index migrations applied +# to the shared dev-services PostgreSQL container by earlier modules in the build. +quarkus.flyway.validate-on-migrate=false Review Comment: Scoped to dev/test profiles only: %dev.quarkus.flyway.validate-on-migrate=false %test.quarkus.flyway.validate-on-migrate=false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
nrknithin commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2812063688
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/mapper/PojoMapper.java:
##
@@ -46,14 +51,60 @@ public PojoMapper(Class clazz) {
@Override
public List produce(List data) {
List transformed = new ArrayList<>();
+Class[] paramTypes = defaultConstructor.getParameterTypes();
for (Object[] row : data) {
try {
-transformed.add(defaultConstructor.newInstance(row));
+// Hibernate 7 changed default return types for native queries
+// (e.g. OffsetDateTime instead of java.util.Date, Long
instead of Integer).
+// Convert each value to match the constructor's declared
parameter types.
+Object[] convertedRow = convertTypes(row, paramTypes);
+transformed.add(defaultConstructor.newInstance(convertedRow));
} catch (InstantiationException | IllegalAccessException |
IllegalArgumentException | InvocationTargetException e) {
LOGGER.error("Could not transform data", e);
}
}
return transformed;
}
+private static Object[] convertTypes(Object[] row, Class[] paramTypes) {
+Object[] result = new Object[row.length];
+for (int i = 0; i < row.length; i++) {
+result[i] = (i < paramTypes.length) ? convertValue(row[i],
paramTypes[i]) : row[i];
+}
+return result;
+}
+
+private static Object convertValue(Object value, Class targetType) {
+if (value == null || targetType.isInstance(value)) {
+return value;
+}
+// Hibernate 7 returns java.time types instead of java.util.Date
+if (targetType == Date.class) {
+if (value instanceof OffsetDateTime) {
+return Date.from(((OffsetDateTime) value).toInstant());
+}
+if (value instanceof Instant) {
+return Date.from((Instant) value);
+}
+if (value instanceof LocalDateTime) {
+return Date.from(((LocalDateTime)
value).atZone(ZoneId.systemDefault()).toInstant());
+}
Review Comment:
Changed ZoneId.systemDefault() → ZoneId.of("UTC") to match DateTimeUtil in
the same package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
Copilot commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2798327463
##
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/graphql/GraphQLProtoSchemaMapper.java:
##
@@ -118,6 +119,11 @@ public void onDomainModelRegisteredEvent(@Observes
DomainModelRegisteredEvent ev
codeBuilder.dataFetcher(coordinates("Query",
rootType.getName()),
schemaManager.getDomainModelDataFetcher(event.getProcessId()));
codeBuilder.dataFetcher(coordinates("Subscription",
rootType.getName() + "Added"),
schemaManager.getDomainModelAddedDataFetcher(event.getProcessId()));
codeBuilder.dataFetcher(coordinates("Subscription",
rootType.getName() + "Updated"),
schemaManager.getDomainModelUpdatedDataFetcher(event.getProcessId()));
+// graphql-java 24.x LightDataFetcher optimization bypasses
instrumentDataFetcher,
+// so PropertyDataFetcher is no longer intercepted for
JsonNode-based sources (MongoDB).
+// Set default data fetcher factory to JsonPropertyDataFetcher
which handles both
+// JsonNode (MongoDB) and POJO (PostgreSQL) sources.
+codeBuilder.defaultDataFetcher(env -> new
JsonPropertyDataFetcher());
Review Comment:
defaultDataFetcher is configured with `env -> new
JsonPropertyDataFetcher()`, which will allocate a new DataFetcher instance each
time the factory is invoked. JsonPropertyDataFetcher appears stateless, so
reuse a single instance (e.g., a static final) to avoid unnecessary allocations
when rebuilding the schema/code registry.
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/src/main/java/org/kie/kogito/app/audit/jpa/queries/mapper/PojoMapper.java:
##
@@ -46,14 +51,60 @@ public PojoMapper(Class clazz) {
@Override
public List produce(List data) {
List transformed = new ArrayList<>();
+Class[] paramTypes = defaultConstructor.getParameterTypes();
for (Object[] row : data) {
try {
-transformed.add(defaultConstructor.newInstance(row));
+// Hibernate 7 changed default return types for native queries
+// (e.g. OffsetDateTime instead of java.util.Date, Long
instead of Integer).
+// Convert each value to match the constructor's declared
parameter types.
+Object[] convertedRow = convertTypes(row, paramTypes);
+transformed.add(defaultConstructor.newInstance(convertedRow));
} catch (InstantiationException | IllegalAccessException |
IllegalArgumentException | InvocationTargetException e) {
LOGGER.error("Could not transform data", e);
}
}
return transformed;
}
+private static Object[] convertTypes(Object[] row, Class[] paramTypes) {
+Object[] result = new Object[row.length];
+for (int i = 0; i < row.length; i++) {
+result[i] = (i < paramTypes.length) ? convertValue(row[i],
paramTypes[i]) : row[i];
+}
+return result;
+}
+
+private static Object convertValue(Object value, Class targetType) {
+if (value == null || targetType.isInstance(value)) {
+return value;
+}
+// Hibernate 7 returns java.time types instead of java.util.Date
+if (targetType == Date.class) {
+if (value instanceof OffsetDateTime) {
+return Date.from(((OffsetDateTime) value).toInstant());
+}
+if (value instanceof Instant) {
+return Date.from((Instant) value);
+}
+if (value instanceof LocalDateTime) {
+return Date.from(((LocalDateTime)
value).atZone(ZoneId.systemDefault()).toInstant());
+}
Review Comment:
PojoMapper converts LocalDateTime -> Date using ZoneId.systemDefault(),
which makes native-query temporal mapping depend on the host timezone and can
shift timestamps between environments. This should use a deterministic zone
(likely UTC, consistent with DateTimeUtil and the other mappers) when
converting LocalDateTime to an Instant.
##
jobs-service/jobs-service-inmemory/src/main/resources/application.properties:
##
@@ -20,6 +20,9 @@
#Flyway - It's safe to enable Flyway by default for in-memory storage
quarkus.flyway.migrate-at-start=true
quarkus.flyway.baseline-on-migrate=true
+# Disable Flyway validation to avoid conflicts with data-index migrations
applied
+# to the shared dev-services PostgreSQL container by earlier modules in the
build.
+quarkus.flyway.validate-on-migrate=false
Review Comment:
Disabling `quarkus.flyway.validate-on-migrate` in main
application.properties reduces protection against accidental schema drift at
runtime. If this is only needed to avoid CI/dev-services cros
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
jeejz commented on code in PR #2298: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2793310542 ## data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/pom.xml: ## @@ -100,9 +100,8 @@ test - org.hibernate - hibernate-entitymanager - 5.6.12.Final + org.hibernate.orm + hibernate-core Review Comment: this is version tag is already present in the kogito-apps-build-parent/pom.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#issuecomment-3871317718
**PR job** `#5` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2298
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/5/display/redirect
**Test results:**
- PASSED: 1737
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/5/testReport/org.kie.kogito.app.jobs.jpa.quarkus/QuarkusJPAJobStoreTest/testBasicPersistence/";>org.kie.kogito.app.jobs.jpa.quarkus.QuarkusJPAJobStoreTest.testBasicPersistence
Expecting value to be true but was false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#issuecomment-3870153765
**PR job** `#4` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2298
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/display/redirect
**Test results:**
- PASSED: 1666
- FAILED: 59
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllScheduledJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllScheduledJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllPendingJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllPendingJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobsByStatus/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobsByStatus
Expecting actual: []to contain exactly in any order:
["job1", "job4"]but could not find the following elements: ["job1",
"job4"]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobById
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobHistoryById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobHistoryById
Expected size: 3 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllInErrorJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllInErrorJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobs
Expected size: 5 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobByProcessInstanceId/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobByProcessInstanceId
Expecting actual not to be empty
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForExecution/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForExecution
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForRetry/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForRetry
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllCompletedJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllCompletedJobs
Expected size: 2 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/4/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTes
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#issuecomment-3854849402
**PR job** `#3` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2298
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/display/redirect
**Test results:**
- PASSED: 1659
- FAILED: 59
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllScheduledJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllScheduledJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllPendingJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllPendingJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobsByStatus/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobsByStatus
Expecting actual: []to contain exactly in any order:
["job1", "job4"]but could not find the following elements: ["job1",
"job4"]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobById
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobHistoryById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobHistoryById
Expected size: 3 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllInErrorJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllInErrorJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobs
Expected size: 5 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobByProcessInstanceId/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobByProcessInstanceId
Expecting actual not to be empty
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForExecution/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForExecution
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForRetry/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForRetry
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllCompletedJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllCompletedJobs
Expected size: 2 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/3/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTes
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#issuecomment-3847672692
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2298
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/display/redirect
**Test results:**
- PASSED: 1659
- FAILED: 59
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllScheduledJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllScheduledJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllPendingJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllPendingJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobsByStatus/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobsByStatus
Expecting actual: []to contain exactly in any order:
["job1", "job4"]but could not find the following elements: ["job1",
"job4"]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobById
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobHistoryById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobHistoryById
Expected size: 3 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllInErrorJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllInErrorJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobs
Expected size: 5 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobByProcessInstanceId/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobByProcessInstanceId
Expecting actual not to be empty
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForExecution/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForExecution
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForRetry/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForRetry
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllCompletedJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllCompletedJobs
Expected size: 2 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/2/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTes
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
Copilot commented on code in PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#discussion_r2753059720
##
data-audit/kogito-addons-data-audit-jpa/kogito-addons-data-audit-jpa-common/pom.xml:
##
@@ -100,9 +100,8 @@
test
- org.hibernate
- hibernate-entitymanager
- 5.6.12.Final
+ org.hibernate.orm
+ hibernate-core
Review Comment:
The hibernate-core dependency is now using groupId org.hibernate.orm without
an explicit version. This dependency should either have:
1. An explicit version tag referencing ${version.org.hibernate}, OR
2. Be managed in the dependencyManagement section of
kogito-apps-build-parent/pom.xml
Currently, hibernate-ant is managed in the parent (line 202-206 of
kogito-apps-build-parent/pom.xml) with version ${version.org.hibernate}, but
hibernate-core is not. Please verify that hibernate-core's version is properly
managed in one of the imported BOMs (kogito-quarkus-bom or kogito-apps-bom). If
it's not managed there, consider adding explicit version management to ensure
consistent versions across all modules.
```suggestion
hibernate-core
${version.org.hibernate}
```
##
kogito-apps-build-parent/pom.xml:
##
@@ -62,7 +62,7 @@
${project.version}
-6.6.11.Final
+7.1.14.Final
Review Comment:
The PR title explicitly states "[DO-NOT-MERGE]". This indicates that this
pull request is not intended to be merged in its current state and likely
requires additional work, review, or coordination with other changes before it
can be merged.
##
jobs/kogito-addons-embedded-jobs-jpa/kogito-addons-common-embedded-jobs-jpa/pom.xml:
##
@@ -109,9 +109,8 @@
test
- org.hibernate
- hibernate-entitymanager
- 5.6.12.Final
+ org.hibernate.orm
+ hibernate-core
test
Review Comment:
The hibernate-core dependency is now using groupId org.hibernate.orm without
an explicit version. This dependency should either have:
1. An explicit version tag referencing ${version.org.hibernate}, OR
2. Be managed in the dependencyManagement section of
kogito-apps-build-parent/pom.xml
Currently, hibernate-ant is managed in the parent (line 202-206 of
kogito-apps-build-parent/pom.xml) with version ${version.org.hibernate}, but
hibernate-core is not. Please verify that hibernate-core's version is properly
managed in one of the imported BOMs (kogito-quarkus-bom or kogito-apps-bom). If
it's not managed there, consider adding explicit version management to ensure
consistent versions across all modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [DO-NOT-MERGE][incubator-kie-issues-2204] Quarkus upgrade 3.27.2 and Spring Boot to 3.5.10 [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2298:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2298#issuecomment-3823712621
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2298
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/display/redirect
**Test results:**
- PASSED: 1658
- FAILED: 60
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllScheduledJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllScheduledJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllPendingJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllPendingJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobsByStatus/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobsByStatus
Expecting actual: []to contain exactly in any order:
["job1", "job4"]but could not find the following elements: ["job1",
"job4"]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobById
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobHistoryById/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobHistoryById
Expected size: 3 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllInErrorJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllInErrorJobs
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllJobs
Expected size: 5 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetJobByProcessInstanceId/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetJobByProcessInstanceId
Expecting actual not to be empty
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForExecution/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForExecution
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllEligibleJobsForRetry/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllEligibleJobsForRetry
Expected size: 1 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTest/testGetAllCompletedJobs/";>org.kie.kogito.app.audit.quarkus.QuarkusAuditJobServiceTest.testGetAllCompletedJobs
Expected size: 2 but was: 0 in:[]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2298/1/testReport/org.kie.kogito.app.audit.quarkus/QuarkusAuditJobServiceTes
