Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
gitgabrio merged PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
ChinchuAjith commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2177543446 ## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BaseFEELFunction.java: ## @@ -20,16 +20,15 @@ import java.lang.reflect.Method; import java.lang.reflect.Modifier; -import java.util.Arrays; -import java.util.Collections; -import java.util.List; -import java.util.Set; +import java.util.*; Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
ChinchuAjith commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2177542824 ## kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNCompilerImpl.java: ## @@ -37,11 +37,7 @@ import java.util.stream.Collectors; import javax.xml.namespace.QName; import org.kie.api.io.Resource; -import org.kie.dmn.api.core.DMNCompiler; -import org.kie.dmn.api.core.DMNCompilerConfiguration; -import org.kie.dmn.api.core.DMNMessage; -import org.kie.dmn.api.core.DMNModel; -import org.kie.dmn.api.core.DMNType; +import org.kie.dmn.api.core.*; Review Comment: Done ## kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/impl/DMNModelImpl.java: ## @@ -57,13 +58,7 @@ import org.kie.dmn.core.assembler.DMNAssemblerService; import org.kie.dmn.core.ast.BusinessKnowledgeModelNodeImpl; import org.kie.dmn.core.ast.DecisionNodeImpl; -import org.kie.dmn.core.compiler.DMNCompilerImpl; -import org.kie.dmn.core.compiler.DMNTypeRegistry; -import org.kie.dmn.core.compiler.DMNTypeRegistryV11; -import org.kie.dmn.core.compiler.DMNTypeRegistryV12; -import org.kie.dmn.core.compiler.DMNTypeRegistryV13; -import org.kie.dmn.core.compiler.DMNTypeRegistryV14; -import org.kie.dmn.core.compiler.DMNTypeRegistryV15; +import org.kie.dmn.core.compiler.*; Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
ChinchuAjith commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2176920598 ## kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/ast/DMNInvocationEvaluator.java: ## @@ -25,14 +25,10 @@ import javax.xml.namespace.QName; -import org.kie.dmn.api.core.DMNContext; -import org.kie.dmn.api.core.DMNMessage; -import org.kie.dmn.api.core.DMNResult; -import org.kie.dmn.api.core.DMNType; +import org.kie.dmn.api.core.*; Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
yesamer commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2177319047 ## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BaseFEELFunction.java: ## @@ -20,16 +20,15 @@ import java.lang.reflect.Method; import java.lang.reflect.Modifier; -import java.util.Arrays; -import java.util.Collections; -import java.util.List; -import java.util.Set; +import java.util.*; Review Comment: @ChinchuAjith Group imports to be removed. ## kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/impl/DMNModelImpl.java: ## @@ -57,13 +58,7 @@ import org.kie.dmn.core.assembler.DMNAssemblerService; import org.kie.dmn.core.ast.BusinessKnowledgeModelNodeImpl; import org.kie.dmn.core.ast.DecisionNodeImpl; -import org.kie.dmn.core.compiler.DMNCompilerImpl; -import org.kie.dmn.core.compiler.DMNTypeRegistry; -import org.kie.dmn.core.compiler.DMNTypeRegistryV11; -import org.kie.dmn.core.compiler.DMNTypeRegistryV12; -import org.kie.dmn.core.compiler.DMNTypeRegistryV13; -import org.kie.dmn.core.compiler.DMNTypeRegistryV14; -import org.kie.dmn.core.compiler.DMNTypeRegistryV15; +import org.kie.dmn.core.compiler.*; Review Comment: @ChinchuAjith Group imports to be removed. ## kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNCompilerImpl.java: ## @@ -37,11 +37,7 @@ import java.util.stream.Collectors; import javax.xml.namespace.QName; import org.kie.api.io.Resource; -import org.kie.dmn.api.core.DMNCompiler; -import org.kie.dmn.api.core.DMNCompilerConfiguration; -import org.kie.dmn.api.core.DMNMessage; -import org.kie.dmn.api.core.DMNModel; -import org.kie.dmn.api.core.DMNType; +import org.kie.dmn.api.core.*; Review Comment: @ChinchuAjith Group imports to be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
ChinchuAjith commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2176921141 ## kie-dmn/kie-dmn-core-jsr223/src/main/java/org/kie/dmn/core/jsr223/JSR223EvaluatorCompiler.java: ## @@ -26,6 +26,7 @@ import javax.script.ScriptEngineFactory; import javax.script.ScriptEngineManager; +import org.kie.dmn.api.core.DMNVersion; Review Comment: Removed this unused imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
ChinchuAjith commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2176922018 ## kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/FEELFnResultTest.java: ## @@ -0,0 +1,22 @@ +package org.kie.dmn.feel.runtime.functions; Review Comment: Added License headers to all required files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [Incubator kie issues#2013] Deprecates use of time types with timezones. [incubator-kie-drools]
jomarko commented on code in PR #6385: URL: https://github.com/apache/incubator-kie-drools/pull/6385#discussion_r2174306363 ## kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/FEELFnResultTest.java: ## @@ -0,0 +1,22 @@ +package org.kie.dmn.feel.runtime.functions; Review Comment: @ChinchuAjith please fix all these files reported by Apache RAT tool. License headers are required for these files due to Apache releases. ``` Run java -jar apache-rat-0.16.1.jar -d . -E .rat-excludes | grep "== File:" && echo "The files listed above are missing license headers." && exit 1 || echo "All files have license headers." ERROR: Ignored 166 lines in your exclusion files as comments or empty lines. == File: ./kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/FEELFnResultTest.java == File: ./kie-dmn/kie-dmn-test-resources/src/test/resources/valid_models/DMNv1_5/timeFunction.dmn == File: ./kie-dmn/kie-dmn-test-resources/src/test/resources/valid_models/DMNv1_6/timeFunction.dmn The files listed above are missing license headers. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
