Re: [PR] [Incubator kie issues#2018] Review InputData value assignment [incubator-kie-drools]

2025-07-07 Thread via GitHub 


gitgabrio merged PR #6390:
URL: https://github.com/apache/incubator-kie-drools/pull/6390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [Incubator kie issues#2018] Review InputData value assignment [incubator-kie-drools]

2025-07-04 Thread via GitHub 


gitgabrio commented on PR #6390:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6390#issuecomment-3034799386

   @AthiraHari77 could you please adjust the `importType` attribute in all the 
`import` tags ? It should be the same as the 1.6 namespace - i.e. 
`https://www.omg.org/spec/DMN/20240513/MODEL/`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [Incubator kie issues#2018] Review InputData value assignment [incubator-kie-drools]

2025-07-03 Thread via GitHub 


AthiraHari77 commented on PR #6390:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6390#issuecomment-3031300318

   @baldimir Verified with the TCK tests from PR 
https://github.com/dmn-tck/tck/pull/695 and it succeeds.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [Incubator kie issues#2018] Review InputData value assignment [incubator-kie-drools]

2025-07-03 Thread via GitHub 


baldimir commented on PR #6390:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6390#issuecomment-3031121142

   Apart from the comment from Yeser, I think it looks ok. @AthiraHari77 please 
also check the TCK tests from this PR pass 
https://github.com/dmn-tck/tck/pull/695.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [Incubator kie issues#2018] Review InputData value assignment [incubator-kie-drools]

2025-07-02 Thread via GitHub 


yesamer commented on code in PR #6390:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6390#discussion_r2180300535


##
kie-dmn/kie-dmn-test-resources/src/test/resources/valid_models/DMNv1_6/multiple/ImportedModel.dmn:
##
@@ -0,0 +1,52 @@
+
+
+https://www.omg.org/spec/DMN/20230324/MODEL/"; 
expressionLanguage="https://www.omg.org/spec/DMN/20230324/FEEL/"; 
namespace="https://kie.org/dmn/_C1C3315B-AE8F-445A-BD91-AABA022783E9"; 
id="_5B4B6163-513E-4B5A-833C-F0E6BEBF5A6E" name="ImportedModel" 
xmlns:included0="https://kie.org/dmn/_19017424-534B-4943-9DD3-3B5C71E64554"; 
xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/"; 
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; 
xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; 
xmlns:kie="https://kie.org/dmn/extensions/1.0";>

Review Comment:
   @AthiraHari77 The correct namespace for 1.6 is 
https://www.omg.org/spec/DMN/20240513/MODEL/ (https://www.omg.org/spec/DMN)
   
   Please compare with existing 1.6 models already available in the directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]