Re: [PR] [NO-ISSUE] Adding additional DMN examples to the editor [incubator-kie-tools]

2025-01-20 Thread via GitHub 


tiagobento commented on PR #2844:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2844#issuecomment-2602539923

   As per private discussion, we're not adding those examples to the StoryBook 
right now. Thank you though @LightGuard for the effort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [NO-ISSUE] Adding additional DMN examples to the editor [incubator-kie-tools]

2025-01-20 Thread via GitHub 


tiagobento closed pull request #2844: [NO-ISSUE] Adding additional DMN examples 
to the editor
URL: https://github.com/apache/incubator-kie-tools/pull/2844


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [NO-ISSUE] Adding additional DMN examples to the editor [incubator-kie-tools]

2025-01-13 Thread via GitHub 


LightGuard commented on code in PR #2844:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2844#discussion_r1913294614


##
packages/dmn-editor/stories/useCases/payroll/Payroll.stories.tsx:
##
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import * as React from "react";
+import type { Meta, StoryObj } from "@storybook/react";
+import { getMarshaller } from "@kie-tools/dmn-marshaller";
+import { Empty } from "../../misc/empty/Empty.stories";
+import { DmnEditor, DmnEditorProps } from "../../../src/DmnEditor";
+import { StorybookDmnEditorProps } from "../../dmnEditorStoriesWrapper";
+
+export const payrollDmn = `
+https://www.omg.org/spec/DMN/20230324/MODEL/"; 
xmlns="https://kiegroup.org/dmn/_DF3A36C5-A538-4FC0-9F3A-56D7AE3C76A2"; 
xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; 
xmlns:kie="https://kie.org/dmn/extensions/1.0"; 
xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/"; 
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; 
xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; 
id="_8DEF2854-76EF-48E0-ACDE-0888E2F0831F" name="payroll" 
typeLanguage="https://www.omg.org/spec/DMN/20230324/FEEL/"; 
namespace="https://kiegroup.org/dmn/_DF3A36C5-A538-4FC0-9F3A-56D7AE3C76A2";>
+  
+  https://www.omg.org/spec/DMN/20230324/FEEL/";>
+https://www.omg.org/spec/DMN/20230324/FEEL/";>
+  number
+
+https://www.omg.org/spec/DMN/20230324/FEEL/";>
+  number
+
+https://www.omg.org/spec/DMN/20230324/FEEL/";>
+  number
+
+  
+  
+
+  string
+
+
+  string
+
+
+  string
+

Review Comment:
   I believe this builds on a tax demo that we have in some other examples, 
honestly not sure why that one isn't here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [NO-ISSUE] Adding additional DMN examples to the editor [incubator-kie-tools]

2025-01-13 Thread via GitHub 


jomarko commented on code in PR #2844:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2844#discussion_r1912883028


##
packages/dmn-editor/stories/useCases/insurancePricing/InsurancePricing.stories.tsx:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import * as React from "react";
+import type { Meta, StoryObj } from "@storybook/react";
+import { getMarshaller } from "@kie-tools/dmn-marshaller";
+import { Empty } from "../../misc/empty/Empty.stories";
+import { DmnEditor, DmnEditorProps } from "../../../src/DmnEditor";
+import { StorybookDmnEditorProps } from "../../dmnEditorStoriesWrapper";
+
+export const insurancePricingDmn = `
+https://www.omg.org/spec/DMN/20230324/MODEL/"; 
xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/"; 
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; 
xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; 
xmlns:kie="https://kie.org/dmn/extensions/1.0"; 
expressionLanguage="https://www.omg.org/spec/DMN/20230324/FEEL/"; 
namespace="https://kie.org/dmn/_3BFF6543-4697-4C29-AF20-B8E622597121"; 
id="_370DC2EC-B59D-453D-9A4E-18A481386E98" name="Insurance Pricing">
+  
+
+  
+  
+
+  
+  
+
+
+  
+
+
+  
+
+
+  
+
+  Age
+
+  
+  
+
+  had previous incidents
+
+  
+  

Review Comment:
   Could we please manually remove this `name="Output-1"`? it is because of :
   - https://github.com/apache/incubator-kie-tools/pull/2834



##
packages/dmn-editor/stories/useCases/payroll/Payroll.stories.tsx:
##
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import * as React from "react";
+import type { Meta, StoryObj } from "@storybook/react";
+import { getMarshaller } from "@kie-tools/dmn-marshaller";
+import { Empty } from "../../misc/empty/Empty.stories";
+import { DmnEditor, DmnEditorProps } from "../../../src/DmnEditor";
+import { StorybookDmnEditorProps } from "../../dmnEditorStoriesWrapper";
+
+export const payrollDmn = `
+https://www.omg.org/spec/DMN/20230324/MODEL/"; 
xmlns="https://kiegroup.org/dmn/_DF3A36C5-A538-4FC0-9F3A-56D7AE3C76A2"; 
xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; 
xmlns:kie="https://kie.org/dmn/extensions/1.0"; 
xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/"; 
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; 
xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; 
id="_8DEF2854-76EF-48E0-ACDE-0888E2F0831F" name="payroll" 
typeLanguage="https://www.omg.org/spec/DMN/20230324/FEEL/"; 
namespace="https://kiegroup.org/dmn/_DF3A36C5-A538-4FC0-9F3A-56D7AE3C76A2";>
+  
+  https://www.omg.org/spec/DMN/20230324/FEEL/";>
+https://www.omg.org/spec/DMN/20230324/FEEL/";>
+  number
+
+https://www.omg.org/spec/DMN/20230324/FEEL/";>
+  number
+
+https://www.omg.org/spec/DMN/20230324/FEEL/";>
+  number
+
+  
+  
+
+  string
+
+
+  string
+
+
+  string
+
+
+  string
+
+  
+  
+
+  string
+
+
+  string
+
+
+  string
+
+
+  Any
+
+
+  tAddress
+
+  
+  
+
+
+  
+  
+
+
+
+
+
+
+  
+  
+
+

Review Comment:
   is `Any` appropriate here?



##
packages/dmn-editor/stories/useCases/payroll/Payroll.stories.tsx:
##
@@ -0,0 +1,343 @@
+/*
+ * License

Re: [PR] [NO-ISSUE] Adding additional DMN examples to the editor [incubator-kie-tools]

2025-01-10 Thread via GitHub 


LightGuard commented on PR #2844:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2844#issuecomment-2583348318

   ![Screenshot 2025-01-10 at 10 46 
05](https://github.com/user-attachments/assets/050d29cc-0b41-4cc4-8644-6be26c1498bc)
   ![Screenshot 2025-01-10 at 10 45 
51](https://github.com/user-attachments/assets/63910448-a47d-42fe-9a57-666bfb1b8070)
   ![Screenshot 2025-01-10 at 10 45 
39](https://github.com/user-attachments/assets/57ff01ae-cc94-4a9f-a3e7-2af5009ee4a3)
   I can add more about the data types and decision tables, if that's needed as 
well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [NO-ISSUE] Adding additional DMN examples to the editor [incubator-kie-tools]

2025-01-10 Thread via GitHub 


ljmotta commented on PR #2844:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2844#issuecomment-2583281329

   @LightGuard Could you please include screenshots of the added models in 
Storybook in the PR description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]