Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio merged PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3280303803 ## kogito-apps-springboot/kogito-apps-springboot-bom/pom.xml: ## @@ -0,0 +1,145 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie.kogito +kogito-apps-springboot +999-SNAPSHOT + + + kogito-apps-springboot-bom Review Comment: @pefernan This has been already mentioned. Point is, that there is not a single "convention" about springboot naming, for the moment being. You may verify by yourself in that very repo: lok for "springboot" and "spring-boot" all over poms. I agree to refactor that later on, but for the moment being I would prefer to avoid introducing unnecessary potential breaking changes: does this make sense ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3280303803 ## kogito-apps-springboot/kogito-apps-springboot-bom/pom.xml: ## @@ -0,0 +1,145 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie.kogito +kogito-apps-springboot +999-SNAPSHOT + + + kogito-apps-springboot-bom Review Comment: @pefernan This has been already mentioned. Point is, that there is not a single "convention" about springboot naming, for the moment being. You may verify by yourself in that very repo: look for "springboot" and "spring-boot" all over poms. I agree to refactor that later on, but for the moment being I would prefer to avoid introducing unnecessary potential breaking changes: does this make sense ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
pefernan commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3280277216 ## kogito-apps-springboot/kogito-apps-springboot-bom/pom.xml: ## @@ -0,0 +1,145 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie.kogito +kogito-apps-springboot +999-SNAPSHOT + + + kogito-apps-springboot-bom Review Comment: @gitgabrio just nip picking, but I see that in runtimes the bom is called `kogito-spring-boot-bom` while here `kogito-apps-springboot-bom` I think we should be consistent with the artifact Id. ```suggestion kogito-apps-spring-boot-bom ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#issuecomment-4506129251 > @gitgabrio thanks massive effort! why not having `data-index-service-common`, `data-index-storage-quarkus` & `data-index-test-utils-quarkus` inside `kogito-apps-quarkus/data-index-quarkus`? When I've done that I preserved the original structure, more or less, to limit as much as possible "parent" changes. Anyway, it is an improvement that could be done later on, also in the springboot counterpart, with your help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#issuecomment-4506022483 > Great work @gitgabrio 😊 Thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
martinweiler commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3275583861
##
explainability/explainability-service-rest/src/test/java/org/kie/kogito/explainability/rest/KeycloakExplainabilityServiceIT.java:
##
@@ -19,19 +19,21 @@
package org.kie.kogito.explainability.rest;
import org.apache.http.HttpStatus;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Disabled;
import org.kie.kogito.test.quarkus.QuarkusTestProperty;
import org.kie.kogito.testcontainers.KogitoKeycloakContainer;
import org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource;
-import io.quarkus.test.common.QuarkusTestResource;
-import io.quarkus.test.junit.QuarkusTest;
import io.restassured.RestAssured;
import static io.restassured.RestAssured.given;
-@QuarkusTest
-@QuarkusTestResource(KeycloakQuarkusTestResource.Conditional.class)
+/*@QuarkusTest
+@QuarkusTestResource(KeycloakQuarkusTestResource.Conditional.class)*/
+@Disabled("Currently disabled due to failures on test instantiation. For some
reason, the KogitoKeycloakContainer" +
+".getMappedPort() is invoked before" +
+"the container is up and running, hence it throws an
IllegalStateException. This needs to be investigated and" +
+" fixed before re-enabling the test.")
Review Comment:
This needs a follow-up tracker to investigate further and re-enable the test
eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
pefernan commented on PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#issuecomment-4500354793 @gitgabrio thanks massive effort! why not having `data-index-service-common`, `data-index-storage-quarkus` & `data-index-test-utils-quarkus` inside `kogito-apps-quarkus/data-index-quarkus`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3265029015 ## trusty/trusty-service/trusty-service-postgresql/pom.xml: ## @@ -88,38 +91,4 @@ test - - - - -io.quarkus -quarkus-maven-plugin Review Comment: Now it inherit the quarkus-maven-plugin configuration, tweaking it with the following variables: ```xml false false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3265012217 ## trusty/trusty-storage/trusty-storage-infinispan/pom.xml: ## Review Comment: It is not part of the reactor anymore. It has been removed on 06/27/2025. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3264831676 ## apps-integration-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java: ## Review Comment: They are not part of the reactor anymore. They have been removed on 06/27/2025. I'll restore them in proper place, but keep them disabled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Dependency management simplification [incubator-kie-kogito-apps]
yesamer commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3261469271
##
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##
Review Comment:
@gitgabrio I'm aware there is an ongoing initiative to remove infinispan
support, is this module removal related to that?
##
apps-integration-tests/integration-tests-trusty-service/integration-tests-trusty-service-common/src/main/java/org/kie/kogito/it/trusty/AbstractTrustyExplainabilityEnd2EndIT.java:
##
Review Comment:
@gitgabrio Was the integration-tests-trusty-service-common intentionally
removed? Why?
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
-@Test
+/* @Test */
Review Comment:
@gitgabrio As you disabled the entire Class, I guess you can remove the
comment.
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
Review Comment:
@gitgabrio As you disabled the entire Class, I guess you can remove the
comment.
##
trusty/trusty-service/trusty-service-postgresql/pom.xml:
##
@@ -88,38 +91,4 @@
test
-
-
-
-
-io.quarkus
-quarkus-maven-plugin
Review Comment:
@gitgabrio Can you please clarify the trusty-module module management? It
previously was a quarkus app and now in no longer that?
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
-@Test
+/* @Test */
void shouldReturnOkWhenValidUser() {
-when(trustyService.getExecutionHeaders(any(OffsetDateTime.class),
any(OffsetDateTime.class), anyInt(), anyInt(), anyString())).thenReturn(new
MatchedExecutionHeaders(new ArrayList<>(), 0));
+when(trustyService.getExecutionHeaders(any(OffsetDateTime.class),
any(OffsetDateTime.class), anyInt(),
+anyInt(), anyString())).thenReturn(new
MatchedExecutionHeaders(new ArrayList<>(), 0));
Review Comment:
I guess this line change is useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
