Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3091344082 ## kogito-apps-springboot/pom.xml: ## @@ -0,0 +1,124 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie.kogito +kogito-spring-boot-bom +999-SNAPSHOT + + + + kogito-apps-springboot Review Comment: @yesamer Sorry, there is not such convention anywhere: please look by yourself: springboot and spring-boot are used interchangeable everywhere, and inside kogito-apps it is constantly referred to with "springboot": (e.g. kogito-runtimes) https://github.com/user-attachments/assets/e1b10344-b295-4646-83f5-2ec3404ca4e2"; /> (e.g. kogito-apps) https://github.com/user-attachments/assets/cb35a25c-88f5-42e6-a3ca-6e966cd3932b"; /> Anyway, I agree that we need to make things consistent, later on (and not only just for the springboot vs spring-boot) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
yesamer commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3087479732 ## kogito-apps-springboot/pom.xml: ## @@ -0,0 +1,124 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + +org.kie.kogito +kogito-spring-boot-bom +999-SNAPSHOT + + + + kogito-apps-springboot Review Comment: @gitgabrio Please use the same convention we have in kogito runtime (`kogito-apps-spring-boot`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086607651
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
-@Test
+/* @Test */
Review Comment:
Yes, since those are broken, I can't understand why, and AFAIK there is no
one who maintain this code and knows what was the logic behind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086637784 ## persistence-commons/persistence-commons-mongodb/pom.xml: ## @@ -34,8 +34,20 @@ org.kie.kogito.persistence.mongodb +5.5.1 Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086607651
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
-@Test
+/* @Test */
Review Comment:
Yes, since those are broken and I can't understand why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086604919 ## trusty/trusty-storage/trusty-storage-infinispan/pom.xml: ## @@ -1,77 +0,0 @@ - - -http://www.w3.org/2001/XMLSchema-instance"; - xmlns="http://maven.apache.org/POM/4.0.0"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - -trusty-storage -org.kie.kogito -999-SNAPSHOT - - 4.0.0 - - trusty-storage-infinispan Review Comment: I restored. Anyway, it is excluded from normal reactor 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086544359 ## trusty/trusty-storage/trusty-storage-infinispan/pom.xml: ## @@ -1,77 +0,0 @@ - - -http://www.w3.org/2001/XMLSchema-instance"; - xmlns="http://maven.apache.org/POM/4.0.0"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - -trusty-storage -org.kie.kogito -999-SNAPSHOT - - 4.0.0 - - trusty-storage-infinispan Review Comment: IIRC, this has been introduced by a PR from Alex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086544359 ## trusty/trusty-storage/trusty-storage-infinispan/pom.xml: ## @@ -1,77 +0,0 @@ - - -http://www.w3.org/2001/XMLSchema-instance"; - xmlns="http://maven.apache.org/POM/4.0.0"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - -trusty-storage -org.kie.kogito -999-SNAPSHOT - - 4.0.0 - - trusty-storage-infinispan Review Comment: IIRC, this has been introduced by a PR from Alex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086528704 ## trusty/trusty-storage/trusty-storage-redis/pom.xml: ## @@ -22,18 +22,20 @@ http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 -trusty-storage org.kie.kogito +trusty-storage 999-SNAPSHOT - 4.0.0 trusty-storage-redis Kogito Apps :: Trusty Storage Redis org.kie.kogito.trusty.storage.redis +false +true Review Comment: @yesamer With this PR, the quarkus plugin configuration is inherited everywhere from quarkus parent bom. Those two properties are needed to: 1. enable/disable the jar renaming 2. enable/disable the plugin itself (there are quarkus modules, like this one, inside which the quarkus plugin should not be executed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-apps]
yesamer commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086446448
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
-@Test
+/* @Test */
Review Comment:
@gitgabrio Are those temporarily disabled?
##
trusty/trusty-storage/trusty-storage-redis/pom.xml:
##
@@ -22,18 +22,20 @@
http://www.w3.org/2001/XMLSchema-instance";
xmlns="http://maven.apache.org/POM/4.0.0";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
-trusty-storage
org.kie.kogito
+trusty-storage
999-SNAPSHOT
- 4.0.0
trusty-storage-redis
Kogito Apps :: Trusty Storage Redis
org.kie.kogito.trusty.storage.redis
+false
+true
Review Comment:
@gitgabrio Can you please explain those additions?
##
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##
@@ -1,77 +0,0 @@
-
-
-http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-
-trusty-storage
-org.kie.kogito
-999-SNAPSHOT
-
- 4.0.0
-
- trusty-storage-infinispan
Review Comment:
@gitgabrio If I understood correctly, are we removing this module entirely?
##
persistence-commons/persistence-commons-mongodb/pom.xml:
##
@@ -34,8 +34,20 @@
org.kie.kogito.persistence.mongodb
+5.5.1
Review Comment:
@gitgabrio Don't we have a "global" mongodb declaration?
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
-@Test
+/* @Test */
Review Comment:
@gitgabrio Are those temporarily disabled?
##
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##
@@ -22,28 +22,28 @@
import java.util.ArrayList;
import org.apache.http.HttpStatus;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.Disabled;
import org.kie.kogito.test.quarkus.QuarkusTestProperty;
import org.kie.kogito.testcontainers.KogitoKeycloakContainer;
import org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource;
import org.kie.kogito.trusty.service.common.models.MatchedExecutionHeaders;
import io.quarkus.test.InjectMock;
-import io.quarkus.test.common.QuarkusTestResource;
-import io.quarkus.test.common.ResourceArg;
-import io.quarkus.test.junit.QuarkusTest;
import static io.restassured.RestAssured.given;
-import static
org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource.KOGITO_OIDC_TENANTS;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.when;
-@QuarkusTest
-@QuarkusTestResource(value = KeycloakQuarkusTestResource.class, initArgs = {
@ResourceArg(name = KOGITO_OIDC_TENANTS, value = "web-app-tenant") })
-@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+/*@QuarkusTest
+@QuarkusTestResource(value = KeycloakQuarkusTestResource.class, initArgs = {
@ResourceArg(name = KOGITO_OIDC_TENANTS,
Review Comment:
@gitgabrio Are those temporarily disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
