Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


yesamer commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086583443


##
addons/common/pom.xml:
##
@@ -35,20 +35,9 @@
   pom
 
   
-5.5.1
 org.kie:kogito-addons-common-parent

Review Comment:
   @gitgabrio I guess this is no longer required.



##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   +1 to remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086499425


##
addons/common/pom.xml:
##
@@ -34,6 +34,21 @@
   Parent Module for the base Addons Commons
   pom
 
+  
+5.5.1

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


yesamer commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086472708


##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   @gitgabrio Perfect!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086447088


##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   I think it was used to inject "project.root.dir" that is used in multiple 
modules to get reference to resources (models) in different ones.
   I fixed all of them, so I think this plugin is not needed anymore (as 
inherently demonstrated by the fact that the build is successfull even if the 
plugin is disabled, as a matter of fact)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086447088


##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   I think it was used to inject "project.root.dir" that is used in multiple 
modules to get reference to resources (models) in different ones.
   I fixed all of them, so I think this plugin is not needed anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086439173


##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   @yesamer 
   
https://github.com/jdcasey/directory-maven-plugin?tab=readme-ov-file#highest-basedir-goal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086247215


##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   During the modifications, I discovered that this plugin break the build 
because it fails to find one single "project.root.dir" when the parent of a 
module is not the super-module, i.e.
   
   supermodule \
  module-a
  module-b
  
   if the parent of any of module-a or mudle-b is not supermodule, the plugin 
throws an exception because it identify two potential "parents": is that clear ?
   Anyway, I'll double-check ASAP to verify again.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


yesamer commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086196352


##
springboot/bom/pom.xml:
##
@@ -19,120 +18,381 @@
 under the License.
 
 -->
-http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-  
-springboot
-org.kie.kogito
-999-SNAPSHOT
-  
-  4.0.0
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+org.kie.kogito
+kogito-build-no-bom-parent
+999-SNAPSHOT
+
../../kogito-build/kogito-build-no-bom-parent/pom.xml
+
+4.0.0
+kogito-spring-boot-bom
+Kogito :: Spring Boot :: BOM
+Spring Boot descriptor for Kogito libraries and projects 
based on Spring runtime.
+pom
+
+
+
org.kie.kogito:kogito-spring-boot-bom
+2.2.38

Review Comment:
   @gitgabrio Yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086194585


##
kogito-codegen-modules/kogito-codegen-decisions/pom.xml:
##
@@ -36,24 +36,6 @@
 3.6.1

Review Comment:
   removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086171250


##
kogito-gradle-plugin-test/pom.xml:
##
@@ -46,7 +46,32 @@
 
   org.kie.kogito
   kogito-gradle-plugin
-  ${project.version}
+  

Review Comment:
   Some because of duplicated classes enforcer, and some for incompatibility 
I've discovered while I was building/testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


gitgabrio commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086145666


##
springboot/bom/pom.xml:
##
@@ -19,120 +18,381 @@
 under the License.
 
 -->
-http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-  
-springboot
-org.kie.kogito
-999-SNAPSHOT
-  
-  4.0.0
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+org.kie.kogito
+kogito-build-no-bom-parent
+999-SNAPSHOT
+
../../kogito-build/kogito-build-no-bom-parent/pom.xml
+
+4.0.0
+kogito-spring-boot-bom
+Kogito :: Spring Boot :: BOM
+Spring Boot descriptor for Kogito libraries and projects 
based on Spring runtime.
+pom
+
+
+
org.kie.kogito:kogito-spring-boot-bom
+2.2.38

Review Comment:
   I removed because it is the same version as declared in kie-parent.
   If, by chance (e.g. framework need) the version had to be different, then it 
would have to be kept even if not directly referenced in the pom or repo (more 
or less same issue we discussed about inheritance and property resolution): am 
I clear ? Does this make sense ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [incubator-kie-issues#2029] Enforce framework-specific BOM separation [incubator-kie-kogito-runtimes]

2026-04-15 Thread via GitHub 


yesamer commented on code in PR #4241:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3085864569


##
kogito-gradle-plugin-test/pom.xml:
##
@@ -46,7 +46,32 @@
 
   org.kie.kogito
   kogito-gradle-plugin
-  ${project.version}
+  

Review Comment:
   @gitgabrio Out of curiosity: Why all those exclusions are required?



##
springboot/bom/pom.xml:
##
@@ -19,120 +18,381 @@
 under the License.
 
 -->
-http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-  
-springboot
-org.kie.kogito
-999-SNAPSHOT
-  
-  4.0.0
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+org.kie.kogito
+kogito-build-no-bom-parent
+999-SNAPSHOT
+
../../kogito-build/kogito-build-no-bom-parent/pom.xml
+
+4.0.0
+kogito-spring-boot-bom
+Kogito :: Spring Boot :: BOM
+Spring Boot descriptor for Kogito libraries and projects 
based on Spring runtime.
+pom
+
+
+
org.kie.kogito:kogito-spring-boot-bom
+2.2.38

Review Comment:
   @gitgabrio This version is unused.



##
kogito-codegen-modules/kogito-codegen-decisions/pom.xml:
##
@@ -36,24 +36,6 @@
 3.6.1

Review Comment:
   @gitgabrio Is this necessary?



##
addons/common/pom.xml:
##
@@ -34,6 +34,21 @@
   Parent Module for the base Addons Commons
   pom
 
+  
+5.5.1

Review Comment:
   @gitgabrio Can't we manage this in a parent bom?



##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/pom.xml:
##
@@ -22,171 +22,174 @@
 http://maven.apache.org/POM/4.0.0";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-4.0.0
-
-org.apache.kie.sonataflow
-sonataflow-quarkus-extension
-999-SNAPSHOT
-
+  4.0.0
+  
+org.apache.kie.sonataflow
+sonataflow-quarkus-extension
+999-SNAPSHOT
+  
 
-sonataflow-quarkus-extension-live-reload-test
-SonataFlow :: Quarkus Serverless Workflow Extension :: Live Reload 
Tests
+  sonataflow-quarkus-extension-live-reload-test
+  SonataFlow :: Quarkus Serverless Workflow Extension :: Live Reload 
Tests
 
   
-
org.kie.kogito.quarkus.serverless.workflow.deployment.livereload
+
org.kie.kogito.quarkus.serverless.workflow.deployment.livereload
   
 
-
-
-org.apache.kie.sonataflow
-sonataflow-quarkus
-
-
-io.quarkus
-quarkus-resteasy
-
-
-io.quarkus
-quarkus-resteasy-jackson
-
-
-io.quarkus
-quarkus-resteasy-client-oidc-filter
-
-
-io.quarkus
-quarkus-smallrye-openapi
-
+  
+

Review Comment:
   @gitgabrio Can we remove this?



##
kogito-build/kogito-build-no-bom-parent/pom.xml:
##
@@ -683,7 +665,7 @@
   
 highest-basedir

-  validate
+  none

Review Comment:
   @gitgabrio Can you please explain this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]