Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer merged PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3929462249
**PR job** `#41` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/41/display/redirect
**Test results:**
- PASSED: 3943
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/41/testReport/org.kie.kogito.addon.quarkus.messaging.common/QuarkusEventThreadPoolTest/testQuarkusEventThreadPoolMultiThreadTest/";>org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadTest
expected: <100> but was: <99>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
fjtirado commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2828874094
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##
@@ -51,7 +54,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@Execution(SAME_THREAD)
+@Disabled("Disabled temporarly - when doing quarkus upgrade.")
public class LiveReloadProcessorTest {
Review Comment:
@jeejz Added PR https://github.com/jeejz/incubator-kie-kogito-runtimes/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
pefernan commented on PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3928290459 all greens @jeejz ยช -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2827894187
##
springboot/addons/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/springboot/SpringBootUserTaskJPAAutoConfiguration.java:
##
@@ -19,10 +19,26 @@
package org.jbpm.usertask.jpa.springboot;
+import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.boot.SpringBootConfiguration;
import org.springframework.boot.autoconfigure.domain.EntityScan;
+import org.springframework.context.annotation.Bean;
+import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean;
@SpringBootConfiguration
@EntityScan("org.jbpm.usertask.jpa.model")
public class SpringBootUserTaskJPAAutoConfiguration {
+
+@Bean
+public static BeanPostProcessor usertaskEmfPostProcessor() {
Review Comment:
hibernate we have already added in the dependency bom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2827890824
##
springboot/addons/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/springboot/SpringBootUserTaskJPAAutoConfiguration.java:
##
@@ -19,10 +19,26 @@
package org.jbpm.usertask.jpa.springboot;
+import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.boot.SpringBootConfiguration;
import org.springframework.boot.autoconfigure.domain.EntityScan;
+import org.springframework.context.annotation.Bean;
+import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean;
@SpringBootConfiguration
@EntityScan("org.jbpm.usertask.jpa.model")
public class SpringBootUserTaskJPAAutoConfiguration {
+
+@Bean
+public static BeanPostProcessor usertaskEmfPostProcessor() {
Review Comment:
Fixed this by adding
```
org.springframework.boot
spring-boot-starter-data-jpa
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2827890824
##
springboot/addons/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/springboot/SpringBootUserTaskJPAAutoConfiguration.java:
##
@@ -19,10 +19,26 @@
package org.jbpm.usertask.jpa.springboot;
+import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.boot.SpringBootConfiguration;
import org.springframework.boot.autoconfigure.domain.EntityScan;
+import org.springframework.context.annotation.Bean;
+import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean;
@SpringBootConfiguration
@EntityScan("org.jbpm.usertask.jpa.model")
public class SpringBootUserTaskJPAAutoConfiguration {
+
+@Bean
+public static BeanPostProcessor usertaskEmfPostProcessor() {
Review Comment:
Fixed this by adding
org.springframework.boot
spring-boot-starter-data-jpa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2827182624
##
springboot/addons/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/springboot/SpringBootUserTaskJPAAutoConfiguration.java:
##
@@ -19,10 +19,26 @@
package org.jbpm.usertask.jpa.springboot;
+import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.boot.SpringBootConfiguration;
import org.springframework.boot.autoconfigure.domain.EntityScan;
+import org.springframework.context.annotation.Bean;
+import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean;
@SpringBootConfiguration
@EntityScan("org.jbpm.usertask.jpa.model")
public class SpringBootUserTaskJPAAutoConfiguration {
+
+@Bean
+public static BeanPostProcessor usertaskEmfPostProcessor() {
Review Comment:
@jeejz this needs some deps to be added in the` pom.xml`
```xml
org.hibernate.orm
hibernate-core
org.springframework.boot
spring-boot-starter-data-jpa
org.springframework.boot
spring-boot-starter
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2827105117 ## springboot/bom/pom.xml: ## @@ -42,8 +42,8 @@ 4.0.29 2.2-groovy-4.0 - - 2024.0.2 + + 2025.0.1 7.2.0 Review Comment: This is upgraded to 7.3.1 in spring boot pom as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
jeejz commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2827087989 ## addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/mapper/TaskOutputsEntityMapper.java: ## @@ -64,7 +64,8 @@ public void mapInstanceToEntity(UserTaskInstance userTaskInstance, UserTaskInsta outputEntity.setValue(JSONUtils.valueToString(value).getBytes(StandardCharsets.UTF_8)); outputEntity.setJavaType(value.getClass().getName()); } -repository.persist(outputEntity); +// No explicit persist needed: parent has @OneToMany(cascade = CascadeType.ALL), +// so child entities are automatically persisted when the parent is saved. Review Comment: This is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#issuecomment-3926288073
**PR job** `#37` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/37/display/redirect
**Test results:**
- PASSED: 3936
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4178/37/testReport/org.kie.kogito.integrationtests.quarkus/TaskIT/testUpdateTaskInfo/";>org.kie.kogito.integrationtests.quarkus.TaskIT.testUpdateTaskInfo
1 expectation failed.Expected status code <403> but was <200>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822907254 ## addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/mapper/TaskMetadataEntityMapper.java: ## @@ -63,7 +63,8 @@ public void mapInstanceToEntity(UserTaskInstance userTaskInstance, UserTaskInsta metadataEntity.setValue(JSONUtils.valueToString(value)); metadataEntity.setJavaType(value.getClass().getName()); } -repository.persist(metadataEntity); +// No explicit persist needed: parent has @OneToMany(cascade = CascadeType.ALL), Review Comment: @jeejz See this can be removed too (Out of curiosity, keeping the persist call results in some issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [incubator-kie-issues-2204] Quarkus upgrade 3.27 and Spring Boot to 3.5.10 [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2822901332 ## addons/common/jbpm-usertask-storage-jpa/src/main/java/org/jbpm/usertask/jpa/mapper/TaskOutputsEntityMapper.java: ## @@ -64,7 +64,8 @@ public void mapInstanceToEntity(UserTaskInstance userTaskInstance, UserTaskInsta outputEntity.setValue(JSONUtils.valueToString(value).getBytes(StandardCharsets.UTF_8)); outputEntity.setJavaType(value.getClass().getName()); } -repository.persist(outputEntity); +// No explicit persist needed: parent has @OneToMany(cascade = CascadeType.ALL), +// so child entities are automatically persisted when the parent is saved. Review Comment: @jeejz See this can be removed too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
