Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Subhanshu20135 closed pull request #6595: Added Drools Open Telemetry Support URL: https://github.com/apache/incubator-kie-drools/pull/6595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Subhanshu20135 commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4178768986 > that impresive. I @Rikkola Thanks a lot for the appreciation. And to answer your question, I am fully interested in maintaining this module in this project. And yes, please share any questions that you have. I will be happy to answer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Rikkola commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4177752933 @Subhanshu20135 repinging you in case you missed the first one. I had few questions in the previous comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Rikkola commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4096600940 @Subhanshu20135 We will need to check each feature one by one and the first one likely clears some way for the others. So there was already a dev list post about this, so we can do this first. You are the first person to deliver anything that at a larger scale that adds more functionality. That is a good thing, but we need to think about maintanence and so on. I will sponsor this, so if you drop and leave I will be the one to keep an eye on it and delete if we run out of man power to maintain. I guess first I should ask if you are interested in maintaining these? Since that will play a part in deciding what is worth keeping. I am trying to push at least this feature in, since it is something I can use at my other projects. Do you have any bigger test project or screenshots of this working on a larger scale? I did a small test project, but then of course the visuals I got were not that impresive. If not, I will try to create one myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Rikkola commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4065890838 @Subhanshu20135 do not worry any AI use is fine, it just needs to be credited in the PR. We just need to be careful with AI bot accounts or "take overs", so asking for some background :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Subhanshu20135 commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4060115352 @Rikkola Ok, will rebase the main branch going forward. I am working in drools from last year and since then I identified some gaps and I implemented some solutions using existing tools but I find it difficult to maintain them alongside my business logic. So, all the development that I did in 4-5 months in this module I compiled them together and raised few PRs together. I know it might be overwhelming to see at first, but I want to assure you that I used AI to just add code comments and writing Unit Tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Rikkola commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4030645257 @Subhanshu20135 I noticed you have quite a few PRs. Can you give some background on how and why these were created and for what needs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Rikkola commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-4029506211 @Subhanshu20135 by the way we rebase the main to the topic branch. This makes the commit log a bit easier to read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Rikkola commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-3984145814 @Subhanshu20135 thanks. I will be taking a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
Subhanshu20135 commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-3960144242 Hi @Rikkola @pibizza @tkobayas @mariofusco , I have Added a Detailed README for the modules I have implemented for the Open Telemetry. Please do have a look into them for Usage and Examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
yesamer commented on PR #6595: URL: https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-3954533323 Hi @Subhanshu20135, thank you very much for contributing to Apache KIE! Since you are proposing a new set of features for Drools, may I kindly ask you to share more information with the Apache KIE community about them? The best way to reach the community is through the Apache KIE mailing list, as described here: https://community.apache.org/contributors/#communication. My suggestion is to start a new “[HEADS-UP]” thread and describe in more detail the changes you’re proposing—their scope, the motivation behind them, and how they would benefit the Apache KIE project. Thank you again, Yeser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Added Drools Open Telemetry Support [incubator-kie-drools]
kie-ci3 commented on PR #6595:
URL:
https://github.com/apache/incubator-kie-drools/pull/6595#issuecomment-3953408800
**PR job** `#12` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-drools -u
https://github.com/apache/incubator-kie-drools/pull/6595 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6595/12/display/redirect
**Test results:**
- PASSED: 24126
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6595/12/testReport/org.drools.persistence.session/RuleFlowGroupRollbackTest/testRuleFlowGroupRollback(String)[1]/">org.drools.persistence.session.RuleFlowGroupRollbackTest.testRuleFlowGroupRollback(String)[1]
org.xml.sax.SAXException:
file:/home/jenkins/jenkins-agent/workspace/llrequest_jobs_drools-pr_PR-6595/kogito-pipelines/bc/apache_incubator-kie-drools/drools-persistence/drools-persistence-jpa/target/test-classes/META-INF/persistence.xml
[Location:Line: 25, C: 131]: org.xml.sax.SAXParseException; systemId:
file:/home/jenkins/jenkins-agent/workspace/llrequest_jobs_drools-pr_PR-6595/kogito-pipelines/bc/apache_incubator-kie-drools/drools-persistence/drools-persistence-jpa/target/test-classes/META-INF/persistence.xml;
lineNumber: 25; columnNumber: 131; cvc-elt.1.a: Cannot find the declaration of
element 'persistence'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
