Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-4012687514
**PR job** `#18` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/18/display/redirect
**Test results:**
- PASSED: 3948
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/18/testReport/org.kie.kogito.quarkus.serverless.workflow.deployment.livereload/LiveReloadProcessorTest/testAsyncApi/";>org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest.testAsyncApi
Assertion condition defined as a Lambda expression in
org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest
null within 10 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli merged PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3959675845
**PR job** `#17` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/17/display/redirect
**Test results:**
- PASSED: 3946
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/17/testReport/org.kie.kogito.process.dynamic/DynamicCallResourceTest/testDynamicCall/";>org.kie.kogito.process.dynamic.DynamicCallResourceTest.testDynamicCall
1 expectation failed.Expected status code <404> but was <200>.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/17/testReport/org.kie.kogito.quarkus.serverless.workflow.deployment.livereload/LiveReloadProcessorTest/testAsyncApi/";>org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest.testAsyncApi
Assertion condition defined as a Lambda expression in
org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest
null within 10 seconds.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/17/testReport/org.kie.kogito.integrationtests.quarkus/TaskIT/testUpdateTaskInfo/";>org.kie.kogito.integrationtests.quarkus.TaskIT.testUpdateTaskInfo
1 expectation failed.Expected status code <403> but was <200>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
gmunozfe commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2851866378
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -94,10 +100,32 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE) &&
!mt.isWildcardType());
Review Comment:
Even this positive logic is more clear, and easy to maintain, if you want to
consider it:
```
boolean wantsHtml = headers.getAcceptableMediaTypes()
.stream()
.anyMatch(mt -> mt.getType().equals("text")
&& mt.getSubtype().equals("html"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
gmunozfe commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2851758409
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -94,10 +100,32 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE) &&
!mt.isWildcardType());
Review Comment:
You could also cover the case when receiving "text/*", which with the
current proposal is considered as HTML. You could add an enforcement clause to
check a wildcard subtype like this:
```suggestion
.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE) &&
!mt.isWildcardType() && !mt.isWildcardSubtype());
```
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -94,10 +100,32 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE) &&
!mt.isWildcardType());
+
+if (wantsHtml) {
+InputStream htmlStream =
getClass().getResourceAsStream("/META-INF/resources/index.html");
+if (htmlStream == null) {
+return Response.status(Response.Status.NOT_FOUND)
+.entity("HTML resource not found")
+.build();
+}
+
+StreamingOutput stream = os -> {
+try (InputStream inputStream = htmlStream) {
Review Comment:
Why don't open the inputStream only when the body is actually written?
```suggestion
try (InputStream inputStream =
getClass().getResourceAsStream(path)) {
```
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -94,10 +100,32 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE) &&
!mt.isWildcardType());
+
+if (wantsHtml) {
+InputStream htmlStream =
getClass().getResourceAsStream("/META-INF/resources/index.html");
+if (htmlStream == null) {
+return Response.status(Response.Status.NOT_FOUND)
+.entity("HTML resource not found")
+.build();
+}
Review Comment:
Check resource existence before creating the inputStream:
```
String path = "/META-INF/resources/index.html";
if (getClass().getResource(path) == null) {
return Response.status(Response.Status.NOT_FOUND)
.entity("HTML resource not found")
.build();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To u
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3957567122 @domhanak can you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3872386506
**PR job** `#15` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/15/display/redirect
**Test results:**
- PASSED: 3890
- FAILED: 6
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/15/testReport/org.kie.kogito.addons.jwt.it/JwtParserIT/testJwtParserWorkflowEndToEnd/";>org.kie.kogito.addons.jwt.it.JwtParserIT.testJwtParserWorkflowEndToEnd
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/15/testReport/org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it/KnativeServingAddonIT/___/";>org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3867748390 @kumaradityaraj I think the failing test is due to some change on this file on `main`: ``` quarkus/integration-tests/integration-tests-quarkus-processes/src/test/java/org/kie/kogito/integrationtests/quarkus/TaskIT.java ``` I would try doing one more sync of the branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kumaradityaraj commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3833736206 @domhanak I changed the link; we can merge it now. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3813886560
**PR job** `#13` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/display/redirect
**Test results:**
- PASSED: 3831
- FAILED: 21
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.mongodb/KogitoProcessInstancesFactoryIT/___/";>org.kie.kogito.mongodb.KogitoProcessInstancesFactoryIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.mongodb/MongoDBProcessInstancesIT/___/";>org.kie.kogito.mongodb.MongoDBProcessInstancesIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.mongodb/PersistentProcessInstancesIT/___/";>org.kie.kogito.mongodb.PersistentProcessInstancesIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.mongodb/PersistentProcessInstancesWithLockIT/___/";>org.kie.kogito.mongodb.PersistentProcessInstancesWithLockIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.mongodb.correlation/MongoDBCorrelationServiceIT/___/";>org.kie.kogito.mongodb.correlation.MongoDBCorrelationServiceIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.mongodb.transaction/AbstractTransactionManagerIT/___/";>org.kie.kogito.mongodb.transaction.AbstractTransactionManagerIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.it/MongoDBOptimisticLockingIT/PR_check___Build_projects___testPersistence/";>PR
check / Build projects /
org.kie.kogito.it.MongoDBOptimisticLockingIT.testPersistence
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable
to start Quarkus test resource class
org.kie.kogito.testcontainers.quarkus.MongoDBQuarkusTestResource
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/13/testReport/org.kie.kogito.it/MongoDBOptimisticLockingIT/PR_check___Build_projects___testPersistence/";>PR
check / Build projects /
org.kie.kogito.it.MongoDBOptimisticLockingIT.testPersistence
Failed to load ApplicationContext for
[WebMergedContextConfiguration@1142d377 testClass =
org.kie.kogito.it.MongoDBOptimisticLockingIT, locations = [], classes =
[org.kie.kogito.it.KogitoSpringbootApplication], contextInitializerClasses =
[org.kie.kogito.testcontainers.springboot.MongoDBSpringBootTestResource],
activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties =
["kogito.persistence.optimistic.lock=true",
"org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true",
"server.port=0"], contextCustomizers =
[org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@1e4d3ce5,
org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@1e81f160,
org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0,
org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@2a3888c1,
org.springframework.boot.test.web.reactor.netty.DisableReactorResource
FactoryGlobalResourcesContextCustomizerFactory$DisableReactorResourceFactoryGlobalResourcesContextCustomizerCustomizer@125290e5,
org.springframework.boot.test.a
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3722737682 @gmunozfe or @domhanak can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3654733671 @gmunozfe can you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on code in PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2602231237 ## quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/pom.xml: ## @@ -34,6 +34,9 @@ org.kie.kogito.serverless.workflow + https://sonataflow.org/serverlessworkflow/latest/index.html +Sonataflow Docs + favicon.svg Review Comment: Please also add the var `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_TITLE` ## quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/resources/META-INF/resources/index.html: ## @@ -0,0 +1,62 @@ + + + + + + + +SONATAFLOW WORKFLOW ENDPOINT Review Comment: @kumaradityaraj I apologise, after my review, I saw we should use a variable in the `pom.xml` to let us customise the title, in the same way you did for `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_DOCLINK_TEXT`. We can name it `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_TITLE` ## quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/resources/META-INF/resources/index.html: ## @@ -0,0 +1,62 @@ + + + + + + + +SONATAFLOW WORKFLOW ENDPOINT + + + + + + + + + SONATAFLOW WORKFLOW ENDPOINT Review Comment: Like in my previous comment, please use the new var `SONATAFLOW_WORKFLOW_ENDPOINT_WEBAPP_TITLE` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3611301410 @gmunozfe can you please re-review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3575387034 @kumaradityaraj I opened a PR to your branch to fix these issues: https://github.com/kumaradityaraj/incubator-kie-kogito-runtimes/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3552265052
**PR job** `#9` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/9/display/redirect
**Test results:**
- PASSED: 3684
- FAILED: 5
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/9/testReport/org.kie.kogito.quarkus.workflows/ProcessMigrationIT/testMigrationEndpointMigrateAllInstances/";>org.kie.kogito.quarkus.workflows.ProcessMigrationIT.testMigrationEndpointMigrateAllInstances
1 expectation failed.Expected status code <200> but was <404>.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/9/testReport/org.kie.kogito.quarkus.workflows/ProcessMigrationIT/testMigrationEndpointMigrateOneInstance/";>org.kie.kogito.quarkus.workflows.ProcessMigrationIT.testMigrationEndpointMigrateOneInstance
1 expectation failed.Expected status code <200> but was <404>.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/9/testReport/org.kie.kogito.quarkus.workflows/GreetRestIT/testJsonResponseWithoutAcceptHeader/";>org.kie.kogito.quarkus.workflows.GreetRestIT.testJsonResponseWithoutAcceptHeader
1 expectation failed.Expected content-type "JSON" doesn't match actual
content-type "text/html;charset=UTF-8".
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/9/testReport/org.kie.kogito.integrationtests.quarkus/PingPongMessageIT/testPingPongBetweenProcessInstances/";>org.kie.kogito.integrationtests.quarkus.PingPongMessageIT.testPingPongBetweenProcessInstances
Assertion condition defined as a Lambda expression in
org.kie.kogito.integrationtests.quarkus.PingPongMessageIT 1 expectation
failed.Expected status code <200> but was <404>. within 5 seconds.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/9/testReport/org.kie.kogito.integrationtests.quarkus/SignalProcessIT/testSignalStartProcess/";>org.kie.kogito.integrationtests.quarkus.SignalProcessIT.testSignalStartProcess
1 expectation failed.Expected status code <200> but was <404>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
gmunozfe commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2536797054
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -88,10 +91,23 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE)
+&& !mt.isWildcardType() && !mt.isWildcardSubtype());
Review Comment:
`MediaType.isCompatible(TEXT_HTML_TYPE) ` already excludes generic ` */*`,
so these extra checks are redundant.
```suggestion
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
gmunozfe commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2536797054
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -88,10 +91,23 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE)
+&& !mt.isWildcardType() && !mt.isWildcardSubtype());
Review Comment:
MediaType.isCompatible(TEXT_HTML_TYPE) already excludes generic ` */*`, so
these extra checks are redundant.
```suggestion
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
gmunozfe commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2536797054
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -88,10 +91,23 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE)
+&& !mt.isWildcardType() && !mt.isWildcardSubtype());
Review Comment:
MediaType.isCompatible(TEXT_HTML_TYPE) already excludes generic */*, so
these extra checks are redundant.
```suggestion
);
```
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -88,10 +91,23 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE)
+&& !mt.isWildcardType() && !mt.isWildcardSubtype());
+if (wantsHtml) {
+InputStream htmlStream =
getClass().getResourceAsStream("/META-INF/resources/index.html");
+if (htmlStream == null) {
+return Response.status(Response.Status.NOT_FOUND)
+.entity("HTML resource not found").build();
+}
Review Comment:
After this, could we better return a `StreamingOutput` wrapping the
`InputStream`? In this way, we ensure closure automatically:
```
StreamingOutput stream = os -> {
try (htmlStream) {
htmlStream.transferTo(os);
}
};
```
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -88,10 +91,23 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$name$(@Context HttpHeaders headers) {
+List<$Type$Output> out =
processService.getProcessInstanceOutput(process);
+boolean wantsHtml = headers.getAcceptableMediaTypes()
+.stream()
+.anyMatch(mt -> mt.isCompatible(MediaType.TEXT_HTML_TYPE)
+&& !mt.isWildcardType() && !mt.isWildcardSubtype());
+if (wantsHtml) {
+InputStream htmlStream =
getClass().getResourceAsStream("/META-INF/resources/index.html");
+if (htmlStream == null) {
+return Response.status(Response.Status.NOT_FOUND)
+.entity("HTML resource not found").build();
+}
+return Response.ok(htmlStream, MediaType.TEXT_HTML).build();
Review Comment:
Shouldn't it be more correct to use `MediaType.TEXT_HTML_TYPE`?
```suggestion
return Response.ok(htmlStream, MediaType.TEXT_HTML_TYPE).build();
```
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/RestResourceQuarkusTemplate.java:
##
@@ -88,10 +91,23 @@ public class $Type$Resource {
}
@GET
-@Produces(MediaType.APPLICATION_JSON)
+@Produces({MediaType.APPLICATION_JSON, MediaType.TEXT_HTML})
@Operation(operationId = "getAllProcessInstances_$name$", summary =
"$documentation$", description = "$processInstanceDescription$")
-public List<$Type$Output> getResources_$name$() {
-return processService.getProcessInstanceOutput(process);
+public Response getResources_$na
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
wmedvede commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3520690173 > @wmedvede @gmunozfe can u please take a look? @fjtirado? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
ricardozanini commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3514351214 @wmedvede @gmunozfe can u please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3480652257
**PR job** `#8` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/8/display/redirect
**Test results:**
- PASSED: 3665
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/8/testReport/org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it/KnativeServingAddonIT/___/";>org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/8/testReport/org.kie.kogito.addons.quarkus.kubernetes/ConfigValueExpanderIT/test/";>org.kie.kogito.addons.quarkus.kubernetes.ConfigValueExpanderIT.test
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.q
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3474966917 > Hey guys, how much work we have left to merge this one? Yes, it seems we still have 2 failures to fix on `kogito-codegen-processes` module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
ricardozanini commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3473168802 Hey guys, how much work we have left to merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3472572837
**PR job** `#6` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/6/display/redirect
**Test results:**
- PASSED: 3683
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/6/testReport/org.kie.kogito.codegen.process/ProcessResourceGeneratorTest/testGenerateProcessWithoutDocumentation(Builder)[1]/">org.kie.kogito.codegen.process.ProcessResourceGeneratorTest.testGenerateProcessWithoutDocumentation(Builder)[1]
Expecting actual: [summary = "ProcessWithoutDocumentation",
description = ""]to contain exactly in any order: [summary =
"ProcessWithoutDocumentation",description = "",operationId =
"getAllProcessInstances_ProcessWithoutDocumentation"]but could not find
the following elements: [operationId =
"getAllProcessInstances_ProcessWithoutDocumentation"]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/6/testReport/org.kie.kogito.codegen.process/ProcessResourceGeneratorTest/testGenerateProcessWithDocumentation(Builder)[1]/">org.kie.kogito.codegen.process.ProcessResourceGeneratorTest.testGenerateProcessWithDocumentation(Builder)[1]
Expecting actual: [summary = "This is the documentation",
description = "This is the process instance description"]to contain
exactly in any order: [summary = "This is the documentation",
description = "This is the process instance description",operationId =
"getAllProcessInstances_ProcessWithDocumentation"]but could not find the
following elements: [operationId =
"getAllProcessInstances_ProcessWithDocumentation"]
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/6/testReport/org.kie.kogito.quarkus.workflows/OpenAPIInterfaceGenIT/verifyOperationIdIsGeneratedByDefault/";>org.kie.kogito.quarkus.workflows.OpenAPIInterfaceGenIT.verifyOperationIdIsGeneratedByDefault
1 expectation failed.JSON path paths.'/helloworld'.get.operationId
doesn't match.Expected: is "getAllProcessInstances_helloworld"
Actual: getResources_helloworld
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on code in PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#discussion_r2480639493
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/GreetRestIT.java:
##
@@ -67,6 +68,43 @@ void testVersion() {
.body("version", is("1.0"));
}
+@Test
+void testHtmlResponse() {
+given()
+.accept("text/html")
+.when()
+.get("/greet")
+.then()
+.statusCode(is(200))
Review Comment:
Let's follow the other tests already in this file
```suggestion
.statusCode(200)
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/GreetRestIT.java:
##
@@ -67,6 +68,43 @@ void testVersion() {
.body("version", is("1.0"));
}
+@Test
+void testHtmlResponse() {
+given()
+.accept("text/html")
+.when()
+.get("/greet")
+.then()
+.statusCode(is(200))
+.contentType(startsWith("text/html"))
Review Comment:
see my previous comment
```suggestion
.contentType(ContentType.HTML)
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/GreetRestIT.java:
##
@@ -67,6 +68,43 @@ void testVersion() {
.body("version", is("1.0"));
}
+@Test
+void testHtmlResponse() {
+given()
+.accept("text/html")
+.when()
+.get("/greet")
+.then()
+.statusCode(is(200))
+.contentType(startsWith("text/html"))
+.body(containsString("SONATAFLOW WORKFLOW ENDPOINT"));
+}
+
+@Test
+void testJsonResponseWithHeader() {
+given()
+.accept(ContentType.JSON)
+.when()
+.get("/greetdetails")
Review Comment:
`greetdetails` workflow is java workflow. We should use `greet`, which is a
classic workflow.
```suggestion
.get("/greet")
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/GreetRestIT.java:
##
@@ -67,6 +68,43 @@ void testVersion() {
.body("version", is("1.0"));
}
+@Test
+void testHtmlResponse() {
+given()
+.accept("text/html")
Review Comment:
it's better to avoid hardcoding of contentypes. We already have
`ContentType` constant.
```suggestion
.accept(ContentType.HTML)
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/GreetRestIT.java:
##
@@ -67,6 +68,43 @@ void testVersion() {
.body("version", is("1.0"));
}
+@Test
+void testHtmlResponse() {
+given()
+.accept("text/html")
+.when()
+.get("/greet")
+.then()
+.statusCode(is(200))
+.contentType(startsWith("text/html"))
+.body(containsString("SONATAFLOW WORKFLOW ENDPOINT"));
+}
+
+@Test
+void testJsonResponseWithHeader() {
+given()
+.accept(ContentType.JSON)
+.when()
+.get("/greetdetails")
+.then()
+.statusCode(200)
+.contentType(ContentType.JSON)
+.body("version", is("1.0"))
+.body("type", is("SW"));
Review Comment:
Like in other `greet` WF tests.
```suggestion
.body(is("[]"));
```
##
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/GreetRestIT.java:
##
@@ -67,6 +68,43 @@ void testVersion() {
.body("version", is("1.0"));
}
+@Test
+void testHtmlResponse() {
+given()
+.accept("text/html")
+.when()
+.get("/greet")
+.then()
+.statusCode(is(200))
+.contentType(startsWith("text/html"))
+.body(containsString("SONATAFLOW WORKFLOW ENDPOINT"));
+}
+
+@Test
+void testJsonResponseWithHeader() {
+given()
+.accept(ContentType.JSON)
+.when()
+
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3401597655
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/2/display/redirect
**Test results:**
- PASSED: 3662
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/2/testReport/org.kie.kogito.addon.quarkus.messaging.common/QuarkusEventThreadPoolTest/testQuarkusEventThreadPoolMultiThreadLongQueueTest/";>org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTest
expected: <1> but was: <>
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/2/testReport/org.kie.kogito.integrationtests.quarkus/PingPongMessageIT/testPingPongBetweenProcessInstances/";>org.kie.kogito.integrationtests.quarkus.PingPongMessageIT.testPingPongBetweenProcessInstances
Assertion condition defined as a Lambda expression in
org.kie.kogito.integrationtests.quarkus.PingPongMessageIT 1 expectation
failed.Expected status code <200> but was <404>. within 5 seconds.
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/2/testReport/org.kie.kogito.integrationtests.quarkus/SignalProcessIT/testSignalStartProcess/";>org.kie.kogito.integrationtests.quarkus.SignalProcessIT.testSignalStartProcess
1 expectation failed.Expected status code <200> but was <404>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
fantonangeli commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3403025036 Hi @kumaradityaraj, I think we are almost there. To fix the build you need just to sync with `upstream/main`. - `curl -i -H 'Accept: application/json' http://localhost:8080/jsongreet` returns a json :rocket: - `curl -i -H 'Accept: text/html' http://localhost:8080/jsongreet` returns the landing page :rocket: - `curl -v http://localhost:8080/jsongreet` asks for any (`Accept: */*`) and receive the landing page as a default. Here the default should be the json. It's just a matter of priorities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4078:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3406461280
**PR job** `#4` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/display/redirect
**Test results:**
- PASSED: 3614
- FAILED: 21
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.mongodb/KogitoProcessInstancesFactoryIT/___/";>org.kie.kogito.mongodb.KogitoProcessInstancesFactoryIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.mongodb/MongoDBProcessInstancesIT/___/";>org.kie.kogito.mongodb.MongoDBProcessInstancesIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.mongodb/PersistentProcessInstancesIT/___/";>org.kie.kogito.mongodb.PersistentProcessInstancesIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.mongodb/PersistentProcessInstancesWithLockIT/___/";>org.kie.kogito.mongodb.PersistentProcessInstancesWithLockIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.mongodb.correlation/MongoDBCorrelationServiceIT/___/";>org.kie.kogito.mongodb.correlation.MongoDBCorrelationServiceIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.mongodb.transaction/AbstractTransactionManagerIT/___/";>org.kie.kogito.mongodb.transaction.AbstractTransactionManagerIT.(?)
Container startup failed for image mirror.gcr.io/library/mongo:5.0.31
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.it/MongoDBOptimisticLockingIT/PR_check___Build_projects___testPersistence/";>PR
check / Build projects /
org.kie.kogito.it.MongoDBOptimisticLockingIT.testPersistence
java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable
to start Quarkus test resource class
org.kie.kogito.testcontainers.quarkus.MongoDBQuarkusTestResource
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4078/4/testReport/org.kie.kogito.it/MongoDBOptimisticLockingIT/PR_check___Build_projects___testPersistence/";>PR
check / Build projects /
org.kie.kogito.it.MongoDBOptimisticLockingIT.testPersistence
Failed to load ApplicationContext for
[WebMergedContextConfiguration@577536e0 testClass =
org.kie.kogito.it.MongoDBOptimisticLockingIT, locations = [], classes =
[org.kie.kogito.it.KogitoSpringbootApplication], contextInitializerClasses =
[org.kie.kogito.testcontainers.springboot.MongoDBSpringBootTestResource],
activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties =
["kogito.persistence.optimistic.lock=true",
"org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true",
"server.port=0"], contextCustomizers =
[org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@1bab8268,
org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@658c5a19,
org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0,
org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@3e2059ae,
org.springframework.boot.test.web.reactor.netty.DisableReactorResource
FactoryGlobalResourcesContextCustomizerFactory$DisableReactorResourceFactoryGlobalResourcesContextCustomizerCustomizer@6337c201,
org.springframework.boot.test.autoconfigu
Re: [PR] Adding a landing page for workflow endpoint [incubator-kie-kogito-runtimes]
kumaradityaraj commented on PR #4078: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4078#issuecomment-3365211777 @fantonangeli Please review this PR. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
