Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]
yesamer commented on code in PR #3823: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905453988 ## kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn: ## @@ -1,24 +1,6 @@ - - -http://www.omg.org/spec/DMN/20180521/MODEL/"; xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; xmlns:kie="http://www.drools.org/kie/dmn/1.2"; xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="decision"> - + Review Comment: @gitgabrio @porcelli @jomarko Indeed we need to investigate this, as far as I know, the prolog should be correctly validated. When creating a new dmn file in our editor, the prolog is automatically added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]
gitgabrio commented on PR #3823: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2575261505 @porcelli On deeper analysis, the problem is that the 1. the "extractModelVersion(DMNResource resource)" method should not exists at all, and it is invoked only on a very specific case 2. the implementation is anyway conceptually completely "wrong", and should simply return `resource.getDmnModel().getDefinitions().getTypeLanguage()` (no need of anything else, apparently) @baldimir @yesamer FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]
gitgabrio commented on code in PR #3823: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905048559 ## kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn: ## @@ -1,24 +1,6 @@ - - -http://www.omg.org/spec/DMN/20180521/MODEL/"; xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; xmlns:kie="http://www.drools.org/kie/dmn/1.2"; xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="decision"> - + Review Comment: HI @porcelli Thanks for PR! As @jomarko pointed out, the `xml` tag has to be removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]
gitgabrio commented on code in PR #3823: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905048559 ## kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn: ## @@ -1,24 +1,6 @@ - - -http://www.omg.org/spec/DMN/20180521/MODEL/"; xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; xmlns:kie="http://www.drools.org/kie/dmn/1.2"; xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="decision"> - + Review Comment: HI @porcelli Thanks for PR! As @jomarko pointed out, the `?xml` tag has to be removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]
jomarko commented on code in PR #3823: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905034916 ## kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn: ## @@ -16,9 +16,9 @@ ~ specific language governing permissions and limitations ~ under the License. --> - -http://www.omg.org/spec/DMN/20180521/MODEL/"; xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; xmlns:kie="http://www.drools.org/kie/dmn/1.2"; xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="decision"> - + Review Comment: failed tests seems to be related to this : ``` DMN Validation schema and model validation contained errors You may configure kogito.decisions.validation=IGNORE to ignore validation errors DMN Validation errors: : DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) , : DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Adding support for DMN 1.5 for maven plugin code-gen [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #3823:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2573776241
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/display/redirect
**Test results:**
- PASSED: 3506
- FAILED: 18
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCloudEventMetaFactoryGeneratorTest/testGenerateWithCloudEventsDisabled/";>org.kie.kogito.codegen.decision.DecisionCloudEventMetaFactoryGeneratorTest.testGenerateWithCloudEventsDisabled
DMN Validation schema and model validation contained errorsYou may
configure kogito.decisions.validation=IGNORE to ignore validation
errorsDMN Validation errors:: DMN: Failed XML validation of DMN file:
/home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn
- The processing instruction target matching "[xX][mM][lL]" is not allowed.
(DMN model failed XML schema validation) ,: DMN: One of the supplied DMN
Models has failed validation; cannot proceed to validation of the remaining DMN
Models. (DMN Validation stopped on failed validation for some DMN Model)
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCloudEventMetaFactoryGeneratorTest/testGenerateWithCloudEventsEnabled/";>org.kie.kogito.codegen.decision.DecisionCloudEventMetaFactoryGeneratorTest.testGenerateWithCloudEventsEnabled
DMN Validation schema and model validation contained errorsYou may
configure kogito.decisions.validation=IGNORE to ignore validation
errorsDMN Validation errors:: DMN: Failed XML validation of DMN file:
/home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn
- The processing instruction target matching "[xX][mM][lL]" is not allowed.
(DMN model failed XML schema validation) ,: DMN: One of the supplied DMN
Models has failed validation; cannot proceed to validation of the remaining DMN
Models. (DMN Validation stopped on failed validation for some DMN Model)
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/generateAllFiles(Builder)[1]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.generateAllFiles(Builder)[1]
DMN Validation schema and model validation contained errorsYou may
configure kogito.decisions.validation=IGNORE to ignore validation
errorsDMN Validation errors:: DMN: Failed XML validation of DMN file:
/home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn
- The processing instruction target matching "[xX][mM][lL]" is not allowed.
(DMN model failed XML schema validation) ,: DMN: One of the supplied DMN
Models has failed validation; cannot proceed to validation of the remaining DMN
Models. (DMN Validation stopped on failed validation for some DMN Model)
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3823/1/testReport/org.kie.kogito.codegen.decision/DecisionCodegenTest/generateAllFiles(Builder)[2]/">org.kie.kogito.codegen.decision.DecisionCodegenTest.generateAllFiles(Builder)[2]
DMN Validation schema and model validation contained errorsYou may
configure kogito.decisions.validation=IGNORE to ignore validation
errorsDMN Validation errors:: DMN: Failed XML validation of DMN file:
/home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacation
