Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-21 Thread via GitHub


porcelli merged PR #3823:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-10 Thread via GitHub


gitgabrio commented on PR #3823:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2582941811

   Thanks @yesamer  👏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-10 Thread via GitHub


yesamer commented on PR #3823:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2582827059

   @porcelli @gitgabrio 
   Here the failure's reason
   
   ```
   2025-01-09T13:36:26.6605040Z [ERROR] Failed to execute goal 
net.revelc.code:impsort-maven-plugin:1.8.0:check (default) on project 
kogito-codegen-decisions: Imports are not sorted in 
/home/runner/work/incubator-kie-kogito-runtimes/incubator-kie-kogito-runtimes/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionModelResourcesProviderGenerator.java
 -> [Help 1]
   2025-01-09T13:36:26.663Z 
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
net.revelc.code:impsort-maven-plugin:1.8.0:check (default) on project 
kogito-codegen-decisions: Imports are not sorted in 
/home/runner/work/incubator-kie-kogito-runtimes/incubator-kie-kogito-runtimes/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/main/java/org/kie/kogito/codegen/decision/DecisionModelResourcesProviderGenerator.java
   ```
   
   Weird, as there are no new imported classes in 
DecisionModelResourcesProviderGenerator.java, maybe there's an unused import?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-09 Thread via GitHub


gitgabrio commented on PR #3823:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2579755196

   Thanks @porcelli !
   Anyway, I can't understand why the kogito-runtimes build is marked as failed 
- the tests seems all succeeding 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-07 Thread via GitHub


gitgabrio commented on PR #3823:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#issuecomment-2575473257

   @porcelli 
   
   Could you pls try with:
   
   
   ```java
   private String extractModelVersion(DMNResource resource) {
   String toReturn = 
resource.getDmnModel().getDefinitions().getTypeLanguage();
   if (toReturn == null || toReturn.isEmpty()) {
   LOGGER.error("Could not extract DMN version from DMN model {}", 
resource.getDmnModel().getName());
   throw new IllegalStateException("The DMN model does not contain 
a unique model version in the metadata.");
   }
   return toReturn;
   }
   ```
   
   so that the CI will check it also downstream ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-07 Thread via GitHub


gitgabrio commented on code in PR #3823:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905554115


##
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##
@@ -1,24 +1,6 @@
-
-
-http://www.omg.org/spec/DMN/20180521/MODEL/"; 
xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; 
xmlns:kie="http://www.drools.org/kie/dmn/1.2"; 
xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; 
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; 
xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; 
id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" 
typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="decision">
-  
+

Review Comment:
   Ok, just double checked, the "?xml" tag should be before the license header, 
as very first line.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] Fix usage of DMN 1.5 for tracing-enabled applications inside maven plugin code-gen [incubator-kie-kogito-runtimes]

2025-01-07 Thread via GitHub


baldimir commented on code in PR #3823:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905537566


##
kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn:
##
@@ -1,24 +1,6 @@
-
-
-http://www.omg.org/spec/DMN/20180521/MODEL/"; 
xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/"; 
xmlns:kie="http://www.drools.org/kie/dmn/1.2"; 
xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/"; 
xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/"; 
xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/"; 
id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" 
typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/"; namespace="decision">
-  
+

Review Comment:
   Yes, should be there. It is also part of e.g. DMN TCK test files, like e.g. 
here (1).
   
   (1) 
https://github.com/dmn-tck/tck/blob/master/TestCases/compliance-level-3/0007-date-time/0007-date-time.dmn#L1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org