Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
yesamer commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413667543 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + + + + + +17 +17 +17 + + +UTF-8 + UTF-8 +8.44.0.Final +2.15.2 +1.1.0 + 2.0.1 Review Comment: SHouldn't we declare those in the global bom? @gitgabrio //cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
yesamer commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413665182 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + Review Comment: @Rikkola Same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
yesamer commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413657405 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + Review Comment: @Rikkola I guess this should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
tkobayas commented on PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#issuecomment-3327214315 - Apache RAT Check : - Need license headers to the files suggested in the GHA log. - Drools / ubuntu-latest : - `ban-duplicated-classes` in `kie-yard-api`. Can this be resolved? - `compare`(reproducible build) issue in `drools-distribution`. Probably we will need investigate with diffoscope locally. But I guess it's better to solve `ban-duplicated-classes` issue first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
yesamer commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413655065 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + + + + + +17 +17 +17 + + +UTF-8 + UTF-8 +8.44.0.Final Review Comment: @Rikkola Hi! Can you please clarify why yard points to this old drools version? it that intended? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
yesamer commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413664502 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard Review Comment: @Rikkola THose looks not correct as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
Rikkola commented on PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#issuecomment-3338752684 Just checking how this builds. I think the correct move is to get all the J2CL features out right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
Rikkola merged PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
gitgabrio commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413690089 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + + + + + +17 +17 +17 + + +UTF-8 + UTF-8 +8.44.0.Final +2.15.2 +1.1.0 + 2.0.1 Review Comment: I'm also confused about the `8.44.0.Final` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
Rikkola commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2414244455 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + + + + + +17 +17 +17 + + +UTF-8 + UTF-8 +8.44.0.Final +2.15.2 +1.1.0 + 2.0.1 Review Comment: Yeah it should to use the current version. I will review the poms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
yesamer commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413676955 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + + + + + +17 +17 +17 + + +UTF-8 + UTF-8 +8.44.0.Final +2.15.2 +1.1.0 + 2.0.1 Review Comment: if I'm not wrong, jackson should be already defined there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
gitgabrio commented on code in PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#discussion_r2413690089 ## kie-yard/pom.xml: ## @@ -0,0 +1,118 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + +org.kie +drools-build-parent +999-SNAPSHOT +../build-parent + + +4.0.0 +org.kie +kie-yard +999-SNAPSHOT +pom + +KIE :: Yard - YAML Rules DSL +Yet another Rules DSL (YaRD) - A YAML-based domain-specific language for defining business rules + +http://drools.org +2022 + +JBoss by Red Hat +http://www.jboss.org/ + + + + +Apache Software License, Version 2.0 +http://www.apache.org/licenses/LICENSE-2.0.txt +repo + + + + +scm:git:https://github.com/kiegroup/yard.git + scm:git:[email protected]:kiegroup/yard.git +https://github.com/kiegroup/yard + + + + +All developers are listed in the KIE GitHub organization +https://github.com/orgs/kiegroup/people + + + + + +17 +17 +17 + + +UTF-8 + UTF-8 +8.44.0.Final +2.15.2 +1.1.0 + 2.0.1 Review Comment: @yesamer @baldimir I'm also confused about the `8.44.0.Final` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
Rikkola commented on PR #6412: URL: https://github.com/apache/incubator-kie-drools/pull/6412#issuecomment-3364895753 @pibizza I am done with all the changes. What is your take on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
kie-ci3 commented on PR #6412:
URL:
https://github.com/apache/incubator-kie-drools/pull/6412#issuecomment-3312030451
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-drools -u
https://github.com/apache/incubator-kie-drools/pull/6412 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6412/2/display/redirect
**Test results:**
- PASSED: 23876
- FAILED: 2
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6412/2/testReport/org.kie.yard.core/InsuranceBasePriceTest/testScenario1/";>org.kie.yard.core.InsuranceBasePriceTest.testScenario1
Expecting {"Age"=47, "Base price"=500, "Downpayment"=50,
"Previous incidents?"=false}to have a property or a field named
"Downpayment" with value 50.0but value was: 50(static and
synthetic fields are ignored)
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6412/2/testReport/org.kie.yard.core/InsuranceBasePriceTest/testScenario2/";>org.kie.yard.core.InsuranceBasePriceTest.testScenario2
Expecting {"Age"=19, "Base price"=1000, "Downpayment"=70,
"Previous incidents?"=true}to have a property or a field named
"Downpayment" with value 70.0but value was: 70(static and
synthetic fields are ignored)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Move YARD into KIE repositories incubator-kie-issues#2044 [incubator-kie-drools]
kie-ci3 commented on PR #6412:
URL:
https://github.com/apache/incubator-kie-drools/pull/6412#issuecomment-3150205689
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-drools -u
https://github.com/apache/incubator-kie-drools/pull/6412 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6412/1/display/redirect
**Test results:**
- PASSED: 23796
- FAILED: 2
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6412/1/testReport/org.kie.yard.core/InsuranceBasePriceTest/testScenario1/";>org.kie.yard.core.InsuranceBasePriceTest.testScenario1
Expecting {"Age"=47, "Base price"=500, "Downpayment"=50,
"Previous incidents?"=false}to have a property or a field named
"Downpayment" with value 50.0but value was: 50(static and
synthetic fields are ignored)
https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6412/1/testReport/org.kie.yard.core/InsuranceBasePriceTest/testScenario2/";>org.kie.yard.core.InsuranceBasePriceTest.testScenario2
Expecting {"Age"=19, "Base price"=1000, "Downpayment"=70,
"Previous incidents?"=true}to have a property or a field named
"Downpayment" with value 70.0but value was: 70(static and
synthetic fields are ignored)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
