Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2025-01-14 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1915292223


##
packages/maven-base/pom.xml:
##
@@ -295,8 +293,8 @@
 
 
   org.apache.maven.plugins
-  maven-helper-plugin
-  ${version.maven.helper.plugin}
+  maven-help-plugin
+  ${version.maven.help.plugin}

Review Comment:
   `maven-helper-plugin ` doesn't exist



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2025-01-14 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2589533437

   @tiagobento After our discussion now I fully understand the scenario you 
described, and I agree it can be a realistic scenario. Thank you for raising 
that and apologize again for not giving the proper attention. 
   Now, to finalize this PR, I'm open to considering your suggestion and don't 
rely on the Apache parent pom for the involved maven plugins, to quickly react 
to the worst-case scenario of overriding a transitive dependency used by a 
maven plugin. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2025-01-07 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1906596545


##
packages/serverless-workflow-diagram-editor/package.json:
##
@@ -18,11 +18,11 @@
   ],
   "scripts": {
 "build:dev": "run-script-os",
-"build:dev:linux:darwin": "mvn clean install -DskipTests -DskipITs 
-Pno-showcase",
-"build:dev:win32": "pnpm powershell \"mvn clean install `-DskipTests 
`-DskipITs `-Pno-showcase\"",

Review Comment:
   @domhanak Sure, this is still a WIP, so we can indeed discuss any 
improvement or suggestions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2025-01-07 Thread via GitHub


domhanak commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1906540758


##
packages/serverless-workflow-diagram-editor/package.json:
##
@@ -18,11 +18,11 @@
   ],
   "scripts": {
 "build:dev": "run-script-os",
-"build:dev:linux:darwin": "mvn clean install -DskipTests -DskipITs 
-Pno-showcase",
-"build:dev:win32": "pnpm powershell \"mvn clean install `-DskipTests 
`-DskipITs `-Pno-showcase\"",

Review Comment:
   could you please move this to separate PR? this has nothing to do with maven 
plugins update. I know the profile does not exist, yet having a PR like `Fix 
non-exsiting profile usage in serverless-workflow-diagram-editor` is way more 
descriptive and makes this change not hidden amongst some other unrelated work.
   Or remove it if possible ( not sure what enforcer settings we have...) and I 
ll fix it in separate PR. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2025-01-07 Thread via GitHub


domhanak commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1906540758


##
packages/serverless-workflow-diagram-editor/package.json:
##
@@ -18,11 +18,11 @@
   ],
   "scripts": {
 "build:dev": "run-script-os",
-"build:dev:linux:darwin": "mvn clean install -DskipTests -DskipITs 
-Pno-showcase",
-"build:dev:win32": "pnpm powershell \"mvn clean install `-DskipTests 
`-DskipITs `-Pno-showcase\"",

Review Comment:
   could you please move this to separate PR? this has nothing to do with maven 
plugins update. I know the profile does not exist, yet having a PR like `Fix 
non-exsiting profile usage in serverless-workflow-diagram-editor` is way more 
descriptive and makes this change not hidden amongst some other unrelated work.
   Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2025-01-07 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2575946466

   @tiagobento Setting this PR on hold until you share your input on the whole 
strategy. Again, apologies for my previous bad answer that I removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-21 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2558352784

   @tiagobento Many apologies for my impulsive rant, that's not my standard and 
my style. Taking a real break here, we can talk about this in private after the 
vacation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-20 Thread via GitHub


yesamer closed pull request #2819: NO-ISSUE: Maven plugins update
URL: https://github.com/apache/incubator-kie-tools/pull/2819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-20 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2558041101

   @tiagobento Of course, I'm available to discuss this topic in private, but 
if you think for real I did this PR *casually* after all the evidences I gave 
to you, trying to explain that the plugin management is NOT THE SAME of the 
dependency management, I think I failed my intent, and I no more interested to 
keep this effort in place.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1890008571


##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0

Review Comment:
   @jomarko Updated versions in `dashbuilder` as well, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1890008571


##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0

Review Comment:
   @jomarko Updated version in `dashbuilder` as well, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2550959499

   @tiagobento Even in such a case, those transitive dependencies are not 
imported in the production code, as that is used at compile time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


tiagobento commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2550954419

   @yesamer Problems are often in transitive dependencies...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2550910930

   @tiagobento I checked the CVE history of all declared plugins in Apache 
parent pom.
   An example: `maven-assembly-plugin`
   
https://security.snyk.io/package/maven/org.apache.maven.plugins%3Amaven-assembly-plugin
   
https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-assembly-plugin
   I didn't find any reported CVE for those plugins EVER.
   Based on that, I guess we are safe to proceed ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889917232


##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1

Review Comment:
   You're right, removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889920626


##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2
+
${version.maven.surefire.plugin}
+3.1.3

Review Comment:
   Removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889917441


##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2

Review Comment:
   You're right, removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889917232


##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1

Review Comment:
   You're reight, removed!



##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2

Review Comment:
   You're reight, removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889913668


##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0

Review Comment:
   I purposely didn't touch dashbuilder because is not a project under our 
control, however, I can do a tentative 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


yesamer commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889910549


##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2
+
${version.maven.surefire.plugin}

Review Comment:
   @jomarko Yes, that's correct. failsafe and surefire have the same release 
cycle. apache pom manages that in the same way: 
https://repo.maven.apache.org/maven2/org/apache/apache/32/apache-32.pom



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-18 Thread via GitHub


jomarko commented on code in PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889845483


##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2

Review Comment:
   version.maven.deploy.plugin seems to be unused



##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0

Review Comment:
   is expected dashbuilder overrides to 3.1.1? I think preferred would be 
single version everywhere if possible 



##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2
+
${version.maven.surefire.plugin}

Review Comment:
   hm, this sounds a little bit non-standard to me, is that intentional to 
combine failsafe and surefire versions? furthermore 
version.maven.failsafe.plugin seems to be unused



##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0
+3.4.0
+3.13.0

Review Comment:
   same comment as above



##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1

Review Comment:
   seems as unused? 
3.7.1
   



##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0
+3.4.0

Review Comment:
   same comment as above



##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0
+3.4.0
+3.13.0
+3.7.1
+3.1.2
+3.5.0

Review Comment:
   same comment as above



##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0
+3.4.0
+3.13.0
+3.7.1
+3.1.2
+3.5.0
 
${version.surefire.plugin}
-2.5.2
+3.1.2

Review Comment:
   same comment as above



##
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##
@@ -41,19 +41,18 @@
 UTF-8
 UTF-8
 
-
-3.4.1
+
+1.6.0
+3.4.0
 3.13.0
-3.3.1
-3.0.0-M7
-3.5.0
-3.1.3
+3.7.1
 3.1.2
+
${version.maven.surefire.plugin}
+3.1.3

Review Comment:
   seems to be unused version.maven.install.plugin



##
packages/stunner-editors/pom.xml:
##
@@ -187,29 +187,29 @@
 1.8
 3.0.0
 3.3.0
-3.2.0
-3.1.0
-3.12.1
-3.3.0
-2.8.2
-3.1.0
+3.4.0
+3.4.0
+3.13.0
+3.7.1
+3.1.2
+3.5.0
 
${version.surefire.plugin}
-2.5.2
+3.1.2

Review Comment:
   version misalignment is also for:
   - `version.maven.artifact.plugin`
   - `version.resources.plugin`
   - `version.site.plugin`
   - `version.surefire.plugin`
   - `version.war.plugin`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-17 Thread via GitHub


yesamer commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2548631965

   @tiagobento Well, at the moment a CVE is detected in any plugin version, we 
can temporarily override. I guess that is a good compromise on having the same 
plugin versions used anywhere and keeping them updated. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org



Re: [PR] NO-ISSUE: Maven plugins update [incubator-kie-tools]

2024-12-17 Thread via GitHub


tiagobento commented on PR #2819:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2819#issuecomment-2548572407

   @yesamer I guess I didn't write this anywhere, but the idea of managing the 
versions of Maven plugins ourselves is to have more control over patches that 
may contain security fixes. If we delegate it to the Apache parent we may find 
ourselves in a position of having to declare them anyway to fix something that 
the Apache parent hasn't.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org