Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
Abhitocode commented on PR #2241: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2241#issuecomment-4252242131 Closing PR as not relevant any more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
Abhitocode closed pull request #2241: Process instance fails to start after successful job scheduling URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
Abhitocode commented on PR #2241: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2241#issuecomment-4252236035 Hi @yesamer Closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
yesamer commented on PR #2241: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2241#issuecomment-4251855685 Hi @Abhitocode, just checking in—does this PR still apply, or can it be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
yesamer commented on PR #2241: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2241#issuecomment-4154626344 Hi @Abhitocode, is this PR still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
Abhitocode commented on code in PR #2241:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2241#discussion_r2227205142
##
jobs-service/kogito-addons-jobs-service/kogito-addons-quarkus-jobs/src/main/java/org/kie/kogito/jobs/embedded/EmbeddedJobExecutor.java:
##
@@ -142,6 +152,45 @@ private Uni
processJobDescription(JobDetails jobDetails, P
.build());
}
+private Uni processJobDescription(JobDetails
jobDetails, ProcessJobDescription processJobDescription) {
+String processId = processJobDescription.processId();
+Process process =
processes.get().processById(processId);
+
+LOGGER.info("Processing processJobDescription for processId: {},
jobDetails: {}, processDescription: {}, and process: {}",
+processId, jobDetails, processJobDescription, process);
+
+if (Objects.isNull(process)) {
+return Uni.createFrom().item(
+JobExecutionResponse.builder()
+.code("401")
+.jobId(jobDetails.getId())
+.now()
+.message("job does not belong to this container")
+.build());
+}
+
+Integer limit = jobDetails.getRetries();
+
+Supplier execute = () ->
executeInUnitOfWork(application.unitOfWorkManager(), () -> {
+process.send(SignalFactory.of("timerTriggered",
processJobDescription.expirationTime()));
Review Comment:
@elguardian
As we dont have "timerId" for ProcessJobDescription like we have for
ProcessInstanceJobDescription, I created TimerInstance using correlationId,
limit and timerId where timerId is null.
```
TimerInstance timerInstance =
TimerInstance.with(jobDetails.getCorrelationId(), null, limit);
Supplier execute = () ->
executeInUnitOfWork(application.unitOfWorkManager(), () -> {
process.send(SignalFactory.of("timerTriggered", timerInstance));
return true;
});
```
we still can see few 401 job cannot be processed error responses as
"JobDetails" in "execute" method of EmbeddedJobExecutor has null JobDescription
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
Abhitocode commented on code in PR #2241:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2241#discussion_r712640
##
jobs-service/kogito-addons-jobs-service/kogito-addons-quarkus-jobs/src/main/java/org/kie/kogito/jobs/embedded/EmbeddedJobExecutor.java:
##
@@ -142,6 +152,45 @@ private Uni
processJobDescription(JobDetails jobDetails, P
.build());
}
+private Uni processJobDescription(JobDetails
jobDetails, ProcessJobDescription processJobDescription) {
+String processId = processJobDescription.processId();
+Process process =
processes.get().processById(processId);
+
+LOGGER.info("Processing processJobDescription for processId: {},
jobDetails: {}, processDescription: {}, and process: {}",
+processId, jobDetails, processJobDescription, process);
+
+if (Objects.isNull(process)) {
+return Uni.createFrom().item(
+JobExecutionResponse.builder()
+.code("401")
+.jobId(jobDetails.getId())
+.now()
+.message("job does not belong to this container")
+.build());
+}
+
+Integer limit = jobDetails.getRetries();
+
+Supplier execute = () ->
executeInUnitOfWork(application.unitOfWorkManager(), () -> {
+process.send(SignalFactory.of("timerTriggered",
processJobDescription.expirationTime()));
Review Comment:
will test again and update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
elguardian commented on code in PR #2241:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2241#discussion_r613771
##
jobs-service/kogito-addons-jobs-service/kogito-addons-quarkus-jobs/src/main/java/org/kie/kogito/jobs/embedded/EmbeddedJobExecutor.java:
##
@@ -142,6 +152,45 @@ private Uni
processJobDescription(JobDetails jobDetails, P
.build());
}
+private Uni processJobDescription(JobDetails
jobDetails, ProcessJobDescription processJobDescription) {
+String processId = processJobDescription.processId();
+Process process =
processes.get().processById(processId);
+
+LOGGER.info("Processing processJobDescription for processId: {},
jobDetails: {}, processDescription: {}, and process: {}",
+processId, jobDetails, processJobDescription, process);
+
+if (Objects.isNull(process)) {
+return Uni.createFrom().item(
+JobExecutionResponse.builder()
+.code("401")
+.jobId(jobDetails.getId())
+.now()
+.message("job does not belong to this container")
+.build());
+}
+
+Integer limit = jobDetails.getRetries();
+
+Supplier execute = () ->
executeInUnitOfWork(application.unitOfWorkManager(), () -> {
+process.send(SignalFactory.of("timerTriggered",
processJobDescription.expirationTime()));
Review Comment:
should not be the timer instance ? instead of the expiration time ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Process instance fails to start after successful job scheduling [incubator-kie-kogito-apps]
kie-ci3 commented on PR #2241:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2241#issuecomment-3079492159
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-apps -u
https://github.com/apache/incubator-kie-kogito-apps/pull/2241
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2241/1/display/redirect
**Test results:**
- PASSED: 1662
- FAILED: 19
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2241/1/testReport/org.kie.kogito.index.inmemory/KogitoDevServiceTest/testDataIndexDevService/";>org.kie.kogito.index.inmemory.KogitoDevServiceTest.testDataIndexDevService
io.quarkus.builder.BuildException: Build failure: Build failed due to
errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at
org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:351)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devservices.keycloak.KeycloakDevSe
rvicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:336)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:556)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:346)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait.strategy.LogMessageWaitStra
tegy.waitUntilReady(LogMessageWaitStrategy.java:47) at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:492)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2241/1/testReport/org.kie.kogito.it.jobs/CallbackStateTimeoutsIT/PR_check___Build_projects___callbackStateTimeoutsExceeded/";>PR
check / Build projects /
org.kie.kogito.it.jobs.CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.
