Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3479381840
**PR job** `#19` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/19/display/redirect
**Test results:**
- PASSED: 2595
- FAILED: 1
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/19/testReport/org.kie.kogito.quarkus.token.persistence.workflows/TokenExchangeIT/tokenExchange/";>org.kie.kogito.quarkus.token.persistence.workflows.TokenExchangeIT.tokenExchange
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: commi
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3475322729
**PR job** `#17` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/17/display/redirect
**Test results:**
- PASSED: 3662
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/17/testReport/org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it/KnativeServingAddonIT/___/";>org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/17/testReport/org.kie.kogito.addons.quarkus.kubernetes/ConfigValueExpanderIT/test/";>org.kie.kogito.addons.quarkus.kubernetes.ConfigValueExpanderIT.test
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3469121460
**PR job** `#15` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/15/display/redirect
**Test results:**
- PASSED: 3662
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/15/testReport/org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it/KnativeServingAddonIT/___/";>org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/15/testReport/org.kie.kogito.addons.quarkus.kubernetes/ConfigValueExpanderIT/test/";>org.kie.kogito.addons.quarkus.kubernetes.ConfigValueExpanderIT.test
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3460649086
**PR job** `#13` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/13/display/redirect
**Test results:**
- PASSED: 3662
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/13/testReport/org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it/KnativeServingAddonIT/___/";>org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/13/testReport/org.kie.kogito.addons.quarkus.kubernetes/ConfigValueExpanderIT/test/";>org.kie.kogito.addons.quarkus.kubernetes.ConfigValueExpanderIT.test
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
martinweiler commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2471127682
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/lifecycle/DefaultUserTaskLifeCycles.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.kie.kogito.usertask.impl.lifecycle;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle;
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycleException;
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycles;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DefaultUserTaskLifeCycles implements UserTaskLifeCycles {
+
+private static final Logger LOG =
LoggerFactory.getLogger(DefaultUserTaskLifeCycles.class);
+
+private final Map userTaskLifeCycleRegistry =
new HashMap<>();
+private String defaultUserTaskLifeCycleId;
+
+public DefaultUserTaskLifeCycles() {
+this.defaultUserTaskLifeCycleId = "default";
Review Comment:
Please change the name to `kogito`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3456503702
**PR job** `#12` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/12/display/redirect
**Test results:**
- PASSED: 3662
- FAILED: 3
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/12/testReport/org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it/KnativeServingAddonIT/___/";>org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.(?)
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer
threw an exception: java.lang.RuntimeException:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:250)
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
at
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255) at
org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at
org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQu
eueExecutor.java:2654) at
org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
at java.base/java.lang.Thread.run(Thread.java:840) at
org.jboss.threads.JBossThread.run(JBossThread.java:499)Caused by:
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image quay.io/keycloak/keycloak:26.1.3 at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
at
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:421)
at java.base/java.util.Optional.orElseGet(Optional.java:364) at
io.quarkus.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:447)
at io.quarkus.devser
vices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:200)
... 10 moreCaused by: org.rnorth.ducttape.RetryCountExceededException:
Retry limit hit with exception at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:331)
... 15 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Could not create/start
container at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:551)
at
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:341)
at
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 16 moreCaused by:
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for
log output matching '.*Keycloak.*started.*' at
org.testcontainers.containers.wait
.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:904)
at
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:487)
... 18 more
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/12/testReport/org.kie.kogito.addons.quarkus.kubernetes/ConfigValueExpanderIT/test/";>org.kie.kogito.addons.quarkus.kubernetes.ConfigValueExpanderIT.test
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build
failure: Build failed due to errors [error]: Build step
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3453411367
**PR job** `#9` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/display/redirect
**Test results:**
- PASSED: 3541
- FAILED: 124
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[13]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[13]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[19]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[19]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[22]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[22]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[23]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[23]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[26]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[26]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[27]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[27]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[28]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[28]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[30]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[30]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/9/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[31]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[31]
Invalid template for '
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3452394931
**PR job** `#5` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/display/redirect
**Test results:**
- PASSED: 3541
- FAILED: 124
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[13]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[13]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[19]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[19]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[22]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[22]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[23]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[23]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[26]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[26]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[27]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[27]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[28]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[28]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[30]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[30]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/5/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[31]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[31]
Invalid template for '
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
martinweiler commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2466423033
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/lifecycle/DefaultUserTaskLifeCycles.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.kie.kogito.usertask.impl.lifecycle;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle;
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycles;
+
+public class DefaultUserTaskLifeCycles implements UserTaskLifeCycles {
+
+private final Map userTaskLifeCycleRegistry =
new HashMap<>();
+private String defaultUserTaskLifeCycleId;
+
+public DefaultUserTaskLifeCycles() {
+this.defaultUserTaskLifeCycleId = "default";
+registerUserTaskLifeCycles();
+
+}
+
+public DefaultUserTaskLifeCycles(String defaultUserTaskLifeCycleId,
Iterable userTaskLifeCycle) {
+this.defaultUserTaskLifeCycleId = defaultUserTaskLifeCycleId;
+registerCustomUserTaskLifeCycleIfAny(userTaskLifeCycle);
+registerUserTaskLifeCycles();
+}
+
+private void registerUserTaskLifeCycles() {
+registerUserTaskLifeCycle("default", new DefaultUserTaskLifeCycle());
+registerUserTaskLifeCycle("ws-human-task", new WsHumanTaskLifeCycle());
+}
+
+private void
registerCustomUserTaskLifeCycleIfAny(Iterable
userTaskLifeCycle) {
+if (userTaskLifeCycle.iterator().hasNext()) {
Review Comment:
Since we are only registering the first custom implementation, we should
throw an error here if there are additional lifecycle implementations present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
martinweiler commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2466397652
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/lifecycle/DefaultUserTaskLifeCycles.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.kie.kogito.usertask.impl.lifecycle;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle;
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycles;
+
+public class DefaultUserTaskLifeCycles implements UserTaskLifeCycles {
+
+private final Map userTaskLifeCycleRegistry =
new HashMap<>();
+private String defaultUserTaskLifeCycleId;
+
+public DefaultUserTaskLifeCycles() {
+this.defaultUserTaskLifeCycleId = "default";
+registerUserTaskLifeCycles();
+
+}
+
+public DefaultUserTaskLifeCycles(String defaultUserTaskLifeCycleId,
Iterable userTaskLifeCycle) {
+this.defaultUserTaskLifeCycleId = defaultUserTaskLifeCycleId;
+registerCustomUserTaskLifeCycleIfAny(userTaskLifeCycle);
+registerUserTaskLifeCycles();
Review Comment:
Please add some logging here to make debugging at runtime easier, eg:
```
logger.info("Registered UserTaskLifeCycles {} with default {}",
userTaskLifeCycleRegistry, this.defaultUserTaskLifeCycleId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
josedee commented on code in PR #4105: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2465641157 ## kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/usertask/UserTaskLifeCyclesQuarkusTemplate.java: ## @@ -0,0 +1,36 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import org.eclipse.microprofile.config.inject.ConfigProperty; +import org.kie.kogito.usertask.impl.lifecycle.DefaultUserTaskLifeCycles; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle; + +import jakarta.enterprise.inject.Instance; + [email protected] +public class UserTaskLifeCycles extends DefaultUserTaskLifeCycles { + [email protected] +public UserTaskLifeCycles( +@ConfigProperty(name = "kogito.usertasks.lifecycle", defaultValue = "default") String configuredUserTaskLifeCycleId, Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
josedee commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2465639955
##
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/usertask/UserTaskCodegen.java:
##
@@ -168,6 +175,15 @@ protected Collection internalGenerate() {
return generatedFiles;
}
+private GeneratedFile generateLifeCycles() {
+String packageName = context().getPackageName();
+CompilationUnit compilationUnit =
lifeCyclesGenerator.compilationUnitOrThrow("No lifecycle template found for
user tasks");
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3443981259
**PR job** `#4` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/display/redirect
**Test results:**
- PASSED: 3541
- FAILED: 124
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[13]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[13]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[19]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[19]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[22]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[22]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[23]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[23]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[26]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[26]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[27]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[27]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[28]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[28]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[30]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[30]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/4/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[31]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[31]
Invalid template for '
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
kie-ci3 commented on PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#issuecomment-3442914638
**PR job** `#3` was: **UNSTABLE**
Possible explanation: This should be test failures
Reproducer
build-chain build full_downstream -f
'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml'
-o 'bc' -p apache/incubator-kie-kogito-runtimes -u
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105
--skipParallelCheckout
NOTE: To install the build-chain tool, please refer to
https://github.com/kiegroup/github-action-build-chain#local-execution
Please look here:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/display/redirect
**Test results:**
- PASSED: 2450
- FAILED: 122
Those are the test failures:
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[13]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[13]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[19]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[19]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[22]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[22]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[23]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[23]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[26]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[26]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[27]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[27]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[28]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[28]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[30]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[30]
Invalid template for 'usertasks', file
'/class-templates/usertask/UserTaskLifeCyclesJavaTemplate.java': No lifecycle
template found for user tasks
https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-4105/3/testReport/org.kie.kogito.codegen.process/ProcessGenerationIT/testProcessGeneration(String)[31]/">org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[31]
Invalid template for '
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
josedee commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2460226978
##
api/kogito-api/src/main/java/org/kie/kogito/usertask/lifecycle/UserTaskLifeCycles.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.kie.kogito.usertask.lifecycle;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class UserTaskLifeCycles {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459953570
##
api/kogito-api/src/main/java/org/kie/kogito/usertask/lifecycle/UserTaskLifeCycles.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.kie.kogito.usertask.lifecycle;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class UserTaskLifeCycles {
Review Comment:
I'd prefer this to be an itnerface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459948647 ## kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/usertask/UserTaskLifeCyclesSpringTemplate.java: ## @@ -0,0 +1,37 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import java.util.List; + +import org.kie.kogito.usertask.impl.lifecycle.DefaultUserTaskLifeCycles; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle; +import org.springframework.beans.factory.annotation.Value; + [email protected] +public class UserTaskLifeCycles extends DefaultUserTaskLifeCycles { + [email protected] +public UserTaskLifeCycles( +@Value("${kogito.usertasks.lifecycle:default}") String configuredUserTaskLifeCycle, Review Comment: Same her -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459946697 ## kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/usertask/UserTaskLifeCyclesQuarkusTemplate.java: ## @@ -0,0 +1,36 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import org.eclipse.microprofile.config.inject.ConfigProperty; +import org.kie.kogito.usertask.impl.lifecycle.DefaultUserTaskLifeCycles; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle; + +import jakarta.enterprise.inject.Instance; + [email protected] +public class UserTaskLifeCycles extends DefaultUserTaskLifeCycles { + [email protected] +public UserTaskLifeCycles( +@ConfigProperty(name = "kogito.usertasks.lifecycle", defaultValue = "default") String configuredUserTaskLifeCycleId, +Instance userTaskLifeCycle) { +super(configuredUserTaskLifeCycleId, userTaskLifeCycle); Review Comment: pass the lifecycle name here, not in the constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459946697 ## kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/usertask/UserTaskLifeCyclesQuarkusTemplate.java: ## @@ -0,0 +1,36 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import org.eclipse.microprofile.config.inject.ConfigProperty; +import org.kie.kogito.usertask.impl.lifecycle.DefaultUserTaskLifeCycles; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle; + +import jakarta.enterprise.inject.Instance; + [email protected] +public class UserTaskLifeCycles extends DefaultUserTaskLifeCycles { + [email protected] +public UserTaskLifeCycles( +@ConfigProperty(name = "kogito.usertasks.lifecycle", defaultValue = "default") String configuredUserTaskLifeCycleId, +Instance userTaskLifeCycle) { +super(configuredUserTaskLifeCycleId, userTaskLifeCycle); Review Comment: pass the string here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459945771 ## kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/usertask/UserTaskLifeCyclesQuarkusTemplate.java: ## @@ -0,0 +1,36 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import org.eclipse.microprofile.config.inject.ConfigProperty; +import org.kie.kogito.usertask.impl.lifecycle.DefaultUserTaskLifeCycles; +import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle; + +import jakarta.enterprise.inject.Instance; + [email protected] +public class UserTaskLifeCycles extends DefaultUserTaskLifeCycles { + [email protected] +public UserTaskLifeCycles( +@ConfigProperty(name = "kogito.usertasks.lifecycle", defaultValue = "default") String configuredUserTaskLifeCycleId, Review Comment: I would pass the lifecylce name directly from the config ("default"/"ws-...") from codegen to the template instead of loading the config property. Config properties can be overwritten in execution via ENVS, I think that this should be static value and should be set during cogeden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459929437
##
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/usertask/UserTaskCodegen.java:
##
@@ -168,6 +175,15 @@ protected Collection internalGenerate() {
return generatedFiles;
}
+private GeneratedFile generateLifeCycles() {
+String packageName = context().getPackageName();
+CompilationUnit compilationUnit =
lifeCyclesGenerator.compilationUnitOrThrow("No lifecycle template found for
user tasks");
Review Comment:
We need to validate the lifecycle property here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2459920689
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/lifecycle/UserTaskLifeCycleRegistry.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.usertask.impl.lifecycle;
+
+import java.util.Map;
+
+import org.kie.kogito.usertask.lifecycle.UserTaskLifeCycle;
+
+public class UserTaskLifeCycleRegistry {
Review Comment:
This can be removed IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2453381643
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/lifecycle/DefaultUserTaskLifeCycle.java:
##
@@ -153,6 +153,7 @@ public Optional
reassign(UserTaskInstance userTaskInsta
}
public Optional activate(UserTaskInstance
userTaskInstance, UserTaskTransitionToken token, IdentityProvider
identityProvider) {
+userTaskInstance.getMetadata().put("Lifecycle", "default");
Review Comment:
ok! we must make sure we put the right data here, maybe getting it from the
config somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2453377731
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/UserTaskServiceImpl.java:
##
@@ -98,6 +105,11 @@ public List
allowedTransitions(String taskId, IdentityPr
}
UserTaskInstance ut = userTaskInstance.get();
UserTaskLifeCycle userTaskLifeCycle =
application.config().get(UserTaskConfig.class).userTaskLifeCycle();
+if
(UserTaskLifeCycleRegistry.get(String.valueOf(ut.getMetadata().get("Lifecycle")))
instanceof WsHumanTaskLifeCycle wsHumanTaskLifeCycle
Review Comment:
There must be another way of doing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
pefernan commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2453373109
##
jbpm/jbpm-usertask/src/main/java/org/kie/kogito/usertask/impl/DefaultUserTaskInstance.java:
##
@@ -262,6 +265,11 @@ public void initialize(Map data,
IdentityProvider identity) {
@Override
public void transition(String transitionId, Map data,
IdentityProvider identity) {
+if
(UserTaskLifeCycleRegistry.get(String.valueOf(this.metadata.get("Lifecycle")))
instanceof WsHumanTaskLifeCycle wsHumanTaskLifeCycle
+&& this.userTaskLifeCycle instanceof DefaultUserTaskLifeCycle)
{
+LOG.debug("Usertask Lifecycle with which the task started is not
compatible with the current one. Switching lifecycles");
+this.userTaskLifeCycle = wsHumanTaskLifeCycle;
Review Comment:
@josedee lifecycle is set when connecting the UserTaskInstance, look at
UserTasksTemplate, that's the place where it should be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] WIP [incubator-kie-issues#2154] Add support for WS-Human Task Lifecycle [incubator-kie-kogito-runtimes]
martinweiler commented on code in PR #4105:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4105#discussion_r2452989290
##
kogito-codegen-modules/kogito-codegen-processes/src/main/resources/class-templates/usertask/UserTaskConfigQuarkusTemplate.java:
##
@@ -47,14 +48,16 @@ public UserTaskConfig(
Instance identityProvider,
Instance userTaskLifeCycle,
Instance
userTaskAssignmentStrategyConfigs,
-Instance userTaskInstances) {
+Instance userTaskInstances,
+@ConfigProperty(name = "kogito.usertasks.lifecycle") String
configuredUserTaskLifeCycle) {
Review Comment:
We should default to `default` in case this config property is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
