Re: [PR] kie-issues#1636: DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
kbowers-ibm merged PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
Kusuma04-dev commented on code in PR #2846:
URL:
https://github.com/apache/incubator-kie-tools/pull/2846#discussion_r1913097472
##
packages/dmn-editor/src/includedModels/IncludedModels.tsx:
##
@@ -611,15 +611,15 @@ function IncludedModelCard({
position={PopoverPosition.bottom}
shouldOpen={() => setRemovePopoverOpen(true)}
>
-
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
jomarko commented on code in PR #2846:
URL:
https://github.com/apache/incubator-kie-tools/pull/2846#discussion_r1912998874
##
packages/dmn-editor/src/includedModels/IncludedModels.css:
##
@@ -20,3 +20,9 @@
.kie-dmn-editor--selected-model-to-include-error {
color: var(--pf-global--danger-color--100);
}
+.kebabtoggle-wrapper {
+ color: grey;
+}
+.kebabtoggle-wrapper:hover {
+ color: black;
+}
Review Comment:
```suggestion
.kie-dmn-editor--model-card-kebabtoggle-wrapper {
color: grey;
}
.kie-dmn-editor--model-card-kebabtoggle-wrapper:hover {
color: black;
}
```
##
packages/dmn-editor/src/includedModels/IncludedModels.tsx:
##
@@ -611,15 +611,15 @@ function IncludedModelCard({
position={PopoverPosition.bottom}
shouldOpen={() => setRemovePopoverOpen(true)}
>
-
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
Kusuma04-dev commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2586214421 > @Kusuma04-dev As @yesamer pointed it out, previously, the buttom was gray (not black) and changed color on hover. I don't think it's a problem to remove the hover if we don't have another solution for it. > > previous-kebab.mp4 Hi Luiz, i have added css styles to make it look like before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
ljmotta commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2583637529 @Kusuma04-dev As @yesamer pointed it out, previously, the buttom was gray (not black) and changed color on hover. I don't think it's a problem to remove the hover if we don't have another solution for it. https://github.com/user-attachments/assets/2f334b38-87fb-4e1f-89d9-6c3a79786d3d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
Kusuma04-dev commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2582414919 > Thank you @Kusuma04-dev . I suspect that `Button` element was added just for styling purposes. If you notice, in the UI the Kebab Element has a different style with your changes. > > Said so, your changes are correct from my point of view. if my above suspect is true, you can even totally remove that element, and not replace it with a div, unless we need that to stop the event propagation to the Kebab element. (to be checked) > > My only doubt is about the element's style. Should we preserve it? Hi Yeser, Yeah i have kept div tag to stop event propogation ,also i don't see difference in the style ,as i have attached one ss with full screen and another with half screen , it might be looking different . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
jomarko commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2582204480 I postpone my review until there is an answer for @yesamer comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
Kusuma04-dev commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2582107962 > @Kusuma04-dev thank you for your PR! Can you please share a screenshot of the change? I mean, what is the impact of changing that Button to a div? Before fix: There is a console error which is telling button inside button shouldn't be there . After fix: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#1636:DMN Editor throw an error opening Included Models tab [incubator-kie-tools]
yesamer commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2582028800 @Kusuma04-dev thank you for your PR! Can you please share a screenshot of the change? I mean, what is the impact of changing that Button to a div? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
