Re: [PR] kie-issues#1906: New version of date and time conversion function on FEEL [incubator-kie-tools]

2025-07-14 Thread via GitHub 


tiagobento merged PR #3192:
URL: https://github.com/apache/incubator-kie-tools/pull/3192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] kie-issues#1906: New version of date and time conversion function on FEEL [incubator-kie-tools]

2025-07-10 Thread via GitHub 


yesamer commented on code in PR #3192:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3192#discussion_r2196893764


##
packages/feel-input-component/src/FeelConfigs.ts:
##
@@ -429,6 +429,20 @@ export const feelDefaultSuggestions = (): 
Monaco.languages.CompletionItem[] => {
   'date and time( "2012-12-24T23:59:00" ) = date and time( date( 
"2012-12-24" ), time ( “23:59:00" ) )',
 ],
   },
+  {
+label: "date and time(date, time, timezone)",
+insertText: "date and time($1, $2, $3)",
+description: "Creates a date time from the given `date`, `time` and 
timezone",
+parameters: [
+  ["date", `\`date\` or \`date and time\``],
+  ["time", `\`time\``],
+  ["timezone", `\`string\``],
+],
+examples: [
+  'date and time( date("2024-12-24"), time("23:59:00"), "Z" ) = date 
and time( "2024-12-24T23:59:00Z" )',

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] kie-issues#1906: New version of date and time conversion function on FEEL [incubator-kie-tools]

2025-07-10 Thread via GitHub 


yesamer commented on code in PR #3192:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3192#discussion_r2196889684


##
packages/feel-input-component/src/FeelConfigs.ts:
##
@@ -429,6 +429,20 @@ export const feelDefaultSuggestions = (): 
Monaco.languages.CompletionItem[] => {
   'date and time( "2012-12-24T23:59:00" ) = date and time( date( 
"2012-12-24" ), time ( “23:59:00" ) )',
 ],
   },
+  {
+label: "date and time(date, time, timezone)",
+insertText: "date and time($1, $2, $3)",
+description: "Creates a date time from the given `date`, `time` and 
timezone",
+parameters: [
+  ["date", `\`date\` or \`date and time\``],
+  ["time", `\`time\``],
+  ["timezone", `\`string\``],
+],
+examples: [
+  'date and time( date("2024-12-24"), time("23:59:00"), "Z" ) = date 
and time( "2024-12-24T23:59:00Z" )',

Review Comment:
   @jomarko IINW, "Z" is correct while "z" is not, according to ISO 8601 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]