Re: [PR] kie-issues#2220: BPMN Editor: Interface tags configured in a service task are missing from the generated XML [incubator-kie-tools]
thiagoelg merged PR #3445: URL: https://github.com/apache/incubator-kie-tools/pull/3445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2220: BPMN Editor: Interface tags configured in a service task are missing from the generated XML [incubator-kie-tools]
thiagoelg commented on PR #3445: URL: https://github.com/apache/incubator-kie-tools/pull/3445#issuecomment-4024836253 Build failures are likely related to the `--if-present` flag. Investigating... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2220: BPMN Editor: Interface tags configured in a service task are missing from the generated XML [incubator-kie-tools]
kbowers-ibm commented on PR #3445: URL: https://github.com/apache/incubator-kie-tools/pull/3445#issuecomment-3944369330 Hi @jomarko, I looked into how the classic BPMN Editor does this, and it consistently sets both outMessageRef and inMessageRef. I’ve updated our side to always add the outMessageRef to match that behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2220: BPMN Editor: Interface tags configured in a service task are missing from the generated XML [incubator-kie-tools]
jomarko commented on PR #3445: URL: https://github.com/apache/incubator-kie-tools/pull/3445#issuecomment-3933895802 Thank you @kbowers-ibm now I understand better the relationship of `inMessgaeRef` and `outMessageRef` with the xml. As you cited the specification, where `outMessageRef` has `[0..1]` occurences, it is clear, it should be in the produced xml, only if the invoked java code (java method) has a non void return type. My concern is, the new BPMN Editor never produces such xml. In the attached screenshot from my previous review. I set and output assignment but the `outMessageRef` was missing. Or do we have a code, that is checking real method signature of set interface and method? I mean when I configure Service task to call interface `com.my.example.CustomClass` and operation `handleThisProblem`, do we have a code that try to resolve that method `handleThisProblem` and check if it has non `void` return type? In my screenshot I configured `service` and `operation` to some non existing values, that it would be fair BPMN Editor does not produce `outMessageRef` as it really did not have chance to check it. However as we use BAMOE Tooling also out of java availability - BAMOE Canvas, I am not sure if we perform such complex check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#2220: BPMN Editor: Interface tags configured in a service task are missing from the generated XML [incubator-kie-tools]
kbowers-ibm commented on PR #3445: URL: https://github.com/apache/incubator-kie-tools/pull/3445#issuecomment-3927860908 Thanks @jomarko and @ljmotta for the feedback! I've fixed the problem of the interface persisting when morphing to a custom task, nice catch! Regarding the ID issue, I'm no bpmn expert, but afaik there's no issue there. For reference this is what happens in the old bpmn editor: ``` _59E44166-295D-413F-A8F4-28808A278CDF_InMessage _59E44166-295D-413F-A8F4-28808A278CDF_OutMessage ``` As you can see they all have the exact same id, as the serviceTask and then append on something at the end. My understanding is that id's are essentially just random strings and are not defined in the bpmn spec, e.g. this is what the operation should consist of: https://github.com/user-attachments/assets/7c5c5e5a-cf13-43fc-b1ed-205b689000d9"; /> So it has to have the inMessageRef and the outMessageRef is optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
