Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
RishiRajAnand merged PR #3319: URL: https://github.com/apache/incubator-kie-tools/pull/3319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
RishiRajAnand commented on PR #3319:
URL:
https://github.com/apache/incubator-kie-tools/pull/3319#issuecomment-3438413058
> @RishiRajAnand Thanks. You'll need to update all the places that are using
this parameter too. Like `buildImage({ ...args, arch: ["amd64"] },
imageFullNames);` and others.
okay, i added it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
tiagobento commented on PR #3319:
URL:
https://github.com/apache/incubator-kie-tools/pull/3319#issuecomment-3438315207
@RishiRajAnand Thanks. You'll need to update all the places that are using
this parameter too. Like
`buildImage({ ...args, arch: ["amd64"] }, imageFullNames);` and others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
RishiRajAnand commented on code in PR #3319: URL: https://github.com/apache/incubator-kie-tools/pull/3319#discussion_r2456353463 ## packages/image-builder/README.md: ## @@ -18,7 +18,7 @@ Options: -f, --containerfile Path to the Containerfile/Dockerfile [string] [default: "Containerfile"] -c, --context Path to the build context [string] [default: "./"] --build-arg Build args for the builder in the format '=', where is a string (Can be used multiple times) [array] [default: []] - --archThe target build architecture. If not provided will default to the native architecture [string] [choices: "amd64", "arm64", "native"] [default: "native"] + --archThe target build architectures. If not provided will default to the native architecture [array] Review Comment: I have added it as part of description and also default value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
RishiRajAnand commented on PR #3319: URL: https://github.com/apache/incubator-kie-tools/pull/3319#issuecomment-3438289779 > Why not change `arch` to be in the format `linux/amd64` instead of programmatically adding `linux/` to the configured values? That would be more flexible and make the code less complicated I think. I added it that way so that it doesn't affect current behavior. I have now changed it to accept OS/ARCH format for better flexibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
tiagobento commented on code in PR #3319: URL: https://github.com/apache/incubator-kie-tools/pull/3319#discussion_r2456030392 ## packages/image-builder/README.md: ## @@ -18,7 +18,7 @@ Options: -f, --containerfile Path to the Containerfile/Dockerfile [string] [default: "Containerfile"] -c, --context Path to the build context [string] [default: "./"] --build-arg Build args for the builder in the format '=', where is a string (Can be used multiple times) [array] [default: []] - --archThe target build architecture. If not provided will default to the native architecture [string] [choices: "amd64", "arm64", "native"] [default: "native"] + --archThe target build architectures. If not provided will default to the native architecture [array] Review Comment: Please add example values. Also, since this is an optional parameter, what is the default value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-issues#3318: Enable kie-tools-image-builder to support multi platform builds [incubator-kie-tools]
tiagobento commented on PR #3319: URL: https://github.com/apache/incubator-kie-tools/pull/3319#issuecomment-3438061778 Why not change `arch` to be in the format `linux/amd64` instead of programmatically adding `linux/` to the configured values? That would be more flexible and make the code less complicated I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
