Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
wmedvede commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2388611161
##
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexBuildConfig.java:
##
@@ -18,17 +18,22 @@
*/
package org.kie.kogito.index.addon.config;
-import io.quarkus.runtime.annotations.ConfigItem;
+import java.util.Optional;
+
import io.quarkus.runtime.annotations.ConfigPhase;
import io.quarkus.runtime.annotations.ConfigRoot;
+import io.smallrye.config.ConfigMapping;
-@ConfigRoot(name = "kogito.data-index", phase = ConfigPhase.BUILD_TIME)
-public class DataIndexBuildConfig {
+@ConfigMapping(prefix = "kogito.data-index.build")
Review Comment:
@pefernan @gmunozfe @fjtirado
Consiering that the new config mechanism is more strict, and to avoid mixing
build and runtime properties that can produce validation errors, we add the
build properties in a specific prefix "kogito.data-idex.build".
btw: currently the only build time property we have is
kogito.data-index.build.blocking and is not exposed, nor used outside the
project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
wmedvede commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2391120182
##
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexRuntimeConfig.java:
##
@@ -20,17 +20,50 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigItem;
import io.quarkus.runtime.annotations.ConfigPhase;
import io.quarkus.runtime.annotations.ConfigRoot;
+import io.smallrye.config.ConfigMapping;
+import io.smallrye.config.WithDefault;
+import io.smallrye.config.WithName;
-@ConfigRoot(prefix = "kogito", name = "data-index", phase =
ConfigPhase.RUN_TIME)
-public class DataIndexRuntimeConfig {
+@ConfigMapping(prefix = "kogito.data-index")
+@ConfigRoot(phase = ConfigPhase.BUILD_TIME)
Review Comment:
good catch, my fault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
fjtirado commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2390837981
##
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexRuntimeConfig.java:
##
@@ -20,17 +20,50 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigItem;
import io.quarkus.runtime.annotations.ConfigPhase;
import io.quarkus.runtime.annotations.ConfigRoot;
+import io.smallrye.config.ConfigMapping;
+import io.smallrye.config.WithDefault;
+import io.smallrye.config.WithName;
-@ConfigRoot(prefix = "kogito", name = "data-index", phase =
ConfigPhase.RUN_TIME)
-public class DataIndexRuntimeConfig {
+@ConfigMapping(prefix = "kogito.data-index")
+@ConfigRoot(phase = ConfigPhase.BUILD_TIME)
Review Comment:
Why configRoot is build time for DataIndexRuntimeConfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
pefernan commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2394542796
##
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexConfigBuilderCustomizer.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.index.addon.config;
+
+import io.smallrye.config.SmallRyeConfigBuilder;
+import io.smallrye.config.SmallRyeConfigBuilderCustomizer;
+
+public class DataIndexConfigBuilderCustomizer implements
SmallRyeConfigBuilderCustomizer {
+
+@Override
+public void configBuilder(SmallRyeConfigBuilder builder) {
+// Align with quarkus to avoid the validation issue when we have
runtime and build-time configs in the same
+// namespace.
https://github.com/quarkusio/quarkus/blob/265a4328f8195d9c2ef4fbf32f41eb23253479b7/core/runtime/src/main/java/io/quarkus/runtime/configuration/QuarkusConfigBuilderCustomizer.java#L113
+builder.withMappingIgnore("kogito.data-index.**");
Review Comment:
good catch @wmedvede this would also help fixing the issue I found in
runtimes with some configs that don't have any config group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
wmedvede commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2397526845
##
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexConfigBuilderCustomizer.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.index.addon.config;
+
+import io.smallrye.config.SmallRyeConfigBuilder;
+import io.smallrye.config.SmallRyeConfigBuilderCustomizer;
+
+public class DataIndexConfigBuilderCustomizer implements
SmallRyeConfigBuilderCustomizer {
+
+@Override
+public void configBuilder(SmallRyeConfigBuilder builder) {
+// Align with quarkus to avoid the validation issue when we have
runtime and build-time configs in the same
+// namespace.
https://github.com/quarkusio/quarkus/blob/265a4328f8195d9c2ef4fbf32f41eb23253479b7/core/runtime/src/main/java/io/quarkus/runtime/configuration/QuarkusConfigBuilderCustomizer.java#L113
Review Comment:
I think the permalink is ok, since currently we align with the solution in
Quarkus 3.20.x series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
gmunozfe commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2397462250
##
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexConfigBuilderCustomizer.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.kie.kogito.index.addon.config;
+
+import io.smallrye.config.SmallRyeConfigBuilder;
+import io.smallrye.config.SmallRyeConfigBuilderCustomizer;
+
+public class DataIndexConfigBuilderCustomizer implements
SmallRyeConfigBuilderCustomizer {
+
+@Override
+public void configBuilder(SmallRyeConfigBuilder builder) {
+// Align with quarkus to avoid the validation issue when we have
runtime and build-time configs in the same
+// namespace.
https://github.com/quarkusio/quarkus/blob/265a4328f8195d9c2ef4fbf32f41eb23253479b7/core/runtime/src/main/java/io/quarkus/runtime/configuration/QuarkusConfigBuilderCustomizer.java#L113
Review Comment:
The link reference is fine, but could it be to the main branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] kie-issues-2120: Adapt the configurations in Kogito Apps Quarkus extensions to use the new Quarkus 3.20.1 mechanism [incubator-kie-kogito-apps]
wmedvede merged PR #2271: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
