Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
ricardozanini merged PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
fantonangeli commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3596701367 @domhanak can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
fantonangeli commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3586423282 > How hard would it be to allow multiple origins? (for example, when I want to use the CORS Proxy service for multiple KIE Sandbox instances). @thiagoelg and @tiagobento I agree with your points and removed the MODE parameter (see https://github.com/apache/incubator-kie-tools/pull/3353#issuecomment-3573176511 ), which can lead to untested scenario, and add the multiple `Allowed Origins` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
thiagoelg commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3577171099 How hard would it be to allow multiple origins? (for example, when I want to use the CORS Proxy service for multiple KIE Sandbox instances). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
fantonangeli commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3571333272 @thiagoelg because these 2 PRs (especially https://github.com/apache/incubator-kie-tools/pull/3353 ) are security fixes, I would ask if we prioritise them and then test yours for the `Accept-encoding: identity` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
thiagoelg commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-357196 Hi @fantonangeli! Sorry it took me this long. I'll review and test both PRs this week. Thank you for fixing these issues! I also have an incoming PR that should fix the CORS Proxy when handling compressed/encoded requests. We shouldn't need to use `Accept-encoding: identity` anymore 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
fantonangeli commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3551437925 @tiagobento @domhanak can you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] kie-tools#3308: [cors-proxy] CORS code-scanning issues [incubator-kie-tools]
fantonangeli commented on PR #3327: URL: https://github.com/apache/incubator-kie-tools/pull/3327#issuecomment-3517827452 GH Action not running on MacOs: "This is a scheduled macos-13 brownout" :sob: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
