Re: [PR] CMake: added tm4c129e-launchpad, launchxl-cc1312r1, lm4f120-launchpad, lm3s8962-ek and ekk-lm3s9b96 boards [nuttx]
xiaoxiang781216 merged PR #16314: URL: https://github.com/apache/nuttx/pull/16314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake: added tm4c129e-launchpad, launchxl-cc1312r1, lm4f120-launchpad, lm3s8962-ek and ekk-lm3s9b96 boards [nuttx]
nuttxpr commented on PR #16314: URL: https://github.com/apache/nuttx/pull/16314#issuecomment-2850845509 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. The summary is clear, describing the change and the affected boards. The impact assessment is thorough, addressing all the required points. The testing section demonstrates successful builds for each of the added boards using CMake. Including the build commands and output is helpful for reviewers. One minor suggestion: While you say "locally," it would be beneficial to specify the host OS and compiler version used for testing, per the requirements. For example: "Build Host: Windows 11, GCC 13.2.1" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] CMake: added tm4c129e-launchpad, launchxl-cc1312r1, lm4f120-launchpad, lm3s8962-ek and ekk-lm3s9b96 boards [nuttx]
simbit18 opened a new pull request, #16314:
URL: https://github.com/apache/nuttx/pull/16314
## Summary
CMake added following boards:
tm4c129e-launchpad
launchxl-cc13r1
lm4f120-launchpad
lm3s8962-ek
ekk-lm3s9b96
## Impact
Impact on user: This PR adds m4c129e-launchpad, launchxl-cc1312r1,
lm4f120-launchpad, lm3s8962-ek and ekk-lm3s9b96 boards with CMake build
Impact on build: NO
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
## Testing
Locally
**tm4c129e-launchpad**
```
PS D:\nuttx_pr\nuttx> cmake -B build -DBOARD_CONFIG=tm4c129e-launchpad:nsh
-GNinja
-- Initializing NuttX
-- ENV{PROCESSOR_ARCHITECTURE} = AMD64
Select HOST_WINDOWS=y
Select WINDOWS_NATIVE=y
-- CMake: 3.31.5
-- Ninja: 1.12.1
-- Board: tm4c129e-launchpad
-- Config: nsh
-- Appdir: D:/nuttx_pr/apps
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- The ASM compiler identification is GNU
-- Found assembler:
D:/nuttx_pr/tools/gcc-arm-none-eabi/bin/arm-none-eabi-gcc.exe
-- Configuring done (8.8s)
-- Generating done (2.0s)
-- Build files have been written to: D:/nuttx_pr/nuttx/build
PS D:\nuttx_pr\nuttx> cmake --build build
[1442/1443] Linking C executable nuttx
Memory region Used Size Region Size %age Used
flash: 135632 B 1 MB 12.93%
sram: 41340 B 256 KB 15.77%
[1443/1443] Generating nuttx.bin
```
**lm4f120-launchpad**
```
PS D:\nuttx_pr\nuttx> cmake -B build -DBOARD_CONFIG=lm4f120-launchpad:nsh
-GNinja
-- Initializing NuttX
-- ENV{PROCESSOR_ARCHITECTURE} = AMD64
Select HOST_WINDOWS=y
Select WINDOWS_NATIVE=y
-- CMake: 3.31.5
-- Ninja: 1.12.1
-- Board: lm4f120-launchpad
-- Config: nsh
-- Appdir: D:/nuttx_pr/apps
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- The ASM compiler identification is GNU
-- Found assembler:
D:/nuttx_pr/tools/gcc-arm-none-eabi/bin/arm-none-eabi-gcc.exe
-- Configuring done (7.7s)
-- Generating done (1.9s)
-- Build files have been written to: D:/nuttx_pr/nuttx/build
PS D:\nuttx_pr\nuttx> cmake --build build
[1072/1073] Linking C executable nuttx
Memory region Used Size Region Size %age Used
flash: 70476 B 256 KB 26.88%
sram:6480 B32 KB 19.78%
[1073/1073] Generating nuttx.bin
```
**lm3s8962-ek**
```
PS D:\nuttx_pr\nuttx> cmake -B build -DBOARD_CONFIG=lm3s8962-ek:nsh -GNinja
-- Initializing NuttX
-- ENV{PROCESSOR_ARCHITECTURE} = AMD64
Select HOST_WINDOWS=y
Select WINDOWS_NATIVE=y
-- CMake: 3.31.5
-- Ninja: 1.12.1
-- Board: lm3s8962-ek
-- Config: nsh
-- Appdir: D:/nuttx_pr/apps
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- The ASM compiler identification is GNU
-- Found assembler:
D:/nuttx_pr/tools/gcc-arm-none-eabi/bin/arm-none-eabi-gcc.exe
-- Configuring done (7.9s)
-- Generating done (2.0s)
-- Build files have been written to: D:/nuttx_pr/nuttx/build
PS D:\nuttx_pr\nuttx> cmake --build build
[1305/1306] Linking C executable nuttx
Memory region Used Size Region Size %age Used
flash: 127256 B 256 KB 48.54%
sram: 17152 B64 KB 26.17%
[1306/1306] Generating nuttx.bin
```
**launchxl-cc1312r1**
```
PS D:\nuttx_pr\nuttx> cmake -B build -DBOARD_CONFIG=launchxl-cc1312r1:nsh
-GNinja
-- Initializing NuttX
-- ENV{PROCESSOR_ARCHITECTURE} = AMD64
Select HOST_WINDOWS=y
Select WINDOWS_NATIVE=y
-- CMake: 3.31.5
-- Ninja: 1.12.1
-- Board: launchxl-cc1312r1
-- Config: nsh
-- Appdir: D:/nuttx_pr/apps
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- The ASM compiler identification is GNU
-- Found assembler:
D:/nuttx_pr/tools/gcc-arm-none-eabi/bin/arm-none-eabi-gcc.exe
-- Configuring done (8.1s)
-- Generating done (1.9s)
-- Build files have been written to: D:/nuttx_pr/nuttx/build
PS D:\nuttx_pr\nuttx> cmake --build build
[1103/1104] Linking C executable nuttx
Memory region Used Size Region Size %age Used
flash: 86472 B 352 KB 23.99%
sram:7600 B80 KB 9.28%
[1104/1104] Generating nuttx.hex
```
**ekk-lm3s9b96**
```
PS D:\nuttx_pr\nuttx> cmake -B build -DBOARD_CONFIG=ekk-lm3s9b96:nsh -GNinja
-- Initializing NuttX
-- ENV{PROCESSOR_ARCHITECTURE} = AMD64
Select HOST_WINDOWS=y
Select WINDOWS_NATIVE=y
-- CMake: 3.
