Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
acassis merged PR #16408: URL: https://github.com/apache/nuttx/pull/16408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
xiaoxiang781216 commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892572178 @ldube please fix the ci error: https://github.com/apache/nuttx/actions/runs/15121852423/job/42505917973?pr=16408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
ldube commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892114778 You are starting to sound like AI :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
acassis commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892077210 > @acassis Yes, I agree those tasks are important, but you can't demand extra from people who are contributing their time freely. I just wanted to clarify that my suggestion about using reStructuredText was not meant as criticism of your work at all. My intent was to help align with the broader NuttX documentation goals, since Apache projects often benefit from a consistent format, especially when integrating with Sphinx and generating better web-based docs. If the goal of your PR is simply to improve the content without changing format, that's totally fine, it’s still a valuable contribution. I’ll be happy to revisit or propose a separate conversion later, as a follow-up. Please don’t take my suggestion as a demand or as undervaluing your contribution. I really appreciate your time and care in improving NuttX! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
ldube commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2892036289 @acassis Yes, I agree those tasks are important, but you can't demand extra from people who are contributing their time freely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
acassis commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2891523182 > @acassis I see FOSS as an opportunity to work on things that interest me, primarily when I'm motivated. I doubt I'll have time for extra things I didn't plan. I'm starting to think keeping my changes in my own branch might be a good enough compromise. Hi @ldube I'm sorry to hear that. Since we are often discussing about how we can improve NuttX quality, something very important is to have good and proper documentation. NuttX has a lot of feature, but few people knows how to use it. So everytime that a new feature or a new board profile is added it needs to include at least some basic documentation to help newcomers. This situation is really sad for me, for you and for the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
ldube commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2891456387 @acassis I see FOSS as an opportunity to work on things that interest me, primarily when I'm motivated. I doubt I'll have time for extra things I didn't plan. I'm starting to think keeping my changes in my own branch might be a good enough compromise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
ldube closed pull request #16408: boards/sama5d3-xplained: Add knsh configuration URL: https://github.com/apache/nuttx/pull/16408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
acassis commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2890400719 > @acassis Is this a requirement? Hi @ldube It is not a requirement, but it is an act of good faith, only then will we finish converting all README.txt to the new standard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
ldube commented on PR #16408: URL: https://github.com/apache/nuttx/pull/16408#issuecomment-2889303600 @acassis Is this is a requirement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] boards/sama5d3-xplained: Add knsh configuration [nuttx]
ldube opened a new pull request, #16408: URL: https://github.com/apache/nuttx/pull/16408 ## Summary Add knsh defconfig ## Impact Only affects users of sama5d3-xplained ## Testing (using Linux host) cd nuttx make distclean; ./tools/configure.sh -l sama5d3-xplained/knsh make -j3 && make export pushd ../apps tools/mkimport.sh -z -x ../nuttx/nuttx-export-*.tar.gz make import tools/mkromfsimg.sh mv boot_romfsimg.h ../nuttx/boards/arm/sama5/sama5d3-xplained/include/boot_romfsimg.h popd make clean clean_context make -j3 Load and run nuttx.bin at 0x20008000 using u-boot Run the hello application knsh> /bin/hello Hello, World!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
