Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 closed pull request #3071: Adding new example Xedge URL: https://github.com/apache/nuttx-apps/pull/3071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
acassis commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2894224874 @surfskidude you didn't need to close the PR to do the git push -f, I think it explains why there is not new commits here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude closed pull request #3071: Adding new example Xedge URL: https://github.com/apache/nuttx-apps/pull/3071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2869398485 @surfskidude here is a new example how to integrate 3rd party library, please study and change your patch as needed: https://github.com/apache/nuttx-apps/pull/3074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2868873635 let me change this patch to draft until it follow the nuttx guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2083195116 ## examples/xedge/prepare.sh: ## @@ -0,0 +1,20 @@ +#!/bin/bash +# This script clones the required repos and builds the Xedge resource file Review Comment: it's required by nuttx, if you don't follow, please close this pr since nobody can merge the patch which doesn't comply with the guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
simbit18 commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081642652 ## examples/xedge/Kconfig: ## @@ -0,0 +1,46 @@ +# +# Xedge IoT Toolkit - NuttX Kconfig integration +# +# Xedge is an embedded software toolkit designed to enable high-level developers +# (e.g., web and Lua programmers) to create sophisticated, secure IoT and industrial +# device applications. It abstracts low-level embedded development through a lightweight +# runtime built on top of the Barracuda App Server and Lua, giving developers direct access +# to HTTP(S), WebSockets, MQTT, file system, and device I/O - all from high-level Lua scripts. +# +# This NuttX integration allows developers to compile and run Xedge as a user application, +# bringing powerful device control capabilities and an embedded web server to NuttX-based +# systems. +# +# Use this if you want to build smart, networked embedded devices with minimal C code, +# and maximum productivity. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge support in NuttX. Xedge is a high-level toolkit that lets you + develop complete IoT device applications using Lua, backed by the Barracuda App Server. + This application demonstrates a complete Xedge runtime integrated into NuttX. + +if EXAMPLES_XEDGE + +config EXAMPLES_XEDGE_PROGNAME + string "Program name" + default "xedge" + ---help--- + This is the name of the ELF executable for the Xedge application in NSH. Review Comment: remove spaces and add a tab (line 32) ## examples/xedge/Kconfig: ## @@ -0,0 +1,46 @@ +# +# Xedge IoT Toolkit - NuttX Kconfig integration +# +# Xedge is an embedded software toolkit designed to enable high-level developers +# (e.g., web and Lua programmers) to create sophisticated, secure IoT and industrial +# device applications. It abstracts low-level embedded development through a lightweight +# runtime built on top of the Barracuda App Server and Lua, giving developers direct access +# to HTTP(S), WebSockets, MQTT, file system, and device I/O - all from high-level Lua scripts. +# +# This NuttX integration allows developers to compile and run Xedge as a user application, +# bringing powerful device control capabilities and an embedded web server to NuttX-based +# systems. +# +# Use this if you want to build smart, networked embedded devices with minimal C code, +# and maximum productivity. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge support in NuttX. Xedge is a high-level toolkit that lets you Review Comment: remove spaces and add a tab (line 22 to 24) ## examples/xedge/Kconfig: ## @@ -0,0 +1,46 @@ +# +# Xedge IoT Toolkit - NuttX Kconfig integration +# +# Xedge is an embedded software toolkit designed to enable high-level developers +# (e.g., web and Lua programmers) to create sophisticated, secure IoT and industrial +# device applications. It abstracts low-level embedded development through a lightweight +# runtime built on top of the Barracuda App Server and Lua, giving developers direct access +# to HTTP(S), WebSockets, MQTT, file system, and device I/O - all from high-level Lua scripts. +# +# This NuttX integration allows developers to compile and run Xedge as a user application, +# bringing powerful device control capabilities and an embedded web server to NuttX-based +# systems. +# +# Use this if you want to build smart, networked embedded devices with minimal C code, +# and maximum productivity. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge support in NuttX. Xedge is a high-level toolkit that lets you + develop complete IoT device applications using Lua, backed by the Barracuda App Server. + This application demonstrates a complete Xedge runtime integrated into NuttX. + +if EXAMPLES_XEDGE + +config EXAMPLES_XEDGE_PROGNAME + string "Program name" + default "xedge" + ---help--- + This is the name of the ELF executable for the Xedge application in NSH. + +config EXAMPLES_XEDGE_PRIORITY + int "Xedge task priority" + default 100 + ---help--- + Set the task priority for the Xedge runtime. + +config EXAMPLES_XEDGE_STACKSIZE + int "Xedge stack size" + default 2 + ---help--- + Set the stack size allocated to the Xedge Lua interpreter and application runtime. Review Comment: remove spaces and add a tab (44) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: u
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082851662 ## examples/xedge/prepare.sh: ## @@ -0,0 +1,20 @@ +#!/bin/bash +# This script clones the required repos and builds the Xedge resource file Review Comment: I do not recommend this. The user needs to understand the sequence. Please see: https://realtimelogic.com/ba/examples/xedge/readme.html#release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082849781 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,207 @@ +/ + * xedge_main.c + * + * Copyright (C) 2025. All rights reserved. Review Comment: I tried, but it failed. Sorry, I am no git expert. git rebase -i HEAD~11 Auto-merging examples/xedge/Kconfig CONFLICT (add/add): Merge conflict in examples/xedge/Kconfig Auto-merging examples/xedge/xedge_main.c CONFLICT (add/add): Merge conflict in examples/xedge/xedge_main.c error: could not apply 055fcfca1... Adding new example Xedge hint: Resolve all conflicts manually, mark them as resolved with hint: "git add/rm ", then run "git rebase --continue". hint: You can instead skip this commit: run "git rebase --skip". hint: To abort and get back to the state before "git rebase", run "git rebase --abort". Could not apply 055fcfca1... Adding new example Xedge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082810660 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,207 @@ +/ + * xedge_main.c + * + * Copyright (C) 2025. All rights reserved. Review Comment: you need use apache copyright like other files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2868323396 please squash your change into one patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082810330 ## examples/xedge/Kconfig: ## @@ -0,0 +1,29 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge Review Comment: no, I look at your latest version, please study how other 3rd party library is integrated into nuttx before making your own porting: https://github.com/apache/nuttx-apps/tree/master/examples/lvgldemo https://github.com/apache/nuttx-apps/tree/master/graphics/lvgl ## examples/xedge/Makefile: ## @@ -0,0 +1,35 @@ + +# apps/examples/xedge/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +include $(APPDIR)/Make.defs + +# Xedge, World! built-in application info + +PROGNAME = $(CONFIG_EXAMPLES_XEDGE_PROGNAME) +PRIORITY = $(CONFIG_EXAMPLES_XEDGE_PRIORITY) +STACKSIZE = $(CONFIG_EXAMPLES_XEDGE_STACKSIZE) +MODULE= $(CONFIG_EXAMPLES_XEDGE) + +# Xedge: BAS Example + +MAINSRC = xedge_main.c BAS/src/BAS.c BAS/src/dlmalloc.c BAS/src/arch/Posix/ThreadLib.c BAS/src/arch/NET/generic/SoDisp.c BAS/src/DiskIo/posix/BaFile.c BAS/examples/xedge/src/xedge.c BAS/examples/xedge/ BAS/examples/xedge/XedgeZip.c Review Comment: please split your example and xedge package to different path. ## examples/xedge/prepare.sh: ## @@ -0,0 +1,20 @@ +#!/bin/bash +# This script clones the required repos and builds the Xedge resource file Review Comment: you need move the script to Makefile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082336926 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: Great, then this issue is solved. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082251005 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: I changed the example file's license to MIT https://github.com/RealTimeLogic/BAS/blob/main/examples/xedge/src/led.c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082251005 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: So what do you want me to do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082227939 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: I don't know who you are, I don't know if you own the code, I don't know if you have the right to relicense the code. What I know is that this part of code is publicly available as GPL2. Things like this should be explained in the first place :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082128795 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: We own that code, we have the right to copy and change the license to whatever we want. Ask an attorney if that is not clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081915165 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: To resolve this, I changed the license of this file to the same as the one in webserver/webserver_main.c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2082014775 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: your change clearly states that it is based on https://github.com/RealTimeLogic/BAS/blob/main/examples/xedge/src/led.c Can you prove that https://github.com/RealTimeLogic/BAS/blob/main/examples/xedge/src/led.c is not GPL2 as the LICENSE file in BAS repository says. You can't just take some GPL2 code and relicense it to a permissive license -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081993060 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: I also added "depends on ALLOW_GPL_COMPONENTS" to the Kconfig as I see in other examples, but note that no code is GPL in the nuttx repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081696093 ## examples/xedge/Kconfig: ## @@ -0,0 +1,46 @@ +# +# Xedge IoT Toolkit - NuttX Kconfig integration +# +# Xedge is an embedded software toolkit designed to enable high-level developers +# (e.g., web and Lua programmers) to create sophisticated, secure IoT and industrial +# device applications. It abstracts low-level embedded development through a lightweight +# runtime built on top of the Barracuda App Server and Lua, giving developers direct access +# to HTTP(S), WebSockets, MQTT, file system, and device I/O - all from high-level Lua scripts. +# +# This NuttX integration allows developers to compile and run Xedge as a user application, +# bringing powerful device control capabilities and an embedded web server to NuttX-based +# systems. +# +# Use this if you want to build smart, networked embedded devices with minimal C code, +# and maximum productivity. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge support in NuttX. Xedge is a high-level toolkit that lets you Review Comment: I have removed all spaces in the file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081973726 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: No, the code I added in the nuttx-apps repo is not GPL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081963814 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: That's why I asked if this code is based on GPL code. If your code is based on GPL code then this code is GPL and can't be relicensed to BSD. This is the code you are referring to: https://github.com/RealTimeLogic/BAS/blob/main/examples/xedge/src/led.c and this is GPL2 according to this: https://github.com/RealTimeLogic/BAS/blob/main/LICENSE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081782318 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: https://nuttx.apache.org/docs/latest/applications/crypto/wolfssl/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081817934 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: If you look at https://github.com/apache/nuttx-apps/tree/master/crypto/wolfssl there is no GPL code hosted in this repository. All GPL code is taken from an external source and protected with `depends on ALLOW_GPL_COMPONENTS`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081787014 ## examples/xedge/Kconfig: ## @@ -0,0 +1,29 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge Review Comment: you are looking at an outdated version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081782318 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: https://nuttx.apache.org/docs/latest/applications/crypto/wolfssl/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081781229 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: GPL here: https://nuttx.apache.org/docs/latest/applications/crypto/wolfssl/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
xiaoxiang781216 commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081772131 ## examples/xedge/Kconfig: ## @@ -0,0 +1,29 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge Review Comment: you need follow the nuttx guide to integrate 3rd party code, otherwise we can't merge your change. ## examples/xedge/Kconfig: ## @@ -0,0 +1,29 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge Review Comment: you need follow the nuttx guide to integrate 3rd party code, otherwise we can't merge your change, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2866493354 @surfskidude I'm not talking about Xedge sources, I'm talking about sources that are added to NuttX repositories in this PR :) I understand that external functions may not meet the NuttX standard, but everything else that goes into the NuttX repositories should. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
raiden00pl commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081664671 ## examples/xedge/xedge_main.c: ## @@ -0,0 +1,169 @@ +/* Xedge NuttX Startup Code (may need adjustments) + * + * Xedge, including this startup code, requires the Barracuda App + * Server library and is licensed using the three license options as + * explained here: https://github.com/RealTimeLogic/BAS#license Review Comment: what is the license of this code? is it based on GPL code? if so, this code cannot be hosted in Apache Foundation repositories -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
simbit18 commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081651992 ## examples/xedge/Makefile: ## @@ -0,0 +1,35 @@ + +# apps/examples/xedge/Make.defs Review Comment: apps/examples/xedge/Make.defs -> apps/examples/xedge/Makefile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2081625142 ## examples/xedge/Kconfig: ## @@ -0,0 +1,29 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge Review Comment: I have created and included a bash script that automates the process, but I have not included the script in the makefile. I do not recommend it to be this way. This becomes clear when reading the Xedge documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2866455814 > The added files are far from the coding standard we use in NuttX. Also, the external project should be automatically downloaded, unpacked and configured without any user intervention as its done for other external projects. > > In this state this PR shouldn't be merged. Please look at other external projects like lvgl in NuttX and fix this PR :) Xedge is an existing and mature product with over 130,000 lines of code developed under a separate coding style. Unfortunately, changing the formatting or structure of the source, including the NuttX startup integration code, is not possible. For this reason, both the Xedge core and the NuttX startup code that boots into Xedge must remain as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
surfskidude commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2866253907 OK, I updated a few things and ran git commit -s ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
jerpelea commented on PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#issuecomment-2865795111 please remove the merge commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Adding new example Xedge [nuttx-apps]
acassis commented on code in PR #3071: URL: https://github.com/apache/nuttx-apps/pull/3071#discussion_r2079597339 ## examples/xedge/Kconfig: ## @@ -0,0 +1,29 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config EXAMPLES_XEDGE + tristate "Xedge IoT Toolkit" + default n + ---help--- + Enable Xedge Review Comment: Please include details: what this application is support to do? Also include a short explanation about Xedge, what is it? Why should people use this? etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
