Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan closed pull request #16212: CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico URL: https://github.com/apache/nuttx/pull/16212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on PR #16212: URL: https://github.com/apache/nuttx/pull/16212#issuecomment-2809564415 @roskuttan Why are your Cmakefiles not aligned with Make.defs? I created a branch for building rp2040 with CMake seems to work. (Ho commentato anche #include rp2040_pico.h in rp2040_common_bringup.c.) You also need this fix #16227 (already included in my branch) `git clone --depth 1 --single-branch --branch simbit18-rp2040 https://github.com/simbit18/nuttx.git nuttx` I don't have a Raspberry Pi Pico board so you have to do the tests. ``` Build CMake [1113/1114] Linking C executable nuttx Memory region Used Size Region Size %age Used flash:148 KB 2 MB 7.23% sram:8336 B 264 KB 3.08% [1114/1114] Generating System.map Build make LD: nuttx Memory region Used Size Region Size %age Used flash:148 KB 2 MB 7.23% sram:8344 B 264 KB 3.09% PICO_SDK_PATH/picotool must be specified/installed for flash boot ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044214312 ## boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt: ## @@ -0,0 +1,49 @@ +# ## +# boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_boardinitialize.c rp2040_bringup.c rp2040_gpio.c) + Review Comment: ``` roskuttan@SILENT-KILLERED:~/nuttx_pr/nuttx$ cmake --build build -t clean -j12 && cmake --build build -j12 [0/1] Re-running CMake... CMake Warning at CMakeLists.txt:176 (message): apps/nuttx-apps directory is not found, use dummy directory instead -- Configuring done (0.2s) -- Generating done (0.1s) -- Build files have been written to: /home/roskuttan/nuttx_pr/nuttx/build [1/1] Cleaning all built files... Cleaning... 1034 files. [1030/1039] Building C object boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj FAILED: boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj /usr/bin/arm-none-eabi-gcc -D__KERNEL__ -D__NuttX__ -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/rp2040 -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/common -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/armv6-m -I/home/roskuttan/nuttx_pr/nuttx/sched -I/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/include -isystem /home/roskuttan/nuttx_pr/nuttx/include -isystem /home/roskuttan/nuttx_pr/nuttx/build/include -mcpu=cortex-m0 -mthumb -mfloat-abi=soft --param=min-pagesize=0 -fno-common -Wall -Wshadow -Wundef -nostdlib -Os -fno-strict-aliasing -fomit-frame-pointer -Wa,-mthumb -Wa,-mimplicit-it=always -ffunction-sections -fdata-sections -g -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -Wno-psabi -fdiagnostics-color=always -DNDEBUG -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/dummy= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/raspberrypi-pico= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nut tx/arch/arm/src/rp2040= @boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.rsp -MD -MT boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -MF boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.d -o boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c:39:10: fatal error: rp2040_pico.h: No such file or directory 39 | #include "rp2040_pico.h" | ^~~ compilation terminated. [1035/1039] Building C object sched/CMakeFiles/sched.dir/wdog/wd_start.c.obj ninja: build stopped: subcommand failed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on PR #16212: URL: https://github.com/apache/nuttx/pull/16212#issuecomment-2808467645 I don't see any `rp2040_pico.h` in the `nuttx/boards/arm/rp2040/common/include` i think that what causing this error. ``` roskuttan@SILENT-KILLERED:~/nuttx_pr/nuttx$ cmake --build build -t clean -j12 && cmake --build build -j12 [1/1] Cleaning all built files... Cleaning... 0 files. [1027/1039] Building C object boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj FAILED: boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj /usr/bin/arm-none-eabi-gcc -D__KERNEL__ -D__NuttX__ -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/rp2040 -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/common -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/armv6-m -I/home/roskuttan/nuttx_pr/nuttx/sched -I/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/include -isystem /home/roskuttan/nuttx_pr/nuttx/include -isystem /home/roskuttan/nuttx_pr/nuttx/build/include -mcpu=cortex-m0 -mthumb -mfloat-abi=soft --param=min-pagesize=0 -fno-common -Wall -Wshadow -Wundef -nostdlib -Os -fno-strict-aliasing -fomit-frame-pointer -Wa,-mthumb -Wa,-mimplicit-it=always -ffunction-sections -fdata-sections -g -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -Wno-psabi -fdiagnostics-color=always -DNDEBUG -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/dummy= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/raspberrypi-pico= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nut tx/arch/arm/src/rp2040= @boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.rsp -MD -MT boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -MF boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.d -o boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c:39:10: fatal error: rp2040_pico.h: No such file or directory 39 | #include "rp2040_pico.h" | ^~~ compilation terminated. [1036/1039] Linking C static library libs/libc/libc.a ninja: build stopped: subcommand failed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2045121514 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: @roskuttan No this has nothing to do with your problem !!! It is how to build raspberrypi-pico/nsh with make on CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2045121514 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: @roskuttan No this has nothing to do with your problem !!! t is how to build raspberrypi-pico/nsh with make on CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2045087150 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: So is it why that header file issue happening? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
nuttxpr commented on PR #16212: URL: https://github.com/apache/nuttx/pull/16212#issuecomment-2804095217 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements yet, specifically in the Testing section. While the PR author has provided details about their build environment and reproduction steps, the build fails. A successful build and accompanying logs demonstrating the functionality are essential before the PR can be considered complete. Here's a breakdown of what needs to be addressed: * **Build Errors:** The CMake build fails with compilation errors. The logs show: * `rp2040_pico.h: No such file or directory`: This suggests an issue with include paths in the CMake configuration. The build system can't find this required header file. * `'CONFIG_BOARDCTL_UNIQUEID_SIZE' undeclared`: This indicates a missing configuration option. This macro likely needs to be defined either in the board's `defconfig` or passed as a CMake option. * **Missing "Before Change" Logs:** The template requests logs from *before* the change was implemented. These logs are crucial for demonstrating the original behavior and highlighting the improvement introduced by the PR. * **Incomplete Testing:** Even if the build succeeded, the logs don't demonstrate that the CMake build *works as intended*. The PR needs to show that the resulting binary functions correctly on the target hardware. This might involve output from `nsh` or other tests demonstrating the board's functionality. **Recommendations for the PR Author:** 1. **Fix Build Errors:** Address the compilation errors highlighted in the logs. Double-check include directories, macro definitions, and any dependencies required for the Raspberry Pi Pico board. 2. **Provide "Before Change" Logs:** Run the existing build system (presumably Make-based) and capture the output. This establishes a baseline for comparison. 3. **Demonstrate Functionality:** After fixing the build, show that the CMake-built firmware works. Include logs from the target demonstrating successful initialization and operation. Consider adding a simple test application to exercise the core functionality of the board. 4. **Consider Compatibility Issues:** The author mentions compatibility issues preventing full compatibility. These issues need to be explicitly described and, if possible, addressed. If full compatibility isn't achievable yet, explain the limitations and any plans for future improvements. By addressing these points, the PR will better meet the NuttX requirements and be ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044157532 ## boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt: ## @@ -0,0 +1,49 @@ +# ## +# boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_boardinitialize.c rp2040_bringup.c rp2040_gpio.c) + Review Comment: set(SRCS rp2040_boardinitialize.c rp2040_appinit.c rp2040_bringup.c) if(CONFIG_DEV_GPIO) list(APPEND SRCS rp2040_gpio.c) endif() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044561567 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: used for the CI system First though, you have to build raspberrypi-pico/nsh with CMake !!! :) ``` Configuration/Tool: raspberrypi-pico/nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI 2025-04-15 08:14:58 Cleaning... Configuring... Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI Building NuttX... [1/1] Normalize raspberrypi-pico/nsh ``` https://github.com/apache/nuttx/actions/runs/14463651512/job/40561050021#step:7:854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044561567 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: used for the CI system -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044103447 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: Hi @roskuttan you must also add board:config in the test lists for Cmake https://github.com/apache/nuttx/blob/master/tools/ci/testlist/arm-06.dat this must be added ``` /arm/r*,CONFIG_ARM_TOOLCHAIN_GNU_EABI # Boards build by CMake CMake,raspberrypi-pico:nsh ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044214312 ## boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt: ## @@ -0,0 +1,49 @@ +# ## +# boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_boardinitialize.c rp2040_bringup.c rp2040_gpio.c) + Review Comment: ``` roskuttan@SILENT-KILLERED:~/nuttx_pr/nuttx$ cmake --build build -t clean -j12 && cmake --build build -j12 [0/1] Re-running CMake... CMake Warning at CMakeLists.txt:176 (message): apps/nuttx-apps directory is not found, use dummy directory instead -- Configuring done (0.2s) -- Generating done (0.1s) -- Build files have been written to: /home/roskuttan/nuttx_pr/nuttx/build [1/1] Cleaning all built files... Cleaning... 1034 files. [1030/1039] Building C object boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj FAILED: boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj /usr/bin/arm-none-eabi-gcc -D__KERNEL__ -D__NuttX__ -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/rp2040 -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/common -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/armv6-m -I/home/roskuttan/nuttx_pr/nuttx/sched -I/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/include -isystem /home/roskuttan/nuttx_pr/nuttx/include -isystem /home/roskuttan/nuttx_pr/nuttx/build/include -mcpu=cortex-m0 -mthumb -mfloat-abi=soft --param=min-pagesize=0 -fno-common -Wall -Wshadow -Wundef -nostdlib -Os -fno-strict-aliasing -fomit-frame-pointer -Wa,-mthumb -Wa,-mimplicit-it=always -ffunction-sections -fdata-sections -g -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -Wno-psabi -fdiagnostics-color=always -DNDEBUG -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/dummy= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/raspberrypi-pico= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nut tx/arch/arm/src/rp2040= @boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.rsp -MD -MT boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -MF boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.d -o boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c:39:10: fatal error: rp2040_pico.h: No such file or directory 39 | #include "rp2040_pico.h" | ^~~ compilation terminated. [1035/1039] Building C object sched/CMakeFiles/sched.dir/wdog/wd_start.c.obj ninja: build stopped: subcommand failed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044063140 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: ``` set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c) if(CONFIG_BOARDCTL_RESET) list(APPEND SRCS rp2040_reset.c) endif() if(CONFIG_BOARDCTL_UNIQUEID) list(APPEND SRCS rp2040_uniqueid.c) endif() ``` https://github.com/apache/nuttx/blob/master/boards/arm/rp2040/common/src/Make.defs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044221397 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: > Hi @roskuttan you must also add board:config in the test lists for Cmake > > https://github.com/apache/nuttx/blob/master/tools/ci/testlist/arm-06.dat > > this must be added > > ``` > /arm/r*,CONFIG_ARM_TOOLCHAIN_GNU_EABI > > # Boards build by CMake > > CMake,raspberrypi-pico:nsh > ``` That to arm-06.dat? whats its purpose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044220281 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: > arm-06.dat That to arm-06.dat? whats its purpose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044220281 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: > arm-06.dat That to arm-06.dat? whats its purpose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044157532 ## boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt: ## @@ -0,0 +1,49 @@ +# ## +# boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_boardinitialize.c rp2040_bringup.c rp2040_gpio.c) + Review Comment: ``` set(SRCS rp2040_boardinitialize.c rp2040_appinit.c rp2040_bringup.c) if(CONFIG_DEV_GPIO) list(APPEND SRCS rp2040_gpio.c) endif() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044157532 ## boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt: ## @@ -0,0 +1,49 @@ +# ## +# boards/arm/rp2040/raspberrypi-pico/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_boardinitialize.c rp2040_bringup.c rp2040_gpio.c) + Review Comment: ``` set(SRCS rp2040_boardinitialize.c rp2040_appinit.c rp2040_bringup.c) if(CONFIG_DEV_GPIO) list(APPEND SRCS rp2040_gpio.c) endif() ``` https://github.com/apache/nuttx/blob/master/boards/arm/rp2040/raspberrypi-pico/src/Make.defs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044146914 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: After those corrections ``` roskuttan@SILENT-KILLERED:~/nuttx_pr/nuttx$ roskuttan@SILENT-KILLERED:~/nuttx_pr/nuttx$ cmake --build build -t clean -j12 && cmake --build build -j12 [0/1] Re-running CMake... CMake Warning at CMakeLists.txt:176 (message): apps/nuttx-apps directory is not found, use dummy directory instead -- Configuring done (0.2s) -- Generating done (0.1s) -- Build files have been written to: /home/roskuttan/nuttx_pr/nuttx/build [1/1] Cleaning all built files... Cleaning... 1034 files. [1028/1039] Building C object boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj FAILED: boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj /usr/bin/arm-none-eabi-gcc -D__KERNEL__ -D__NuttX__ -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/rp2040 -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/common -I/home/roskuttan/nuttx_pr/nuttx/arch/arm/src/armv6-m -I/home/roskuttan/nuttx_pr/nuttx/sched -I/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/include -isystem /home/roskuttan/nuttx_pr/nuttx/include -isystem /home/roskuttan/nuttx_pr/nuttx/build/include -mcpu=cortex-m0 -mthumb -mfloat-abi=soft --param=min-pagesize=0 -fno-common -Wall -Wshadow -Wundef -nostdlib -Os -fno-strict-aliasing -fomit-frame-pointer -Wa,-mthumb -Wa,-mimplicit-it=always -ffunction-sections -fdata-sections -g -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -Wno-psabi -fdiagnostics-color=always -DNDEBUG -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/dummy= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/raspberrypi-pico= -fmacro-prefix-map=/home/roskuttan/nuttx_pr/nut tx/arch/arm/src/rp2040= @boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.rsp -MD -MT boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -MF boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj.d -o boards/CMakeFiles/board.dir/arm/rp2040/common/src/rp2040_common_bringup.c.obj -c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c /home/roskuttan/nuttx_pr/nuttx/boards/arm/rp2040/common/src/rp2040_common_bringup.c:39:10: fatal error: rp2040_pico.h: No such file or directory 39 | #include "rp2040_pico.h" | ^~~ compilation terminated. [1035/1039] Building C object boards/CMakeFiles/board.dir/arm/rp2040/raspberrypi-pico/src/rp2040_autoleds.c.obj ninja: build stopped: subcommand failed. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
simbit18 commented on code in PR #16212: URL: https://github.com/apache/nuttx/pull/16212#discussion_r2044063140 ## boards/arm/rp2040/common/src/CMakeLists.txt: ## @@ -0,0 +1,113 @@ +# ## +# boards/arm/rp2040/common/src/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ## + +set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c rp2040_reset.c + rp2040_uniqueid.c) Review Comment: set(SRCS rp2040_common_bringup.c rp2040_common_initialize.c) if(CONFIG_BOARDCTL_RESET) list(APPEND SRCS rp2040_reset.c) endif() if(CONFIG_BOARDCTL_UNIQUEID) list(APPEND SRCS rp2040_uniqueid.c) endif() https://github.com/apache/nuttx/blob/master/boards/arm/rp2040/common/src/Make.defs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan closed pull request #16196: CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico URL: https://github.com/apache/nuttx/pull/16196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
raiden00pl commented on PR #16196: URL: https://github.com/apache/nuttx/pull/16196#issuecomment-2798697903 you need `boards/arm/rp2040/common/CMakeLists.txt` and `boards/arm/rp2040/common/src/CMakeLists.txt`. You can look how it's done for `boards/arm/stm32/common` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
roskuttan commented on PR #16196: URL: https://github.com/apache/nuttx/pull/16196#issuecomment-2798696204 > @roskuttan I see the problem now. You have to port `boards/arm/rp2040/common` to cmake. All missing definitions are from `boards/arm/rp2040/common/Kconfig` So i just have to make a new cmakelist to the boards/arm/rp2040/common right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
raiden00pl commented on PR #16196: URL: https://github.com/apache/nuttx/pull/16196#issuecomment-2798686957 @roskuttan I see the problem now. You have to port `boards/arm/rp2040/common` to cmake. All missing definitions are from `boards/arm/rp2040/common/Kconfig` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]
nuttxpr commented on PR #16196:
URL: https://github.com/apache/nuttx/pull/16196#issuecomment-2798684235
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
__Fill In The Commit Message:__ This PR contains a Commit with an Empty
Commit Message. Please fill in the Commit Message with the PR Summary.
This PR review assesses the CMake build system introduction for the
Raspberry Pi Pico against the NuttX requirements.
**Summary:** The summary is well-written and explains the purpose, affected
code areas, and implementation approach clearly. The inspiration note is
helpful.
**Impact:** The impact assessment is mostly thorough. However, the "Impact
on Documentation" should be YES, even if demonstrating general CMake usage
exists. This PR introduces a *specific board's* CMake build, requiring at
least a mention in the board's documentation. Clarify that existing general
CMake documentation is *relevant* but not *sufficient*.
**Testing:** The testing section needs improvement.
* **Incomplete Build Host Information:** Specify the toolchain version
(arm-none-eabi-gcc *version*). WSL version is also relevant.
* **Incomplete Target Information:** "nsh configuration" is too vague.
Specify the exact `.config` file or the steps to generate it. Are you using the
default `defconfig`?
* **Build Errors:** The build clearly failed. A PR should ideally not have
failing builds. The identified undefined macros are a significant issue.
Investigate *why* these macros aren't defined. Are they missing from
`defconfig`? Is the CMake build process not correctly incorporating the
configuration? Simply stating "I tried adding these" is insufficient; detail
*where* and *how* you tried to add them. Provide the changes you attempted.
* **"CMake is working well" Contradiction:** The logs show a failing build.
You can't claim CMake is working well if it doesn't produce a working binary.
The build errors must be resolved before this PR is ready.
* **Lack of "Before Change" Context:** The "before change" log simply shows
CMake failing because the Pico's CMake files didn't exist. This is expected and
doesn't provide a useful comparison. Instead, describe how the Pico was built
*before* this change (likely Make-based). A successful Make-based build log
would be helpful as a baseline.
* **Missing Functional Testing:** Even if the build succeeded, you need to
demonstrate that the resulting binary functions correctly on the Pico. Provide
logs or other evidence of successful operation after the CMake build.
**Does this PR meet the NuttX Requirements?**
No. While the PR makes good progress, the failing build and incomplete
testing prevent it from meeting the requirements. The following actions are
needed:
1. **Fix the build errors:** Investigate and resolve the undefined macro
issue. Document the solution clearly.
2. **Complete the testing:**
* Provide full build host and target details.
* Include a successful Make-based build log ("before change").
* Demonstrate successful flashing and operation of the CMake-built
binary on the Pico.
3. **Update documentation:** Mention the new CMake build option in the
relevant Pico documentation.
By addressing these points, the PR will have a much better chance of being
accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
