Re: [PR] DOCS: Chip tagging [nuttx]
cederom merged PR #16321: URL: https://github.com/apache/nuttx/pull/16321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] DOCS: Chip tagging [nuttx]
cederom commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2075518138 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chip:xczu28dr Review Comment: FPGA would be the general name, subclass could include vendor (i.e. `vendor:amd, vendor:xilinx`) and/or chip family (i.e. `chip:fpga, chip:zynq, chip:ultrascale+` not sure if `+` mark can be part of tag name so just `chip:ultrascale` should be fine too) ? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] DOCS: Chip tagging [nuttx]
cederom commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2075518138 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chip:xczu28dr Review Comment: FPGA would be the general name, subclass could include vendor (i.e. `vendor:amd, vendor:xilinx`) and/or chip family (i.e. `chip:fpga, chip:zynq, chip:ultrascale+` not sure if `+` mark can be part of tag name) ? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] DOCS: Chip tagging [nuttx]
linguini1 commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2074649541 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chip:xczu28dr Review Comment: I like this idea! I wonder if just `fpga` would suffice? Since that is not really a specific chip/chip family but more of a descriptor about the architecture (although not quite something like `arch:arm`, still different)? Any ideas maybe about a prefix I could use for this to differentiate from chip name but still convey a "class" of chip? I was thinking of doing the same thing for the virtual platforms, like `virt` or `emulator`. I can add this along with the other changes in the morning if you have any ideas! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] DOCS: Chip tagging [nuttx]
cederom commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2074478831 ## Documentation/platforms/arm/nrf91/boards/thingy91/index.rst: ## @@ -2,6 +2,8 @@ Nordic Thingy:91 = +.. tags:: chip:nrf91, chip:nrf9160, chip:nrf52840 Review Comment: + chip:nrf52 ? :-) ## Documentation/platforms/arm/nrf52/boards/nrf9160-dk-nrf52/index.rst: ## @@ -2,6 +2,8 @@ Nordic nRF9160 DK (nRF52840) +.. tags:: chip:nrf52, chip:nrf52840, chip:nrf9160 Review Comment: + chip:nrf91 ? :-) According to [1] they recommend nRF9151 for new designs so nRF91 becomes the family too :-) [1] https://www.nordicsemi.com/Products/nRF9160 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chip:xczu28dr Review Comment: + chip:fpga ? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] DOCS: Chip tagging [nuttx]
nuttxpr commented on PR #16321: URL: https://github.com/apache/nuttx/pull/16321#issuecomment-2852199679 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. The summary clearly explains the change, its purpose, and its scope. The impact section correctly identifies the limited scope of the change to documentation. The testing section, while lacking specific logs, describes the verification process adequately for a documentation-only change. Including a few "before" and "after" snippets of the rendered documentation showing the tag additions might further strengthen the testing evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
