Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 merged PR #16401: URL: https://github.com/apache/nuttx/pull/16401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2900563790 > Is there anything else I need to do for this PR? all change need at least two committer approve before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2900392627 Is there anything else I need to do for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2892657130 > please rebase your patch to fix the conflict. BTW why sim-01 can't citest with your patch? I just pushed the rebased branch. The sim-01 failure was in fact the consequence of a string change in `tools/ci/testrun/script/test_os/test_os.py`. But this spelling problem relied on a corresponding spelling problem in the apps repository. I will fix this evil couple later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2890831178 @sumpfralle please rebase your patch to fix the conflict. BTW why sim-01 can't citest with your patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-208411 > > the following warning could be fixed, I think: [..] > > Which specific warning do you mean? > > * configed / persistance / vaild / avalaible: I mentioned these in the summary of expected CI failures (see the PR description). > > * two unnecessary "global" scopes in `tools/pynuttx/nxgdb/utils.py`: should I really sneak a code change into this spelling-focussed PR? Ok, let's ignore the rest warning in this patchset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2888759926 > the following warning could be fixed, I think: [..] Which specific warning do you mean? * configed / persistance / vaild / avalaible: I mentioned these in the summary of expected CI failures (see the PR description). * two unnecessary "global" scopes in `tools/pynuttx/nxgdb/utils.py`: should I really sneak a code change into this spelling-focussed PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on code in PR #16401:
URL: https://github.com/apache/nuttx/pull/16401#discussion_r2094238487
##
.codespell-ignore-lines:
##
@@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A
24V
* [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix
typo PREPROCES -> PREPROCESS
* [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling
typo premption -> preemption
* [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo
falgs and align local name to irq_mask
+* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video
+* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove
bcmf_txavail_work and resue bcmf_tx_poll_work
ans init
+ uint32_t levl;
+ levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal);
Review Comment:
I removed these lines now from `.codespell-ignore-lines`.
In general, I would not try to care too much about the content of this file.
It is just meant as a dump of codespell's false positives within nuttx.
Regarding these specific exceptions: since the variable name `levl` is in
line with the nuttx code style ("short", "avoid underscores"), there is no real
need to "fix" this variable name. Thus, I would consider exceptions for these
lines as the appropriate solution.
Now we defer this decision to the next contributor working on these files.
(fine for me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on code in PR #16401:
URL: https://github.com/apache/nuttx/pull/16401#discussion_r2094235869
##
tools/checkpatch.sh:
##
@@ -125,7 +126,14 @@ check_file() {
fi
if [ $spell != 0 ]; then
-if ! codespell -q 7 ${@: -1}; then
+if [ "$codespell_config_file_location_was_shown_once" != "1" ]; then
Review Comment:
I would not call it an option, but a flag. I introduced it to track whether
the configuration file location was already displayed in this run of
`checkpatch`. Without this flag, the path of the configuration file would be
emitted for *every single* file, that was changed.
I do not have an opinion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093878551 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video +* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove bcmf_txavail_work and resue bcmf_tx_poll_work ans init + uint32_t levl; + levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal); Review Comment: how about we leave these warning alone without adding many rule to the config file, and let the late contributor who is more familiar with the code to decide what's the best way to do. If we add these uncertain words/lines blindly, other people can't know some spell improvement may exist. ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video +* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove bcmf_txavail_work and resue bcmf_tx_poll_work ans init + uint32_t levl; + levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal); Review Comment: how about we leave these warning alone without adding many rules to the config file, and let the late contributor who is more familiar with the code to decide what's the best way to do. If we add these uncertain words/lines blindly, other people can't know some spell improvement may exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093878551 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video +* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove bcmf_txavail_work and resue bcmf_tx_poll_work ans init + uint32_t levl; + levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal); Review Comment: how about we leave these warning alone without adding many rules to the config file, and let the late contributor who is more familiar with the code decide what's the best way to do. If we add these uncertain words/lines blindly, other people can't know some spell improvement may exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on code in PR #16401:
URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093880852
##
tools/checkpatch.sh:
##
@@ -125,7 +126,14 @@ check_file() {
fi
if [ $spell != 0 ]; then
-if ! codespell -q 7 ${@: -1}; then
+if [ "$codespell_config_file_location_was_shown_once" != "1" ]; then
Review Comment:
let's remove the option to simplify the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2888037413 the following warning could be fixed, I think: ``` /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/tlsr82/tlsr82_adc.c:75: configed ==> configured /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/tlsr82/tlsr82_adc.c:126: configed ==> configured /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/tlsr82/tlsr82_adc.c:1017: configed ==> configured /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/tlsr82/tlsr82_adc.c:1041: configed ==> configured /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/tlsr82/tlsr82_adc.c:1150: configed ==> configured /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/tlsr82/tlsr82_adc.c:1152: configed ==> configured /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:298: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:328: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:554: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:569: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:677: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1011: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1016: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1028: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1035: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1035: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1296: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1732: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1740: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1745: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1757: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1764: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/apds9922.c:1764: persistance ==> persistence /home/runner/work/nuttx/nuttx/nuttx/fs/v9fs/client.c:326: vaild ==> valid /home/runner/work/nuttx/nuttx/nuttx/tools/pynuttx/nxgdb/stack.py:114: avalaible ==> available /home/runner/work/nuttx/nuttx/nuttx/tools/pynuttx/nxgdb/utils.py:229:5: F824 `global g_type_cache` is unused: name is never assigned in scope global g_type_cache ^ /home/runner/work/nuttx/nuttx/nuttx/tools/pynuttx/nxgdb/utils.py:250:5: F824 `global long_type` is unused: name is never assigned in scope global long_type ^ 2 F824 `global g_type_cache` is unused: name is never assigned in scope ยทยทยท -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093878551 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video +* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove bcmf_txavail_work and resue bcmf_tx_poll_work ans init + uint32_t levl; + levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal); Review Comment: how about we leave this warning alone without adding many rule to the config file, and let the late contributor who is more familiar with the code to decide what's the best way to do. If we add these uncertain words/lines blindly, other people can't know some spell improvement may exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2887053635 > > ``` > > * [codespell] `noral`: I am not sure, which word the original author intended [there](https://github.com/apache/nuttx/blob/55f85dd727e670151d7455b22880a60036b3fe9f/arch/xtensa/src/esp32s3/hardware/esp32s3_rtccntl.h#L4252) (two occurrences). > > ``` > > this should be `normal` by checking the similar places Fixed. > > ``` > > * [codespell] `menas`: I am not sure, which word the original author intended [there](https://github.com/apache/nuttx/blob/master/include/nuttx/power/pm.h#L628) (two occurrences). > > ``` > > should be `means` Fixed. > > ``` > > * `libs/libm/libm/lib_lgamma.c: error: Operator/assignment must be preceded with whitespace`: I think, the scientific number expression with a positive exponent (`123e+4`) is misdetected as a problem by `nxstyle`. I failed to see a quick way for fixing this issue in `nxstyle`. Thus, I would suggest to ignore this error here. > > ``` > > one fix is changing `+00` to `-00`. Indeed, thanks for the hint! All exponents are `+00`. I changed these lines accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093260889 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video +* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove bcmf_txavail_work and resue bcmf_tx_poll_work ans init + uint32_t levl; + levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal); Review Comment: I tried to follow this approach: 1. Is it clearly wrong? -> fix it 1. Can it be easily renamed? -> rename * for the above example: `levl` means something like `level_left`. But the code style discourages the use of underscores in variable names. Thus, I did not rename it. 1. Is the misspelling used in many files (e.g. a traditional spelling of a variable name in a specific context)? -> add to `ignore-words-list` in `.codespellrc` 1. All others -> add line exception to `.codespell-ignore-lines` Personally I would suggest to understand `.codespell-ignore-lines` as an unsorted collection of all lines, which are certainly spelled correctly. Thus, I would suggest to *not* consider it as a well-documented perfectly maintained archive of wisdom. It is just there to make it easy to work with codespell's false positives. I tried to document the above intended usage in the `.codespellrc` file (see #16302). Of course, I am fine with any other approach. If you suggest an alternative handling, I could prepare a separate PR for changing the documentation in the `.codespellrc` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2887008226 > and please ignore this kind of error: > > ``` > Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/phy62xx/ble/ble_controller.h:69:3: error: Mixed case identifier found > ``` I think, the warning is reasonable (the name conflicts with the documented code style). Thus, I would not remove this warning completely. In case of this specific PR it is just annoying, but can be skipped visually easily. Or what would you suggest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2887003190 > could we drop from log: > > ``` > Used config files: > 1: .codespellrc > ``` I just pushed another commit to this PR (a bit unrelated), which avoids repeated output of the codespell log file location. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
sumpfralle commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093235790 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video Review Comment: Sadly I have no idea, what the original author intended here. If you can tell me, I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on code in PR #16401: URL: https://github.com/apache/nuttx/pull/16401#discussion_r2093230386 ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video +* [#6447](https://github.com/apache/nuttx/pull/6447) bcm43xxx: Remove bcmf_txavail_work and resue bcmf_tx_poll_work ans init + uint32_t levl; + levl = classd_get_atten(vol, AUDIO_BALANCE_RIGHT - bal); Review Comment: could we avoid add so many ignore line? ## .codespell-ignore-lines: ## @@ -15,4 +15,162 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V * [#14540](https://github.com/apache/nuttx/pull/14540) CMake/preprocess: fix typo PREPROCES -> PREPROCESS * [#14927](https://github.com/apache/nuttx/pull/14927) spelling: fix spelling typo premption -> preemption * [#15520](https://github.com/apache/nuttx/pull/15520) drivers/note: fix typo falgs and align local name to irq_mask +* [#4526](https://github.com/apache/nuttx/pull/4526) Rearch video Review Comment: why not fix the release note like before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2886985041 > This set of changes causes CI failures for the following reasons: > > * `error: Mixed case identifier found`: unrelated problematic naming of variables. I think, these should be fixed by contributors maintaining these specific modules. > let's ignore it. > * [codespell] `nd`: Maybe the variable should be renamed in order to avoid false positives. I think, this should be fixed by contributors maintaining these specific modules. > > * [codespell] `clen`: see before. > > * [codespell] `ist`: This abbreviation for "Interrupt Stack Table" is used in four files (related to the `x86_64` architecture). I am not sure, whether it shall be renamed or whether a global (or line-based) exception should be added. IMO this should be deferred to a maintainer of this module/architecture. > > * [codespell] `noral`: I am not sure, which word the original author intended [there](https://github.com/apache/nuttx/blob/55f85dd727e670151d7455b22880a60036b3fe9f/arch/xtensa/src/esp32s3/hardware/esp32s3_rtccntl.h#L4252) (two occurrences). > this should be `normal` by checking the similar places > * `drivers/video/vnc/vnc_keymap.c` (blank lines): I think, these blank lines are correct (see [source](https://github.com/apache/nuttx/blob/master/drivers/video/vnc/vnc_keymap.c#L120)). > > * [codespell] `menas`: I am not sure, which word the original author intended [there](https://github.com/apache/nuttx/blob/master/include/nuttx/power/pm.h#L628) (two occurrences). should be `means` > > * [codespell] `configed` / `INDX` / `vaild` / `avalaible`: These variable names will be fixed in another PR containing rather _questionable_ changes (to be proposed after this PR is merged). > > * `include/nuttx/net/*.h` (long lines): These are copyright statements. I guess, these should not be wrapped. > > * `libs/libm/libm/lib_lgamma.c: error: Operator/assignment must be preceded with whitespace`: I think, the scientific number expression with a positive exponent (`123e+4`) is misdetected as a problem by `nxstyle`. I failed to see a quick way for fixing this issue in `nxstyle`. Thus, I would suggest to ignore this error here. one fix is changing `+00` to `-00`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in comments and strings [nuttx]
xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2886948623 @sumpfralle could we drop from log: ``` Used config files: 1: .codespellrc ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
