Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
acassis merged PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
vrmay23 commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2118839521 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. +Enable POSIX stdio example that shows how to use open(), write() and +close() via /dev/console. Review Comment: It's done! ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. +Enable POSIX stdio example that shows how to use open(), write() and +close() via /dev/console. config EXAMPLES_POSIX_STDIO_PROGNAME string "Program name" default "posix_stdio" depends on EXAMPLES_POSIX_STDIO config EXAMPLES_POSIX_STDIO_PRIORITY - int "POSIX_STDIO test priority" + int "POSIX_STDIO priority" default 100 depends on EXAMPLES_POSIX_STDIO + +config EXAMPLES_POSIX_STDIO_STACKSIZE + int "POSIX_STDIO stack size" Review Comment: It's done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
acassis commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2118185138 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. +Enable POSIX stdio example that shows how to use open(), write() and +close() via /dev/console. Review Comment: Use TAB to create the help comments and align the text below ---help---, please look existing code ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. +Enable POSIX stdio example that shows how to use open(), write() and +close() via /dev/console. config EXAMPLES_POSIX_STDIO_PROGNAME string "Program name" default "posix_stdio" depends on EXAMPLES_POSIX_STDIO config EXAMPLES_POSIX_STDIO_PRIORITY - int "POSIX_STDIO test priority" + int "POSIX_STDIO priority" default 100 depends on EXAMPLES_POSIX_STDIO + +config EXAMPLES_POSIX_STDIO_STACKSIZE + int "POSIX_STDIO stack size" Review Comment: Ditto, use TAB here too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
cederom commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2107659159 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. + Enable POSIX stdio example that shows how to use open(), write() and + close() via /dev/console. Review Comment: Damn, true, tabs should be used as the rest of file, sorry, just align as the rest, thanks :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
vrmay23 commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2107656117 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. + Enable POSIX stdio example that shows how to use open(), write() and + close() via /dev/console. Review Comment: its done! Thanks as well for reminder me. but I did not found any tabs on the Kconfig. Anyways I just put two spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
vrmay23 commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2107655615 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. + Enable POSIX stdio example that shows how to use open(), write() and + close() via /dev/console. config EXAMPLES_POSIX_STDIO_PROGNAME string "Program name" default "posix_stdio" depends on EXAMPLES_POSIX_STDIO config EXAMPLES_POSIX_STDIO_PRIORITY - int "POSIX_STDIO test priority" + int "POSIX_STDIO priority" default 100 depends on EXAMPLES_POSIX_STDIO + +config EXAMPLES_POSIX_STDIO_STACKSIZE + int "POSIX_STDIO stack size" + default 2048 Review Comment: done! Thanks for reminder! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
cederom commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2106349314 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. + Enable POSIX stdio example that shows how to use open(), write() and + close() via /dev/console. Review Comment: Please align line start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fixing Kconfig file, adding the STACKSIZE symbol to example posix_stdio [nuttx-apps]
xiaoxiang781216 commented on code in PR #3082: URL: https://github.com/apache/nuttx-apps/pull/3082#discussion_r2106271842 ## examples/posix_stdio/Kconfig: ## @@ -7,14 +7,20 @@ config EXAMPLES_POSIX_STDIO bool "Posix stdio example" default n ---help--- - Enable POSIX stdio example that shows how to use open(), write() and close() via /dev/console. + Enable POSIX stdio example that shows how to use open(), write() and + close() via /dev/console. config EXAMPLES_POSIX_STDIO_PROGNAME string "Program name" default "posix_stdio" depends on EXAMPLES_POSIX_STDIO config EXAMPLES_POSIX_STDIO_PRIORITY - int "POSIX_STDIO test priority" + int "POSIX_STDIO priority" default 100 depends on EXAMPLES_POSIX_STDIO + +config EXAMPLES_POSIX_STDIO_STACKSIZE + int "POSIX_STDIO stack size" + default 2048 Review Comment: ```suggestion default DEFAULT_TASK_STACKSIZE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
