Re: [PR] Revert "libs/libc/semaphore: Fix DEBUGASSERTS" [nuttx]
xiaoxiang781216 merged PR #16216: URL: https://github.com/apache/nuttx/pull/16216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Revert "libs/libc/semaphore: Fix DEBUGASSERTS" [nuttx]
tmedicci commented on PR #16216: URL: https://github.com/apache/nuttx/pull/16216#issuecomment-2807302972 > @tmedicci please include the Summary info to the git commit log Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Revert "libs/libc/semaphore: Fix DEBUGASSERTS" [nuttx]
jlaitine commented on PR #16216: URL: https://github.com/apache/nuttx/pull/16216#issuecomment-2805163740 I kind of understand your explanation; but why on earth someone tries to lock a mutex in interrupt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Revert "libs/libc/semaphore: Fix DEBUGASSERTS" [nuttx]
acassis commented on PR #16216: URL: https://github.com/apache/nuttx/pull/16216#issuecomment-2805476161 @jlaitine please review (GH doesn't allow me add you as review) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Revert "libs/libc/semaphore: Fix DEBUGASSERTS" [nuttx]
tmedicci commented on PR #16216: URL: https://github.com/apache/nuttx/pull/16216#issuecomment-2805447578 > I kind of understand your explanation; but why on earth someone tries to take a semaphore in interrupt? This comes from the bt adapter, which is inspired on ESP-IDF's. Take a look at [`semphr_take_from_isr_wrapper`](https://github.com/espressif/esp-idf/blob/cc0485e40de1fa9b0e11221ac5c43a6565a447c7/components/bt/controller/esp32/bt.c#L603). Such callback calls FreeRTOS's interface that is safe to be called from interrupt. > Is the situation such that you know that the semaphore can't block at that point in the irq, and you want to cause some task to block on it later? Yes, exactly. It's used internally as signalling only (that's why we use the non-blocking version). > But reverting that is fine by me ! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Revert "libs/libc/semaphore: Fix DEBUGASSERTS" [nuttx]
tmedicci commented on PR #16216: URL: https://github.com/apache/nuttx/pull/16216#issuecomment-2804971440 @jlaitine , can you take a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
