Re: [PR] Support LLVM linked ELF RISC-V executable [nuttx]
acassis commented on PR #13197: URL: https://github.com/apache/nuttx/pull/13197#issuecomment-2858453119 Hi @metarutaiga, nice to see you working on it again. Please note that now all commits need to be signed (git commit -S) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support LLVM linked ELF RISC-V executable [nuttx]
acassis commented on code in PR #13197: URL: https://github.com/apache/nuttx/pull/13197#discussion_r2077556351 ## libs/libc/machine/risc-v/arch_elf.c: ## @@ -104,6 +104,19 @@ static const char *_get_rname(int type) return "?"; } +/ + * Name: _extract_bits + * + * Description: + * Copied from ELF_riscv.cpp (LLVM) Review Comment: Please update the description to explain what it does, you can keep this comment since ELF_riscv.cpp is licensed under Apache 2.0 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Support LLVM linked ELF RISC-V executable [nuttx]
xiaoxiang781216 commented on PR #13197: URL: https://github.com/apache/nuttx/pull/13197#issuecomment-2313127171 @metarutaiga please squash into one patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
